<josie>
cant make the meeting today due to a conflict, but wanted to drop a quick proof of life and a quick update for the benchmarking and silent payments working groups: novo and i are picking back up the batch validation benchmarking and ill be rebasing the silent payments PRs this week and next. will have more detailed updates next week!
arthur has joined #bitcoin-core-dev
arthur has quit [Remote host closed the connection]
arthur has joined #bitcoin-core-dev
arthur has quit [Quit: Leaving]
arthur69 has joined #bitcoin-core-dev
arthur69 has quit [Changing host]
arthur69 has joined #bitcoin-core-dev
<arthur69>
hello bitcoin core developer. I used to install bitcoin core and didn't enter password but when I reinstalled it and restored my wallet, I found that my btc address had password. what should I do?
arthur69 has quit [Quit: Leaving]
<glozow>
ping (testing my connection?)
<hebasto>
glozow pong
<vasild>
I got a "You are no longer in the group" in a bunch of groups in Signal, but not from all groups. Anybody else experiencing that?
<bitcoin-git>
bitcoin/master 62a9ff1 glozow: [refactor] change type of unique_parents to Txid
<bitcoin-git>
bitcoin/master e810842 glozow: [txorphanage] support multiple announcers
<bitcoin-git>
[bitcoin] fanquake merged pull request #31397: p2p: track and use all potential peers for orphan resolution (master...2024-11-multi-orphan) https://github.com/bitcoin/bitcoin/pull/31397
<glozow>
#topic Erlay WG Update (sr_gi, gleb, marcofleon)
<cfields>
I have a quick notice about the build-system
<sr_gi[m]>
#here
<tdb3>
hi
<gleb>
hi
<cfields>
(for after the wg updates)
<glozow>
Any erlay updates or should we move on?
<sr_gi[m]>
Not much to update on my end this week, I started collecting a small subset of data to answer the question of how to select fanout peers in Erlay, but I ended up switching to collect a much bigger set afterwards, as I feared I may be missing something
<sr_gi[m]>
The script finished tonight, so I´ll be processing it today. Hopefully more to update on next week
<TheCharlatan>
otherwise things seem to be moving along, thank you to the reviewers.
<glozow>
#topic Benchmarking WG Update (josie, l0rinc)
<glozow>
#topic Silent Payments WG Update (josie, RubenSomsen)
<glozow>
Just copying josie's message: "quick proof of life and a quick update for the benchmarking and silent payments working groups: novo and i are picking back up the batch validation benchmarking and ill be rebasing the silent payments PRs this week and next. will have more detailed updates next week!"
<glozow>
lmk if anybody has anything to add to those
<glozow>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<sipa>
not much to update from me; i've gotten some comments for sdaftuar about the txgraph code, while he's working on rebasing the full cluster mempool implementation on top, which have been addressed
<sipa>
so the thing to review remains #31363, and waiting for the rebase
<sipa>
oh, and there is more progress on the research side; new linearization algorithm is starting to look increasingly practical as a drop-in replacement (but not now, plz review txgraph first)
<sipa>
that's it for me
<achow101>
#31242 seems rfm, #31243 is next for review. that's all
<core-meetbot>
achow101: Unknown command: #31242
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<glozow>
will take a look
<glozow>
#topic Legacy Wallet Removal WG Update (achow101)
<achow101>
no updates. pr to review is still #31495. I'll address commeents next week
<gribble>
https://github.com/bitcoin/bitcoin/issues/31495 | wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases by achow101 · Pull Request #31495 · bitcoin/bitcoin · GitHub
<glozow>
#topic orphan resolution WG Update (glozow)
<glozow>
#31397 was just merged, I've opened a followups PR at #31666
<achow101>
let's start with this new time next week
<glozow>
Cool, starting Jan 23 we'll meet at 16 UTC
<glozow>
#topic quick notice about the build-system (cfields)
<cfields>
Just a quick heads-up that hebasto/fanquake/I are working through a few build-system issues that may require changes to the way people build. Mainly related to debug options and build types. The goal is to get any last breaking changes out of the way before v29 branch-off so that nothing has to change for v30. I can give updates at a future meeting if/when any breaking changes have been merged for those who miss the PRs.
jonatack has joined #bitcoin-core-dev
<glozow>
thanks cfields!
<achow101>
cfields: what sort of breaking changes?
<cfields>
achow101: mostly what happens when you set -DCMAKE_BUILD_TYPE=Foo
<sipa>
i can't imagine it'll be nearly as invasive as the autotools -> cmake switch, and even that was remarkably painless for me, so as far as i'm concerned, carry on and keep up the good work please
<cfields>
achow101: will ping you on the PRs for discussion if you'd like.
<achow101>
cfields: only if it breaks gdb :)
<jonatack>
hi
<cfields>
achow101: heh, we're trying to make it easier to get exactly the result you want rather than having to fight to override figure out where to put flags. So that should get better, not worse :)
<bitcoin-git>
bitcoin/master 4936567 Ava Chow: desc spkm: Return SigningProvider only if we have the privkey
<bitcoin-git>
bitcoin/master 62a95f5 Sebastian Falbesoner: test: refactor: move `CreateDescriptor` helper to wallet test util module
<bitcoin-git>
bitcoin/master f6a6d91 Sebastian Falbesoner: test: add check for getting SigningProvider for a CPubKey
<bitcoin-git>
[bitcoin] fanquake merged pull request #31242: wallet, desc spkm: Return SigningProvider only if we have the privkey (master...wallet-signingprov-no-h) https://github.com/bitcoin/bitcoin/pull/31242
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #31676: fuzz: add targets for PCP and NAT-PMP port mapping requests (master...2501_pcp_fuzzing) https://github.com/bitcoin/bitcoin/pull/31676
Talkless has quit [Quit: Konversation terminated!]