07:46 <@wumpus> luke-jr: no, I don't

07:54 <@wumpus> luke-jr: we do test windows on travis AFAIK?

08:03 <@wumpus> e.g. cross-build for windows, then run the tests in wine

08:04 <@wumpus> but not sure this covers all the tests

13:43 < luke-jr> wumpus: the Trusty changes appear to have disabled the GUI build and WINE testing :/

13:43 < luke-jr> ie, just builds bitcoind and doesn't test it

13:51 < sipa> luke-jr: https://travis-ci.org/bitcoin/bitcoin/jobs/138611890#L2144

13:51 < sipa> seems it does

13:51 < luke-jr> hm

13:52 < sipa> ah, but not the RPC tests

13:52 < sipa> only comparison tool and unit tests

13:54 < sipa> wumpus: https://github.com/bitcoin/bitcoin/pull/5677#issuecomment-136646964

13:54 < sipa> wumpus: does that still apply?

13:55 < luke-jr> - env: HOST=i686-w64-mingw32 PPA="ppa:ubuntu-wine/ppa" PACKAGES="nsis gcc-mingw-w64-i686 g++-mingw-w64-i686 binutils-mingw-w64-i686 mingw-w64-dev wine1.7 bc" RUN_TESTS=true GOAL="deploy" BITCOIN_CONFIG="--enable-gui --enable-reduce-exports" MAKEJOBS="-j2"

13:55 < luke-jr> + env: HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"

13:55 < luke-jr> I guess I misread the RUN_TESTS part, but what does the GOAL change imply?

13:58 < sipa> i think it just means we don't build the installer

15:11 < Chris_Stewart_5> sipa: Do you have any thoughts on property based checking? I'm starting to integrate it into a library I'm writing and it seems it would be useful in Bitcoin Core. I was looking at this library for C++

15:11 < Chris_Stewart_5> https://github.com/emil-e/rapidcheck

15:12 < Chris_Stewart_5> I'm wondering if there is any outright objections before I put more time into investigating this for Core..

15:20 <@wumpus> luke-jr: yes the GUI build is disabled for travis, for all platforms, that's intentional as there is still some caching issue

15:21 <@wumpus> sipa: no idea, could be that the RPC tests could be re-enabled, just no one has tried since

15:21 < sipa> Chris_Stewart_5: no objections to the concept, but i have no experience with the code/logistics of integrating it

15:22 < sipa> Chris_Stewart_5: perhaps you want to talk to Marco Falke (our qa maintainer)

15:23 <@wumpus> Chris_Stewart_5: I have no experience with it either, if you can apply it to improve test coverage of bitcoin core, why not try it

15:23 <@wumpus> at first glance it looks like a type of fuzzing, you could take a look at https://github.com/bitcoin/bitcoin/pull/7940

15:24 < Chris_Stewart_5> Will do. Is it best to submit a pull request with a [WIP] on it, or just develop on my own branch and submit a pull request later on?

15:25 <@wumpus> that's really up to you

15:25 <@wumpus> in both cases you develop on your own branch, in the former cast it has somewhat more visibility, which is useful if you want other people's opinions about things

15:33 < Chris_Stewart_5> good point, another question, is there any vetting process for dependencies that are being added to our src files?

15:34 < Chris_Stewart_5> I get that this one isn't as crucial since it is test dependecy, but it would be important if a dependency was affect src files

15:34 < Chris_Stewart_5> src meaning everything but the child test dir

16:00 < sipa> Chris_Stewart_5: if you add a dependency, you need to make sure that it's available in the depends system (see the depends subdir), so that it's available to the deterministic build system

16:01 < Chris_Stewart_5> Hmm ok. I'm just starting to look at this stuff. Doesn't look quite as simple as maven on the JVM :-). Cory is the build expert right?

16:05 < sipa> Chris_Stewart_5: indeed

16:06 < sipa> Chris_Stewart_5: deterministic building is a pretty new concept, and there are few tools available to do it for you, so it's all pretty custom

16:07 < sipa> Chris_Stewart_5: though, generally don't worry about that, if it's useful we'll find a way to integrate it

16:08 < Chris_Stewart_5> sipa: Ok, I'm just going to hack it together to start and submit a pull request testing a few simple properties

16:12 < GitHub4> [bitcoin] wbinns opened pull request #8224: readme: Revise 'an experimental new' phrasing in reference to Bitcoin (master...binns-update-readme) https://github.com/bitcoin/bitcoin/pull/8224

18:09 < Chris_Stewart_5> So i've created a file inside of package giving the instructions of how to build the library, what is the next step? I've tried to add the header to the test file and it fails.

18:10 < Chris_Stewart_5> I've also added it to the first line in packages.mk

18:12 < Chris_Stewart_5> See https://github.com/Christewart/bitcoin/commit/18638a532a8977d19a104f7fca76783b74d5e9fb

23:44 < GitHub63> [bitcoin] wbinns opened pull request #8226: contributing.md: Fix formatting (line lengths and smart quotes) (master...binns-contributing-formatting) https://github.com/bitcoin/bitcoin/pull/8226