< moneyball> #proposedmeetingtopic next CoreDev meetup...be ready to give feedback at Thursday's weekly meeting...considering 3 days prior to Breaking Bitcoin June 5-7 in Amsterdam https://twitter.com/breakingbitcoin/status/1070060118866305026
< bitcoin-git> [bitcoin] mysticaltech opened pull request #14872: Adding -daemon default option to bitcoind (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14872
< meshcollider> moneyball: awesome :D
< aj> moneyball: yeah, sounds good
< bralyclow> ident
< gmaxwell> https://github.com/bitcoin/bitcoin/pull/14780 looks like it is the only thing outstanding for 0.17.1, which would be _really_ good to get out considering that 0.17 is broken on both the latest ubuntu and fedora. achow101 is a specfically requested reviewer, meshcollider also reviewed one of the original PRs.
< sipa> it's also marked 0.17.1 :)
< gmaxwell> Yes, I'm nagging people to review it.
< gmaxwell> because AFAICT it is the only thing blocking issuing a release candidate for 0.17.1 now.
< sipa> yup
< meshcollider> gmaxwell: Ok I'll review it in a couple of hours
< provoostenator> moneyball: pff, Amsterdam is a bit far on a bicycle :-P
< provoostenator> I'll test the PSBT thing as well now
< provoostenator> I'm a bit confused how C++ magic makes it so that CTransactionRef (non_witness_utxo) and CTxOut (witness_utxo) are interchangeable. Context: https://github.com/bitcoin/bitcoin/pull/14588/commits/565500508aa5df0011109ebf375ba71b693fc7de#diff-d546634098d8003b6397c8643b74e47dR297
< sipa> am i looking at the wrong line? it's just nullptr being assigned on line 297
< sipa> and on line 296 the value being assigned is utxo (a CTxOut), not inout.non_witness_utxo
< provoostenator> Right side: input.non_witness_utxo = nullptr;
< provoostenator> YEs wrong lne
< provoostenator> 296: input.witness_utxo = utxo;
< gwillen> utxo is a CTxOut, as is witness_utxo
< gwillen> when we deal with non_witness_utxo (which is kind of poorly named), we extract the actual CTxOut from it: utxo = input.non_witness_utxo->vout[tx.vin[index].prevout.n];
< provoostenator> gwillen: ah I see it now, thanks.
< gwillen> np!
< stevenroose> How can transactions_tests.cpp be debugged?
< stevenroose> I'm getting: unknown location(0): fatal error: in "transaction_tests/tx_valid": std::ios_base::failure[abi:cxx11]: CDataStream::read(): end of data: iostream error
< stevenroose> test/transaction_tests.cpp(175): last checkpoint
< stevenroose> Without more info. Is that line 175 "last checkpoint" the last line that didn't error?
< stevenroose> Is there a way to know what vector is making it fail?
< Chris_Stewart_5> stevenroose: The best i've been able to do is manual debugging of printing, finding the test case, and then deleting all other test cases in tx_valid.json while i debug...
< Chris_Stewart_5> Not great
< promag> regarding #13780, I'm going to reproduce what sipa said in https://github.com/bitcoin/bitcoin/pull/14780#issuecomment-441101314
< gribble> https://github.com/bitcoin/bitcoin/issues/13780 | 0.17: Pre-branch maintenance by DrahtBot · Pull Request #13780 · bitcoin/bitcoin · GitHub
< promag> I mean #14780
< gribble> https://github.com/bitcoin/bitcoin/issues/14780 | PSBT backports to 0.17 by sipa · Pull Request #14780 · bitcoin/bitcoin · GitHub
< achow101> gmaxwell: I will review later today
< bitcoin-git> [bitcoin] MarcoFalke pushed 10 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/3362a95be360...5d12143c730c
< bitcoin-git> bitcoin/0.17 a3fe125 Andrew Chow: check that a separator is found for psbt inputs, outputs, and global map...
< bitcoin-git> bitcoin/0.17 cfdd6b2 Glenn Willen: More concise conversion of CDataStream to string...
< bitcoin-git> bitcoin/0.17 a9eab08 Glenn Willen: Remove redundant txConst parameter to FillPSBT...
< MarcoFalke> wumpus: Mind to bump the version and run gen-manpages.sh on the 0.17 branch?
< MarcoFalke> I can create a pull request if that is preferable
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/86ff0413bb8f...e2c473ff75f9
< bitcoin-git> bitcoin/master 1db0096 MarcoFalke: rpc: Pass argument descriptions to RPCHelpMan
< bitcoin-git> bitcoin/master fafd040 MarcoFalke: rpc: Add description to fundrawtransaction vout_index
< bitcoin-git> bitcoin/master fabca42 MarcoFalke: RPCHelpMan: Add space after colons in extended description...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #14796: rpc: Pass argument descriptions to RPCHelpMan (master...Mf1810-rpcHelpMan) https://github.com/bitcoin/bitcoin/pull/14796
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14875: RPCHelpMan: Support required arguments after optional ones (master...Mf1812-rpcOptional) https://github.com/bitcoin/bitcoin/pull/14875
< bitcoin-git> [bitcoin] ch4ot1c opened pull request #14876: zmq: Add jsonblock, jsontx (master...feature/zmq-json) https://github.com/bitcoin/bitcoin/pull/14876
< moneyball> zallarak there are 26 open PRs on the good first issue list. does this help? https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #14878: 0.17: Further backports (0.17...Mf1812-17Backports) https://github.com/bitcoin/bitcoin/pull/14878
< bitcoin-git> [bitcoin] hebasto opened pull request #14879: qt: Add warning messages to the debug window (master...20181205-debugwindow-warnings) https://github.com/bitcoin/bitcoin/pull/14879
< promag> MarcoFalke: re https://github.com/bitcoin/bitcoin/pull/14641#discussion_r239270214, what do you mean by "disallowing something else"?
< bitcoin-git> [bitcoin] promag opened pull request #14880: 0.17: Backport #14453 (0.17...2018-12-backport-14453) https://github.com/bitcoin/bitcoin/pull/14880