ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<luke-jr> [13:38] <luke-jr> update: apparently seone... <-- scratch that, seone apparently isn't tcatm
zeropoint has quit [Quit: leaving]
bitdex has quit [Ping timeout: 260 seconds]
mcey_ has quit [Ping timeout: 264 seconds]
mcey has joined #bitcoin-core-dev
disgruntled has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62ef33a718c9...5127844cabbe
<bitcoin-git> bitcoin/master b50d127 Hennadii Stepanov: refactor: Make 64-bit shift explicit
<bitcoin-git> bitcoin/master 5127844 merge-script: Merge bitcoin/bitcoin#30017: refactor, fuzz: Make 64-bit shift explicit
<bitcoin-git> [bitcoin] fanquake merged pull request #30017: refactor, fuzz: Make 64-bit shift explicit (master...240501-fix-shift) https://github.com/bitcoin/bitcoin/pull/30017
mcey has quit [Remote host closed the connection]
mcey has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
Saloframes has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<warren> https://twitter.com/wtogami/status/1786234311752253685 My suggestion is to focus on the tooling to isolate the tiny string differences in the downstream project and automatically re-merge upon tx checkout. This might have benefits to Core as well in being able to push some translations to PRs long before they are merged on Core. Whatever happens it is unproductive to further make each other mad over this. Please try to look at it from the
<warren> other side's POV.
<warren> hebasto: please remove me from the transifex admin. I don't want to be accused of having influence here while I haven't been a contributor here for a long time.
jonatack has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jamesob8 has joined #bitcoin-core-dev
jamesob has quit [Ping timeout: 252 seconds]
jamesob443688173 has quit [Ping timeout: 252 seconds]
jamesob8 is now known as jamesob
pablomartin has quit [Ping timeout: 272 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<laanwj> @warren thanks for trying to be constructive and not getting caught up in the drama... that's what we need right now...
MingxuanLi has joined #bitcoin-core-dev
MingxuanLi has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
blockdyor has joined #bitcoin-core-dev
myrrhhh has joined #bitcoin-core-dev
myrrhhh has quit [Changing host]
myrrhhh has joined #bitcoin-core-dev
<myrrhhh> where is laanw ?
<myrrhhh> we need him
<myrrhhh> where is laanw when we need him
<myrrhhh> we need laanw right inside our ass
<myrrhhh> merry christmas folks, bye now
myrrhhh has quit [Client Quit]
<laanwj> sigh...
<hebasto> warren: done
puchka has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5127844cabbe...99d7538cdb2a
<bitcoin-git> bitcoin/master 8496f69 glozow: [refactor] make MempoolAcceptResult::m_replaced_transactions non-optional
<bitcoin-git> bitcoin/master 9a762ef glozow: [txpackages] use std::lexicographical_compare instead of sorting hex strin...
<bitcoin-git> bitcoin/master c2ada05 glozow: [doc] remove redundant PackageToValidate comment
<bitcoin-git> [bitcoin] fanquake merged pull request #30012: opportunistic 1p1c followups (master...2024-05-1p1c-followups) https://github.com/bitcoin/bitcoin/pull/30012
PaperSword1 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 256 seconds]
PaperSword1 is now known as PaperSword
Miyah has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 264 seconds]
PaperSword1 is now known as PaperSword
Lockesmith has quit [Remote host closed the connection]
Lockesmith has joined #bitcoin-core-dev
vasild has quit [Quit: leaving]
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #30029: test: remove duplicate `WITNESS_SCALE_FACTOR` constant defination (master...05-2024-remove-duplicate-defination) https://github.com/bitcoin/bitcoin/pull/30029
Chris_Stewart_5 has quit [Ping timeout: 240 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
Guest35 has joined #bitcoin-core-dev
Guest35 has quit [Client Quit]
vasild has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
midnight_ has joined #bitcoin-core-dev
midnight has quit [Ping timeout: 268 seconds]
the_mariner has joined #bitcoin-core-dev
blockdyor has quit [Quit: Textual IRC Client: www.textualapp.com]
TallTim_ has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 256 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 256 seconds]
bitdex has quit [Ping timeout: 260 seconds]
Wronsk has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #30031: msvc: Compile `test\fuzz\miniscript.cpp` (master...240503-msvc-fuzz-miniscript) https://github.com/bitcoin/bitcoin/pull/30031
<pinheadmz> achow101: I was thinking you could start a blank repository in the organization for the moderation policy so the policy itself and list of moderators could be authored and reviewed by pull request. Then simply link from CONTRIBUTING in the code repo to that document.
<pinheadmz> cc ajonas
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
bitdex has quit [Quit: = ""]
Wronsk has quit [Remote host closed the connection]
TallTim_ is now known as TallTim
<bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99d7538cdb2a...70e4d6ff1d26
<bitcoin-git> bitcoin/master bd2de7a Hennadii Stepanov: refactor, test: Always initialize pointer
<bitcoin-git> bitcoin/master 70e4d6f Ryan Ofsky: Merge bitcoin/bitcoin#30026: refactor, test: Always initialize pointer
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30026: refactor, test: Always initialize pointer (master...240502-msvc-c4703) https://github.com/bitcoin/bitcoin/pull/30026
pablomartin has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
vasild has quit [Remote host closed the connection]
preimage has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<instagibbs> is there a good way to have a unit test halt immediately on first fatal error vs plowing through
<sipa> instagibbs: use BOOST_REQUIRE instead of BOOST_CHECK
<instagibbs> err, on a particular run without rewriting it(It's not telling me where the failure is on exit, pretty annoying)
<instagibbs> i stepped through to find it, like usual, but feels like there's a better way
<laanwj> setting a breakpoint on the check fail function would work, no idea how it's called though
the_mariner has quit [Remote host closed the connection]
the_mariner has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
cguida has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] hebasto closed pull request #30031: msvc: Compile `test\fuzz\miniscript.cpp` (master...240503-msvc-fuzz-miniscript) https://github.com/bitcoin/bitcoin/pull/30031
cguida_ has joined #bitcoin-core-dev
cguida has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] hebasto reopened pull request #30031: msvc: Compile `test\fuzz\miniscript.cpp` (master...240503-msvc-fuzz-miniscript) https://github.com/bitcoin/bitcoin/pull/30031
cguida_ has quit [Ping timeout: 268 seconds]
cguida_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] instagibbs opened pull request #30032: p2p: Allow 1P1C to fetch parent from compact block extra_txn (master...2024-05-opportunistic-extratxn) https://github.com/bitcoin/bitcoin/pull/30032
cguida_ has quit [Ping timeout: 255 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
the_mariner1 has joined #bitcoin-core-dev
sr_gi has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 272 seconds]
the_mariner1 is now known as the_mariner
sr_gi has quit [Remote host closed the connection]
sr_gi has joined #bitcoin-core-dev
sr_gi has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70e4d6ff1d26...f9486de6a96b
<bitcoin-git> bitcoin/master af3c181 ismaelsadeeq: [test]: remove duplicate WITNESS_SCALE_FACTOR
<bitcoin-git> bitcoin/master f9486de Ava Chow: Merge bitcoin/bitcoin#30029: test: remove duplicate `WITNESS_SCALE_FACTOR`...
<bitcoin-git> [bitcoin] achow101 merged pull request #30029: test: remove duplicate `WITNESS_SCALE_FACTOR` constant definition (master...05-2024-remove-duplicate-defination) https://github.com/bitcoin/bitcoin/pull/30029
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f9486de6a96b...f5b6f621fff7
<bitcoin-git> bitcoin/master ffc6745 Jon Atack: Replace remaining "520" magic numbers with MAX_SCRIPT_ELEMENT_SIZE
<bitcoin-git> bitcoin/master f5b6f62 Ava Chow: Merge bitcoin/bitcoin#30024: doc: replace remaining "520" magic nums with ...
<bitcoin-git> [bitcoin] achow101 merged pull request #30024: doc: replace remaining "520" magic nums with MAX_SCRIPT_ELEMENT_SIZE (master...2024-05-MAX_SCRIPT_ELEMENT_SIZE) https://github.com/bitcoin/bitcoin/pull/30024
<achow101> pinheadmz: that's a good idea
pablomartin has quit [Remote host closed the connection]
<achow101> Created https://github.com/bitcoin-core/meta for us to propose and discuss more specfic changes to the moderation guidelines
<pinheadmz> cool
Wronsk has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Guest23 has joined #bitcoin-core-dev
Guest23 has quit [Quit: Client closed]
cguida_ has joined #bitcoin-core-dev
aleggg has quit [Remote host closed the connection]
jonatack has quit [Ping timeout: 256 seconds]
aleggg has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #30034: ci: add markdown link check job (master...link-check-action) https://github.com/bitcoin/bitcoin/pull/30034
the_mariner has quit [Ping timeout: 268 seconds]
the_mariner1 is now known as the_mariner
preimage has quit [Quit: WeeChat 4.2.2]
<bitcoin-git> [bitcoin] paplorinc opened pull request #30035: test: Add a few more corner cases to the base58 test suite (master...paplorinc/base58-tests) https://github.com/bitcoin/bitcoin/pull/30035
___nick___ has quit [Ping timeout: 255 seconds]
Wronsk has quit [Ping timeout: 245 seconds]
jamesob has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
Miyah has quit [Quit: Miyah]
blockdyor has joined #bitcoin-core-dev
blockdyor has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
bugs_ has quit [Quit: Leaving]
Talkless has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
mcey has quit [Read error: Connection reset by peer]
twistedline_ has joined #bitcoin-core-dev
zeropoin1 has joined #bitcoin-core-dev
jrayhawk_ has joined #bitcoin-core-dev
twistedline has quit [Remote host closed the connection]
zeropoint has quit [Remote host closed the connection]
puchka has quit [Remote host closed the connection]
dermoth has quit [Remote host closed the connection]
dermoth_ has joined #bitcoin-core-dev
puchka1101 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
dermoth_ is now known as dermoth
abubakarsadiq has quit [Quit: Connection closed for inactivity]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]