#bitcoin-core-dev on 2024-05-07 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:01 the_mariner has joined #bitcoin-core-dev

00:05 the_mariner has quit [Ping timeout: 255 seconds]

00:18 jonatack has quit [Ping timeout: 255 seconds]

00:39 zeropoint has quit [Quit: leaving]

00:39 the_mariner has joined #bitcoin-core-dev

00:46 Guest82 has joined #bitcoin-core-dev

00:48 the_mariner has quit [Ping timeout: 256 seconds]

00:56 brunoerg has joined #bitcoin-core-dev

00:58 Guest82 has quit [Quit: Client closed]

01:01 brunoerg has quit [Ping timeout: 246 seconds]

01:05 cryptapus has quit [Quit: Konversation terminated!]

01:07 cryptapus has joined #bitcoin-core-dev

01:08 the_mariner has joined #bitcoin-core-dev

01:11 maflcko has quit [Ping timeout: 255 seconds]

01:12 maflcko has joined #bitcoin-core-dev

01:12 hel has quit [Read error: Connection reset by peer]

01:13 the_mariner has quit [Ping timeout: 256 seconds]

01:13 hel has joined #bitcoin-core-dev

01:24 the_mariner has joined #bitcoin-core-dev

01:29 the_mariner has quit [Ping timeout: 260 seconds]

01:29 brunoerg has joined #bitcoin-core-dev

01:34 brunoerg has quit [Ping timeout: 260 seconds]

01:46 the_mariner has joined #bitcoin-core-dev

01:46 brunoerg has joined #bitcoin-core-dev

01:51 the_mariner has quit [Ping timeout: 272 seconds]

01:52 brunoerg has quit [Ping timeout: 272 seconds]

01:55 abubakarsadiq has quit [Quit: Connection closed for inactivity]

02:15 brunoerg has joined #bitcoin-core-dev

02:23 the_mariner has joined #bitcoin-core-dev

02:28 the_mariner has quit [Ping timeout: 255 seconds]

02:29 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/63d0b930f821...ef09f535b7b5

02:29 <bitcoin-git> bitcoin/master 7766dd2 laanwj: net: Replace ifname check with IFF_LOOPBACK in Discover

02:29 <bitcoin-git> bitcoin/master a68fed1 laanwj: net: Fix misleading comment for Discover

02:29 <bitcoin-git> bitcoin/master ef09f53 merge-script: Merge bitcoin/bitcoin#29984: net: Replace ifname check with IFF_LOOPBACK i...

02:29 <bitcoin-git> [bitcoin] fanquake merged pull request #29984: net: Replace ifname check with IFF_LOOPBACK in Discover (master...2024-04-iff-loopback) https://github.com/bitcoin/bitcoin/pull/29984

02:34 Guest82 has joined #bitcoin-core-dev

02:35 Guest82 has quit [Client Quit]

02:35 Guest82 has joined #bitcoin-core-dev

02:36 Guest82 has quit [Client Quit]

02:37 brunoerg has quit [Ping timeout: 255 seconds]

02:55 the_mariner has joined #bitcoin-core-dev

03:02 the_mariner has quit [Ping timeout: 256 seconds]

03:08 brunoerg has joined #bitcoin-core-dev

03:13 brunoerg has quit [Ping timeout: 268 seconds]

03:26 brunoerg has joined #bitcoin-core-dev

03:31 brunoerg has quit [Ping timeout: 268 seconds]

03:32 the_mariner has joined #bitcoin-core-dev

03:35 hel has quit [Read error: Connection reset by peer]

03:37 the_mariner has quit [Ping timeout: 268 seconds]

03:42 jonatack has joined #bitcoin-core-dev

03:45 jon_atack has joined #bitcoin-core-dev

03:46 hel has joined #bitcoin-core-dev

03:48 jonatack has quit [Ping timeout: 255 seconds]

03:49 the_mariner has joined #bitcoin-core-dev

03:53 the_mariner has quit [Ping timeout: 255 seconds]

03:59 brunoerg has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:04 brunoerg has quit [Ping timeout: 268 seconds]

04:13 bitdex has joined #bitcoin-core-dev

04:32 brunoerg has joined #bitcoin-core-dev

04:37 the_mariner has joined #bitcoin-core-dev

04:38 brunoerg has quit [Ping timeout: 252 seconds]

04:44 the_mariner has quit [Ping timeout: 256 seconds]

05:04 the_mariner has joined #bitcoin-core-dev

05:07 brunoerg has joined #bitcoin-core-dev

05:09 the_mariner has quit [Ping timeout: 256 seconds]

05:11 brunoerg has quit [Ping timeout: 256 seconds]

05:17 jonatack has joined #bitcoin-core-dev

05:19 jon_atack has quit [Ping timeout: 256 seconds]

05:24 brunoerg has joined #bitcoin-core-dev

05:37 the_mariner has joined #bitcoin-core-dev

05:42 the_mariner has quit [Ping timeout: 260 seconds]

05:51 the_mariner has joined #bitcoin-core-dev

05:55 the_mariner has quit [Ping timeout: 255 seconds]

06:25 jonatack has quit [Ping timeout: 264 seconds]

06:26 jonatack has joined #bitcoin-core-dev

06:27 the_mariner has joined #bitcoin-core-dev

06:29 brunoerg has quit [Ping timeout: 268 seconds]

06:31 the_mariner has quit [Ping timeout: 252 seconds]

06:41 brunoerg has joined #bitcoin-core-dev

06:46 brunoerg has quit [Ping timeout: 272 seconds]

06:49 dviola has joined #bitcoin-core-dev

06:57 <bitcoin-git> [bitcoin] maflcko opened pull request #30054: ci: Exclude feature_init for now in valgrind task (master...2405-ci-val-init) https://github.com/bitcoin/bitcoin/pull/30054

07:10 Zenton has quit [Ping timeout: 252 seconds]

07:15 brunoerg has joined #bitcoin-core-dev

07:22 brunoerg has quit [Ping timeout: 255 seconds]

07:48 vyHamii has joined #bitcoin-core-dev

07:51 brunoerg has joined #bitcoin-core-dev

07:54 abubakarsadiq has joined #bitcoin-core-dev

07:58 brunoerg has quit [Ping timeout: 256 seconds]

08:02 Zenton has joined #bitcoin-core-dev

08:12 Guyver2 has joined #bitcoin-core-dev

08:21 brunoerg has joined #bitcoin-core-dev

08:23 Chris_Stewart_5 has quit [Ping timeout: 264 seconds]

08:26 brunoerg has quit [Ping timeout: 256 seconds]

08:32 the_mariner has joined #bitcoin-core-dev

08:36 the_mariner has quit [Ping timeout: 240 seconds]

08:41 brunoerg has joined #bitcoin-core-dev

08:45 brunoerg has quit [Ping timeout: 268 seconds]

08:53 the_mariner has joined #bitcoin-core-dev

08:58 the_mariner has quit [Ping timeout: 260 seconds]

08:58 brunoerg has joined #bitcoin-core-dev

09:00 <bitcoin-git> [bitcoin] vasild closed pull request #22563: addrman: treat Tor/I2P/CJDNS as a single group (master...addrman_per_group_bucketing) https://github.com/bitcoin/bitcoin/pull/22563

09:05 the_mariner has joined #bitcoin-core-dev

09:10 the_mariner has quit [Ping timeout: 268 seconds]

09:22 Guyver2 has left #bitcoin-core-dev [Closing Window]

09:24 the_mariner has joined #bitcoin-core-dev

09:25 brunoerg has quit [Ping timeout: 252 seconds]

09:31 the_mariner has quit [Ping timeout: 256 seconds]

09:39 brunoerg has joined #bitcoin-core-dev

09:43 brunoerg has quit [Ping timeout: 256 seconds]

09:44 lbia has quit [Ping timeout: 264 seconds]

09:48 r3rer3 has joined #bitcoin-core-dev

09:54 the_mariner has joined #bitcoin-core-dev

09:56 brunoerg has joined #bitcoin-core-dev

09:58 the_mariner has quit [Ping timeout: 260 seconds]

10:01 brunoerg has quit [Ping timeout: 260 seconds]

10:13 the_mariner has joined #bitcoin-core-dev

10:17 the_mariner has quit [Ping timeout: 260 seconds]

10:22 brunoerg has joined #bitcoin-core-dev

10:28 Guest21 has joined #bitcoin-core-dev

10:28 brunoerg has quit [Ping timeout: 255 seconds]

10:28 Guest21 has quit [Client Quit]

10:42 brunoerg has joined #bitcoin-core-dev

10:48 brunoerg has quit [Ping timeout: 268 seconds]

10:49 the_mariner has joined #bitcoin-core-dev

10:54 the_mariner has quit [Ping timeout: 256 seconds]

10:54 the_mariner has joined #bitcoin-core-dev

11:00 the_mariner has quit [Ping timeout: 256 seconds]

11:05 brunoerg has joined #bitcoin-core-dev

11:12 brunoerg has quit [Ping timeout: 256 seconds]

11:15 the_mariner has joined #bitcoin-core-dev

11:19 the_mariner has quit [Ping timeout: 255 seconds]

11:29 the_mariner has joined #bitcoin-core-dev

11:41 brunoerg has joined #bitcoin-core-dev

11:46 brunoerg has quit [Ping timeout: 246 seconds]

12:00 brunoerg has joined #bitcoin-core-dev

12:05 brunoerg has quit [Ping timeout: 255 seconds]

12:33 brunoerg has joined #bitcoin-core-dev

12:34 VonNaturAustreVe has joined #bitcoin-core-dev

12:39 brunoerg has quit [Ping timeout: 260 seconds]

12:40 bitdex has quit [Quit: = ""]

12:50 brunoerg has joined #bitcoin-core-dev

13:21 luke-jr has quit [Read error: Connection reset by peer]

13:21 luke-jr has joined #bitcoin-core-dev

13:50 brunoerg_ has joined #bitcoin-core-dev

13:52 adil has joined #bitcoin-core-dev

13:53 adil has quit [Client Quit]

13:53 brunoerg has quit [Ping timeout: 255 seconds]

14:08 mailman has joined #bitcoin-core-dev

14:09 mailman has quit [Client Quit]

14:12 mailman has joined #bitcoin-core-dev

14:13 mailman has quit [Remote host closed the connection]

14:20 Chris_Stewart_5 has joined #bitcoin-core-dev

14:22 jonatack has quit [Ping timeout: 264 seconds]

14:58 <vasild> When I visit the topmost commit at https://github.com/bitcoin/bitcoin/commit/ef09f535b7b540d997f8c2bfa67b3386711bc8b4 there is a message "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository." which is strange. Surely that commit belongs to the master branch. I think it was not shown before.

14:59 <sipa> vasild: i see that message all the time, and have no clue what it means

15:01 <vasild> well, the intention is to warn if one opens a commit that does not belong to any branch. E.g. that commit may only be in an unmerged pull request. I think before people were fooled that some change existed in https://github.com/bitcoin/bitcoin/ this way

15:04 <vasild> looks like a (new?) bug in github to show that message for commits that actually belong to the master branch

15:08 <_aj_> vasild: i don't see any reports of it, perhaps worth filing one at https://github.com/orgs/community/discussions/categories/general ?

15:09 <vasild> is this the place to submit github bugs? let me try some other repositories...

15:10 <sipa> i'm pretty sure i have seen that behavior since forever

15:11 <sipa> though i've never investigated whether it's just confusing, or a bug

15:12 <instagibbs> on the actual branch seems new? but who knows

15:13 <sipa> maybe it's just an out of date cache?

15:13 <_aj_> i've only ever noticed it occurring in places i expect, so seems new to me too, but *shrug*

15:15 <vasild> here no https://github.com/freebsd/freebsd-ports/commit/a3136faade21a9cfb7ab89b0db1ecb6c68f6504b, here yes: https://github.com/vim/vim/commit/8d8cb45756cb7e6fda17013b8347be3a11b29610

15:29 <vasild> reported here https://github.com/orgs/community/discussions/122781

15:30 <sipa> vasild: that example works for me...

15:30 <sipa> https://github.com/vim/vim/commit/8d8cb45756cb7e6fda17013b8347be3a11b29610 doesn't have the banner, and lists "

15:30 <sipa> master" below

15:31 <_aj_> vim no longer has the banner for me, did earlier

15:31 <vasild> :-/ I will post a screen shot then and more examples...

15:38 pablomartin has joined #bitcoin-core-dev

15:39 <vasild> updated https://github.com/orgs/community/discussions/122781 with screenshots

15:41 preimage has joined #bitcoin-core-dev

15:45 jarthur has joined #bitcoin-core-dev

16:25 zeropoint has joined #bitcoin-core-dev

16:27 the_mariner1 has joined #bitcoin-core-dev

16:31 the_mariner1 has quit [Ping timeout: 246 seconds]

16:31 the_mariner has quit [Ping timeout: 268 seconds]

16:31 the_mariner has joined #bitcoin-core-dev

16:38 pablomartin has quit [Ping timeout: 252 seconds]

16:46 the_mariner1 has joined #bitcoin-core-dev

16:49 the_mariner has quit [Ping timeout: 268 seconds]

16:49 the_mariner1 is now known as the_mariner

16:54 the_mariner1 has joined #bitcoin-core-dev

16:55 the_mariner has quit [Ping timeout: 240 seconds]

16:56 the_mariner has joined #bitcoin-core-dev

16:58 the_mariner1 has quit [Ping timeout: 272 seconds]

16:59 Talkless has joined #bitcoin-core-dev

17:19 bugs_ has joined #bitcoin-core-dev

17:51 brunoerg_ has quit [Remote host closed the connection]

17:52 brunoerg has joined #bitcoin-core-dev

17:57 brunoerg has quit [Ping timeout: 256 seconds]

18:02 hel has quit [Quit: ""]

18:07 hel has joined #bitcoin-core-dev

18:10 brunoerg has joined #bitcoin-core-dev

18:14 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ef09f535b7b5...8efd03ad0472

18:14 <bitcoin-git> bitcoin/master dddd40b MarcoFalke: scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes

18:14 <bitcoin-git> bitcoin/master fa09451 MarcoFalke: Add lint check for bitcoin-config.h include IWYU pragma

18:14 <bitcoin-git> bitcoin/master 8efd03a Ava Chow: Merge bitcoin/bitcoin#29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma ...

18:14 <bitcoin-git> [bitcoin] achow101 merged pull request #29494: build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes (master...2402-iwyu-bitcoin-config-) https://github.com/bitcoin/bitcoin/pull/29494

18:15 brunoerg has quit [Ping timeout: 256 seconds]

18:16 hernanmarino has joined #bitcoin-core-dev

18:33 hernanmarino has quit [Quit: ZNC 1.8.2+deb2 - https://znc.in]

18:35 hernanmarino has joined #bitcoin-core-dev

18:43 the_mariner has quit [Ping timeout: 256 seconds]

18:44 the_mariner has joined #bitcoin-core-dev

18:44 brunoerg has joined #bitcoin-core-dev

18:48 the_mariner has quit [Ping timeout: 252 seconds]

18:49 brunoerg has quit [Ping timeout: 246 seconds]

18:49 Wronsk has joined #bitcoin-core-dev

19:07 Talkless has quit [Quit: Konversation terminated!]

19:11 brunoerg has joined #bitcoin-core-dev

19:31 jonatack has joined #bitcoin-core-dev

19:34 Wronsk has quit [Remote host closed the connection]

19:49 VonNaturAustreVe has quit [Quit: Leaving]

20:34 preimage has quit [Quit: WeeChat 4.2.2]

20:34 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8efd03ad0472...4e56df8f915b

20:34 <bitcoin-git> bitcoin/master fb9f150 willcl-ark: gui: fix misleading signmessage error with segwit

20:34 <bitcoin-git> bitcoin/master 4e56df8 merge-script: Merge bitcoin-core/gui#819: Fix misleading signmessage error with segwit

20:35 <bitcoin-git> [gui] hebasto merged pull request #819: Fix misleading signmessage error with segwit (master...signmessage-error-fix) https://github.com/bitcoin-core/gui/pull/819

20:49 ___nick___ has joined #bitcoin-core-dev

20:51 ___nick___ has quit [Client Quit]

20:53 ___nick___ has joined #bitcoin-core-dev

20:55 ___nick___ has quit [Client Quit]

20:57 ___nick___ has joined #bitcoin-core-dev

21:31 ___nick___ has quit [Ping timeout: 255 seconds]

21:31 mudsip has joined #bitcoin-core-dev

21:32 mudsip has quit [Client Quit]

21:40 pablomartin has joined #bitcoin-core-dev

21:52 brunoerg has quit [Remote host closed the connection]

21:59 abubakarsadiq has quit [Quit: Connection closed for inactivity]

22:21 bugs_ has quit [Quit: Leaving]

22:23 pablomartin has quit [Ping timeout: 255 seconds]

22:32 <bitcoin-git> [bitcoin] stickies-v opened pull request #30058: Encapsulate warnings in generalized node::Warnings and remove globals (master...2024-04/move-warnings-node) https://github.com/bitcoin/bitcoin/pull/30058

22:56 yonson has quit [Remote host closed the connection]

22:58 yonson has joined #bitcoin-core-dev

23:41 Chris_Stewart_5 has quit [Ping timeout: 264 seconds]