<bitcoin-git>
[gui] hebasto opened pull request #931: Release: Update src/qt/locale/bitcoin_en.xlf after string freeze (master...260220-tr) https://github.com/bitcoin-core/gui/pull/931
enochazariah has joined #bitcoin-core-dev
enochazariah has quit [Client Quit]
enochazariah has joined #bitcoin-core-dev
<enochazariah>
I see PR #34184 addresses a template flood during IBD/catch-up. Conceptually, why does the node even generate/send templates during this phase? Shouldn't it suppress all mining activity until it is fully caught up to the network tip?
<Sjors[m]1>
enochazariah: it's similar to the getblocktemplate RPC, which you can also call before we're fully caught up. If you call it again immedidately after it returns you also get a flood.
<Sjors[m]1>
But the IPC is designed to be push rather than poll based, so the problem is a bit more pronounced.
<Sjors[m]1>
There's no independent mining process in the node. It generates a new block template when you ask for one.
<Sjors[m]1>
#33421 is a step in that direction though
<enochazariah>
OKay, that makes sense. RPC was 'pull' so the client set the pace, but IPC 'pushes' on every tip update, which exposes the flood during catchup. Makes sense why we need the cooldown until we get proper manager logic
<enochazariah>
Thanks
adil has joined #bitcoin-core-dev
tarotfied has quit [Server closed connection]
tarotfied has joined #bitcoin-core-dev
adil has quit [Quit: adil]
<fanquake>
Sjors[m]1: looking at #33777, what things are actual bugfixes/regressions, and should ship, as opposed to nice to have
<fanquake>
It sucks if things haven't gotten review this cycle, but I'm not sure about listing a bunch of (conflicting) things for v31, on the day of feature freeze
<fanquake>
Seems like this list should have appeared 2-3 months ago
<fanquake>
I take it any of the fixes have already been confirmed as working from downstream?
<Sjors[m]1>
The first 3 are a package that fix node crashes by connected IPC clients. It first adds a test, then fixes it in libmultiprocess and then pulls the fix in.
<Sjors[m]1>
The last one fixes a flood of templates, as discussed above. It's been actively reviewed over the past month or two, but had to be based on #34568, which just got merged today.
<Sjors[m]1>
Neither are breaking changes, so if they end up in v32.1 backport that's not the end of the world.
<Sjors[m]1>
v31.1 I mean
<Sjors[m]1>
Added clarification to the tracking issue.
Ara has quit [Server closed connection]
Ara has joined #bitcoin-core-dev
theStack has quit [Quit: theStack]
theStack has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 269 seconds]
<bitcoin-git>
[bitcoin] hodlinator closed pull request #31929: http: Make server shutdown more robust (master...2025/02/stop_http_robust) https://github.com/bitcoin/bitcoin/pull/31929
<bitcoin-git>
[bitcoin] ryanofsky closed pull request #34284: ipc, test: Add tests for unclean disconnect and thread busy behavior (master...pr/ipc-testasync) https://github.com/bitcoin/bitcoin/pull/34284
<bitcoin-git>
[bitcoin] l0rinc closed pull request #31644: leveldb: show non-default options during init (master...l0rinc/leveldb-options-logging) https://github.com/bitcoin/bitcoin/pull/31644
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
svanstaa has quit [Ping timeout: 264 seconds]
svanstaa_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #34639: iwyu: Remove some `pragma: export` and other improvements (master...260220-iwyu-pragma) https://github.com/bitcoin/bitcoin/pull/34639
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]