<bitcoin-git>
[bitcoin] theStack opened pull request #34796: rpc, net: remove `startingheight` field of `getpeerinfo` RPC and from node state (master...2026-remove-starting_height_field) https://github.com/bitcoin/bitcoin/pull/34796
dzxzg has quit [Remote host closed the connection]
adil has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 258 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 246 seconds]
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 258 seconds]
Name_Brian-Hughe has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 258 seconds]
Name_Brian-Hughe has quit [Quit: Client closed]
Satoshi_N_Brian has joined #bitcoin-core-dev
Satoshi_N_Brian has quit [Client Quit]
enochazariah has joined #bitcoin-core-dev
Satoshi_N_Brian has joined #bitcoin-core-dev
Satoshi_N_Brian has quit [Client Quit]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 258 seconds]
w0xlt has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 258 seconds]
svanstaa has quit [Ping timeout: 255 seconds]
svanstaa has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 248 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 276 seconds]
memset has quit [Remote host closed the connection]
enochazariah has quit [Ping timeout: 240 seconds]
memset has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
w0xlt has quit [Ping timeout: 248 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 248 seconds]
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
w0xlt has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 258 seconds]
w0xlt has quit [Ping timeout: 264 seconds]
ghost43 has joined #bitcoin-core-dev
maflcko has quit [Ping timeout: 276 seconds]
maflcko has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
adil has quit [Ping timeout: 248 seconds]
adil has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 73e3853 Martin Zumsande: test: add test for rebroadcast of transaction received via p2p
<bitcoin-git>
bitcoin/master 3201abe merge-script: Merge bitcoin/bitcoin#34359: test: add test for rebroadcast of transaction...
<bitcoin-git>
[bitcoin] sedited merged pull request #34359: test: add test for rebroadcast of transaction received via p2p (master...202601_test_rebroadcast) https://github.com/bitcoin/bitcoin/pull/34359
<bitcoin-git>
[bitcoin] mangoostaa opened pull request #34797: Improved CustomBuildField for std::optional in IPC/libmultiprocess (master...feature/optional-forward) https://github.com/bitcoin/bitcoin/pull/34797
<bitcoin-git>
bitcoin/master af041c4 Ava Chow: wallet: Always rewrite tx records during migration
<bitcoin-git>
bitcoin/master 63f2772 merge-script: Merge bitcoin/bitcoin#32985: wallet: Always rewrite tx records during migr...
<bitcoin-git>
[bitcoin] sedited merged pull request #32985: wallet: Always rewrite tx records during migration (master...migratewallet-rewrite-txs) https://github.com/bitcoin/bitcoin/pull/32985
<bitcoin-git>
[bitcoin] sedited closed pull request #34797: Improved CustomBuildField for std::optional in IPC/libmultiprocess (master...feature/optional-forward) https://github.com/bitcoin/bitcoin/pull/34797
<_aj_>
sedited: 34692 as "achow101 merged commit" prior to darosior's "Oh really?" comment for me. i wonder if it'll appear later after github runs a cron job or something maybe
<sedited>
_aj_ huh you're right, could have sworn that it wasn't there before.
enochazariah has quit [Quit: Client closed]
jonatack has quit [Ping timeout: 268 seconds]
enochazariah has joined #bitcoin-core-dev
<real_or_random>
Potentially dangerous email: I just got an email "Job Application: Contribution to bitcoin-abc" which was apparently also addressed to some other contributors... Ignoring the fact that we're not bitcoin-abc and you don't apply to an open source project, it has a PDF attached. I don't want to open that one.
<bitcoin-git>
[bitcoin] sedited merged pull request #34436: refactor: add overflow-safe `CeilDiv` helper and use it in unsigned callsites (master...l0rinc/ceildiv-utxo-flush-gib) https://github.com/bitcoin/bitcoin/pull/34436
<bitcoin-git>
[bitcoin] maflcko opened pull request #34799: rpc: Run type check on decodepsbt result (master...2603-rpc-elision-type-check) https://github.com/bitcoin/bitcoin/pull/34799
l0rinc has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 264 seconds]
pablomartin has joined #bitcoin-core-dev
adil has quit [Quit: adil]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
flooded has joined #bitcoin-core-dev
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fanquake closed pull request #34293: Bugfix: net_processing: Restore missing comma between peer and peeraddr in "receive version message" and "New ___ peer connected" (master...fix_vermsg_missing_comma) https://github.com/bitcoin/bitcoin/pull/34293
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #34804: Update libmultiprocess subtree to fix race conditions on disconnects (master...pr/subtree-9) https://github.com/bitcoin/bitcoin/pull/34804
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
timbo_xyz has quit [Quit: WeeChat 4.8.1]
bugs_ has joined #bitcoin-core-dev
<darosior>
_aj_: so your approach is to keep the upgrade logic for all bits, just not warn for unknown deployments using bits >= 5. If those bits are to be used as extranonce going forward, why should we continue supporting soft fork deployments using those?
<darosior>
Of course one advantage of your approach is that it's a smaller diff, which is essentially answering my question with "because the tests are using some of them". But i don't find that too convincing, because we should test what we intend to support.
_andrewtoth_ has quit [Remote host closed the connection]
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<_aj_>
darosior: so that we can keep testdummy around to test depoyments even when we have no active/historical versionbits deployments in the code, and so that we can keep it set at a value that will never interfere with any active deployment we'll use <-- would be the positive argument. shorter diff, avoid touching consensus == easier review would be the lazy argument
<bitcoin-git>
qa-assets/main d00c4f8 maflcko: Merge pull request #262 from maflcko/main
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
afiore_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] ajtowns opened pull request #34806: refactor: logging: Various API improvements (master...202603-log-niceties2) https://github.com/bitcoin/bitcoin/pull/34806
afiore has quit [Ping timeout: 258 seconds]
afiore_ is now known as afiore
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
<bitcoin-git>
[bitcoin] theStack opened pull request #34807: kernel: doc: explain return value for `btck_WriteBytes` callback (master...202603-kernel-document-btck_WriteBytes-retval) https://github.com/bitcoin/bitcoin/pull/34807
_andrewtoth_ has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
<dzxzg>
Should a node process the header from a protocol-violating CMPCTBLOCK message it receives?
<dzxzg>
e.g. if a `-blocksonly` node that never sends its peers a `SENDCMPCT` receives a CMPCTBLOCK, #32606 as-is processes the header and then drops the message, but should it be dropped without processing the header?
<corebot`>
dzxzg: Error: That URL appears to have no HTML title within the first 32KB.
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
halloy8692 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #34808: cmake, translation: Use native Qt TS file as source for transaltions on Transifex (master...260311-qt-ts-source) https://github.com/bitcoin/bitcoin/pull/34808
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
corebot` has quit [Remote host closed the connection]
w0xlt has quit [Ping timeout: 246 seconds]
jerryf has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
corebot has joined #bitcoin-core-dev
achow101 has joined #bitcoin-core-dev
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior closed pull request #34779: BIP xxx: reserve version bits 5-28 as extra nonce space (master...2602_more_version_bits_rolling) https://github.com/bitcoin/bitcoin/pull/34779
<bitcoin-git>
[bitcoin] darosior reopened pull request #34779: BIP xxx: reserve version bits 5-28 as extra nonce space (master...2602_more_version_bits_rolling) https://github.com/bitcoin/bitcoin/pull/34779
w0xlt has quit [Ping timeout: 276 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]