< dcousens> explains the locking too
< diegoviola> heya
< diegoviola> will bitcoin core implement SPV like electrum and seeds?
< diegoviola> I'd like to use core but I can't afford to download the whole blockchain
< diegoviola> my connection sucks
< diegoviola> my internet is only 1mb
< diegoviola> :-(
< belcher> once you have it all downloaded and verified you wont use much bandwidth at all
< diegoviola> sure but will take days to download it
< belcher> oh damn this channel, didnt realise, ask in #bitcoin
< diegoviola> k
< phantomcircuit> gmaxwell, that's interesting, it looks like if we fail to load a key from the wallet we exit without writing anything to the log
< phantomcircuit> oh nvm...
< dcousens> morcos: still intending to help with those stats, just waiting for a re-index to finish
< GitHub195> [bitcoin] laanwj opened pull request #6919: Backport chainstate obfuscation to 0.11 (0.11...2015_10_backport_chainstate_obfuscation) https://github.com/bitcoin/bitcoin/pull/6919
< gmaxwell> wumpus: sorry if I came across as suggesting we should wait on #6917 for any reason; that wasn't my goal. Rather, earlier you mentioned some doubt on which sync operation needed to do what, and maybe the new behavior is too strong, and my thought was if there isn't a performance regression "who cares, don't bother thinking about it."
< wumpus> I think that optimization on windows should be a different issue. It's not like we ever paid attention to that before :-) I agree with sipa that benchmarking before and after would be nice - though I'm not sure exactly how - I have a slow windows laptop, probably bogged down by lots of crap, so I doubt it will yield any resuls within the noise margin :-)
< wumpus> (that said, having looked at various syncs of block 0 to block 200000, I didn't notice any noticable difference)
< wumpus> (and benchmarking in wine wouldn't be interesting, as these are exactly the OS specific things...)
< wumpus> goal of Flush() seems to be 'flush application and OS buffers to file' and Sync() 'flush buffers to file, then wait for sync to disk to complete'. As far as I see windows' FlushFileBuffers has no way to distinguish between them
< wumpus> what the previous implementation did was to leave Flush() empty. But that doesn't feel right at least...
< wumpus> ... it's something that could be done again later if it turns out to be safe
< wumpus> (e.g. I think the rationale for that is "by using the OS API directly, anything written is by definition flushed to the OS". The POSIX implementation uses FILE* which has its own bufers)
< wumpus> (then uses fflush in Flush(), "forces a write of all user-space buffered data for the given output or update stream via the stream's underlying write function". Yeah we don't need that...)
< GitHub48> [bitcoin] Diapolo opened pull request #6920: remove unneded include from rpcserver.cpp and rpcclient.cpp (master...univalue) https://github.com/bitcoin/bitcoin/pull/6920
< gmaxwell> Can we ask diapolo to test this leveldb fix?
< GitHub69> [bitcoin] Diapolo opened pull request #6921: [Trivial] remove unneeded spaces from init.cpp (master...trivial_typo_space) https://github.com/bitcoin/bitcoin/pull/6921
< wumpus> I think so!
< gmaxwell> Does github have messaging?
< wumpus> nope, all you can do si @ someone
< gmaxwell> "The edge of what?" "No one is sure..."
< wumpus> yes, that edge ;-)
< gmaxwell> Writefile and such isn't buffered like (some) libc functions?
< wumpus> it's more like write() - a sytem call
< wumpus> using libc and FILE* would be possible on windows too, but I'm not convinced of those in mingw
< wumpus> (and the Sync requires an ugly construct to unwrap the file handle then, as we do here https://github.com/bitcoin/bitcoin/blob/master/src/util.cpp#L608 )
< GitHub10> [bitcoin] Diapolo opened pull request #6922: minor updates/changes in txmempool.h/.cpp (master...txmempool) https://github.com/bitcoin/bitcoin/pull/6922
< wumpus> sigh....
< * wumpus> kicks diapolo
< wumpus> way to drown out the super cool work have been doing lately in 'let's fudge two lines areound' kind of pulls...
< wumpus> +people
< wumpus> "strip: unable to rename 'bitcoin-qt.exe'; reason: File exists"
< CodeShark> do node count statistics going back more than two years exist? or at least reasonable estimates?
< CodeShark> or if not continuous data at least a few discrete samples
< wumpus> I don't think so (you may be better off asking in #bitcoin though, apart from the counting methodology this is not essentially dev related)
< GitHub88> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/48b5b84ee511...a6e80e401716
< GitHub88> bitcoin/master c939792 Peter Todd: Add BIP65 CHECKLOCKTIMEVERIFY to release notes
< GitHub88> bitcoin/master a6e80e4 Wladimir J. van der Laan: Merge pull request #6883...
< GitHub104> [bitcoin] laanwj closed pull request #6883: Add BIP65 CHECKLOCKTIMEVERIFY to release notes (master...cltv-release-notes-v0.12.0) https://github.com/bitcoin/bitcoin/pull/6883
< gmaxwell> FWIW, I think testnet has activated BIP65.
< phantomcircuit> gmaxwell, not clear to me which chain is longer though...
< tulip> phantomcircuit: on 0.11.0 I'm seeing the expected "This version is obsolete; upgrade required!".
< phantomcircuit> the chains are equal length now...
< GitHub125> [bitcoin] laanwj closed pull request #6921: [Trivial] remove unneeded spaces from init.cpp (master...trivial_typo_space) https://github.com/bitcoin/bitcoin/pull/6921
< tulip> phantomcircuit: yeah, bouncing between tips.
< GitHub197> [bitcoin] laanwj closed pull request #6920: remove unneded include from rpcserver.cpp and rpcclient.cpp (master...univalue) https://github.com/bitcoin/bitcoin/pull/6920
< GitHub161> [bitcoin] Diapolo closed pull request #6922: minor updates/changes in txmempool.h/.cpp (master...txmempool) https://github.com/bitcoin/bitcoin/pull/6922
< GitHub49> [bitcoin] Diapolo closed pull request #6710: [Qt] polish new ban ui from #6315 (master...polish_ban_ui) https://github.com/bitcoin/bitcoin/pull/6710
< GitHub100> [bitcoin] Diapolo closed pull request #6371: banlist updates (master...banlist) https://github.com/bitcoin/bitcoin/pull/6371
< GitHub180> [bitcoin] Diapolo closed pull request #6309: [Qt] simplify code for third party TX urls handling (master...txurls) https://github.com/bitcoin/bitcoin/pull/6309
< GitHub0> [bitcoin] Diapolo closed pull request #5466: [Qt] log cert errors for payment requests and harden test-cases (master...pr_harden_certchecks) https://github.com/bitcoin/bitcoin/pull/5466
< jonasschnelli> ^^ Diaplolo is closing..
< dcousens> and deleting
< dcousens> shouldn't BIP65 be Accepted now?
< gmaxwell> dcousens: no, accepted status changes based on adoption in the network.
< gmaxwell> who gives a crap what some random software repository does?
< phantomcircuit> gmaxwell, the chainwork value in getblockchaininfo
< phantomcircuit> lower values means more total work right?
< phantomcircuit> heh well this certainly shows that a 75% threshold for switch over is a bad idea
< phantomcircuit> testnet is now 50/50 split between bip65 and !bip65
< CodeShark_> still? lol
< phantomcircuit> there's even someone mining version=2 blocks still
< phantomcircuit> also no bigger numbers == more work
< GitHub162> [bitcoin] BTCDDev opened pull request #6925: Added zmq flag for owned transactions (master...master) https://github.com/bitcoin/bitcoin/pull/6925