< jcorgan> amazing
< sipa> we've had those for ages
< dcousens> I don't know how it happens so often...
< GitHub123> [bitcoin] gmaxwell closed pull request #6935: 0.10 (master...0.10) https://github.com/bitcoin/bitcoin/pull/6935
< phantomcircuit> dcousens, shiny green button
< dcousens> lol
< dcousens> But, they don't even apologize, or close it
< dcousens> Just straight up "everything is fine"
< gmaxwell> dcousens: I think a lot of the people who do this don't read english very well.
< gmaxwell> if so, their derpy behavior is much more understandable.
< sipa> gmaxwell: github being confused and showing comments on commits in the PR
< jcorgan> is github the blockchain.info of web-based repositories? :-)
< sipa> yes
< gmaxwell> sipa: oh right, I forgot about that, it looked like a comment on the psycho PR. It's normally more obvious.
< dcousens> gmaxwell: ah, no, there are commits on the PR, but that last one is fresh AFAIK
< dcousens> comments on the commits*
< dcousens> Ref, its an "issuecomment", not a "commitcomment"
< dcousens> See your link above
< gmaxwell> interesting.
< dcousens> subtle version of 'wut'
< GitHub186> [bitcoin] arowser opened pull request #6937: Fix Boots 1.58.0 build for mips arch (master...mips-options-fix) https://github.com/bitcoin/bitcoin/pull/6937
< arowser> The Boost 1.58 can't support build for MIPS32 on a x86_64 machine, its a known bug https://github.com/boostorg/build/pull/71
< midnightmagic> You *may* wish to temporarily /mode * +b $j:#bitcoin-global-bans while we track that guy.
< MarcoFalke> wumpus, fyi. ERROR: cannot verify dev.visucore.com's certificate:
< MarcoFalke> Issued certificate has expired.
< wumpus> yeh, need to replace them
< wumpus> it's that time of the year again
< wumpus> ok, certs upgraded @MarcoFalke
< jonasschnelli> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/6917#issuecomment-153667846 ... do you thing a sudden VMWare shutdown will emulate the problem realistic enought?
< jonasschnelli> Is it even required to fully catch up the chain?
< jonasschnelli> (still ~40weeks behing)
< jonasschnelli> *behind
< wumpus> jonasschnelli: a sudden VM shutdown is somewhat realistic yes
< jonasschnelli> okay.. will try as soon as i have access to that machine.
< wumpus> you don't need to catch up with the chain - it does make sense to wait for the dbcache to be flushed a few times, but it's easy enough to reproduce around ~200000
< wumpus> (supposing you stick to default dbcache number and don't set it to 4GB so that nothing ever gets flushed)
< jonasschnelli> wumpus: I'm using default values... just double-clicked bitcoin-qt.exe
< wumpus> ok
< GitHub158> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/42f339ef780b...aca0c00ae1fc
< GitHub158> bitcoin/master caa3d42 Luke Dashjr: Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method
< GitHub158> bitcoin/master 420a82f Luke Dashjr: Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool)
< GitHub158> bitcoin/master 5f9260f Luke Dashjr: Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo
< GitHub126> [bitcoin] laanwj closed pull request #6905: Use constants and minor fixes by luke-jr (master...lukejr-constants-no-mergeConf) https://github.com/bitcoin/bitcoin/pull/6905
< GitHub120> [bitcoin] laanwj opened pull request #6938: build: If both Qt4 and Qt5 are installed, use Qt5 (master...2015_11_prefer_qt5) https://github.com/bitcoin/bitcoin/pull/6938
< GitHub113> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aca0c00ae1fc...29c3c43e19ca
< GitHub113> bitcoin/master 35bb381 Wladimir J. van der Laan: build: Improve build instructions...
< GitHub113> bitcoin/master 29c3c43 Wladimir J. van der Laan: Merge pull request #6933...
< GitHub159> [bitcoin] laanwj closed pull request #6933: build: Improve build instructions (master...2015_10_modernize_linux_build_instructions) https://github.com/bitcoin/bitcoin/pull/6933
< GitHub11> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/29c3c43e19ca...aa03fb35c4b3
< GitHub11> bitcoin/master de0499d João Barbosa: Fix ZMQ Notification initialization and shutdown...
< GitHub11> bitcoin/master aa03fb3 Wladimir J. van der Laan: Merge pull request #6927...
< GitHub24> [bitcoin] laanwj closed pull request #6927: Fix ZMQ Notification initialization and shutdown (master...bugfix/zmq-initialization-shutdown) https://github.com/bitcoin/bitcoin/pull/6927
< MarcoFalke> wumpus, anything left to improve https://github.com/bitcoin/bitcoin/pull/6669 ?
< wumpus> don't think so
< GitHub172> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa03fb35c4b3...8a95a18562b2
< GitHub172> bitcoin/master 6b0e622 MarcoFalke: [wallet] Refactor to use new MIN_CHANGE...
< GitHub172> bitcoin/master a9c73a1 MarcoFalke: [wallet] Add comments for doxygen
< GitHub172> bitcoin/master 6342a48 MarcoFalke: Init: Use DEFAULT_TRANSACTION_MINFEE in help message
< GitHub90> [bitcoin] laanwj closed pull request #6669: [wallet] Refactor to use new MIN_CHANGE (master...MarcoFalke-2015-walletCleanup) https://github.com/bitcoin/bitcoin/pull/6669
< MarcoFalke> Good to see this merged.
< GitHub61> [bitcoin] MarcoFalke opened pull request #6939: [wallet] [qa] check MAX_STANDARD_TX_SIZE (master...MarcoFalke-2015-largeTx) https://github.com/bitcoin/bitcoin/pull/6939
< GitHub84> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a95a18562b2...c702521a8564
< GitHub84> bitcoin/master 28313b8 MarcoFalke: [qt] Use fixed pitch font for the rpc console...
< GitHub84> bitcoin/master 268b79e MarcoFalke: [qt] rpcconsole: Scale monospace font to 95%
< GitHub84> bitcoin/master c702521 Wladimir J. van der Laan: Merge pull request #6864...
< GitHub18> [bitcoin] laanwj closed pull request #6864: [qt] Use monospace font (master...MarcoFalke-2015-qtMonospace) https://github.com/bitcoin/bitcoin/pull/6864
< GitHub17> [bitcoin] MarcoFalke closed pull request #6939: [wallet] [qa] check MAX_STANDARD_TX_SIZE (master...MarcoFalke-2015-largeTx) https://github.com/bitcoin/bitcoin/pull/6939
< GitHub145> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c702521a8564...193f7b553e0a
< GitHub145> bitcoin/master dbacc69 Wladimir J. van der Laan: build: If both Qt4 and Qt5 are installed, use Qt5...
< GitHub145> bitcoin/master 193f7b5 Wladimir J. van der Laan: Merge pull request #6938...
< GitHub40> [bitcoin] laanwj closed pull request #6938: build: If both Qt4 and Qt5 are installed, use Qt5 (master...2015_11_prefer_qt5) https://github.com/bitcoin/bitcoin/pull/6938
< GitHub178> [bitcoin] laanwj closed pull request #6917: leveldb: Win32WritableFile without memory mapping (master...2015_10_leveldb_win_nomap) https://github.com/bitcoin/bitcoin/pull/6917
< bsm1175321> Yay!
< wangchun> We've lately got lots of 20000-sigop blocks, it seems someone is flooding the network with 144-sigop and 225-sigop transactions
< petertodd> wangchun: link to such a tx? luke-jr had some code to filter that stuff out
< gmaxwell> Was there any argument against my proposal for making the effective fee rate based on max(size, sigops/20k*max_block_size) instead of size?
< gmaxwell> for ordinary txn there is no change.
< gmaxwell> petertodd: do you see any problem with that approach?
< petertodd> gmaxwell: none, and luke-jr's mining branch does that already IIRc
< gmaxwell> Luke-Jr: ^
< GitHub165> [bitcoin] jonathancross opened pull request #6940: Improving labels for Sent / Received "Bytes" (master...patch-1) https://github.com/bitcoin/bitcoin/pull/6940
< Luke-Jr> mine just rejects transactions that don't have a reasonable sigop-to-size ratio
< Luke-Jr> I think that is better than adjusting fee, because absurd sigop-to-size ratios have no legitimate use case.
< gmaxwell> Luke-Jr: what I suggest just avoids having to decide whats absurd.
< Luke-Jr> that may make it worse, since the cost for an absurd one can't be much higher than the cost for a barely-reasonable one :/
< mcelrath> I don't think it's up to us to decide what is a legitimate use case. If they're paying a reasonable fee, why reject it?
< Luke-Jr> mcelrath: fees are not entitlement
< Luke-Jr> mcelrath: besides, it's very objective in this case
< Luke-Jr> signatures and keys *must* be a certain size. so if the ratio isn't met, there's no possibility of a real signature verification
< gmaxwell> it's true, less than ~73 bytes per sigop is clearly an attack.
< gmaxwell> except the inaccurate accounting nonsense.
< gmaxwell> :(
< gmaxwell> Luke-Jr: so I think the inaccurate accounting nonsense breaks your thinking.
< Luke-Jr> ?
< mcelrath> I decoded one, it's a giant pile (500) of $0.06 (or so) payments to a lot of P2PKH addresses. Not sure I'd call that an attack...
< Luke-Jr> mcelrath: what makes you assume it fails the sigop ratio limit?
< gmaxwell> Luke-Jr: what ratio test are you using?
< gmaxwell> if you're using under ~20 bytes per sigop you're going to deny some p2pkh output heavy txn..
< gmaxwell> and checkmultsig output heavy is really hard to not exclude with a static limit.
< gmaxwell> because it counts as 20 even if s just a 1 of 1
< Luke-Jr> it's configurable
< Luke-Jr> and apparently defaults to unlimited (facepalm)
< gmaxwell> in any case, what I suggest is just superior, because it changes to prioritization to "fee per percentage of the block the transaction is taking up, in the most limiting direction"
< gmaxwell> like the postal service using the MAX of the dimensions of a package as a limit.
< mcelrath> FWIW I like gmaxwell's suggestion.
< Luke-Jr> in any case, this is a miner policy thing, and both should be easy for miners to do
< Luke-Jr> deciding policy should not be a development discussion
< jtimon> gmaxwell: re max(size, sigops/20k*max_block_size) nothing against, just that one thinks about putting more things in that formula (ie utxo_size_delta(tx) to encourage a more efficient usage of the utxo space)
< jtimon> I mean, being policy, we don't have to have the perfect formula from the start
< jtimon> eventually, if we like a tx cost function a lot, we can make it consensus
< GitHub108> [bitcoin] peterjosling opened pull request #6942: Fix CCoins serialization documentation (master...docfix) https://github.com/bitcoin/bitcoin/pull/6942
< davec> I brought it up over in bitcoin-dev, but I'll put it here too for visibility. As of block 583930 on testnet, the CLTV soft fork is active although there is a lot of hash power still mining under the pre-CLTV rules.
< davec> That means once it's released and everybody switches over testnet is going to have a huge reorg
< * helo> grabs popcorn and spins up a node
< belcher> i seem to recall testnet gets reorg'd a lot anyway
< davec> True, but unless I'm mistaken I think the release is planned for Feb
< davec> that will be months worth of blocks the CLTV side wil have to catch up with, etc
< davec> Might be worth considering adding a minimum timestamp to the activation rules
< davec> I had a typo in the block height - it's 582930
< gmaxwell> davec: yea, mentioned here previously.
< gmaxwell> davec: you're incorrect about your belief
< gmaxwell> the release was planned for a couple days ago, I expect it will be next week.
< davec> oh good to know about the release, so it won't be too bad then
< gmaxwell> davec: yup! it's obnoxious though.
< gmaxwell> though there is deciesively more hashpower on the CLTV side now at least.
< gmaxwell> jtimon: that formula has nothing to do with the blocksize limit.
< davec> I was also planning a release for next week with the CLTV rules, so that will line up well with Core
< gmaxwell> the schedue was "end of october" and it's all backported but we're shepearding a couple other fixes for our releases.
< wumpus> we could do a release now if that's necessary
< gmaxwell> I don't currently think we need to rush that fast.
< davec> Yeah, a few days won't matter. For some reason I thought the next release was Feb and that could've been really nasty.
< davec> (as far as potential for a months long reorg)
< gmaxwell> davec: in any case, there are pools mining on master so...
< wumpus> the next major release is (probably) feb
< gmaxwell> But we do not couple soft-forks to bitcoin core major releases.
< gmaxwell> (which is why CLTV is in the prior branches already)
< GitHub46> [bitcoin] pstratem opened pull request #6943: [WIP] Wallet: Store hash for encrypted keys (master...ckey_hash) https://github.com/bitcoin/bitcoin/pull/6943
< belcher> gmaxwell can CLTV be used on regtest from a release? or only by compiling the github master
< belcher> normally id just try it and see, but scripts always give confusing error messages so im never sure whats wrong
< wumpus> only on master right now
< belcher> ty
< wumpus> oh that's not true - you can also use a version compiled from the 0.11 or 0.10 branch
< wumpus> just not a tagged version
< belcher> hmm, so the bitcoin 0.11 you can download from the website doesnt have it? but later commits on the github add it in
< wumpus> right
< gmaxwell> 0.11.2 will have it, but it isn't out yet.
< gmaxwell> belcher: also be mindful of mediantimepast's effect.
< belcher> dont know what that is, google cant find anything meaningful
< belcher> hold on, found something
< GitHub124> [bitcoin] sipa opened pull request #6944: Update LevelDB tree to include #6917 (master...leveldbfix0.12) https://github.com/bitcoin/bitcoin/pull/6944
< GitHub44> [bitcoin] sipa opened pull request #6945: Update LevelDB tree to include #6917 (0.11) (0.11...leveldbfix0.11) https://github.com/bitcoin/bitcoin/pull/6945
< GitHub128> [bitcoin] sipa opened pull request #6946: Update LevelDB tree to include #6917 (0.10) (0.10...leveldbfix0.10) https://github.com/bitcoin/bitcoin/pull/6946
< gmaxwell> \O/
< gmaxwell> lol when I saw the PR with a zillion commits I thought it was another spam PR.
< sipa> I made a mistake and used 0.11 + fix in my 0.10 PR
< sipa> so it included all of 0.10..0.11
< sipa> fixed now
< GitHub146> [bitcoin] sipa opened pull request #6948: Always flush block and undo when switching to new file (master...fixflush) https://github.com/bitcoin/bitcoin/pull/6948
< gmaxwell> sipa: awesome.
< jgarzik> heh