< gamersg>
i probably more time figuring out git since im new to it
< gamersg>
spent*
< PRab_>
Looks good to me.
< PRab_>
Git is a bit tricky. I just spend an hour today teaching a coworker about branches, forks, remotes, etc.
< PRab_>
Once you get the hang of it, it is very powerful.
< PRab_>
I'm just sad that sourcetree constantly hangs for me.
< PRab_>
gamersg: It probably wouldn't be a bad idea to link to the image from your pull request. It helps make it a bit more concrete.
< gamersg>
PRab_: ok now, to figure out how to do that
< PRab_>
Just add a comment on github with a link. If you want I can do it for you.
< PRab_>
Oh, looks like you did it!
< gamersg>
ya good that it supports file attachments
< PRab_>
Yep, github is pretty nice.
< gamersg>
bash completion is probably a nightmare
< gamersg>
unless u are a shell scripting expert
< gamersg>
is there a define signifying NOWALLET?
< PRab_>
#ifdef ENABLE_WALLET?
< gamersg>
hmm ok, travis seems to fail for NO WALLET builds
< gamersg>
there ought to be a variable as well, since wallet can be disabled from command line
< PRab_>
I'm heading to bed. Good luck.
< PRab_>
It wasn't #ifdef ENABLE_WALLET ?
< gamersg>
define is compile time
< gamersg>
variable will affect runtime
< gamersg>
yeah, i gtg as well, will look into it tmr
< GitHub146>
[bitcoin] luke-jr opened pull request #7614: Bugfix: gitian: Add curl to packages (now needed for depends) (master...depends_curl) https://github.com/bitcoin/bitcoin/pull/7614
< GitHub93>
[bitcoin] MarcoFalke opened pull request #7615: [wallet] Couple MIN_CHANGE with minimum relay fee (master...Mf1602-walletMinChange) https://github.com/bitcoin/bitcoin/pull/7615
< GitHub56>
[bitcoin] MarcoFalke opened pull request #7616: Revert "depends: fix Boost 1.55 build on GCC 5" (master...Mf1602-boost155) https://github.com/bitcoin/bitcoin/pull/7616
< GitHub116>
[bitcoin] MarcoFalke opened pull request #7617: [doc] Minor corrections to release notes and links (master...Mf1602-trivial9) https://github.com/bitcoin/bitcoin/pull/7617
< btcdrak>
does anyone know why gitian builder keeps asking for sudo password before making new image? It's supposed to be in the sudoers, I think there might be some other command that needs to be whitelisted.
< btcdrak>
I am sure I remember this being discussed before in this channel, but cant find it in the logs
< sipa>
i think it is vmbuilder that builds the image