< michagogo> 22:55:47 <sipa> i think it is vmbuilder that builds the image <- only for KVM
< michagogo> LXC uses debootstrap, and if you use VBox with Vagrant (does that actually work? Don't think I've heard of anyone using it) it downloads the Ubuntu Cloud Image from cloud-images.ubuntu.com
< michagogo> 22:54:48 <btcdrak> does anyone know why gitian builder keeps asking for sudo password before making new image? It's supposed to be in the sudoers, I think there might be some other command that needs to be whitelisted. <-- *before*? Afaik it should be during the process.
< michagogo> Or to be precise, after creating the new copy, while doing the setup
< btcdrak> michagogo: That seemed to fix it. I submitted a PR.
< michagogo> btcdrak: yeah, it should
< michagogo> Actually, the way you had it before might have worked :P
< btcdrak> i just whitelisted lxc-execute
< michagogo> AIUI, you need either lxc-start or lxc-execute, depending on the setup
< michagogo> But never both
< michagogo> So if in the context of the VBox/Debian/LXC guide lxc-execute is needed, I believe lxc-start isn't.
< btcdrak> well, as of the PR, it works without asking sudo password anymore. good enough I guess?
< michagogo> I mean, not that it really hurts to have another command NOPASSWD'd…
< GitHub168> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/317462123f8e...18b3f1b7f625
< GitHub168> bitcoin/master f41927e BtcDrak: Add missing sudo entry in gitian VM setup....
< GitHub168> bitcoin/master 18b3f1b Wladimir J. van der Laan: Merge #7619: Add missing sudo entry in gitian VM setup....
< GitHub133> [bitcoin] laanwj closed pull request #7619: Add missing sudo entry in gitian VM setup. (master...gitian-sudo) https://github.com/bitcoin/bitcoin/pull/7619
< GitHub147> [bitcoin] laanwj closed pull request #7607: [0.10] Fix .travis.yml (0.10...Mf1602-010travis) https://github.com/bitcoin/bitcoin/pull/7607
< GitHub44> [bitcoin] laanwj pushed 4 new commits to 0.10: https://github.com/bitcoin/bitcoin/compare/b0c97ce31a93...12a0c0b3aac4
< GitHub44> bitcoin/0.10 dc9ae4c MarcoFalke: Fix url in .travis.yml...
< GitHub44> bitcoin/0.10 6bf4884 Luke Dashjr: Workaround Travis-side CI issues...
< GitHub44> bitcoin/0.10 6164639 MarcoFalke: [depends] builders: No need to set -L and --location for curl...
< GitHub63> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/18b3f1b7f625...f39819140c30
< GitHub63> bitcoin/master ff2be40 Alfie John: [doc] Typo fix...
< GitHub63> bitcoin/master f398191 Wladimir J. van der Laan: Merge #7612: [doc] Typo fix...
< GitHub129> [bitcoin] laanwj closed pull request #7612: [doc] Typo fix (master...master) https://github.com/bitcoin/bitcoin/pull/7612
< GitHub61> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f39819140c30...354b03dee188
< GitHub61> bitcoin/master 3d19193 Chris Moore: Remove spurious dollar sign. Fixes #7189.
< GitHub61> bitcoin/master 354b03d Wladimir J. van der Laan: Merge #7604: build: Remove spurious dollar sign. Fixes #7189....
< GitHub134> [bitcoin] laanwj closed pull request #7604: build: Remove spurious dollar sign. Fixes #7189. (master...fix_qt4_failback) https://github.com/bitcoin/bitcoin/pull/7604
< GitHub24> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/354b03dee188...b53d201eab6d
< GitHub24> bitcoin/master fa7a5c5 MarcoFalke: [depends] builders: No need to set -L and --location for curl
< GitHub24> bitcoin/master b53d201 Wladimir J. van der Laan: Merge #7606: [depends] builders: No need to set -L and --location for curl...
< GitHub173> [bitcoin] laanwj closed pull request #7606: [depends] builders: No need to set -L and --location for curl (master...Mf1602-curl) https://github.com/bitcoin/bitcoin/pull/7606
< GitHub17> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b53d201eab6d...f06af574fbb8
< GitHub17> bitcoin/master 8c5a5fb Jonathan Cross: Improving wording related to Boost library requirements [updated]...
< GitHub17> bitcoin/master f06af57 Wladimir J. van der Laan: Merge #7590: Improving wording related to Boost library requirements [updated]...
< GitHub31> [bitcoin] laanwj closed pull request #7590: Improving wording related to Boost library requirements [updated] (master...patch-3) https://github.com/bitcoin/bitcoin/pull/7590
< GitHub183> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f06af574fbb8...78e81b0bc554
< GitHub183> bitcoin/master ca8fb59 Wladimir J. van der Laan: wallet: Warn on unexpected EOF while salvaging wallet...
< GitHub183> bitcoin/master 78e81b0 Wladimir J. van der Laan: Merge #7537: wallet: Warn on unexpected EOF while salvaging wallet...
< GitHub72> [bitcoin] laanwj closed pull request #7537: wallet: Warn on unexpected EOF while salvaging wallet (master...2016_02_salvage_unexpected_eof) https://github.com/bitcoin/bitcoin/pull/7537
< MarcoFalke> wumpus, I was more thinking about a wrapper for LogPrint[f] which adds the new line as default. But I don't know enough CPP to get this working
< wumpus> that'd be too much diff impact
< wumpus> we want to avoid chaning every single line with LogPrint(f)
< MarcoFalke> Keep the name but instead of using the #define LogPrintf, use an actual function
< wumpus> in retrospect, sure, defaulting to adding \n, and having a special function to build incomplete lines would have been better
< MarcoFalke> and then have this function somehow use the macro. But I don't know how to do this in cpp
< wumpus> then again it's not important enough to warrant changes over the code everywhere, breaking every single patch
< wumpus> (we have been extremely conservative with LogPrintf/LogPrint changes before, which is also why the functions are still so similarly named, which is a trap in itself...)
< wumpus> a RAII approach I've seen in other sw, log::debug("mempool") << "Rejecting transaction " << tx.GetHash.ToString(); - where going out-of-scope of the object returned from log::debug automatically generates a newline would probably have been better, in all cases it needs to be terminated with newline eventually. Then again, too much impact to change all of them now.
< go1111111> a bit of friction for new devs that it might be worth it to avoid: on linux if i follow the build instructions all tests pass except for zmq_test.py, because python-zmq isn't on the build dependency list. on one hand this is fine, because it's not needed for non-devs. on the other hand, it'd be nice if tests passed after following build instructions. worth it to submit a PR like this? https://github.com/elliotolds/bitcoin/commit/bc48a5b89e1
< go1111111> e502b1914504b7272ae3581fe1b6a. or if you think I should add it elsewhere let me know
< MarcoFalke> Did you set `ENABLE_ZMQ`?
< MarcoFalke> Oh, is it enabled by default...
< go1111111> I didn't set anything, just followed the build instructions exactly then tried to run the tests as described in the docs.
< go1111111> ah, maybe it used to be disabled and that's the issue?
< go1111111> (by default)
< MarcoFalke> You could create a pull to disable it instead: https://github.com/bitcoin/bitcoin/pull/6103/files#r38071295
< Luke-Jr> imo just make the error friendly
< Luke-Jr> or maybe get the test harness to explicitly "SKIP" it
< wumpus> that's strange, the test should be automatically skipped if ZMQ is disabled
< wumpus> that's what qa/pull-tester/tests_config.py.in is about
< wumpus> ohh, python-zmq! no, we don't check for that
< wumpus> so if you have the zmq library installed it will enable ZMQ, and run the test against it
< wumpus> the test should probably be skipped if python-zmq is not enabled
< wumpus> installed*
< go1111111> ok, I will attempt that tomorrow. if someone knows of an existing place in the codebase where a test is skipped if a python library isn't installed, let me know
< wumpus> in tests_config.py something like try: import BLA except ImportError: zmq_installed=False else: zmq_installed=True
< wumpus> may print a warning if so too
< wumpus> (at least if zmq is enabled)
< jtimon> I think it would still be nice to mention python-zmq in build-unix.md
< btcdrak> jtimon: +1
< jonasschnelli> jtimon, btcdrak: do we also mention the other python modules required for running the tests?
< jonasschnelli> Stuff like: "from binascii import unhexlify"
< jtimon> jonasschnelli: I don't see why not, it can be a couple of lines below libqrencode-dev
< jonasschnelli> IMO it has nothing to do with the build itself... i think it should go here: https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/README.md
< jtimon> jonasschnelli: well, it can certainly go somewhere else
< jtimon> jonasschnelli: yeah, actually that seems like a better place
< btcdrak> jonasschnelli: yes, we need to correctly list all dependencies else it's a real pest for new developers setting up
< btcdrak> jonasschnelli: well the build.md should at least make reference to RPC docs.
< jtimon> sipa: can you take a look at #7566 's latest version?
< GitHub91> [bitcoin] MarcoFalke opened pull request #7620: [travis] Only run check-doc.py once (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7620
< GitHub49> [bitcoin] mrbandrews opened pull request #7621: Fixes ZMQ startup with bad arguments. (master...ba-fix-zmq) https://github.com/bitcoin/bitcoin/pull/7621
< GitHub192> [bitcoin] TazeTSchnitzel opened pull request #7622: Increase DEFAULT_BLOCK_MAX_SIZE to 1MB (master...increaseDefaultBlockSize) https://github.com/bitcoin/bitcoin/pull/7622
< morcos> sdaftuar and i have question about the new standardness rules for version 2 txs
< morcos> hmm
< morcos> is it ok if txs with nsequence bits which are still undefined are still standard
< morcos> i think we answered our own question, its ok. b/c if you want to further impart meaning to the nsequence field you'd increase tx version again
< btcdrak> yes
< GitHub41> [bitcoin] vlamer opened pull request #7623: newcomer can think bitcoincore.org is Bitcoin homepage. (master...master) https://github.com/bitcoin/bitcoin/pull/7623
< CodeShark> On a plane heading back home. I think the roundtable went really well.
< gmaxwell> Which I knew something about it.
< sipa> Wish? Witch? s/it//?
< petertodd> morcos: please make sure undefined nSequence bits are standard...
< petertodd> morcos: may need them for voting schemes
< sipa> i believe that's the case
< GitHub133> [bitcoin] vlamer closed pull request #7623: newcomer can think bitcoincore.org is Bitcoin homepage. (master...master) https://github.com/bitcoin/bitcoin/pull/7623
< gmaxwell> Was anyone here ever contacted by a group called the "Bitcoin Privacy Project"? They just put out a report that said that we did not respond to repeated contact attempts.
< gmaxwell> The reports is quite ... remarkable. For example, it places "Samourai" wallet ahead of Bitcoin-QT.... this wallet was recently in some reddit controversy when someone reverse engineered their closed source binaries and found that they were, without disclosure, sending all the user's addresses to BC.i.
< AaronvanW> gmaxwell: that's interesting because I think kristiv atlas (bc.i) co-authored the report
< sipa> that?
< Luke-Jr> 4.Does your application fully implement BIP 62? <-- lol?
< gmaxwell> Likewise, they rated Bitcoin-Qt at 0 for physical security; when I believe it's the only wallet software in their test which is hardned against timing and RF sidechannels (some of the hardware wallets, like ledger are). Most of their wallets in their test do not implement meaningful KDFs for wallet encryption, thouh Bitcoin Core does.