< luke-jr> Is the address leakage issue significant enough that we need a backport for 0.13?
< gmaxwell> it's a bugfix that is a zero effort backport. Its usually hard to assess the risk of information leaks.
< luke-jr> gmaxwell: yes, but it might also be a risk because it changes p2p behaviour globally? (I haven't looked too closely at its implications.)
< luke-jr> but more to the point: it's not merged in master yet
< gmaxwell> luke-jr: sure, shoudln't be backported until after.
< GitHub82> [bitcoin] jl2012 opened pull request #8756: Implement excessive sighashing protection policy with conservative counting (master...sighashpolicylite) https://github.com/bitcoin/bitcoin/pull/8756
< GitHub139> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1e5799c52535...239e8ce95896
< GitHub139> bitcoin/master d9c99c3 Wladimir J. van der Laan: net: No longer send local address in addrMe...
< GitHub139> bitcoin/master 239e8ce Wladimir J. van der Laan: Merge #8740: net: No longer send local address in addrMe...
< GitHub126> [bitcoin] laanwj closed pull request #8740: net: No longer send local address in addrMe (master...2016_09_addrfrom_version) https://github.com/bitcoin/bitcoin/pull/8740
< luke-jr> well, that's one way to solve that :p
< GitHub140> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/239e8ce95896...483e8e4f4875
< GitHub140> bitcoin/master fad41f3 MarcoFalke: [qa] walletbackup: Sync blocks inside the loop
< GitHub140> bitcoin/master 483e8e4 MarcoFalke: Merge #8724: [qa] walletbackup: Sync blocks inside the loop...
< GitHub31> [bitcoin] MarcoFalke closed pull request #8724: [qa] walletbackup: Sync blocks inside the loop (master...Mf1609-qaWalletBackupFix) https://github.com/bitcoin/bitcoin/pull/8724
< GitHub157> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/483e8e4f4875...a5b20edd3dc6
< GitHub157> bitcoin/master fa5d276 MarcoFalke: [init] ParameterInteraction() iff wallet enabled
< GitHub157> bitcoin/master a5b20ed Wladimir J. van der Laan: Merge #8494: [init, wallet] ParameterInteraction() iff wallet enabled...
< GitHub56> [bitcoin] laanwj closed pull request #8494: [init, wallet] ParameterInteraction() iff wallet enabled (master...Mf1608-initWalletParamInt) https://github.com/bitcoin/bitcoin/pull/8494
< jonasschnelli> Should listsinceblock list mempool transactions? IMO no... but it does
< GitHub73> [bitcoin] jonasschnelli opened pull request #8757: Fix issue with conflicted mempool tx in listsinceblock (master...2016/09/listsinceblock) https://github.com/bitcoin/bitcoin/pull/8757
< GitHub53> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5b20edd3dc6...254ea97e940f
< GitHub53> bitcoin/master b16a7f6 Michael Ford: [Doc] Target protobuf 2.6 in OS X build notes....
< GitHub53> bitcoin/master 254ea97 Wladimir J. van der Laan: Merge #8754: [Doc] Target protobuf 2.6 in OS X build notes....
< GitHub35> [bitcoin] laanwj closed pull request #8754: [Doc] Target protobuf 2.6 in OS X build notes. (master...osx-protobuf-doc) https://github.com/bitcoin/bitcoin/pull/8754
< GitHub185> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/254ea97e940f...0171a1e559aa
< GitHub185> bitcoin/master dad932c Anders Øyvind Urke-Sætre: Minor change in section name...
< GitHub185> bitcoin/master 0171a1e Wladimir J. van der Laan: Merge #8720: Minor change in section name...
< GitHub123> [bitcoin] laanwj closed pull request #8720: Minor change in section name (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8720
< GitHub181> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0171a1e559aa...2ebb8099d9a2
< GitHub181> bitcoin/master c4084c2 fanquake: Specify Protobuf version 2 in paymentrequest.proto
< GitHub181> bitcoin/master 2ebb809 Wladimir J. van der Laan: Merge #8742: Specify Protobuf version 2 in paymentrequest.proto...
< GitHub155> [bitcoin] laanwj closed pull request #8742: Specify Protobuf version 2 in paymentrequest.proto (master...proto2-vs-proto3) https://github.com/bitcoin/bitcoin/pull/8742
< GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ebb8099d9a2...9ac01301f5c4
< GitHub197> bitcoin/master fa644d0 MarcoFalke: [qa] wallet: Check legacy wallet as well
< GitHub197> bitcoin/master 9ac0130 Wladimir J. van der Laan: Merge #8716: [qa] wallet: Check legacy wallet as well...
< GitHub191> [bitcoin] laanwj closed pull request #8716: [qa] wallet: Check legacy wallet as well (master...Mf1609-qaWalletLegacy) https://github.com/bitcoin/bitcoin/pull/8716
< sipa> lol @ zu
< * sipa> proposes as name for next release "The knights who say zu"
< GitHub111> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ac01301f5c4...f07424a6716c
< GitHub111> bitcoin/master f3552da Cory Fields: net: fix maxuploadtarget setting...
< GitHub111> bitcoin/master f07424a Wladimir J. van der Laan: Merge #8707: net: fix maxuploadtarget setting...
< GitHub18> [bitcoin] laanwj closed pull request #8707: net: fix maxuploadtarget setting (master...fix-maxupload) https://github.com/bitcoin/bitcoin/pull/8707
< GitHub199> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f07424a6716c...c40dd70d0da7
< GitHub199> bitcoin/master dddd04f MarcoFalke: [qa] Refactor RPCTestHandler to prevent TimeoutExpired
< GitHub199> bitcoin/master c40dd70 Wladimir J. van der Laan: Merge #8750: [qa] Refactor RPCTestHandler to prevent TimeoutExpired...
< GitHub0> [bitcoin] laanwj closed pull request #8750: [qa] Refactor RPCTestHandler to prevent TimeoutExpired (master...Mf1609-qaRefactorTimeout) https://github.com/bitcoin/bitcoin/pull/8750
< GitHub0> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c40dd70d0da7...8bae52a9a0d1
< GitHub0> bitcoin/master b4fb512 Pavel Janík: UndoReadFromDisk works on undo files (rev), not on block files.
< GitHub0> bitcoin/master 8bae52a Wladimir J. van der Laan: Merge #8737: Trivial: UndoReadFromDisk works on undo files (rev), not on block files....
< GitHub129> [bitcoin] laanwj closed pull request #8737: Trivial: UndoReadFromDisk works on undo files (rev), not on block files. (master...20160915_Undo_error_message_fix) https://github.com/bitcoin/bitcoin/pull/8737
< GitHub122> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8bae52a9a0d1...1cf11cc3eca8
< GitHub122> bitcoin/master 37a7fe9 isle2983: [copyright] add MIT License copyright header to zmq_sub.py
< GitHub122> bitcoin/master 1cf11cc Wladimir J. van der Laan: Merge #8701: [copyright] add MIT License copyright header to zmq_sub.py...
< GitHub99> [bitcoin] laanwj closed pull request #8701: [copyright] add MIT License copyright header to zmq_sub.py (master...zmq_sub-copyright) https://github.com/bitcoin/bitcoin/pull/8701
< GitHub113> [bitcoin] MarcoFalke opened pull request #8760: [init] Get rid of some ENABLE_WALLET (master...Mf1609-walletInitGuard) https://github.com/bitcoin/bitcoin/pull/8760
< GitHub74> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1cf11cc3eca8...894c0ad9a9ab
< GitHub74> bitcoin/master 4677b19 isle2983: [copyright] add MIT License copyright header to remaining Python files
< GitHub74> bitcoin/master 894c0ad Wladimir J. van der Laan: Merge #8702: [copyright] add MIT License copyright header to remaining Python files...
< GitHub34> [bitcoin] laanwj closed pull request #8702: [copyright] add MIT License copyright header to remaining Python files (master...misc-copyright) https://github.com/bitcoin/bitcoin/pull/8702
< michagogo> sipa: maybe when we port the code over. Right now we're still in C++…
< sipa> michagogo: ?
< michagogo> sipa: aren't those references a Python thing?
< sipa> ?
< sipa> i'm talking about the mingw issue that causes the "Content-length: zu" line in the http responses
< GitHub9> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/894c0ad9a9ab...047ded0b12f3
< GitHub9> bitcoin/master d9ff591 Pieter Wuille: Move static global randomizer seeds into CConnman
< GitHub9> bitcoin/master 047ded0 Wladimir J. van der Laan: Merge #8688: Move static global randomizer seeds into CConnman...
< GitHub182> [bitcoin] laanwj closed pull request #8688: Move static global randomizer seeds into CConnman (master...detrandconnman) https://github.com/bitcoin/bitcoin/pull/8688
< GitHub23> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/047ded0b12f3...d8b4b631c5be
< GitHub23> bitcoin/master 783e930 isle2983: [copyright] Add missing copyright headers
< GitHub23> bitcoin/master d8b4b63 Wladimir J. van der Laan: Merge #8676: Add missing copyright headers...
< GitHub173> [bitcoin] laanwj closed pull request #8676: Add missing copyright headers (master...missing-copyright) https://github.com/bitcoin/bitcoin/pull/8676
< instagibbs> sipa: does the v2 cb assume that clients will prefer newer versions over old? I can't make heads or tails of how version agreement is achieved otherwise
< instagibbs> I'm just reading the bip for now
< gmaxwell> wumpus: perhaps someone with a running fedora system could confirm, but I believe the maximum locked memory ulimit by default on fedora and centos is 32kb.
< gmaxwell> wumpus: any idea why we're using so much locked memory? 300k for a big wallet sounds like a lot.
< BlueMatt> the help documentation for getblocktemplate does not anywhere explain how to get it to spit out a response post-segwit :(
< BlueMatt> (nor does the segwit-gbt bip, afaict)
< BlueMatt> luke-jr: ^
< gmaxwell> BlueMatt: yes it does...
< gmaxwell> BlueMatt: you want the relevant BIP9 rules, it's described in BIP 145 and BIP 9.
< BlueMatt> ahh, its mentioned in a one-line below a chart...thats confusing
< BlueMatt> anyway, its not mentioned in the rpc help text
< BlueMatt> and I dont really know enough about gbt to trust myself to not confuse the spec adding the "rules" thinggy to the help text
< luke-jr> ?
< BlueMatt> luke-jr: the help text for getblocktemplate does not explain how to add the "rules" entry so that it will return anything except an error
< luke-jr> oh
< luke-jr> it has a link to the BIPs ☺
< BlueMatt> .....
< luke-jr> for better or worse, it's not really feasible to implement GBT from less than the BIPs
< * BlueMatt> goes to write up a 10-minute replacement that only returns what you need to build a block
< luke-jr> getwork was just removed
< gmaxwell> BlueMatt: go write a integrated stratum server instead, that hides all this stuff.
< luke-jr> gmaxwell: libblkmaker already hides it ;)
< BlueMatt> gmaxwell: true, but every time I ask anyone they also want to kill stratum
< BlueMatt> though, really, I think if you were to just return essentially the stratum data, but as binary instead of hex, people would be happy
< gmaxwell> BlueMatt: well it still leaves the protocol utterly unauthenticated which is bad.
< gmaxwell> but it would certantly be a usability step up.
< BlueMatt> true, easy enough to add a sig field that just gets appended to the end
< luke-jr> +1
< * BlueMatt> goes to find p2p-auth code to figure out how it stores keys
< TD-Linux> gmaxwell, 64kB on fedora 24
< instagibbs> BlueMatt: does the v2 cb assume that clients will prefer newer versions over old? I can't make sense of the latest bip text on agreement, although this might be my head cold....
< BlueMatt> instagibbs: does the sample negotiation not help? the text is dense, but the sample and actual code are pretty readable, imo
< instagibbs> it seems to assume it, yes, but it's an "example" after all :P
< instagibbs> in other words, is it assumed I could send "1, 2" and you could send "2, 1" in the initial messages? If so, I just need to sit down and read it again I think.
< BlueMatt> yes, you should be able to send any preference you want...if its not clear from the spec tell me where i should change it
< instagibbs> Ok so then that part is clear, but I can't connect dots. I'll try again tomorrow after sleep.