sipa: you mistyped "No, you're wrong, here's the full explanation dumbass: ___"
oh, silly me.
I have many addresses in my wallet. and I want to pay with the address I chose. So I want to choose the address I will send to?
AdulrunaRedviva -> head over to #bitcoin (this is the development channel)
hmm, it just occured to me (after staring at some fuzzing failure) that some CNetAddr objects do not ser+deser into the original. For example a torv3 address when serialized (as done by the fuzzer, ADDRV2_FORMAT is not set) end up with 16 zeroes.
When 16 zeroes are deserialized the result is not equal to the torv3 address.
that's expected, right?
What about extending AssertEqualAfterSerializeDeserialize() so that when called with CNetAddr it also uses ADDRV2_FORMAT.
wumpus: exactlty, that is expected
... but not expected by the fuzzer :-D
could do that; there would need to be some exception there, the fuzzer shouldn't generate, do this test on objects that are not valid to be serialized in the target representation
I will have another important question. Is there anyone to answer?
wumpus: yeah, something like that
AdulrunaRedviva: please go to the channel #bitcoin
AdulrunaRedviva: this is the development channel, do you have any suggestions on the above fuzzing issue?
it looks like it is a harmless detail of how .plt is handled on POWER64: in the ELF binary it's part of the LOAD program header with 'RW ' permissions (not 'R E'), something else like the dynamic linker or program initialization code needs to mprotect it to 'R E' after loading, before it can be used
anyone have workarounds for github not properly expanding comments that are hidden? in my case, someone left comments on a PR and marked as resolved, but i can't expand to see them (#20187)
sdaftuar: search for that comment in email notification, and open it via emailed link
thanks, i think that may have worked (slightly confusing but i believe github duplicated the comment on their website, as part of someone else's review and in-thread with an earlier review comment - ugh)
sdaftuar: if you can be bothered documenting any exmaples, please pass them on to me, and pass them through to GH
Although they don't seem too concerned about any of the issues we've raised so far