memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ChanServ has quit [shutting down]
ChanServ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
jonatack has quit [Read error: Connection reset by peer]
l0rinc has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
phungus8153520 has quit [Quit: Ping timeout (120 seconds)]
afiore_ has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore_ is now known as afiore
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
lightningbot has quit [Server closed connection]
lightningbot has joined #bitcoin-core-dev
enochazariah_ has joined #bitcoin-core-dev
tegila has joined #bitcoin-core-dev
tegila_ has quit [Ping timeout: 266 seconds]
Guyver2 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
javi404 has quit [Ping timeout: 244 seconds]
javi404 has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
conman has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
jarolrod_ has quit [Server closed connection]
jarolrod_ has joined #bitcoin-core-dev
RubenSomsen has quit [Server closed connection]
RubenSomsen has joined #bitcoin-core-dev
svanstaa_ has joined #bitcoin-core-dev
svanstaa has quit [Ping timeout: 268 seconds]
smartin has quit [Quit: smartin]
smartin2 has joined #bitcoin-core-dev
smartin2 is now known as smartin
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 252 seconds]
greypw1495085720 has quit [Ping timeout: 252 seconds]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
johnny9dev has quit [Server closed connection]
johnny9dev has joined #bitcoin-core-dev
kinlo has quit [Server closed connection]
kinlo has joined #bitcoin-core-dev
mbrochh_ has quit [Server closed connection]
mbrochh_ has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
Guest66 has quit [Client Quit]
Guest66 has joined #bitcoin-core-dev
Guest66 has quit [Client Quit]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
ghost43 has joined #bitcoin-core-dev
pzafonte_ has quit [Ping timeout: 244 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
katsu has quit [Server closed connection]
pzafonte has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
fjahr has quit [Server closed connection]
fjahr has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
diego has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
SpellChecker_ has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Guest42 has joined #bitcoin-core-dev
Guest42 has quit [Client Quit]
Guest42 has joined #bitcoin-core-dev
Guest42 has quit [Client Quit]
ozdeadman has joined #bitcoin-core-dev
deadmanoz has quit [Ping timeout: 276 seconds]
adil has joined #bitcoin-core-dev
<dviola>
hebasto: hi, I managed to solve that specific problem here: https://github.com/bitcoin-core/gui/pull/948#issuecomment-5337430176 -- but honestly, I think freespacechecker.cpp needs an overhaul, right now when passing -blocksdir via gArgs.IsArgSet, dataDir becomes the blocksdir path and by the look of it, freespacechecker.cpp wasn't designed around that assumption, but it works
<dviola>
anyway, I'm not too familiar with the code in freespacechecker.cpp so I can't be the one to make that refactor, or at least not yet
tegila has quit [Ping timeout: 252 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
tegila has joined #bitcoin-core-dev
<dviola>
I'd probably change freespacechecker.cpp to consider 1 or all paths bitcoin-qt knows about, combine their sizes and estimate
jonatack has quit [Ping timeout: 263 seconds]
jonatack has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 242 seconds]
enochazariah has joined #bitcoin-core-dev
<dviola>
thank you for testing btw
<maflcko>
I don't think we need to treat authors and co-authors differently. Any author is already required to fully understand the complete patch (and required to could have written it themselves). So I think it is fine to apply the same policy to co-authors and avoid introducing a new policy for this.
<fanquake>
If everyone is a co-author, it starts to make git blame less useful, and it's not clear who actually understands, or can be asked questions about the code (now or in future)
Guest53 has quit [Client Quit]
Guest53 has joined #bitcoin-core-dev
<maflcko>
Also (re low-prio AI issues): I agree that it is fine to file them in the public repo. If needed, they can be marked with a label such as ON_HOLD or LOW_PRIO and if needed DrahtBot can automatically close all pulls fixing such issues as ai slop.
Guest53 has quit [Client Quit]
Guest53 has joined #bitcoin-core-dev
adil has quit [Quit: adil]
tegila has quit [Ping timeout: 256 seconds]
tegila has joined #bitcoin-core-dev
Guest53 has quit [Quit: Client closed]
Guest10 has joined #bitcoin-core-dev
enochazariah has quit [Read error: Connection reset by peer]
Guest10 has quit [Client Quit]
enochazariah has joined #bitcoin-core-dev
Guest54 has joined #bitcoin-core-dev
Guest54 has quit [Client Quit]
<dviola>
the problem with changing freespacechecker.cpp is that you have to change all the other things that call it
<andrewtoth_>
maflcko: I guess what we need clarity on is in what circumstances we should add a contributor as a co-author to a commit we have authored?
<maflcko>
I'd say only if they have substantially (co-) authored a good chunk of the patch (and fully understand the whole patch)
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
janb84 has quit [Remote host closed the connection]
janb84 has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 264 seconds]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
<sipa>
fanquake: if co-authors are expected to understand the whole patch, that would mean it's not just a means of giving credit but comes with a responsibility as well, and you should probably have permission from the co-author to list them? I think that's perhaps a step too far. My interpretation of it is really something like "you wrote a patch which could reasonably be a commit on its own, but for
<sipa>
logistical reasons i squashed it into mine", which doesn't...
<sipa>
imply you understand the whole combined patch. I think this makes sense, as it's roughly the point where you'd be considered a copyright holder
jonatack has quit [Ping timeout: 265 seconds]
<fanquake>
sipa: sure, I don’t know where the bar is exactly, I just think it’s gotta be higher than someone cloning and running the code
<sipa>
fanquake: my friendly neighborhood LLM says that the bar for claiming copyright ownership is a rather subjective "threshold of originality", but many people use a 5-10 line patch limit as rule of thumb.
<sipa>
I think this matches with my interpretation of "co-author", you basically contributed (the near-actual code of, not just the idea) of a substantial function
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
<sipa>
So I'd say just assisting with a PR, doing benchmarks, providing review comments/ideas... not co-author. You need to actually have contributed code that got included in the commit.
<sipa>
On the other hand, I also don't think co-authorship needs to come with a responsibility of being able to explain the entire commit.
<sipa>
unrelatedly, anyone know how to resolve this error when building --preset libfuzzer-nosan?
<sipa>
/home/pw/git/bitcoin/src/ipc/libmultiprocess/src/mp/gen.cpp:277:23: error: use of undeclared identifier 'capnp_PREFIX' 277 | args.emplace_back(capnp_PREFIX "/bin/capnp");
<sipa>
-DENABLE_IPC=OFF helps, but i don't see why (and why it doesn't happen with --prefix libfuzzer)
WizJin has quit [Quit: Leaving]
jonatack has joined #bitcoin-core-dev
schmidty has quit [Server closed connection]
schmidty has joined #bitcoin-core-dev
dzxzg has joined #bitcoin-core-dev
<hebasto>
sipa: cannot reproduce on my machine; `libmultiprocess/cmake/compat_config.cmake` is involved, so the detailed description of the affected system is needed
<hebasto>
just in case, please assure that the build tree is empty
jerryf has joined #bitcoin-core-dev
<sipa>
yeah, i wiped the build_fuzz_nosan directory and recreated it
<sipa>
don't worry about it if it's not easily reproducible
dzxzg2 has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 248 seconds]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
whist has quit [Server closed connection]
whist has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 263 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
<dviola>
hebasto: anyway, I look forward to your feedback (if you test it, but no rush) -- thanks in advance
jerryf has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
angusp has quit [Server closed connection]
angusp has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 256 seconds]
elichai2 has quit [Server closed connection]
elichai2 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
enochazariah_ has quit [Quit: Connection closed for inactivity]
___nick___ has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Quit: Client closed]
bugs_ has quit [Quit: Leaving]
jonatack has quit [Ping timeout: 256 seconds]
S3RK_ has joined #bitcoin-core-dev
<fjahr>
I haven't been seeing any git opens or merges here recently, is that bot dead? Sorry if that was raised earlier or if that is intentional, then I must have missed it. Seems like it died even before the GitHub outage earlier this week.
S3RK has quit [Ping timeout: 241 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Ping timeout: 252 seconds]
jerryf has quit [Ping timeout: 252 seconds]
afiore has quit [Ping timeout: 252 seconds]
afiore has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 252 seconds]
jerryf has joined #bitcoin-core-dev
<achow101>
pinged laanwj about that
memset_ has joined #bitcoin-core-dev
Flow has quit [Server closed connection]
memset has quit [Remote host closed the connection]
Flow has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
<l0rinc>
fanquake: I have removed your coauthorship from #36000 as requested.
<l0rinc>
We already have reviewers acking, if we need to ask questions it's usually the reviewers who can answer them.
<l0rinc>
Coauthors are per commit and I consider them to be simple attributions: other people have helped me get to this state. It's simply a way to thank and incentivise people to review: their work is appreciated and noted.
<l0rinc>
btw, on the topic of #36000 - I just finished a reindex-chainstate on a HDD and it was 1.37x faster.
<l0rinc>
I'm also investigating how much faster we could get (given we're already loading the blocks from disk on threads that don't expose the blocks immediately) whether we can do a simple context-independent `CheckBlock` validation before handing the block to the rest of validation. The diff is tiny, but we should probably do this after #36000.