< bitcoin-git>
[bitcoin] jnewbery opened pull request #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework (master...refactor_invalidtxrequest) https://github.com/bitcoin/bitcoin/pull/11771
< bitcoin-git>
[bitcoin] joemphilips opened pull request #11770: [REST] add a rest endpoint for estimatesmartfee, docs, and test (master...rest_fee) https://github.com/bitcoin/bitcoin/pull/11770
< Randolf>
jl2012: This channel is focused on the software development aspects of bitcoin core. What you've raised seems to be a usability question, which is much more likely to be served well on the #bitcoin channel. That's why I suggested that you ask there.
< Randolf>
jl2012: Well, why don't you ask in the #bitcoin channel? Maybe it's already supported (I don't know).
< Randolf>
jl2012: You seem to be asking a question about useability rather than about development. Have you tried asking your question in the #bitcoin channel?
< bitcoin-git>
[bitcoin] aaron-hanson opened pull request #11765: [REST] added blockhash api, tests and documentation (master...rest-blockhash-endpoint) https://github.com/bitcoin/bitcoin/pull/11765
2017-11-24
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11762: Avoid locking mutexes that are already held by the same thread (master...remove-double-locks) https://github.com/bitcoin/bitcoin/pull/11762
< Provoostenator>
@jonasschnelli me too, but I think a more realistic scenario is more people running Bitcoin Core nodes and connecting their favorite wallet to it.
< jonasschnelli>
I'd like to see more users using Bitcoin Core as a wallet
< jonasschnelli>
The current bitcoin wallets do loose one of the primary elements Bitcoin can defeat "Trusted third parties are security holes".
< jonasschnelli>
b) you add a script to your bitcoin core machine that would server over TLS (an RPC proxy)
< jonasschnelli>
I think long term we should not expect that private keys are on the same machine then bitcoin core runs (at least not with the current one process design)
< wumpus>
bitcoin isn't really a good project for first time open source contributors in that regard, some projects just merge everything effectively instantly, but we cannot have a policy like that, not for first contributors ither
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11749: Set m_last_block_processed to nullptr in SetNull() (master...m_last_block_processed) https://github.com/bitcoin/bitcoin/pull/11749
< bitcoin-git>
[bitcoin] merehap opened pull request #11748: [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. (master...blockchain_unittests) https://github.com/bitcoin/bitcoin/pull/11748
< aj>
meshcollider: mainnet bitcoin.conf and network.conf live in the same directory :(
< meshcollider>
Or would having them both called bitcoin.conf be confusing
< aj>
meshcollider: i'm not sure if there's a use case... atm, you could have standard settings in bitcoin.conf and special settings in network.conf (mainnet addnode's say), and switch either independently via command line options. that just seems a bit more flexible and maybe natural to me?
< aj>
meshcollider: i worry about that too. current behaviour is that bitcoin.conf is loaded first and network.conf second (so bitcoin.conf can specify the network), and any setting in bitcoin.conf overrides any setting in network.conf
< aj>
meshcollider: yeah: patch makes bitcoind load two config files, .bitcoin/bitcoin.conf and .bitcoin/testnet3/network.conf; -conf lets you choose a different name for the first one, -netconf a different name for the second one
< andytoshi>
Chris_Stewart_5: #bitcoin-mining will probably be more helpful, or #bitcoin. this channel is specifically about software development of Bitcoin Core
< wumpus>
also it'd make no sense, we'd have to distinguish which daemon is logging for each line - if you really want to dump all your bitcoin logging to one place, you can already use -printtoconsole w/ some log aggregation like systemd
< wumpus>
also if you just want to test w/ bitcoin and times there's setmocktime
< Sentineo>
so if I set my time to 2015 would I invalidate blocks? It sounds like bitcoin-core would take the blockchain (and other nodes) as the source of time
< bitcoin-git>
[bitcoin] laanwj closed pull request #11738: Fix sendrawtransaction hang when sending a tx already in mempool (master...2017-11-fix-sendraw-block) https://github.com/bitcoin/bitcoin/pull/11738
< bitcoin-git>
bitcoin/master d4267a3 Wladimir J. van der Laan: Merge #11738: Fix sendrawtransaction hang when sending a tx already in mempool...
< bitcoin-git>
bitcoin/master d9340ce Matt Corallo: Fix sendrawtransaction hang when sending a tx already in mempool
< Randolf>
JeffSlentz: If not, then there may be other options for you, but you'll probably need to ask about those possibilities in the #bitcoin channel.
< JeffSlentz>
Hey, as a recent grad with not much experience with the Bitcoin Core project, are there any suggestions for contributing?
< Murch>
morcos: I was just looking at fee rate estimation. I'm surprised that the Bitcoin Core estimate is still on 170 for second block target when the network has been clearing the mempool of <40 for four days.
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #11738: Fix sendrawtransaction hang when sending a tx already in mempool (master...2017-11-fix-sendraw-block) https://github.com/bitcoin/bitcoin/pull/11738
< merehap>
Hi all, I just ran "make cov" on bitcoin core, looking for low hanging fruit for writing new unit tests. I found that src/rpc/blockchain.cpp has low coverage. Are there any objections to me adding unit tests for this file? Any caveats?
< bitcoin-git>
[bitcoin] tjps opened pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
< bitcoin-git>
[bitcoin] fanquake opened pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
< bitcoin-git>
[bitcoin] laanwj closed pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
< bitcoin-git>
bitcoin/master 5197100 Wladimir J. van der Laan: Merge #11706: Make default issue text all comments to make issues more readable...
< bitcoin-git>
bitcoin/master e89adba Matt Corallo: Make default issue text all comments to make issues more readable
< bitcoin-git>
bitcoin/master f6f8d54 Wladimir J. van der Laan: Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)...
< bitcoin-git>
[bitcoin] MeshCollider opened pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
< jtimon>
weren't they using a naming just the same as bitcoin core but increasing a version? (ie 0.14.3)
< jonasschnelli>
861 peers with "Bitcoin ABC" and 100% uptime during last two hours.
< wumpus>
PSA before the meeting is over: I want to collect corrupted leveldb files, if you have a leveldb corruption please patch https://github.com/bitcoin/bitcoin/pull/11674 and send me the indicated corrupted file.
< gmaxwell>
change in topic, anyone have recent stats for the number of remaining btc1 nodes-- which are likely about to become a distributed DOS attack on the bitcoin network?
< gmaxwell>
jtimon: cli makes you specify it as a dashed argument to bitcoin-cli, which is a bit obnoxious but works.
< wumpus>
yes, it's the same with bitcoin-cli
< wumpus>
jtimon: no, agree, jonasschnelli's proposal to make it stateless and have to provide it for every command is better, that's the same as needs tobe done for bitcoin-cli
< gribble>
https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
< kinlo>
asu: that question is for #bitcoin, not for here
< asu>
buy i found if my customer send 0.01bitcoin to another, the fee is 0.00027 bitcoin
< asu>
i want to build a bitcoin p2p trade web
< bitcoin-git>
[bitcoin] laanwj closed pull request #11654: tests: Initialize recently introduced non-static class member lastCycles to zero in constructor (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/11654
< bitcoin-git>
bitcoin/master 084f52f Wladimir J. van der Laan: Merge #11654: tests: Initialize recently introduced non-static class member lastCycles to zero in constructor...
< bitcoin-git>
bitcoin/master 069215e practicalswift: Initialize recently introduced non-static class member lastCycles to zero in constructor...
< gmaxwell>
But there is just an utterly stupendous amount of work required, ... the software is highly optimized (and sure, there are also still many things that could be done to make it faster). .. but e.g. compared to ethereum the amount of blockchain bitcoin core processes per second is something like two orders of magnitude greater. ( https://anduck.net/bitcoincore_vs_geth_full_node_stats.png )
< wumpus>
LMDB seemed promising but I never got spectacular results, maybe I was just using it wrong, and maybe the approach of not caching at the bitcoin level would work better with it
< eck>
alright, at a high level i want to know why bitcoin has a caching layer at all: there is already some caching in the kernel page cache, leveldb has some caching og it its own, and then bitcoin itself will cache data for up to 24h
< bitcoin-git>
[bitcoin] laanwj closed pull request #11651: refactor: Make all #includes relative to project root (laanwj, MeshCollider, ryanofsky) (master...201711_absolute_includes) https://github.com/bitcoin/bitcoin/pull/11651
< bitcoin-git>
bitcoin/master 5b56ec9 Wladimir J. van der Laan: qt: refactor: Use absolute include paths in .ui files
< bitcoin-git>
bitcoin/master 0c71521 Wladimir J. van der Laan: build: Remove -I for everything but project root...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (master...desktop-file) https://github.com/bitcoin/bitcoin/pull/11690
< bitcoin-git>
bitcoin/master f0c1f8a MarcoFalke: Merge #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it...