00:49 < phantomcircuit> morcos, #7589 why create a new class instead of adding those methods to CBlockTemplate

00:50 < phantomcircuit> something like CBlockTemplate::buildFromMempool(CTxMempool& mempool)

00:50 < morcos> phantomcircuit: good question. I suppose it could ahve been done that way.

00:50 < morcos> I'm not a super big fan of CBlockTemplate honestly

00:51 < morcos> perhaps when we have more time on our hands we can do a more radical redesign....

00:52 < phantomcircuit> morcos, what dont you like about it?

01:04 < jtimon> oh, bip9 now has a graph with the state machine, very nice

01:09 < phantomcircuit> gmaxwell, are you aware of any libraries for forward error correction which are mit licensed and competently done?

01:10 < sipa> phantomcircuit: tell me if you find one

01:10 < phantomcircuit> sipa, not encouraging! :P

01:13 < sipa> phantomcircuit: i'd say BlockAssembler is an encapsulation of the state maintained during the runtime of CreateNewBlock, but not useful afterwards

01:13 < sipa> CBlockTemplate is the result, and its behaviour is defined by the GBT RPC call

01:22 < gmaxwell> phantomcircuit: forward error correction is a pretty broad space, I'd need more info.

01:24 < phantomcircuit> gmaxwell, split block into lots of udp packets and attempt to reassemble on the other end

01:25 < midnightmagic> zfec

01:25 < midnightmagic> the tahoe guys use it -- as far as I'm aware it's also the fastest

01:26 < gmaxwell> cpu time of an RS code is going to be too slow for your application.

01:26 < gmaxwell> very likely.

01:34 < gmaxwell> (if followed up with phantomcircuit off channel)

01:35 < midnightmagic> what was the result?

01:35 < midnightmagic> like, suggestion/algorithm/library wise?

02:02 < * midnightmagic> prods gmaxwell

02:04 < * midnightmagic> withdraws prodding :)

05:49 < GitHub160> [bitcoin] CryptoDJ opened pull request #7640: Removes backslashes from user agent in peers UI. (master...master) https://github.com/bitcoin/bitcoin/pull/7640

13:42 < instagibbs> im still getting a ton of potential deadlocks, and got this overnight, which I believe crashed bitcoind: sync.cpp:112: void potential_deadlock_detected(const std::pair<void*, void*>&, const LockStack&, const LockStack&): Assertion `onlyMaybeDeadlock' failed.

14:36 < GitHub22> [bitcoin] rebroad opened pull request #7642: Avoid "Unknown command" messages when receiving getaddr on outbound c… (master...GetAddrUnknownCommand) https://github.com/bitcoin/bitcoin/pull/7642

14:59 < morcos> instagibbs: do you have the rest of the stack information so we could see where that might have been called from?

15:15 < instagibbs> morcos, first time it's happened, I assume I can't get the stack after the fact

17:12 < GitHub116> [bitcoin] JeremyRubin opened pull request #7643: Remove always true cases in wallet/crypter.cpp encrypt and decrypt function (master...master) https://github.com/bitcoin/bitcoin/pull/7643

21:05 < gmaxwell> https://news.ycombinator.com/item?id=11223266 latest timing attacks on ECDSA paper is now published. #bitcoin-core-user-not-impacted. Though perhaps we should CVE versions prior to 0.10.

23:55 < GitHub118> [bitcoin] promag opened pull request #7646: Fix lockunspents help message (master...support/fix-lockunspent-help-message) https://github.com/bitcoin/bitcoin/pull/7646