< cfields>
jonasschnelli: 2 callbacks are added. one for events, one purely to report read/write chunks
< jonasschnelli>
cfields: Okay. But after you get a callback on first_read_cb(), you redirect to read_cb,.. why exactly?
< cfields>
jonasschnelli: more specifically, for the bufferevents, watermarks are used so that data reads are only reported for each complete message. for the evbuffers, it'll report every time a chunk is read/written from the socket
< cfields>
jonasschnelli: there's a timeout of N seconds before we disconnect from a peer if no data is read/written. After that first read/write, the initial timeout is no longer needed, and we switch to the regular timeout value
< jonasschnelli>
cfields: Okay. I see. evbuffer_add_cb(input, read_data, this); adds an additional callback.
< jonasschnelli>
And the first_read_cb is for the different timeouts
< cfields>
jonasschnelli: sorry, "if no data is *ever read/written"
< jonasschnelli>
Okay. Thanks!
< cfields>
jonasschnelli: thanks for reviewing! Please fire away with questions. I'd like to document it thoroughly, just not quite sure how
< jonasschnelli>
cfields: I'll try now to understand the code,... its a pre-step for the review. :)
< cfields>
it's probably worth commenting every time the callbacks are set.
< cfields>
adding that to the todo
< madu>
hello
< madu>
someone there?
< sipa>
nope, sorry
< madu>
damn
< madu>
thats sad
< sipa>
:)
< madu>
sipa
< madu>
do you know how i can change something in the translation ?
< madu>
of the gui
< MarcoFalke>
translations are done on transifex
< madu>
i changed somethings e.g. in bitcoin_de.ts and used lrelease to update bitcoin_de.qm
< madu>
but the translations does not change
< MarcoFalke>
We only pull them from transifex before every rc: