< Chris_Stewart_5> Why does this test case fail? ["1","0xba", "P2SH,STRICTENC", "0xba == OP_NOP10 + 1"]
< Chris_Stewart_5> does it hit this in bitcoin core? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L990
< phantomcircuit> Chris_Stewart_5, there's usually comments explaining why a test should fail
< phantomcircuit> cfields, what's the correct way to add another binary to the automake process?
< GitHub31> [bitcoin] TheBlueMatt opened pull request #7903: Fix help text around importaddress and rename it to importscript (master...16-04-importaddress-helptext) https://github.com/bitcoin/bitcoin/pull/7903
< assder> Is version 0x20000000 voting for BIP68/112/113?
< sipa> it is not
< sipa> it's BIP9 without supporting any specific deployment
< sipa> the CSV deployment (bip68/112/113) only starts on may 1st
< assder> Ok. Just to be clear, they could vote for it, but it wouldn't count, right?
< sipa> yes; in fact, it would trigger warnings as it would be support for an undefined bit
< assder> Ok. version 0x20000000 means they are mining with 0.12.1 though, correct?
< sipa> or master
< sipa> or any software tweaked to set that version number there
< assder> Gotcha.
< assder> Thanks.
< sipa> in fact, some 0x20000000 blocks appeared before 0.12.1 was released
< GitHub19> [bitcoin] laanwj opened pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
< GitHub153> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/73fc922ed643...ec870e13991f
< GitHub153> bitcoin/master 1e2c29f Kaz Wesley: prevector: destroy elements only via erase()...
< GitHub153> bitcoin/master 4ed41a2 Kaz Wesley: test prevector::swap...
< GitHub153> bitcoin/master a7af72a Kaz Wesley: prevector::swap: fix (unreached) data corruption...
< GitHub124> [bitcoin] laanwj closed pull request #7888: prevector: fix 2 bugs in currently unreached code paths (master...pvfix) https://github.com/bitcoin/bitcoin/pull/7888
< GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec870e13991f...b1bf511af693
< GitHub29> bitcoin/master 5078ca4 Wladimir J. van der Laan: tests: Check Content-Type header returned from RPC server...
< GitHub29> bitcoin/master b1bf511 Wladimir J. van der Laan: Merge #7833: tests: Check Content-Type header returned from RPC server...
< GitHub134> [bitcoin] laanwj closed pull request #7833: tests: Check Content-Type header returned from RPC server (master...2016_04_rpc_tests_check_content_type) https://github.com/bitcoin/bitcoin/pull/7833
< GitHub146> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1bf511af693...88616d200863
< GitHub146> bitcoin/master 9ad1a51 Wladimir J. van der Laan: crypto: bytes counts are 64 bit...
< GitHub146> bitcoin/master 76212bb Wladimir J. van der Laan: rpc: make sure `gettxoutsetinfo` hash has txids...
< GitHub146> bitcoin/master 28b400f Wladimir J. van der Laan: doc: update release-notes for `gettxoutsetinfo` change
< GitHub59> [bitcoin] laanwj closed pull request #7848: Divergence between 32- and 64-bit when hashing >4GB affects `gettxoutsetinfo` (master...2016_04_hash_4gb_utxoset) https://github.com/bitcoin/bitcoin/pull/7848
< GitHub167> [bitcoin] laanwj opened pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
< GitHub185> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88616d200863...9eb7565cddf2
< GitHub185> bitcoin/master dc0693f Chris Moore: add missing newline...
< GitHub185> bitcoin/master 9eb7565 Wladimir J. van der Laan: Merge #7897: add missing newline...
< GitHub170> [bitcoin] laanwj closed pull request #7897: add missing newline (master...patch-2) https://github.com/bitcoin/bitcoin/pull/7897
< GitHub30> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9eb7565cddf2...d28995018003
< GitHub30> bitcoin/master 3107c47 Chris Moore: fix spelling mistake
< GitHub30> bitcoin/master d289950 Wladimir J. van der Laan: Merge #7900: fix spelling mistake...
< GitHub61> [bitcoin] laanwj closed pull request #7900: fix spelling mistake (master...patch-3) https://github.com/bitcoin/bitcoin/pull/7900
< Chris_Stewart_5> Where is the sigop limit tracked in bitcoin core? I cannot seem to find it in interpreter.cpp
< Chris_Stewart_5> Does it have its own variable used as a counter?
< Chris_Stewart_5> maybe even a better question, is sigop count distict from script op counts?
< GitHub148> [bitcoin] gavinandresen closed pull request #7887: Remove mapBlockSource (master...remove_mapBlockSource) https://github.com/bitcoin/bitcoin/pull/7887
< instagibbs> Chris_Stewart_5, find where it complains about too many sigops. Pretty straight forward.
< Chris_Stewart_5> instagibbs: The term 'sigop' doesn't exist anywhere in interpreter.cpp. Looks like the error is propogated as a normal SCRIPT_ERR_OP_COUNT.
< sipa> Chris_Stewart_5: sigops are counted separately, before script execution
< Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L906 is the line i think is where the error is set
< sipa> Chris_Stewart_5: that's a different limit
< Chris_Stewart_5> Where the heck is counted then? I can't seem to find it. VerifyScript?
< sipa> CScript::GetSigOpCount
< sipa> in script/script.cpp
< Chris_Stewart_5> and policy.cpp is where this is enforced instead of interpreter i'm assuming?
< sipa> the sigop limit is not just policy
< sipa> CheckBlock and ConnectBlock count the sigops and if too high, reject the block
< Chris_Stewart_5> thanks
< instagibbs> what is CScriptCompressor used for exactly? I can't find any usage of it by grepping.
< instagibbs> and it appears to be the only code that uses CFlatData as well. So, same question I suppose.
< sipa> instagibbs: it's used for storing scripts in the utxo set
< sipa> CCoins serialization uses CScriptCompressor
< instagibbs> ah, so it is, thanks
< GitHub142> [bitcoin] theuni opened pull request #7906: net: prerequisites for p2p encapsulation changes (master...net-refactor-prerequisites) https://github.com/bitcoin/bitcoin/pull/7906