< GitHub71> [bitcoin] kazcw opened pull request #7922: CBase58Data::SetString: cleanse the full vector (master...cleanse-fully) https://github.com/bitcoin/bitcoin/pull/7922
< GitHub185> [bitcoin] kazcw opened pull request #7923: Enable leveldb obfuscation for new databases (master...obfuscate) https://github.com/bitcoin/bitcoin/pull/7923
< GitHub172> [bitcoin] kazcw closed pull request #7923: Enable leveldb obfuscation for new databases (master...obfuscate) https://github.com/bitcoin/bitcoin/pull/7923
< phantomcircuit> sipa, gmaxwell anywhere in particular i should start poking around?
< wumpus> well the most straightforward place to start is all kinds of parsing/deserialization functions, from json to base58 to consensus deserialization...
< wumpus> that's why I gave you the univalue example
< wumpus> I submitted my first patch to gcc, wish me luck :< https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01222.html
< paveljanik> :-)
< paveljanik> seems like you like removing stuff ;-)
< phantomcircuit> wumpus, yeah i fuzzed libconsensus before the launch of alpha
< wumpus> makes sense too, probably with disabled signature validation to give the fuzzer a chance?
< wumpus> paveljanik: I can't deny I do :)
< phantomcircuit> wumpus, nah i was looking for interesting results not valid results, so the harness returned 0 for valid and invalid scripts
< phantomcircuit> indeed i virtually always want the harness to return 0
< wumpus> ok, anyhow, go fuzz something already :)
< GitHub132> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/59ad56851a34...0c95ebce7e67
< GitHub132> bitcoin/master 9f7336b Jonas Schnelli: [Wallet] slightly refactor GetOldestKeyPoolTime()
< GitHub132> bitcoin/master 0c95ebc Wladimir J. van der Laan: Merge #7816: [Wallet] slighly refactor GetOldestKeyPoolTime()...
< GitHub90> [bitcoin] laanwj closed pull request #7816: [Wallet] slighly refactor GetOldestKeyPoolTime() (master...2016/04/wallet_oldest_key) https://github.com/bitcoin/bitcoin/pull/7816
< GitHub59> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c95ebce7e67...76176823ba6a
< GitHub59> bitcoin/master 3a99fb2 Suhas Daftuar: Fix headers announcements edge case...
< GitHub59> bitcoin/master 7617682 Wladimir J. van der Laan: Merge #7919: Fix headers announcements edge case...
< GitHub157> [bitcoin] laanwj closed pull request #7919: Fix headers announcements edge case (master...fix-sendheaders-edge-case) https://github.com/bitcoin/bitcoin/pull/7919
< wumpus> cfields: ccache eats gcc's warning/error coloring!
< gmaxwell> I think gcc probably doesn't emit it unless it's writing to a terminal.
< wumpus> ah right, ccache probably pipes the output
< gmaxwell> try -fdiagnostics-color=always
< wumpus> gmaxwell: that worked, thanks!
< GitHub186> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/76176823ba6a...90653bc91d39
< GitHub186> bitcoin/master 5770449 Kaz Wesley: CBase58Data::SetString: cleanse the full vector...
< GitHub186> bitcoin/master 90653bc Wladimir J. van der Laan: Merge #7922: CBase58Data::SetString: cleanse the full vector...
< GitHub105> [bitcoin] laanwj closed pull request #7922: CBase58Data::SetString: cleanse the full vector (master...cleanse-fully) https://github.com/bitcoin/bitcoin/pull/7922
< GitHub139> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90653bc91d39...351abf9e0355
< GitHub139> bitcoin/master a4625ac Cory Fields: leveldb: integrate leveldb into our buildsystem...
< GitHub139> bitcoin/master 351abf9 Wladimir J. van der Laan: Merge #7911: leveldb: integrate leveldb into our buildsystem...
< GitHub133> [bitcoin] laanwj closed pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
< jonasschnelli> where is the DEFAULT_INCLUDES defined?
< wumpus> it's part of the automake system itself
< wumpus> the path to the config.h is added thre
< jonasschnelli> Okay. I see. Thanks.
< GitHub99> [bitcoin] laanwj opened pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925
< phantomcircuit> this is without a doubt a terrible framework
< * phantomcircuit> goes back to the drawing board
< phantomcircuit> first step in fuzzing serializer... use serializer
< wumpus> yes, e.g. deserialize a block passed in on stdin, or a transaction, or network packet, or anything else
< wumpus> what is a terrible framework, afl? I found it a breeze to use, at least compared to previous, more academic instrumented fuzzing frameworks
< wumpus> no need to use a patched LLVM/clang etc a tleast
< phantomcircuit> wumpus, no im trying to build a framework for doing this that does things like de-serializes a CScript object from stdin
< wumpus> oh right
< phantomcircuit> wumpus, it's a pita
< phantomcircuit> it's 2016
< phantomcircuit> why can't i just do std::vector.pop<uint32_t>()
< phantomcircuit> :|
< wumpus> I don't know, use a sane language instead of c++? :-)
< wumpus> c and derivatives are, in a way, like living in the 80's, with a few modern niceties bolted on in surprising and artful ways
< phantomcircuit> wumpus, heh
< GitHub197> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/351abf9e0355...f604bf63211f
< GitHub197> bitcoin/master f59dceb Wladimir J. van der Laan: qt: Fix out-of-tree GUI builds...
< GitHub197> bitcoin/master f604bf6 Wladimir J. van der Laan: Merge #7925: qt: Fix out-of-tree GUI builds...
< GitHub26> [bitcoin] laanwj closed pull request #7925: qt: Fix out-of-tree GUI builds (master...2016_04_qt_out_of_tree_build) https://github.com/bitcoin/bitcoin/pull/7925
< most> hi everyone. i'm currently playing around with the watch-only-feature to archive the balance of adresses. therefore i've used: importadress 1CC6eBM579riyXRVkrBtPtRcmy8C4mpqw2 "test" true
< most> after successfully rescanning the blockchain, i had look into the balance by using >>getbalance "test" 0 true<< and the balance differs to the one i've actually expected
< most> as >>listtransactions "test" 1000 0 true<< just show up all the received transactions, but not the send-related ones
< sipa> most: accounts are virtual bean counters that all share the same wallet coins... they don't have any relation to the blockchain
< sipa> most: the wallet does not have a way to give you a so-called address balance
< most> hmm, ok, so i have to get summarize the debits and credits by myself?
< sipa> it will show you sends and receives by using listtransactions
< sipa> if you specify an account name to listtransactions, it will only list transactions associated with that account
< wumpus> listunspent, with filter by address, can give you the unspent outputs, you can sum them up and get an 'address balance'. For whatever that's worth.
< most> yeah, i saw the sends in listtransactions, but the account-field equals to ""
< most> whereas in a received transaction the account-field states "test", which was the account i imported the address into
< wumpus> it usually indicates you're doing something wrong, like reusing addresses
< sipa> most: that's correct; sends are always associated with "" unless you use the sendfrom command
< sipa> most: again, accounts have nothing to do with the actual coins
< wumpus> better forget about using accounts, except as a convenient label for a group of addresses
< most> yeah, even as the "accounting-feature" is been dropped somewhere in the future
< wumpus> the account balance feature, apart from being deprecated, is not useful for what you're trying to do
< wumpus> right
< most> ok, so i will have a look into listunspend. thank you very much
< sipa> listunspent only gives you the remaining coins and their value
< sipa> not any history
< most> i guess for my purpose it should be fine
< wumpus> which is enough if you just want to compute the balance
< most> i'm just looking for current balance of an address
< wumpus> if you want the history per address you can look at listtranscations, and bucket per receiving address
< most> no, just the balance is fine. i'm regulary checking the balance. and if drops compared to the last one (which is stored in a db or somewhere else) i'll send a notice
< most> anyway, thanks for the help
< sipa> MarcoFalke: i'm not going to rebase until there has been more review, but i'll modify the last commit with your binascii/hex/bytes changes
< GitHub82> [bitcoin] MarcoFalke closed pull request #7918: [qa] mininode: Use hexlify wrapper from util (master...Mf1604-qaMininodeHexlify) https://github.com/bitcoin/bitcoin/pull/7918
< wumpus> jonasschnelli: Q: in your lmdb benchmarks, were you using a VM or otherwise a filesystem mounted from a file instead of block device? I'm seeing some very slow behavior, hanging for ages in fdatasync when I benchmark in a VM
< jonasschnelli> wumpus: No. I was testing on a non-VM system with physical wired SSD.
< wumpus> ok
< jonasschnelli> Though I can give it a testrun on a VM on the same system.
< jonasschnelli> s/can/could
< sipa> wumpus: was your benchmark on an ssd?
< wumpus> jonasschnelli: not necessary, just trying to figure out what is different between your and gmaxwell's benchmark
< wumpus> sipa: I didn't time any full syncs with it
< sipa> here is a theory: lmdb uses mmap, and we use bulk writes often. this means that the OS can do a better job of scheduling the necessary writes to disk than the single-threaded, linear, synchronous approach used by leveldb
< sipa> if your latency for disk writes is low, that perhaps means that the benefit from lmdb is smaller
< wumpus> jonasschnelli: it would be interesting to see if in your case most time is also spent in fdatasync
< sipa> as on an ssd a random write isnas fast as a linear
< jonasschnelli> wumpus: how did you measure the time-spent-in-what-function? Did you add some benchmark logs or ran with a time profiler?
< wumpus> jonasschnelli: no, worse, just break into the debugger when I see it hangin the log
< wumpus> you can find out the same with a profiler, ofc :)
< jonasschnelli> hah. Okay. Yes.
< jonasschnelli> I think we should add a debug=lmbd in your branch.
< jonasschnelli> Otherwise this will be a myst forever
< wumpus> sipa: yes that sounds convincing
< jonasschnelli> sipa: btw: the basic reindex with you new PR took ~24min. (2016-04-20 14:25:30 Reindexing block file blk00000.dat... 2016-04-20 14:49:28 Reindexing finished)
< jonasschnelli> But then I got "UpdateTips" untill 2016-04-20 19:05:21 (~4h15').
< wumpus> yes, that's the idea, it splits the reindex into two phases, which in total should be faster than the whole process was before
< sipa> jonasschnelli: yes, that's expected... how long was a reindex beforehand?
< jonasschnelli> sipa: not sure. But somewhere around 5h IIRC (need to check the IRC logs).
< * jonasschnelli> checking logs...
< jonasschnelli> can find it anymore.
< * jonasschnelli> checking the log
< sipa> cfields: any problems getting the flag from travis?
< GitHub6> [bitcoin] instagibbs opened pull request #7926: [RPC] push back getaddednodeinfo dead value (master...getaddedpushbackmaster) https://github.com/bitcoin/bitcoin/pull/7926
< cfields> sipa: I never heard back this time. It was going too smoothly...
< gmaxwell> sdaftuar: I have a patch that removes the feerate, and also takes it out of acceptmempool, but sipa would have killed me if I expanded the scope of that PR any further.
< gmaxwell> but as soon as that goes in I will PR it.
< phantomcircuit> it's doing crazy things when built against afl on fedora 23
< gmaxwell> what does crazy things mean?
< gmaxwell> also, turn up warnings.
< phantomcircuit> gmaxwell, segfaults