< bitcoin-git> [bitcoin] sipa pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/3186ad4a81a4...5a666428b0f1
< bitcoin-git> bitcoin/master f55f4fc Jim Posen: util: Establish global logger object....
< bitcoin-git> bitcoin/master 6a6d764 Jim Posen: util: Move debug file management functions into Logger.
< bitcoin-git> bitcoin/master 3316a9e Jim Posen: util: Encapsulate logCategories within BCLog::Logger.
< bitcoin-git> [bitcoin] sipa closed pull request #12954: util: Refactor logging code into a global object (master...logging) https://github.com/bitcoin/bitcoin/pull/12954
< meshcollider> ping kallewoof are you online? Need to talk to you about bitcoin wiki but you're not in that channel
< kallewoof> meshcollider: pong. I'm joining
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13133: Remove python2 from configure.ac (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13133
< wumpus> provoostenator: thanks!
< jtimon> BlueMatt: around?
< jtimon> regarding the roundings, we can also multiply everything by 1000 and then divide at the end instead of using floats
< jtimon> not sure what do you mean by "rounding issues you see here where things are rounded to the nearest 1"
< jtimon> I'd rather change the unit than chaging from int to float
< Syd> Bypassicloud
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a666428b0f1...a024a1841d62
< bitcoin-git> bitcoin/master 457c2da Chun Kuan Lee: Remove python2 from configure.ac
< bitcoin-git> bitcoin/master a024a18 MarcoFalke: Merge #13133: Remove python2 from configure.ac...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13133: Remove python2 from configure.ac (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13133
< bitcoin-git> [bitcoin] laanwj opened pull request #13134: net: Add option `-peersendreject` to configure sending of BIP61 notifications (master...2018_05_optional_bip61) https://github.com/bitcoin/bitcoin/pull/13134
< jnewbery> < wumpus> jnewbery: great to see so much progress on account deprecation re: #13075, should we create an issue to track the importprunedfunds issue?
< gribble> https://github.com/bitcoin/bitcoin/issues/13075 | Remove account API from wallet functional tests by jnewbery · Pull Request #13075 · bitcoin/bitcoin · GitHub
< jnewbery> wumpus: sorry, only just saw this. The importprunedfunds issue is tracked in #13078
< gribble> https://github.com/bitcoin/bitcoin/issues/13078 | importprunedfunds + removeprunedfunds + listtransactions can cause OOM · Issue #13078 · bitcoin/bitcoin · GitHub
< wumpus> jnewbery: ok will take a look
< wumpus> can anyone please pick up #12384 and do just the relevant change?
< gribble> https://github.com/bitcoin/bitcoin/issues/12384 | [Docs] Add version footnote to tor.md by Willtech · Pull Request #12384 · bitcoin/bitcoin · GitHub
< wumpus> I don't lose patience quickly but there's no reason a one-line change has to take forever
< wumpus> and we're not going to change the header style there, his point is 'consistency' but if you look at any of our other .mds we use the ------ / ====== style
< wumpus> heck, I'll do it myself
< bitcoin-git> [bitcoin] laanwj opened pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< bitcoin-git> [bitcoin] laanwj closed pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< wumpus> gah
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a024a1841d62...c5f7efe3312f
< bitcoin-git> bitcoin/master 39d2911 Damian Williamson: [Docs] Add version footnote to tor.md...
< bitcoin-git> bitcoin/master c5f7efe Wladimir J. van der Laan: Merge #12384: [Docs] Add version footnote to tor.md...
< bitcoin-git> [bitcoin] laanwj closed pull request #12384: [Docs] Add version footnote to tor.md (master...tor.md) https://github.com/bitcoin/bitcoin/pull/12384
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5f7efe3312f...35eb9d6c880e
< bitcoin-git> bitcoin/master 9085532 ctp-tsteenholdt: Sync contrib/debian from Matt Corallo's PPA
< bitcoin-git> bitcoin/master 2a87b1b ctp-tsteenholdt: Add systemd service for bitcoind...
< bitcoin-git> bitcoin/master 35eb9d6 Wladimir J. van der Laan: Merge #12769: Add systemd service to bitcoind in debian package...
< bitcoin-git> [bitcoin] laanwj closed pull request #12769: Add systemd service to bitcoind in debian package (master...master) https://github.com/bitcoin/bitcoin/pull/12769
< BlueMatt> wumpus: oops, I dont think I can build with those changes until at least 2019
< wumpus> BlueMatt: gah, I guess it shouldn't have been a PR then
< wumpus> BlueMatt: should I revert it?
< BlueMatt> yea, my fault, I should have been clear that I intended to un-ack after luke's comments
< BlueMatt> I mean I dont care *too* much, the ppa has often been out of sync, but it kinda sucks to remain out of sync
< BlueMatt> obviously for any modern releases of ubuntu/debian those changes make sense
< BlueMatt> I can also use them on new distros and just revert them on old ones
< BlueMatt> oh, I may be wrong, its there on trusty
< wumpus> it's been reverted
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/1408d6cf768cc3c88e9ab9efe98b0cb52ae3b537
< bitcoin-git> bitcoin/master 1408d6c Wladimir J. van der Laan: Revert #12769: Add systemd service to bitcoind in debian package...
< wumpus> wouldn't it be better to host the debian stuff in a separate repository, that you have write access to yourself BlueMatt?
< wumpus> I'm really out of my depth here
< bitcoin-git> [bitcoin] jnewbery opened pull request #13136: [trivial] [tests] Fix flake8 warnings in several wallet functional tests (master...wallet_test_flake8) https://github.com/bitcoin/bitcoin/pull/13136
< wumpus> otherwise, just re-file in 2019
< BlueMatt> wumpus: thats an option, I mean tbh /I'm/ also definitely a debian packaging expert
< BlueMatt> so tbh I'm mostly out of my depth too, though I am using debian again now soooo
< MarcoFalke> BlueMatt: wumpus: So what's the status of this? Should this stay reverted in master? Otherwise I suggest a force push to the commit that merged it
< wumpus> well I"m not going to re-revert it as least, this is not an edit war
< wumpus> having an edit war with myself would be kind of pathetic in any case :)
< MarcoFalke> Yeah, thats why I suggested the force push
< BlueMatt> MarcoFalke: we do not force-push master
< wumpus> sometimes we do
< MarcoFalke> ^
< BlueMatt> I mean its been like 30 minutes
< BlueMatt> sure, if its been 30 seconds
< BlueMatt> but....
< wumpus> in any case the only options are: force push, or re-submit in 2019
< wumpus> we're not going to have a fight on the repository
< BlueMatt> I mean its /probably/ fine if its merged
< wumpus> and I'm heading for today, already feels like I've done more damage than good
< BlueMatt> but I'd have to do uploads to figure it out
< BlueMatt> also its usually out-of-sync with master, so whatever
< BlueMatt> so other option: try to build with it merged when we next do a release, then do a "sync with ppa" pr at that point
< wumpus> the optoin I'd prefer is to host this stuff outside of the repository completely, it seems a side-show
< wumpus> yeah...
< BlueMatt> or that
< wumpus> especially if it's always out of sync
< wumpus> sgtm
< wumpus> then a debian directory under that, I suppose
< MarcoFalke> jup, also move the /rpm/ one
< MarcoFalke> * ./contrib/rpm/
< wumpus> indeed
< BlueMatt> sgtm
< wumpus> ok, teams also set up so that BlueMatt has admin access to the repository
< BlueMatt> ok, I'll try to push the current-changes to it today
< bitcoin-git> [bitcoin] laanwj opened pull request #13137: contrib: Remove distribution packaging (master...2018_05_move_distro_packaging) https://github.com/bitcoin/bitcoin/pull/13137
< wumpus> right, probably more urgent to bring it up to date than the (more risky) systemd switch
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1408d6cf768c...baf6b4e3f956
< bitcoin-git> bitcoin/master a533834 John Newbery: [tests] Fix flake8 warnings in several wallet functional tests...
< bitcoin-git> bitcoin/master baf6b4e MarcoFalke: Merge #13136: [tests] Fix flake8 warnings in several wallet functional tests...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13136: [tests] Fix flake8 warnings in several wallet functional tests (master...wallet_test_flake8) https://github.com/bitcoin/bitcoin/pull/13136
< luke-jr> wumpus: BlueMatt: problem with a separate repo is that debian/ has non-packaging stuff in it..
< luke-jr> I suppose we could/should fix that anyway
< BlueMatt> yes, and I assume the debian/copyright file will now never be updated, but honestly, I'm not sure anyone could care less about that
< luke-jr> but IMO it's much nicer to have it in the same repo regardless
< BlueMatt> nor why they should, its clearly presented if they get the source dir
< luke-jr> BlueMatt: what is clearly presented?
< BlueMatt> the licenses on individual files
< bitcoin-git> [bitcoin] jnewbery opened pull request #13138: [tests] Remove accounts from wallet_importprunedfunds.py (master...remove_account_wallet_importprunedfunds) https://github.com/bitcoin/bitcoin/pull/13138
< bitcoin-git> [bitcoin] sidhujag opened pull request #13139: Dev 3.x (master...dev-3.x) https://github.com/bitcoin/bitcoin/pull/13139
< bitcoin-git> [bitcoin] sidhujag closed pull request #13139: Dev 3.x (master...dev-3.x) https://github.com/bitcoin/bitcoin/pull/13139
< luke-jr> BlueMatt: afaik the only place with those is the debian/copyrights file
< BlueMatt> lol
< bitcoin-git> [bitcoin] marcoagner opened pull request #13141: [doc] qt: fixes broken link on readme (master...fix_qt_readme_typo) https://github.com/bitcoin/bitcoin/pull/13141
< bitcoin-git> [bitcoin] sipa opened pull request #13142: Separate IsMine from solvability (master...201804_separate_ismine_solvable) https://github.com/bitcoin/bitcoin/pull/13142
< Chris_Stewart_5> Is there ever a situation where we would re-org to a chain that is shorter than the current tip, assuming the current tip is valid of course
< cfields> Chris_Stewart_5: sure, if the shorter chain has more work
< sipa> in practice, that's very unlikely to happen absent an attack
< sipa> as it requires a reorg that spans a retarget
< gmaxwell> it's trivial for someone to make that happen to a node in IBD however, so don't take the "absent an attack" to mean "absent a very hard attack"
< bitcoin-git> [bitcoin] jimpo opened pull request #13144: RPC: Improve error messages on RPC endpoints that use GetTransaction (master...gettransaction-refactor) https://github.com/bitcoin/bitcoin/pull/13144