< bitcoin-git>
[bitcoin] laanwj opened pull request #13134: net: Add option `-peersendreject` to configure sending of BIP61 notifications (master...2018_05_optional_bip61) https://github.com/bitcoin/bitcoin/pull/13134
< jnewbery>
< wumpus> jnewbery: great to see so much progress on account deprecation re: #13075, should we create an issue to track the importprunedfunds issue?
< wumpus>
I don't lose patience quickly but there's no reason a one-line change has to take forever
< wumpus>
and we're not going to change the header style there, his point is 'consistency' but if you look at any of our other .mds we use the ------ / ====== style
< wumpus>
heck, I'll do it myself
< bitcoin-git>
[bitcoin] laanwj opened pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< bitcoin-git>
[bitcoin] laanwj closed pull request #13135: [Docs] Add version footnote to tor.md (Willtech) (master...2018_05_tor_md_version) https://github.com/bitcoin/bitcoin/pull/13135
< bitcoin-git>
bitcoin/master 1408d6c Wladimir J. van der Laan: Revert #12769: Add systemd service to bitcoind in debian package...
< wumpus>
wouldn't it be better to host the debian stuff in a separate repository, that you have write access to yourself BlueMatt?
< wumpus>
I'm really out of my depth here
< bitcoin-git>
[bitcoin] jnewbery opened pull request #13136: [trivial] [tests] Fix flake8 warnings in several wallet functional tests (master...wallet_test_flake8) https://github.com/bitcoin/bitcoin/pull/13136
< wumpus>
otherwise, just re-file in 2019
< BlueMatt>
wumpus: thats an option, I mean tbh /I'm/ also definitely a debian packaging expert
< BlueMatt>
so tbh I'm mostly out of my depth too, though I am using debian again now soooo
< MarcoFalke>
BlueMatt: wumpus: So what's the status of this? Should this stay reverted in master? Otherwise I suggest a force push to the commit that merged it
< wumpus>
well I"m not going to re-revert it as least, this is not an edit war
< wumpus>
having an edit war with myself would be kind of pathetic in any case :)
< MarcoFalke>
Yeah, thats why I suggested the force push
< BlueMatt>
MarcoFalke: we do not force-push master
< wumpus>
sometimes we do
< MarcoFalke>
^
< BlueMatt>
I mean its been like 30 minutes
< BlueMatt>
sure, if its been 30 seconds
< BlueMatt>
but....
< wumpus>
in any case the only options are: force push, or re-submit in 2019
< wumpus>
we're not going to have a fight on the repository
< BlueMatt>
I mean its /probably/ fine if its merged
< wumpus>
and I'm heading for today, already feels like I've done more damage than good
< BlueMatt>
but I'd have to do uploads to figure it out
< BlueMatt>
also its usually out-of-sync with master, so whatever
< BlueMatt>
so other option: try to build with it merged when we next do a release, then do a "sync with ppa" pr at that point
< wumpus>
the optoin I'd prefer is to host this stuff outside of the repository completely, it seems a side-show
< Chris_Stewart_5>
Is there ever a situation where we would re-org to a chain that is shorter than the current tip, assuming the current tip is valid of course
< cfields>
Chris_Stewart_5: sure, if the shorter chain has more work
< sipa>
in practice, that's very unlikely to happen absent an attack
< sipa>
as it requires a reorg that spans a retarget
< gmaxwell>
it's trivial for someone to make that happen to a node in IBD however, so don't take the "absent an attack" to mean "absent a very hard attack"
< bitcoin-git>
[bitcoin] jimpo opened pull request #13144: RPC: Improve error messages on RPC endpoints that use GetTransaction (master...gettransaction-refactor) https://github.com/bitcoin/bitcoin/pull/13144