03:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ffa86af45363...0612d96ca43b

03:20 < bitcoin-git> bitcoin/master 506c578 practicalswift: Enable Travis checking for two Python linting rules we are currently not violating

03:20 < bitcoin-git> bitcoin/master 0612d96 MarcoFalke: Merge #13214: Enable Travis checking for two Python linting rules we are currently not violating...

03:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13214: Enable Travis checking for two Python linting rules we are currently not violating (master...enable-python-lint-rules) https://github.com/bitcoin/bitcoin/pull/13214

07:26 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #13229: [trivial] Qt: Add testnet chainsize constants and switch for intro (master...2018/05/fix_intro_chainsize) https://github.com/bitcoin/bitcoin/pull/13229

07:40 < Empact> Hey Guys, I've been making contributions in a pretty ad-hoc way but I'm open to suggestions on how to be more helpful. For example, if I take https://github.com/bitcoin/bitcoin/pull/13228 as an impetus to break the circular dependencies (which is one of the categories of work I'm inclined to enjoy), would it be better to:

07:41 < Empact> 1) defer work until #13228 is merged

07:41 < Empact> 2) open PRs covering a single dependency per PR

07:41 < Empact> 3) open a batch-change PR

07:41 < Empact> I'm inclined to 2)

07:41 < gribble> https://github.com/bitcoin/bitcoin/issues/13228 | Add script to detect circular dependencies between source modules by sipa · Pull Request #13228 · bitcoin/bitcoin · GitHub

07:41 < Empact> Pending an answer, I'll do the work on a local branch.

08:00 < bitcoin-git> [bitcoin] practicalswift opened pull request #13230: Allow for easy include analysis by enforcing the developer guide's include syntax preference (master...bracket-syntax-includes) https://github.com/bitcoin/bitcoin/pull/13230

08:32 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #13229: [trivial] Qt: Add testnet chainsize constants and switch for intro (master...2018/05/fix_intro_chainsize) https://github.com/bitcoin/bitcoin/pull/13229

09:18 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/0612d96ca43b...e03c0db08f3b

09:18 < bitcoin-git> bitcoin/master dd3c07a Andrew Chow: Separate HaveKey function that checks whether a key is in a keystore

09:18 < bitcoin-git> bitcoin/master b5ba01a Chris Moore: Add 'sethdseed' RPC to initialize or replace HD seed

09:18 < bitcoin-git> bitcoin/master 2bcf2b5 Andrew Chow: Test sethdseed

09:19 < bitcoin-git> [bitcoin] laanwj closed pull request #12560: [wallet] Upgrade path for non-HD wallets to HD (master...sethdseed) https://github.com/bitcoin/bitcoin/pull/12560

09:23 < fanquake> Empact Definitely don't have to wait for 1)

09:23 < fanquake> 2) building on top of 13228 sounds fine

09:56 < fanquake> wumpus want to merge #13093

09:56 < gribble> https://github.com/bitcoin/bitcoin/issues/13093 | [0.15] backport: depends qt patches by fanquake · Pull Request #13093 · bitcoin/bitcoin · GitHub

11:59 < bitcoin-git> [bitcoin] glaksmono closed pull request #13209: [WIP] Refactoring platform-specific code in util.h/util.cpp (master...bitcoin-12697) https://github.com/bitcoin/bitcoin/pull/13209

12:05 < bitcoin-git> [bitcoin] laanwj closed pull request #11750: Multiselect in coincontrol treewidget and display selected count (master...ccmultiselect) https://github.com/bitcoin/bitcoin/pull/11750

12:22 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e03c0db08f3b...3cbd25f9bfbe

12:22 < bitcoin-git> bitcoin/master 7384a35 John Newbery: [tests] Remove spurious error log in p2p_segwit.py...

12:22 < bitcoin-git> bitcoin/master 3cbd25f Wladimir J. van der Laan: Merge #13205: [tests] Remove spurious error log in p2p_segwit.py...

12:22 < bitcoin-git> [bitcoin] laanwj closed pull request #13205: [tests] Remove spurious error log in p2p_segwit.py (master...p2p_segwit_remove_spurious_error_log) https://github.com/bitcoin/bitcoin/pull/13205

12:32 < bitcoin-git> [bitcoin] laanwj closed pull request #11859: Qt: Fixing restore from system tray behaviour of main window (master...minimize-to-tray) https://github.com/bitcoin/bitcoin/pull/11859

12:35 < bitcoin-git> [bitcoin] laanwj closed pull request #9422: Refactor mempool.dat to be extensible, and store missing info (master...mempool_dat_extensible) https://github.com/bitcoin/bitcoin/pull/9422

12:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cbd25f9bfbe...ea7d6553bc7d

12:50 < bitcoin-git> bitcoin/master 012dec0 practicalswift: Add Clang thread safety annotations for variables guarded by cs_rpcWarmup

12:50 < bitcoin-git> bitcoin/master cf13ad2 practicalswift: Add Clang thread safety annotations for variables guarded by cs_nTimeOffset

12:50 < bitcoin-git> bitcoin/master 8499f15 practicalswift: Add Clang thread safety annotations for variables guarded by cs_warnings

12:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} (master...guarded-by-misc) https://github.com/bitcoin/bitcoin/pull/13116

13:07 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea7d6553bc7d...7cc1bd3aaeb6

13:07 < bitcoin-git> bitcoin/master 264c643 Tim Ruffing: wallet: Reset BerkeleyDB handle after connection fails...

13:07 < bitcoin-git> bitcoin/master b6f0b4d Tim Ruffing: wallet: Improve logging when BerkeleyDB environment fails to close

13:07 < bitcoin-git> bitcoin/master 7cc1bd3 Wladimir J. van der Laan: Merge #13161: wallet: Reset BerkeleyDB handle after connection fails...

13:07 < bitcoin-git> [bitcoin] laanwj closed pull request #13161: wallet: Reset BerkeleyDB handle after connection fails (master...bdb-reset) https://github.com/bitcoin/bitcoin/pull/13161

13:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cc1bd3aaeb6...0dec5b5af4e8

13:20 < bitcoin-git> bitcoin/master 66b0b1b practicalswift: Add compile time checking for all cs_wallet runtime locking assertions

13:20 < bitcoin-git> bitcoin/master 0dec5b5 MarcoFalke: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions...

13:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions (master...cs_wallet-compile-time-checking) https://github.com/bitcoin/bitcoin/pull/13081

13:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0dec5b5af4e8...cb088b146178

13:33 < bitcoin-git> bitcoin/master 9e49db2 Evan Klitzke: Make --enable-debug to pick better options...

13:33 < bitcoin-git> bitcoin/master cb088b1 Wladimir J. van der Laan: Merge #13005: Make --enable-debug to pick better options...

13:34 < bitcoin-git> [bitcoin] laanwj closed pull request #13005: Make --enable-debug to pick better options (master...enabledebug-again) https://github.com/bitcoin/bitcoin/pull/13005

13:49 < bitcoin-git> [bitcoin] dbolser closed pull request #13122: --disable-asm is required to compile on FreeBSD (master...patch-4) https://github.com/bitcoin/bitcoin/pull/13122

13:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb088b146178...19a3a9e8fba7

13:59 < bitcoin-git> bitcoin/master 56921f9 practicalswift: wallet: Add Clang thread safety annotations for variables guarded by cs_db

13:59 < bitcoin-git> bitcoin/master 19a3a9e MarcoFalke: Merge #13127: wallet: Add Clang thread safety annotations for variables guarded by cs_db...

14:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13127: wallet: Add Clang thread safety annotations for variables guarded by cs_db (master...guarded-by-cs_db) https://github.com/bitcoin/bitcoin/pull/13127

14:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/19a3a9e8fba7...0264836695a2

14:32 < bitcoin-git> bitcoin/master 6bc5b71 practicalswift: Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins)...

14:32 < bitcoin-git> bitcoin/master 0e2dfa8 practicalswift: Fix missing locking in CTxMemPool::setSanityCheck(double dFrequency)...

14:32 < bitcoin-git> bitcoin/master 47782b4 practicalswift: Add Clang thread safety analysis annotations

14:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11689: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) (master...CTxMemPool-check) https://github.com/bitcoin/bitcoin/pull/11689

14:39 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0264836695a2...682698970d45

14:39 < bitcoin-git> bitcoin/master c5bcc7d Karl-Johan Alm: util: warn about recursive -includeconf arguments in configuration files...

14:39 < bitcoin-git> bitcoin/master 2352aa9 Karl-Johan Alm: test: Ensure that recursive -includeconf produces appropriate warnings

14:39 < bitcoin-git> bitcoin/master 6826989 Wladimir J. van der Laan: Merge #13197: util: warn about ignored recursive -includeconf calls...

14:40 < bitcoin-git> [bitcoin] laanwj closed pull request #13197: util: warn about ignored recursive -includeconf calls (master...includeconf-warn-nonrecursive) https://github.com/bitcoin/bitcoin/pull/13197

14:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/682698970d45...c5870ab68999

14:48 < bitcoin-git> bitcoin/master fd447a6 practicalswift: Fix dead stores. Values were stored but never read. Limit scope.

14:48 < bitcoin-git> bitcoin/master 159c32d practicalswift: Add assertion to guide static analyzers. Clang Static Analyzer needs this guidance.

14:48 < bitcoin-git> bitcoin/master c5870ab MarcoFalke: Merge #12963: Fix Clang Static Analyzer warnings...

14:48 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12963: Fix Clang Static Analyzer warnings (master...issue-12961) https://github.com/bitcoin/bitcoin/pull/12963

15:20 < bitcoin-git> [bitcoin] practicalswift opened pull request #13232: build: Use -DDEBUG_ADDRMAN when building with --enable-debug (master...enable-DEBUG_ADDRMAN-when-using-——enable-debug) https://github.com/bitcoin/bitcoin/pull/13232

15:27 < achow101> oooh lots of merges today

15:38 < sipa> m-m-m-multimerge

17:48 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #13233: Skip PrecomputedTransactionData hashing for cache hits. (master...2018-05-no-needless-precompute) https://github.com/bitcoin/bitcoin/pull/13233

18:13 < BlueMatt> sipa: feel like ack-and-merge'ing #13011?

18:13 < gribble> https://github.com/bitcoin/bitcoin/issues/13011 | Cache witness hash in CTransaction by MarcoFalke · Pull Request #13011 · bitcoin/bitcoin · GitHub

19:14 < Guest94782> can anyone point me to the function def used in bitcoin/src/interpreter.cpp @ line 280 ?

19:14 < Guest94782> i've grepped the shit out of bitcoin/src and cannot find a def for count(...)

19:32 < bitcoin-git> [bitcoin] practicalswift closed pull request #13232: build: Use -DDEBUG_ADDRMAN when building with --enable-debug (master...enable-DEBUG_ADDRMAN-when-using-——enable-debug) https://github.com/bitcoin/bitcoin/pull/13232

20:32 < jimpo> Guest94782: http://en.cppreference.com/w/cpp/algorithm/count

21:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c5870ab68999...81c533c6f481

21:10 < bitcoin-git> bitcoin/master f08a385 marcoagner: [qt]: changes sendcoinsdialog's box layout for improved readability....

21:10 < bitcoin-git> bitcoin/master 81c533c MarcoFalke: Merge #13158: [Qt]: Improve sendcoinsdialog readability...

21:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13158: [Qt]: Improve sendcoinsdialog readability (master...improve_sendcoinsdialog_readability) https://github.com/bitcoin/bitcoin/pull/13158

22:09 < savantgarde> About the method ListSinceBlock of Bitcoin Core - for a 'receive' category payment (entry of 'transactions' field), will vout refer to an output in a transaction?

22:09 < savantgarde> And will the 'amount' field refer to the amount in said output?

23:17 < promag> savantgarde: yes