< bitcoin-git> [bitcoin] sipa opened pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0fc6ea216c00...17cfa52d3806
< bitcoin-git> bitcoin/master 7dda912 Hennadii Stepanov: test: Do not swallow flake8 exit code
< bitcoin-git> bitcoin/master 5d77549 Hennadii Stepanov: doc: Add mypy to test dependencies
< bitcoin-git> bitcoin/master 17cfa52 fanquake: Merge #19172: test: Do not swallow flake8 exit code
< bitcoin-git> [bitcoin] fanquake merged pull request #19172: test: Do not swallow flake8 exit code (master...200605-mypy) https://github.com/bitcoin/bitcoin/pull/19172
< bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< jonatack> any preference in naming for an assertion that an amount has the expected number of digits after the decimal? i'm thinking "assert_scale", "assert_fractional_part_size", "assert_mantissa_length", "assert_decimal_places", etc.
< jonatack> going with "assert_scale" and an explanatory docstring for now
< ryanofsky> phantomcircuit, to fix link errors you may need to move blockfilter.cpp from libbitcoin_server library to libbitcoin_util library in makefile
< ryanofsky> wallet isn't linked against libbitcoin_server to prevent wallet code from trying to access node global variables
< ryanofsky> but a lot of things in libbitcoin_server that are just utilities without server state don't really belong there
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
< bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19188: 2006 test no shadow field (master...2006-testNoShadowField) https://github.com/bitcoin/bitcoin/pull/19188
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/17cfa52d3806...b1b173994406
< bitcoin-git> bitcoin/master fa3999f MarcoFalke: net: Reformat excessively long if condition into multiple lines
< bitcoin-git> bitcoin/master fa9604c MarcoFalke: doc: noban precludes maxuploadtarget disconnects
< bitcoin-git> bitcoin/master b1b1739 MarcoFalke: Merge #18968: doc: noban precludes maxuploadtarget disconnects
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
< bitcoin-git> [bitcoin] hebasto opened pull request #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp (master...200605-timedata) https://github.com/bitcoin/bitcoin/pull/19189
< bitcoin-git> [bitcoin] hebasto opened pull request #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp (master...200606-netbase) https://github.com/bitcoin/bitcoin/pull/19190
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19191: net: Extract download permission from noban (master...2006-netPerDow) https://github.com/bitcoin/bitcoin/pull/19191
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19192: doc: Extract net permissions doc (master...2006-docNetPerm) https://github.com/bitcoin/bitcoin/pull/19192
< bitcoin-git> [bitcoin] hebasto opened pull request #19193: refactor, qt, net: Deduplicate NumConnections enum (master...200606-numconn) https://github.com/bitcoin/bitcoin/pull/19193
< bitcoin-git> [bitcoin] miztake opened pull request #19194: util: Don't reference errno when pthread fails. (master...prototype) https://github.com/bitcoin/bitcoin/pull/19194
< jarthur> Does the REST API use libevent goodness?
< fjahr> jarthur: yes
< jarthur> ty
< phantomcircuit> eyyyy using a filter with fixed siphash parameters and 30 bits does a wallet rescan in 4.6 minutes
< sipa> phantomcircuit: nice
< phantomcircuit> sipa, i also realized last night i was still loading the blocks when i did the BASIC filter benchmarks so im redoing those correctly
< phantomcircuit> i can tell from the heat of my laptop that it's much much slower though
< phantomcircuit> sipa, there's some house keeping stuff to do in the ScanForWalletTransactions method that could be a separate pr and are trivial, should i do that?
< phantomcircuit> im not sure what the thinking is on that right now
< bitcoin-git> [bitcoin] pstratem opened pull request #19195: wallet: ScanForWalletTransactions cleanup (master...2020-06-06-scanforwallettransactions-cleanup) https://github.com/bitcoin/bitcoin/pull/19195
< phantomcircuit> btw is master broken? make check "ERROR: ConnectBlock(): coinbase pays too much (actual=5010000000 vs limit=5000000000)"
< sipa> phantomcircuit: when?
< phantomcircuit> no it's just my branch that has nothing to do with the coinbase values
< phantomcircuit> what
< phantomcircuit> oh hmm findNextBlock has identical results for a reorg and a straight failure to load the block
< phantomcircuit> so the wallet test is expecting FAILURE when im returning success because the reorg flag is set, but the reorg flag doesn't mean reorg it means reorg or the block couldn't be found
< phantomcircuit> right there's no way to distinguish between the start block is invalid and the start block was reorg'd so this test is just bad