< bitcoin-git>
[bitcoin] fanquake opened pull request #19375: build: target Windows 7 when building libevent and fix ipv6 usage (master...libevent_target_0x0601) https://github.com/bitcoin/bitcoin/pull/19375
< fanquake>
wumpus / sipa: can you block dahuisong
< bitcoin-git>
[bitcoin] fanquake closed pull request #18287: depends: Patch libevent build to fix IPv6 -rpcbind on Windows (master...fix_libevent_win_ipv6) https://github.com/bitcoin/bitcoin/pull/18287
< bitcoin-git>
[bitcoin] hebasto opened pull request #19378: refactor: Use Mutex type for g_cs_recent_confirmed_transactions (master...200625-recent-mx) https://github.com/bitcoin/bitcoin/pull/19378
< wumpus>
fanquake: done
< fanquake>
wumpus: thanks
< bitcoin-git>
[bitcoin] practicalswift opened pull request #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) (master...fuzzers-SigHashLowR) https://github.com/bitcoin/bitcoin/pull/19379
< bitcoin-git>
[bitcoin] practicalswift closed pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
< bitcoin-git>
[bitcoin] practicalswift reopened pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
< provoostenator>
sipa shesek achow101see also #18043
< provoostenator>
Can #19215 be added to the hardware wallet project? It's a pain test stuff on updated devices without that...
< gribble>
https://github.com/bitcoin/bitcoin/issues/19215 | psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs by achow101 · Pull Request #19215 · bitcoin/bitcoin · GitHub
< luke-jr>
on that note, it might be nice if there was a HWI preview release people could play with
< provoostenator>
wumpus: it's supposed to prevent that
< wumpus>
provoostenator: added #19215 to hw project
< provoostenator>
Because if you enter "1" it won't interpret that at BTC/KB
< gribble>
https://github.com/bitcoin/bitcoin/issues/19215 | psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs by achow101 · Pull Request #19215 · bitcoin/bitcoin · GitHub
< achow101>
sipa: I guess I should update the bip
< wumpus>
provoostenator: OK, I guess there is still some time to figure this out before the release
< wumpus>
I'm also not sure reverting the entire PR makes sense
< sipa>
achow101: right
< luke-jr>
Even if we get to a release point, might be nicer to just minimally remove the RPC interface to it
< sipa>
achow101: it's unfortunate that this pushes behaviour towards a postel's law...
< provoostenator>
This uses the "unset" estimate mode, as before IIUC: bitcoin-cli sendtoaddress bcrt1... 1 "" "" false false 1
< provoostenator>
And this uses satoshi per byte: bitcoin-cli sendtoaddress bcrt1... 1 "" "" false false 1 sat/b
< provoostenator>
I've never been a fan of the "unset" estimate mode, documented as "Use default settings based on other criteria". I would prefer failure.
< achow101>
sipa: it's supposed to be for compatibility with older software that relies on the type of utxo available to determine signing
< sipa>
achow101: yes, i understand - i'm not saying it's the wrong choice
< sipa>
only saddened by its necessity
< achow101>
but it might also be probable that most of those software are following our same check that both utxos aren't provided
< achow101>
in which case it wouldn't be necessary
< luke-jr>
and then the witness_utxo gets renamed to taproot_utxo? :p
< provoostenator>
#16378 just went from 16 commits down to 4...
< wumpus>
I somehow thought #18297 already did this :)
< gribble>
https://github.com/bitcoin/bitcoin/issues/18297 | build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto · Pull Request #18297 · bitcoin/bitcoin · GitHub
< jeremyrubin>
hi
< luke-jr>
tbh I never really understood why we didn't do this from the start
< hebasto>
18297 did for Qt only
< luke-jr>
yes, I mean why we *ever* had any other behaviour
< wumpus>
luke-jr: it used to be extremely difficult or even impossible to get pkgconfig to do the right thing on mingw
< luke-jr>
wumpus: really? I never had a problem :/
< wumpus>
or at least that was the assumption, it grew from that
< wumpus>
sure, it could have been a faulty assumption
< wumpus>
in any case I'm happy that this can use a simpler unified approach now
< luke-jr>
I guess someone should test it in the same environment that once had problems?
< wumpus>
FWIW I also remember pkg-config horror with cross-compiles in the past, this became a lot better in recent times
< cfields>
^^ what wumpus said. mingw+pkgconfig wasn't well supported when it was implemented.
< wumpus>
I doubt that environment still exists, or is capable of building bitcoin core :)
< luke-jr>
wumpus: I thought half the point of pkg-config in the first place was to fix cross-compile stuff
< luke-jr>
ie, by having text files defining the requirements instead of custom qt-config type binaries
< luke-jr>
wumpus: well, MingW on Windows then?
< wumpus>
in my case it was something with paths not getting set right in the text files
< luke-jr>
would be a shame to get locked into MSVC++ for native Windows builds
< luke-jr>
i c
< cfields>
luke-jr: a big part of the problem was that libs didn't bother trying to get the libs right for windows. Now they're better.
< wumpus>
so it required an ugly level of patching, or, the target program supporting another way to pass in dependencies
< wumpus>
in any case this was problably solved 5 years ago :)
< wumpus>
it's no longer relevant and we can move on
< wumpus>
does anyone have other topics to discuss?
< luke-jr>
wtxid relay got a BIP I saw
< luke-jr>
oh, and shaolinfry merged my PR to BIP 8, which fixes up some stuff and also enables a path forward for any other revisions we might want to make
< wumpus>
good to hear that
< sipa>
BIP 339 is wtxid relay
< luke-jr>
(enables it because that PR added me as a co-champion)