< bitcoin-git> [bitcoin] achow101 opened pull request #19290: wallet: move BDB specific classes to bdb.{cpp/h} (master...move-bdb) https://github.com/bitcoin/bitcoin/pull/19290
< bitcoin-git> [bitcoin] achow101 opened pull request #19292: wallet: Refactor BerkeleyBatch Read, Write, Erase, and Exists functions into non-template functions (master...refactor-bdb-read) https://github.com/bitcoin/bitcoin/pull/19292
< bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1c86ed414834...28ce05d06f2a
< bitcoin-git> bitcoin/master 1c6b787 gzhao408: [netprocessing] disconnect node that sends filterclear
< bitcoin-git> bitcoin/master ff8c430 gzhao408: [test] test disconnect for filterclear
< bitcoin-git> bitcoin/master 3a10d93 gzhao408: [p2p/refactor] move disconnect logic and remove misbehaving
< bitcoin-git> [bitcoin] fanquake merged pull request #19260: p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic (master...filterclear-disconnect) https://github.com/bitcoin/bitcoin/pull/19260
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/28ce05d06f2a...46bdd4b537cb
< bitcoin-git> bitcoin/master edae607 John Newbery: [tests] Only acquire lock once in p2p_compactblocks.py
< bitcoin-git> bitcoin/master 9d80762 John Newbery: [tests] Don't acquire mininode_lock twice in wait_for_broadcast()
< bitcoin-git> bitcoin/master c67c1f2 John Newbery: [tests] Don't call super twice in P2PTxInvStore.on_inv()
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19178: Make mininode_lock non-reentrant (master...2020-05-mininode-lock-reentrancy) https://github.com/bitcoin/bitcoin/pull/19178
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19293: net: Avoid redundant and confusing FAILED log (master...2006-netNoRet) https://github.com/bitcoin/bitcoin/pull/19293
< wumpus> MarcoFalke: it looks like somehow, merges are not credited to your github account ,see e.g. https://github.com/bitcoin/bitcoin/commits/master there's no icon and no link
< wumpus> not sure why, it doesn't look like you changed mail recently
< fanquake> wumpus: from what I understand, he has started doing that on purpose
< wumpus> is the mail (falke.marco@gmail.com) still listed in your github settings?
< wumpus> fanquake: I think it means everyone can claim that mail now
< wumpus> fanquake: do you know why?
< fanquake> wumpus: I think I'd rather let him explain
< wumpus> ok
< wumpus> I jus don't want the same problem as with the satoshi commits
< wumpus> falke.marco@gmail.com
< wumpus> Unverified
< wumpus> Not visible in emails
< wumpus> didn't work, it seems, it still shows them without link
< wumpus> OH IT DID
< wumpus> https://github.com/bitcoin/bitcoin/commits/master reload, all MarcoFalke's commits are mine now
< fanquake> Yep, I can you as merging the last commit
< fanquake> All of his recent merges and commits show here too: https://github.com/bitcoin/bitcoin/commits?author=laanwj
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46bdd4b537cb...0afbeb73ccb7
< bitcoin-git> bitcoin/master 16d4b3f Ivan Metlushko: test: mempool.dat compatibility between versions
< bitcoin-git> bitcoin/master 0afbeb7 MarcoFalke: Merge #19153: test: mempool compatibility test
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19153: test: mempool compatibility test (master...feature/mempool_compatibility_test) https://github.com/bitcoin/bitcoin/pull/19153
< MarcoFalke> fanquake: wumpus: hi, I was exploring on how to make pull request review focus more on the content as opposed to the author of a commit
< MarcoFalke> Removing the GitHub avatar from commit messages seemed like an easy first step
< MarcoFalke> I didn't realize that GitHub still has this nasty bug
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19294: test: refactor: Inline adjust_bitcoin_conf_for_pre_17 (master...2006-testAdjust) https://github.com/bitcoin/bitcoin/pull/19294
< wumpus> I've updated the bitcoin/frequent-contributors bitcoin-core/frequent-contributors to have the same people in it, so if you get a seemingly spurious invite that's the reason
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0afbeb73ccb7...4b30c41b4ebf
< bitcoin-git> bitcoin/master d1cca12 Hennadii Stepanov: refactor: Use bilingual_str::empty()
< bitcoin-git> bitcoin/master 083daf7 Hennadii Stepanov: Pass bilingual_str argument to AbortNode()
< bitcoin-git> bitcoin/master d924f2a Hennadii Stepanov: Drop MSG_NOPREFIX flag
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
< bitcoin-git> [bitcoin] hebasto closed pull request #18298: build: Fix Qt processing of configure script for depends with DEBUG=1 (master...20200309-depends-debug) https://github.com/bitcoin/bitcoin/pull/18298
< bitcoin-git> [bitcoin] hebasto reopened pull request #18298: build: Fix Qt processing of configure script for depends with DEBUG=1 (master...20200309-depends-debug) https://github.com/bitcoin/bitcoin/pull/18298
< elichai2> wumpus: FYI, why is there still bitcoin and bitcoin-core as different orgs? (I mistype sometimes when I move between secp and bitcoin)
< wumpus> elichai2: because it seems better to keep bitcoin/bitcoin there for now
< wumpus> there's no way to create a permanent redirect on github, all solutions to that basically suck
< wumpus> but all new repositories are created under bitcoin-core, at some point, if enough things split off from the main codebase, at some point maybe only the consensus code (and bips) will be left under bitcoin
< wumpus> that would be my personal preference at least, to have all active development happen under bitcoin-core and (lower traffic, but critical) "specs"/protocol work remain under bitcoin
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19295: refactor: Use AbortError in FatalError (master...2006-refactorAbortError) https://github.com/bitcoin/bitcoin/pull/19295
< bitcoin-git> [bitcoin] practicalswift opened pull request #19296: tests: Add fuzzing harness for AES{CBC,}256{Encrypt,Decrypt} (crypto/aes.h) (master...fuzzers-more-crypto) https://github.com/bitcoin/bitcoin/pull/19296
< bitcoin-git> [bitcoin] glowang opened pull request #19297: [test] WIP: rewrite generate() in test_node to gain determinism in test data (master...2020/05/21/rewrite_generate_in_testnode) https://github.com/bitcoin/bitcoin/pull/19297
< bitcoin-git> [bitcoin] hebasto closed pull request #19251: [Do Not Merge] ci: Temporary Test Case for negative capabilities in the Clang Thread Safety annotations (master...200611-dnm-test) https://github.com/bitcoin/bitcoin/pull/19251
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4b30c41b4ebf...f658c15bb936
< bitcoin-git> bitcoin/master 968aaae fanquake: tests: run test-security-check.py in CI
< bitcoin-git> bitcoin/master 9fe71a5 fanquake: test: use subprocess.run() in test-security-check.py
< bitcoin-git> bitcoin/master f658c15 Wladimir J. van der Laan: Merge #18434: tests: add a test-security target and run it in CI
< bitcoin-git> [bitcoin] laanwj merged pull request #18434: tests: add a test-security target and run it in CI (master...run_security_check_ci) https://github.com/bitcoin/bitcoin/pull/18434
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f658c15bb936...86590c17fc17
< bitcoin-git> bitcoin/master 313a081 wiz: [net] Add seed.bitcoin.wiz.biz to DNS seeds
< bitcoin-git> bitcoin/master 86590c1 Wladimir J. van der Laan: Merge #19284: [net] Add seed.bitcoin.wiz.biz to DNS seeds
< bitcoin-git> [bitcoin] laanwj merged pull request #19284: [net] Add seed.bitcoin.wiz.biz to DNS seeds (master...add-wiz-seed) https://github.com/bitcoin/bitcoin/pull/19284
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86590c17fc17...23b2a68df571
< bitcoin-git> bitcoin/master 44cc75f Karl-Johan Alm: wallet: error if an explicit fee rate was given but the needed fee rate di...
< bitcoin-git> bitcoin/master 23b2a68 MarcoFalke: Merge #18275: wallet: error if an explicit fee rate was given but the need...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18275: wallet: error if an explicit fee rate was given but the needed fee rate differed (master...2003-wallet-error-on-feechange) https://github.com/bitcoin/bitcoin/pull/18275
< achow101> <wumpus> there's no way to create a permanent redirect on github, all solutions to that basically suck <--- No? Moving a repo wil permanently redirect the old location to the new one. Even the git urls so existing contributors don't need to change anything
< achow101> e.g. HWI used to be achow101/HWI and achow101/HWI now permanently redirects to bitcoin-core/HWI
< wumpus> fairly sure that ends after a while
< achow101> I don't think so
< wumpus> in any case I still hope for a future separation between consensus code and the rest of the implementation makes sense, and maybe it fits this split
< dongcarl> wumpus fanquake: Shall we move https://github.com/theuni/apple-sdk-tools into the bitcoin-core org?
< dongcarl> We can also pull the script into the repo, but I just thought other projects might be interested in it
< provoostenator> The tool to extract xip files certainly seems useful outside the project
< luke-jr> I thougth that was 3rd party
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19298: test: Add missing sync_blocks (master...2006-syncBlocks) https://github.com/bitcoin/bitcoin/pull/19298
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19299: refactor: Remove unused vars, Add missing includes (master...2006-removeUnusedVars) https://github.com/bitcoin/bitcoin/pull/19299
< dongcarl> luke-jr: what do you mean?
< harding> github.com/bitcoin/bitcoin.org redirects to github.com/bitcoin-dot-org/bitcoin.org and that move was in 2015.
< luke-jr> dongcarl: XIP is extracted by the `xar` command, which is maintained by Apple
< dongcarl> luke-jr: Right, but with apple-sdk-tools, we don't need xar, we just need a python script!
< elichai2> I think bitcoin-core/bitcoin also redirects to bitcoin/bitcoin
< luke-jr> dongcarl: what's wrong with xar? O.o
< dongcarl> Nothing's wrong with it, just that before we needed xar+pbzx, now we just need a 109 sloc python script
< luke-jr> oh, it takes care of both? :o
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/23b2a68df571...5cafb46fef3f
< bitcoin-git> bitcoin/master faa841b MarcoFalke: test: refactor: Inline adjust_bitcoin_conf_for_pre_17
< bitcoin-git> bitcoin/master fa41b0a MarcoFalke: pep-8 test/functional/test_framework/util.py
< bitcoin-git> bitcoin/master 5cafb46 MarcoFalke: Merge #19294: test: refactor: Inline adjust_bitcoin_conf_for_pre_17
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19294: test: refactor: Inline adjust_bitcoin_conf_for_pre_17 (master...2006-testAdjust) https://github.com/bitcoin/bitcoin/pull/19294
< dongcarl> luke-jr: Yup! I was surprised too haha
< wumpus> dongcarl: sounds good to me (moving it to the bitcoin-core organization ,that is, I'd prefer not to put such scripts into the repo)
< dongcarl> 👍
< luke-jr> crc32c/src/./crc32c_read_le.h:39:70: warning: left shift count >= width of type [-Wshift-count-overflow]
< luke-jr> are LevelDB CRCs effectively broken on BE?
< luke-jr> (and fixing it may break chainstates on BE..)
< sipa> luke-jr: that looks like an upstream bug
< sipa> luke-jr: but it's code that's only used on sse 4.2 compatible systems
< sipa> and i think none of those are big endian
< sipa> hmm, https://github.com/google/crc32c doesn't have issues enabled
< luke-jr> yeah, I don't know of any BE with SSE
< luke-jr> but it's being compiled for ppc64 :/
< sipa> src/crc32c_portable.cc includes the file
< sipa> but only uses the ReadUint32LE function, which is correct
< sipa> there actually is a unit test for that function
< sipa> i expect it will catch the issue
< * luke-jr> glares at Linux for not letting him run even static BE binaries on his LE kernel
< sipa> so i conclude that literally nobody ever used google/crc32c on a BE system?
< sipa> or at least ever ran the unit test
< midnight> google has a pile of power cloud systems now don't they?
< sipa> internally they wouldn't use this
< sipa> i expect
< sipa> luke-jr: the fix is easy; you want to do it, or want me to?
< luke-jr> sipa: since it's upstream, and doesn't affect us, not sure there's a need?
< sipa> sure
< luke-jr> it's not in *our* unit tests, right?
< sipa> but i consider it polite to at least inform them their code is broken
< luke-jr> do you know how to?
< luke-jr> I've only ever hit dead ends trying to report problems to Google so far..
< sipa> you can open PRs
< luke-jr> ah
< sipa> they can take a long time, but some get merged
< luke-jr> sipa: I don't care who does it
< luke-jr> if you don't want to, I can
< sipa> i don't mind, but you discovered it :)
< * luke-jr> shrugs
< luke-jr> sipa: if the next block's LSB is 1, I'll do it :P
< sipa> OKAY
< * sipa> expects a dispute about exactly which bit is the LSB
< luke-jr> lol
< midnight> lol
< luke-jr> sipa: is it 0 or 1? ;)
< sipa> 000000000000000000067dba714e87293db53aa399e60072466f75978bbeb0a4
< sipa> looks pretty LSB=0 to me
< luke-jr> k