< bitcoin-git> [bitcoin] practicalswift opened pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
< hebasto> promag: it was useful (at least for me) when I was playing with wallet stuff
< promag> hebasto: how so? what you used it for?
< hebasto> promag: opening multiple copies of sqlite wallet
< bitcoin-git> [bitcoin] wodry opened pull request #20582: [doc] Fix documenation of options onlynet and listenonion (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20582
< theStack> i'm just running my first gitian build. is there any reason why the use of Docker is not more encouraged (it's not even mentioned in gitian-building.md)? are there potential problems/drawbacks? setting up an extra VM seems to be massive overkill for this task
< luke-jr> Docker would be the extra ;)
< theStack> installing docker to the distro of your choice and simply passing "--docker" to the gitian build script (if it's not that easy i may missed somethig :)) seems less of an effort to me than to setting up a virtual machine
< luke-jr> just wait until you see the macOS hoops
< theStack> grated, i was focussing on linux here
< theStack> *granted
< hebasto> theStack: conventional lxc works fine with less overhead
< jonatack> at least a dozen people have followed it for their first gitian builds
< jonatack> hebasto: yes. you and achow are generally the fastest builders :)
< hebasto> :D
< hebasto> jonatack: your guide is must-read for novices
< jonatack> hebasto: thanks :) it's based on fanquake's guide, maybe my first-time point of view helped
< jonatack> theStack: good to see you building too +1
< achow101> theStack: docker is less documented because it is much much newer than the other methods
< theStack> hebasto: okay good to know, haven't looked into lxc (and how it differs from docker) much yet
< theStack> jonatack: huge thanks, this guide seems to be exactly what i was looking for!
< achow101> the only reason it exists is because lxc stopped working for me at some point so I added it to gitian
< hebasto> theStack: for ubuntu&lxc host don't hesitate to look at my notes https://gist.github.com/hebasto/e0b4f5bb948174353e10989b24b6a82c
< hebasto> yet not updated with the latest macOS stuff
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f35e4d906fee...9385549a31e7
< bitcoin-git> bitcoin/master 12dcdaa practicalswift: Don't make "in" parameters look like "out"/"in-out" parameters: pass by re...
< bitcoin-git> bitcoin/master 9385549 MarcoFalke: Merge #20581: Don't make "in" parameters look like "out"/"in-out" paramete...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9385549a31e7...64156ad4d1f5
< bitcoin-git> bitcoin/master fa135a1 MarcoFalke: Revert "test: Add missing sync_all to wallet_balance test"
< bitcoin-git> bitcoin/master fa6af31 MarcoFalke: test: Document why syncwithvalidationinterfacequeue is needed in tests
< bitcoin-git> bitcoin/master 64156ad MarcoFalke: Merge #19893: test: Remove or explain syncwithvalidationinterfacequeue
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19893: test: Remove or explain syncwithvalidationinterfacequeue (master...2009-testSync) https://github.com/bitcoin/bitcoin/pull/19893
< luke-jr> does anyone have a crawler that handles Tor?
< sipa> luke-jr: my dns seeder does, but oniy torv2
< luke-jr> oh! I didn't realise that
< phantomcircuit> there's no reason to drop peers sending you commands you don't understand
< phantomcircuit> it's literally not a DoS
< sipa> you could argue it is one if there were no other way to waste nodes' bandwidth
< sipa> given that that is (a) trivial and (b) solutions for that (e.g. deprioritizing peers that send too much) aren't orthogonal to permitting unknown messages or not, it isn't
< phantomcircuit> sipa, no matter what you do i can always waste your inbound bandwidth
< phantomcircuit> there's just no way to prevent that
< luke-jr> pls dont udp flood me phantomcircuit
< phantomcircuit> what luke-jr said
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20583: rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs (master...2012-walletSync) https://github.com/bitcoin/bitcoin/pull/20583
< sipa> phantomcircuit: well there are CPU costs involved with handling messages you're ignoring (making its way to the network stack into process, checksum computation, ...) that just spamming UDP messages doesn't have
< sipa> my point is those costs are negligable compared to say spamming with ping or tx messages
< phantomcircuit> sipa, sure, but the worst thing you can do is cause the cpu to spin doing nonsense for a brief instant, in between doing real work
< sipa> phantomcircuit: i'm not saying you're wrong - i obviously agree that there is no harm in just ignoring unknown messages
< sipa> but i think it needs a slightly more nuanced explanation than "literally not a DoS"
< phantomcircuit> the amount of cpu time used is roughly on par with the cpu time used to resolve udp packet fragmentation
< sipa> yes, that sort of expalanation :)
< phantomcircuit> sipa, it's certainly less of a DoS than just spamming someone with ip fragments
< bitcoin-git> [bitcoin] practicalswift opened pull request #20584: Don't declare de facto const member functions as non-const. Don't declare de facto const reference variables as non-const. (master...const-member-fn-and-const-ref-var) https://github.com/bitcoin/bitcoin/pull/20584
< bitcoin-git> [bitcoin] hebasto closed pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
< bitcoin-git> [bitcoin] hebasto opened pull request #20586: Fix Windows build with --enable-werror (master...201206-win) https://github.com/bitcoin/bitcoin/pull/20586