<meshcollider>
kalle: I think block privs require being a github repo admin, which is the highest permission level. Not opposed to fanquake being added but it is definitely a bigger move so it'd have to be discussed at the meeting I guess (plus the more people with those permissions the greater the "attack surface").
vasild has quit [Ping timeout: 244 seconds]
vasild has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
vysn has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
Guest18 has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
vnogueira has quit [Remote host closed the connection]
prayank has joined #bitcoin-core-dev
vnogueira has joined #bitcoin-core-dev
<prayank>
re: wallet files should not be used across chains
<prayank>
If yes, would review and test this ASAP. Request other wallet devs to review as well and get this merged.
<prayank>
Reason: This can result in some weird vulnerabilities if not managed properly and things aren't kept separate
<vasild>
Is anybody working on fixing the addrman/asmap order issue reported above? I guess this would fix it: https://bpa.st/7TLQ (a possible quick fix, would not improve the quality of the code like making it impossible to wrong-do in the future).
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jnewbery>
vasild: I don't think that diff would work. Addrman needs to be constructed before connman.
<jnewbery>
I'll open a fix PR this morning
<vasild>
node.addrman = std::make_unique... is not moved
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22788: scripted-diff: Use generate* from TestFramework (master...2108-testGenDiff) https://github.com/bitcoin/bitcoin/pull/22788
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<vasild>
i.e. addrman is constructed before connman
<vasild>
but anyway, if you will fix it properly (e.g. make asmap argument to addrman constructor), poke me for review :)
<jnewbery>
ah, ok. Yes, I think that'd do it then, but I think it'd be preferable to collect all of the addrman initialization code together in one place.
<vasild>
I wonder if it would be better to pass `std::vector<bool> asmap` to the addrman ctor and read it before calling the ctor with the static CAddrMan::DecodeAsmap() or to pass fs::path asmap_path to the ctor.
<vasild>
std::optional<fs::path>
<vasild>
I guess also CConnman::SetAsmap() can be removed
<jnewbery>
vasild: I was planning on making `std::vector<bool>* asmap` the argument
<jnewbery>
indeed - remove CConnman::SetAsmap()
<jnewbery>
and potentially make m_asmap private
<vasild>
+1, maybe a getter method would be required
<vasild>
std::vector<bool> asmap = CAddrMan::DecodeAsmap(path); CAddrMan addrman(asmap); // this pattern looks a bit strange
<vasild>
CAddrMan addrman(asmap_path); // and call DecodeAsmap() inside the ctor looks more straight-forward to me
<jnewbery>
vasild: I agree. DecodeAsmap() does not need to be a static member function on CAddrMan at all. In fact, I don't think asmap belongs inside CAddrMan, but it's a bigger job to extract it
<vasild>
DecodeAsmap() can be non-static private method, only called from the ctor. But anyway, I guess it can be improved in different ways :)
janb has quit [Ping timeout: 240 seconds]
Henrik has quit [Ping timeout: 250 seconds]
yanmaani has quit [Ping timeout: 244 seconds]
Bullit has quit [Read error: Connection reset by peer]
yanmaani has joined #bitcoin-core-dev
Bullit has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 244 seconds]
pigeons has quit [Ping timeout: 240 seconds]
yanmaani has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 244 seconds]
yanmaani has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #22789: external_signer: improve fingerprint matching logic (stop on first match) (master...202108-external_signer-improve_fingerprint_matching) https://github.com/bitcoin/bitcoin/pull/22789
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Zero-1729 opened pull request #22790: test: add aarch64-apple-darwin platform entry to get_previous_releases (master...add-aarch64-apple-darwin-get-prev-releases) https://github.com/bitcoin/bitcoin/pull/22790
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<S3RK>
folks are using wallet RPC remotely over hidden Tor service
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #22793: Simplify BaseSignatureChecker virtual functions and GenericTransactionSignatureChecker constructors (master...refactor-sig-checker) https://github.com/bitcoin/bitcoin/pull/22793
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<sipa>
S3RK: i think that's fine if it's only exposed to trusted clients
JackH has quit [Ping timeout: 248 seconds]
<S3RK>
would you call it a supported use case? Should we add more method params to deal with the latency?
yanmaani has quit [Ping timeout: 244 seconds]
ExEric3 has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
moneyball_ has quit []
moneyball_ has joined #bitcoin-core-dev
RubenSomsen has quit []
RubenSomsen has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
S3RK: In PR #22775 I don't think latency really is a good enough reason to make changes. However, this would make listtransactions RPC easier to use. I have answered few related questions on Stackexchange and GitHub, some users are not sure how this works and TBH it's a kind of puzzle. Also if a change reduces number of calls it's always good.
<gribble>
https://github.com/bitcoin/bitcoin/issues/22775 | rpc: Add option to list transactions from oldest to newest in `listtransactions` RPC command by ben-kaufman · Pull Request #22775 · bitcoin/bitcoin · GitHub
jespada has quit [Ping timeout: 252 seconds]
ajonas has quit []
ajonas has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
<S3RK>
prayank: it depens on how we define the purpose/users for the RPC. Based on my understanding, RPC interface is an API for machines and is not intended for the end users. If users are still confused the fix should have GUI-first approach and only modify RPCs if necessary
<S3RK>
to be clear, I'm more interested in understanding our philosophy on designing RPC API and whether my understanding is correct, rather this specific example
<prayank>
RPC can be used by devs or power users in CLI, POST requests, code etc. Consider an example in which you want to list last 10 transactions from wallet, machine will run RPC but you have to write what are the arguments for it.
<prayank>
Maybe Copilot or some other tools have suggestions but eventually humans write code that machines run
<S3RK>
in my mind CLI and RPC are very much different things. CLI is a user-facing interface and RPC is a machine API. Those two things should have different design philosophies
<S3RK>
but in bitcoin-core CLI is just a thin proxy. Which begs the question whether it's a serious user-facing interface or not
hex17or has quit [Ping timeout: 244 seconds]
hex17or has joined #bitcoin-core-dev
<Bullit>
listtransactions causes me to open blockchain.info to retrieve via shared mutual .info handshake the adresses of inferior bech58 or bech3X
lightlike has quit [Quit: Leaving]
belcher has quit [Read error: Connection reset by peer]
belcher has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
yanmaani has quit [Ping timeout: 244 seconds]
yanmaani has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] lsilva01 opened pull request #22794: test: Split rpc_invalid_address_message test into two (master...split_invalid_address_message_test) https://github.com/bitcoin/bitcoin/pull/22794
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest54 has joined #bitcoin-core-dev
Ananta-shesha has quit [Remote host closed the connection]
Guest54 has quit [Client Quit]
instagibbs has quit [Quit: Leaving]
prayank has quit [Ping timeout: 250 seconds]
Ananta-shesha has joined #bitcoin-core-dev
hex17or has quit [Ping timeout: 244 seconds]
instagibbs has joined #bitcoin-core-dev
hex17or has joined #bitcoin-core-dev
<Bullit>
recall listtransactions as a command from japan and return 8.533fractal bitcoin to 3KWmEuAXy8HauiZRhUJLVdn4eFKvoGCtap split Recall Protocol Controller invalid adress
bitdex has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
vysn has quit [Ping timeout: 250 seconds]
VzxPLnHqr has joined #bitcoin-core-dev
davterra has quit [Read error: Connection reset by peer]
davterra has joined #bitcoin-core-dev
hex17or has quit [Ping timeout: 244 seconds]
midnight has joined #bitcoin-core-dev
<midnight>
Hello. Where are the gitian signers typically storing their pgp keys these days? Is there a keyserver you're uploading to..?