#bitcoin-core-dev on 2021-08-11 — searchable irc log

00:05 grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

00:10 jarthur has quit [Ping timeout: 272 seconds]

00:13 sipsorcery has quit [Ping timeout: 272 seconds]

00:15 b10c has quit [Quit: Connection closed for inactivity]

00:16 jarthur has joined #bitcoin-core-dev

01:01 AaronvanW has quit [Remote host closed the connection]

01:11 AaronvanW has joined #bitcoin-core-dev

01:14 grettke has joined #bitcoin-core-dev

01:15 AaronvanW has quit [Ping timeout: 268 seconds]

01:18 bitcoin-git has joined #bitcoin-core-dev

01:18 <bitcoin-git> [gui] ljkt7334 opened pull request #402: Create codeql-analysis.yml (master...master) https://github.com/bitcoin-core/gui/pull/402

01:18 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:19 bitcoin-git has joined #bitcoin-core-dev

01:19 <bitcoin-git> [gui] fanquake closed pull request #402: Create codeql-analysis.yml (master...master) https://github.com/bitcoin-core/gui/pull/402

01:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:20 AaronvanW has joined #bitcoin-core-dev

01:24 grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

01:24 AaronvanW has quit [Ping timeout: 248 seconds]

01:29 AaronvanW has joined #bitcoin-core-dev

01:33 AaronvanW has quit [Ping timeout: 258 seconds]

01:38 AaronvanW has joined #bitcoin-core-dev

01:43 warren_ is now known as warren

01:44 earnestly has quit [Ping timeout: 248 seconds]

01:54 AaronvanW has quit [Ping timeout: 268 seconds]

01:54 bitcoin-git has joined #bitcoin-core-dev

01:54 <bitcoin-git> [bitcoin] achow101 opened pull request #22680: guix: make git tag and commit known prior to building (master...guix-use-tag) https://github.com/bitcoin/bitcoin/pull/22680

01:54 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:57 bitcoin-git has joined #bitcoin-core-dev

01:57 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0b5344b0d187...c3545a739678

01:57 <bitcoin-git> bitcoin/master 6a5ccd6 Hennadii Stepanov: scripted-diff: Rename JoinErrors in more general MakeUnorderedList

01:57 <bitcoin-git> bitcoin/master 77a90f0 Hennadii Stepanov: refactor: Move MakeUnorderedList into util/string.h to make it reusable

01:57 <bitcoin-git> bitcoin/master bb56486 Hennadii Stepanov: refactor: Reuse MakeUnorderedList where possible

01:57 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:57 bitcoin-git has joined #bitcoin-core-dev

01:57 <bitcoin-git> [bitcoin] fanquake merged pull request #22653: refactor: Rename JoinErrors and re-use it (master...210806-err) https://github.com/bitcoin/bitcoin/pull/22653

01:57 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

02:00 bitcoin-git has joined #bitcoin-core-dev

02:00 <bitcoin-git> [bitcoin] fanquake closed pull request #22625: guix: Build out of source tree (master...210804-tag) https://github.com/bitcoin/bitcoin/pull/22625

02:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

02:03 jarthur has quit [Ping timeout: 258 seconds]

02:04 jarthur has joined #bitcoin-core-dev

02:06 AaronvanW has joined #bitcoin-core-dev

02:15 bitcoin-git has joined #bitcoin-core-dev

02:15 <bitcoin-git> [bitcoin] fanquake closed pull request #18818: Fix release tarball generated by gitian (master...fix_gitian_src_202004) https://github.com/bitcoin/bitcoin/pull/18818

02:15 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

02:41 AaronvanW has quit [Ping timeout: 272 seconds]

02:55 AaronvanW has joined #bitcoin-core-dev

02:59 bitdex has joined #bitcoin-core-dev

03:24 yanmaani has joined #bitcoin-core-dev

03:28 AaronvanW has quit [Ping timeout: 258 seconds]

03:43 AaronvanW has joined #bitcoin-core-dev

03:55 bitcoin-git has joined #bitcoin-core-dev

03:55 <bitcoin-git> [bitcoin] fanquake closed pull request #22664: docs: fix typo spelling grammar (master...docs-fixing) https://github.com/bitcoin/bitcoin/pull/22664

03:55 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:05 Guest12 has joined #bitcoin-core-dev

04:06 Guest12 has quit [Client Quit]

04:07 Guest66 has joined #bitcoin-core-dev

04:07 <Guest66> when is the next meeting?

04:08 Guest66 has quit [Client Quit]

04:16 AaronvanW has quit [Ping timeout: 258 seconds]

04:22 AaronvanW has joined #bitcoin-core-dev

04:27 AaronvanW has quit [Ping timeout: 272 seconds]

04:31 AaronvanW has joined #bitcoin-core-dev

04:40 belcher_ has joined #bitcoin-core-dev

04:45 belcher has quit [Ping timeout: 272 seconds]

04:54 babasancheti has joined #bitcoin-core-dev

05:05 AaronvanW has quit [Ping timeout: 272 seconds]

05:19 AaronvanW has joined #bitcoin-core-dev

05:47 commmon has quit [Read error: Connection reset by peer]

05:52 AaronvanW has quit [Ping timeout: 248 seconds]

05:58 AaronvanW has joined #bitcoin-core-dev

06:03 AaronvanW has quit [Ping timeout: 258 seconds]

06:07 AaronvanW has joined #bitcoin-core-dev

06:19 jarthur has quit [Quit: jarthur]

06:37 belcher_ is now known as belcher

06:41 AaronvanW has quit [Ping timeout: 268 seconds]

06:50 Guyver2 has joined #bitcoin-core-dev

06:54 vysn has joined #bitcoin-core-dev

06:55 jarthur has joined #bitcoin-core-dev

06:56 AaronvanW has joined #bitcoin-core-dev

07:01 jarthur has quit [Ping timeout: 268 seconds]

07:09 Talkless has joined #bitcoin-core-dev

07:20 bomb-on has joined #bitcoin-core-dev

07:30 AaronvanW has quit [Ping timeout: 268 seconds]

07:37 hex17or has quit [Ping timeout: 244 seconds]

07:39 hex17or has joined #bitcoin-core-dev

07:43 AaronvanW has joined #bitcoin-core-dev

07:50 bomb-on has quit [Quit: aллилѹіа!]

07:58 sipsorcery has joined #bitcoin-core-dev

08:03 earnestly has joined #bitcoin-core-dev

08:18 AaronvanW has quit [Ping timeout: 248 seconds]

08:32 AaronvanW has joined #bitcoin-core-dev

08:46 sipsorcery has quit [Ping timeout: 268 seconds]

08:49 sipsorcery has joined #bitcoin-core-dev

08:54 <jnewbery> roasbeef: > since the "new" protocol essentially uses the space between version and verack for interactive protocol feature negotiation instead of service bits

08:54 <jnewbery> My mental model is that service bits are for permanent attributes of the node. They communicate what services the node is capable of providing (historic blocks, segwit serialized blocks & txs, compact block filters, etc), and that service support is gossipped around the network in addrs.

08:54 <jnewbery> That allows nodes that require specific services to find peers that support those services.

08:55 <jnewbery> Feature negotiation using individual messages like sendcmpct, wtxidrelay, sendaddrv2, etc are for features for that specific connection. It's perfectly fine for a node to negotiate those features on some of its connections and not on others.

08:55 <jnewbery> If you need to support addrv2 and not wtxidrelay, it's safe to use p2p protocol version 70016 and just not send `wtxidrelay` during the version handshake. The peer will see that you don't support wtxidrelay and won't inv txs to you using wtxid.

09:05 AaronvanW has quit [Ping timeout: 248 seconds]

09:11 AaronvanW has joined #bitcoin-core-dev

09:15 AaronvanW has quit [Ping timeout: 268 seconds]

09:20 AaronvanW has joined #bitcoin-core-dev

09:20 b10c has joined #bitcoin-core-dev

09:39 RDK has joined #bitcoin-core-dev

09:54 AaronvanW has quit [Ping timeout: 272 seconds]

10:07 AaronvanW has joined #bitcoin-core-dev

10:14 lkqwejhhgasdjhgn has joined #bitcoin-core-dev

10:17 RDK has quit [Quit: Leaving]

10:24 SpellChecker has joined #bitcoin-core-dev

10:26 bomb-on has joined #bitcoin-core-dev

10:41 AaronvanW has quit [Ping timeout: 248 seconds]

10:47 AaronvanW has joined #bitcoin-core-dev

10:52 AaronvanW has quit [Ping timeout: 268 seconds]

10:56 AaronvanW has joined #bitcoin-core-dev

11:21 babasancheti has quit [Quit: Client closed]

11:25 bitcoin-git has joined #bitcoin-core-dev

11:25 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/4b523c8f0a72...89d148c8c65b

11:25 <bitcoin-git> bitcoin/0.21 e94e433 W. J. van der Laan: doc: Update manual pages for 0.21.2

11:25 <bitcoin-git> bitcoin/0.21 bf672ce W. J. van der Laan: build: Bump version to 0.21.2rc1

11:25 <bitcoin-git> bitcoin/0.21 89d148c W. J. van der Laan: qt: Translations update for 0.21.2rc1

11:25 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:29 AaronvanW has quit [Ping timeout: 258 seconds]

11:44 bitcoin-git has joined #bitcoin-core-dev

11:44 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 22.x: https://github.com/bitcoin/bitcoin/compare/873fbc745d03...d3bd5410f64e

11:44 <bitcoin-git> bitcoin/22.x d3bd541 W. J. van der Laan: doc: Manual pages update for 22.0rc2

11:44 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:44 AaronvanW has joined #bitcoin-core-dev

11:45 bitdex has quit [Quit: = ""]

11:49 Zenton has quit [Remote host closed the connection]

11:54 sipsorcery has quit [Remote host closed the connection]

11:54 sipsorcery has joined #bitcoin-core-dev

12:17 AaronvanW has quit [Ping timeout: 248 seconds]

12:19 common has joined #bitcoin-core-dev

12:36 AaronvanW has joined #bitcoin-core-dev

12:58 vnogueir- has joined #bitcoin-core-dev

13:00 vnogueira has quit [Ping timeout: 244 seconds]

13:05 AaronvanW has quit [Ping timeout: 258 seconds]

13:06 <Talkless> what does "Code review ACK" mean, how it's different.. from others? :)

13:07 <hebasto> Talkless: reviewed only, not actually tested

13:07 <Talkless> hebasto: so same as utACK ?

13:07 <Talkless> or is there still difference?

13:07 <hebasto> yes, but `utACK` is kind of undocumented

13:08 <sipa_> and it may mean "i haven't thought if this is a good idea, but the code changes look fine"

13:08 <hebasto> also https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review

13:11 AaronvanW has joined #bitcoin-core-dev

13:12 <sipa_> i interpret crACK as an utACK without concept/approach ACK

13:14 jonatack has quit [Quit: Client closed]

13:16 AaronvanW has quit [Ping timeout: 268 seconds]

13:17 <jnewbery> sipa_: oh interesting, I'd just started using it instead of utACK (since it seems more precise)

13:18 <hebasto> jnewbery: agree, crACK seems more precise and looks fancy

13:20 AaronvanW has joined #bitcoin-core-dev

13:20 <sipa_> no reason why you can't write a while sentence to elaborate on exactly what you did

13:20 <sipa_> *whole

13:22 bitcoin-git has joined #bitcoin-core-dev

13:22 <bitcoin-git> [gui] hebasto merged pull request #354: Refactor open date range to use std::optional (master...2021-06-date-range) https://github.com/bitcoin-core/gui/pull/354

13:22 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:22 bitcoin-git has joined #bitcoin-core-dev

13:22 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3545a739678...3d9cdb16897b

13:22 <bitcoin-git> bitcoin/master 4830f49 João Barbosa: qt: Refactor open date range to use std::optional

13:22 <bitcoin-git> bitcoin/master 3d9cdb1 Hennadii Stepanov: Merge bitcoin-core/gui#354: Refactor open date range to use std::optional

13:22 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:31 <Talkless> hebasto: Code review ACK is alos not docummented..? :/

13:31 jonatack has joined #bitcoin-core-dev

13:31 <laanwj> "code review ACK" for me is "i've looked at the code changes and they look good to me, no comments, no critical conceptual issues, have run the auto-tests locally but not done any specific testing" (by far my most common kind of ACK)

13:34 <Talkless> laanwj: and utACK ?

13:35 <laanwj> i try to never use that

13:35 <laanwj> it's just too aspecific

13:38 <laanwj> i do "tested ACK" (which means I did some specific testing of the feature or change, and generally code review too, unless mentioned otherwise), "concept ACK" (didn't look at the code but the described concept sounds good, I do not include a commit id with this), "concept and code review ACK" sometimes (I especially like the concept and also reviewed the code)

13:39 <Talkless> OK so I'll not gonna use utACK

13:44 <jonatack> i guess part of the job of maintaining is evaluating what different people mean with their ACKs :)

13:45 <hebasto> the simplest way is just to follow our own dev docs

13:48 <jonatack> ("code review ACK" isn't described in CONTRIBUTING.md, much less "crACK" ;)

13:50 yanmaani has quit [Ping timeout: 244 seconds]

13:54 AaronvanW has quit [Ping timeout: 248 seconds]

13:56 vysn has quit [Ping timeout: 258 seconds]

13:56 bitcoin-git has joined #bitcoin-core-dev

13:56 <bitcoin-git> [gui] hebasto merged pull request #317: Add Direction column to Peers Tab (master...direction-col-peers) https://github.com/bitcoin-core/gui/pull/317

13:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:56 bitcoin-git has joined #bitcoin-core-dev

13:56 <bitcoin-git> bitcoin/master 6971e79 Jon Atack: gui: add Direction column to peers tab

13:56 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d9cdb16897b...77e23ca94503

13:56 <bitcoin-git> bitcoin/master 77e23ca Hennadii Stepanov: Merge bitcoin-core/gui#317: Add Direction column to Peers Tab

13:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:59 AaronvanW has joined #bitcoin-core-dev

13:59 <jonatack> oh, nice to see this cleared up ^ thank you jarolrod for picking it up

14:00 bitcoin-git has joined #bitcoin-core-dev

14:00 <bitcoin-git> [gui] hebasto closed pull request #372: Remove "Type" column from peers window (master...remove-peers-type-column) https://github.com/bitcoin-core/gui/pull/372

14:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:00 <jonatack> ty hebasto

14:00 <hebasto> thanks to jonatack and jarolrod

14:02 bitcoin-git has joined #bitcoin-core-dev

14:02 <bitcoin-git> [gui] hebasto closed pull request #400: Honor inbound/outbound arrow prefix when sorting peer address column (master...address_prefix_sort) https://github.com/bitcoin-core/gui/pull/400

14:02 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:04 vnogueir- is now known as vnogueira

14:04 AaronvanW has quit [Ping timeout: 268 seconds]

14:07 yanmaani has joined #bitcoin-core-dev

14:08 AaronvanW has joined #bitcoin-core-dev

14:22 grettke has joined #bitcoin-core-dev

14:23 vasild has quit [Ping timeout: 244 seconds]

14:46 gleb has quit [Ping timeout: 272 seconds]

14:47 <Talkless> jonatack: eyah, reviewing docs could be better...

14:48 vasild has joined #bitcoin-core-dev

15:28 AaronvanW has quit [Ping timeout: 268 seconds]

15:32 gleb7 has joined #bitcoin-core-dev

15:35 muhblockchain has joined #bitcoin-core-dev

15:42 AaronvanW has joined #bitcoin-core-dev

15:48 lightlike has joined #bitcoin-core-dev

16:01 VzxPLnHqr has joined #bitcoin-core-dev

16:05 grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

16:10 grettke has joined #bitcoin-core-dev

16:15 AaronvanW has quit [Ping timeout: 245 seconds]

16:21 <achow101> laanwj: are we doing 0.21.2rc1 soon?

16:23 jarthur has joined #bitcoin-core-dev

16:23 Naiza has joined #bitcoin-core-dev

16:24 lkqwejhhgasdjhgn has quit [Quit: Konversation terminated!]

16:33 AaronvanW has joined #bitcoin-core-dev

16:38 sipsorcery has quit [Ping timeout: 268 seconds]

16:42 lightlike has left #bitcoin-core-dev [Leaving]

16:45 sipsorcery has joined #bitcoin-core-dev

16:50 vasild has quit [Ping timeout: 244 seconds]

16:56 raj has joined #bitcoin-core-dev

17:01 kuler has joined #bitcoin-core-dev

17:03 AaronvanW has quit [Ping timeout: 268 seconds]

17:10 vasild has joined #bitcoin-core-dev

17:13 AaronvanW has joined #bitcoin-core-dev

17:15 <Talkless> laanwj: about "Tested ACK" means only that you tested GUI for expected behaviour, but did not ran any unit/functional tests..? Here's also ambiguity :/

17:17 <sipa_> really, if you feel there is ambiguity, write a sentence that describes what you did

17:28 ghost43 has joined #bitcoin-core-dev

17:32 bitcoin-git has joined #bitcoin-core-dev

17:32 <bitcoin-git> [gui] hebasto opened pull request #403: refactor: Make paths to update Encryption and HD wallet statuses simpler (master...210811-hd) https://github.com/bitcoin-core/gui/pull/403

17:32 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:34 Aaronvan_ has joined #bitcoin-core-dev

17:35 AaronvanW has quit [Read error: Connection reset by peer]

17:45 Jackielove4u has quit [Quit: Connection closed for inactivity]

17:51 SpellChecker has quit [Quit: bye]

17:54 SpellChecker has joined #bitcoin-core-dev

18:01 raj has quit [Quit: Leaving]

18:04 sipsorcery has quit [Ping timeout: 272 seconds]

18:08 janb has joined #bitcoin-core-dev

18:17 Naiza has quit [Quit: Connection closed]

18:17 VzxPLnHqr has quit [Remote host closed the connection]

18:22 Jackielove4u has joined #bitcoin-core-dev

18:24 lightlike has joined #bitcoin-core-dev

18:38 bitcoin-git has joined #bitcoin-core-dev

18:38 <bitcoin-git> [bitcoin] theStack opened pull request #22684: test: check for invalid `-prune` parameters (master...202108-test-check_invalid_prune_parameters) https://github.com/bitcoin/bitcoin/pull/22684

18:38 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

18:54 Aaronvan_ has quit [Remote host closed the connection]

18:54 AaronvanW has joined #bitcoin-core-dev

18:59 AaronvanW has quit [Ping timeout: 252 seconds]

19:03 AaronvanW has joined #bitcoin-core-dev

19:04 SpellChecker has quit [Remote host closed the connection]

19:06 yanmaani has quit [Ping timeout: 244 seconds]

19:07 SpellChecker has joined #bitcoin-core-dev

19:08 AaronvanW has quit [Ping timeout: 272 seconds]

19:12 AaronvanW has joined #bitcoin-core-dev

19:17 AaronvanW has quit [Ping timeout: 256 seconds]

19:21 AaronvanW has joined #bitcoin-core-dev

19:25 AaronvanW has quit [Ping timeout: 248 seconds]

19:29 yanmaani has joined #bitcoin-core-dev

19:30 bitcoin-git has joined #bitcoin-core-dev

19:30 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77e23ca94503...e614cc8cd808

19:30 <bitcoin-git> bitcoin/master 0237d95 Prateek Sancheti: qt: Add Load PSBT functionaliy with nowallet

19:30 <bitcoin-git> bitcoin/master e614cc8 Hennadii Stepanov: Merge bitcoin-core/gui#399: Fix "Load PSBT" functionality when no wallet l...

19:30 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:30 AaronvanW has joined #bitcoin-core-dev

19:30 bitcoin-git has joined #bitcoin-core-dev

19:30 <bitcoin-git> [gui] hebasto merged pull request #399: Fix "Load PSBT" functionality when no wallet loaded (master...i232-0806) https://github.com/bitcoin-core/gui/pull/399

19:30 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:32 babasancheti has joined #bitcoin-core-dev

19:35 babasancheti has quit [Client Quit]

19:45 AaronvanW has quit [Ping timeout: 245 seconds]

19:49 sipsorcery has joined #bitcoin-core-dev

19:58 AaronvanW has joined #bitcoin-core-dev

20:10 vasild has quit [Ping timeout: 244 seconds]

20:15 meshcollider has quit [Remote host closed the connection]

20:17 vasild has joined #bitcoin-core-dev

20:21 Guyver2_ has joined #bitcoin-core-dev

20:24 Guyver2 has quit [Ping timeout: 248 seconds]

20:24 Guyver2_ is now known as Guyver2

20:28 vysn has joined #bitcoin-core-dev

20:32 AaronvanW has quit [Ping timeout: 268 seconds]

20:33 mdrollette has joined #bitcoin-core-dev

20:36 meshcollider has joined #bitcoin-core-dev

20:37 AaronvanW has joined #bitcoin-core-dev

20:41 sipa_ is now known as sipa

20:42 AaronvanW has quit [Ping timeout: 248 seconds]

20:46 bitcoin-git has joined #bitcoin-core-dev

20:46 <bitcoin-git> [bitcoin] dongcarl opened pull request #22685: clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE (master...2021-08-clientversion-is-cursed) https://github.com/bitcoin/bitcoin/pull/22685

20:46 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

20:46 AaronvanW has joined #bitcoin-core-dev

20:53 Guest71 has joined #bitcoin-core-dev

20:54 Guest71 has quit [Client Quit]

21:00 bitcoin-git has joined #bitcoin-core-dev

21:00 <bitcoin-git> [bitcoin] achow101 closed pull request #22680: guix: make git tag and commit known prior to building (master...guix-use-tag) https://github.com/bitcoin/bitcoin/pull/22680

21:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

21:05 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

21:20 AaronvanW has quit [Ping timeout: 252 seconds]

21:21 Lightsword has quit [Quit: ZNC]

21:26 AaronvanW has joined #bitcoin-core-dev

21:30 AaronvanW has quit [Ping timeout: 268 seconds]

21:35 AaronvanW has joined #bitcoin-core-dev

21:55 vnogueir- has joined #bitcoin-core-dev

21:56 vnogueira has quit [Remote host closed the connection]

21:58 Talkless has quit [Quit: Konversation terminated!]

21:58 Lightsword has joined #bitcoin-core-dev

22:01 AaronvanW has quit [Remote host closed the connection]

22:23 SpellChecker has quit [Remote host closed the connection]

22:26 SpellChecker has joined #bitcoin-core-dev

22:29 Ananta-shesha has quit [Ping timeout: 256 seconds]

22:31 Ananta-shesha has joined #bitcoin-core-dev

22:48 hex17or has quit [Ping timeout: 244 seconds]

22:51 hex17or has joined #bitcoin-core-dev

22:55 hex17or has quit [Remote host closed the connection]

22:56 hex17or has joined #bitcoin-core-dev

22:58 sipsorcery has quit [Remote host closed the connection]

22:58 sipsorcery has joined #bitcoin-core-dev

22:59 lightlike has quit [Quit: Leaving]

23:03 <fanquake> achow101: yes

23:08 meshcollider has quit [Changing host]

23:08 meshcollider has joined #bitcoin-core-dev

23:15 vnogueir- has quit [Remote host closed the connection]

23:16 vnogueira has joined #bitcoin-core-dev

23:17 sipsorcery has quit [Ping timeout: 245 seconds]

23:18 sipsorcery has joined #bitcoin-core-dev

23:21 nanotube has quit [Ping timeout: 248 seconds]

23:29 bitcoin-git has joined #bitcoin-core-dev

23:29 <bitcoin-git> [gui] hebasto merged pull request #390: Add SubFeeFromAmount to options (master...i386_0729) https://github.com/bitcoin-core/gui/pull/390

23:29 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

23:29 bitcoin-git has joined #bitcoin-core-dev

23:29 <bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e614cc8cd808...9948f114f8e6

23:29 <bitcoin-git> bitcoin/master ad28b66 Prateek Sancheti: qt: Add SubFeeFromAmount option

23:29 <bitcoin-git> bitcoin/master 62b125f Prateek Sancheti: qt, refactor: Fix indentation

23:29 <bitcoin-git> bitcoin/master 9948f11 Hennadii Stepanov: Merge bitcoin-core/gui#390: Add SubFeeFromAmount to options

23:29 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

23:35 nanotube has joined #bitcoin-core-dev

23:49 bomb-on has quit [Quit: aллилѹіа!]

23:53 bitdex has joined #bitcoin-core-dev