#bitcoin-core-dev on 2023-06-01 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:00 b_101 has joined #bitcoin-core-dev

00:08 brunoerg has joined #bitcoin-core-dev

00:10 b_101_ has joined #bitcoin-core-dev

00:11 b_101 has quit [Ping timeout: 265 seconds]

00:13 brunoerg has quit [Ping timeout: 265 seconds]

00:16 b_101_ has quit [Ping timeout: 256 seconds]

00:17 b_101 has joined #bitcoin-core-dev

00:31 brunoerg has joined #bitcoin-core-dev

00:33 abubakarsadiq has quit [Quit: Connection closed for inactivity]

00:36 brunoerg has quit [Ping timeout: 250 seconds]

01:07 brunoerg has joined #bitcoin-core-dev

01:08 vysn has quit [Remote host closed the connection]

01:12 brunoerg has quit [Ping timeout: 250 seconds]

01:24 brunoerg has joined #bitcoin-core-dev

01:40 brunoerg has quit [Ping timeout: 265 seconds]

01:49 brunoerg has joined #bitcoin-core-dev

01:53 brunoerg has quit [Ping timeout: 246 seconds]

01:59 b_101 has quit [Ping timeout: 256 seconds]

02:00 b_101 has joined #bitcoin-core-dev

02:06 brunoerg has joined #bitcoin-core-dev

02:11 brunoerg has quit [Ping timeout: 265 seconds]

02:22 _aj_ has quit [Ping timeout: 256 seconds]

02:23 _aj_ has joined #bitcoin-core-dev

02:34 brunoerg has joined #bitcoin-core-dev

02:39 brunoerg has quit [Ping timeout: 250 seconds]

02:48 test__ has joined #bitcoin-core-dev

02:48 jarthur has quit [Quit: jarthur]

02:51 jakob[m] has joined #bitcoin-core-dev

02:51 flooded has quit [Ping timeout: 240 seconds]

02:56 brunoerg has joined #bitcoin-core-dev

03:01 brunoerg has quit [Ping timeout: 250 seconds]

03:12 hernanmarino has quit [Ping timeout: 250 seconds]

03:19 brunoerg has joined #bitcoin-core-dev

03:24 brunoerg has quit [Ping timeout: 265 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:01 realies has quit [Quit: ~]

04:04 realies has joined #bitcoin-core-dev

04:08 brunoerg has joined #bitcoin-core-dev

04:13 brunoerg has quit [Ping timeout: 265 seconds]

04:22 Guest27 has joined #bitcoin-core-dev

04:24 Guest27 has quit [Client Quit]

04:24 debby has joined #bitcoin-core-dev

04:26 qxs has quit [Ping timeout: 240 seconds]

04:28 qxs has joined #bitcoin-core-dev

04:37 debby has quit [Ping timeout: 245 seconds]

04:41 mxz has quit [Quit: cya]

04:42 brunoerg has joined #bitcoin-core-dev

04:46 mxz has joined #bitcoin-core-dev

04:47 brunoerg has quit [Ping timeout: 265 seconds]

05:00 brunoerg has joined #bitcoin-core-dev

05:02 PaperSword has quit [Quit: PaperSword]

05:05 brunoerg has quit [Ping timeout: 250 seconds]

05:06 b_101 has quit [Ping timeout: 240 seconds]

05:17 brunoerg has joined #bitcoin-core-dev

05:22 brunoerg has quit [Ping timeout: 265 seconds]

05:23 brunoerg has joined #bitcoin-core-dev

05:28 brunoerg has quit [Ping timeout: 246 seconds]

05:29 brunoerg has joined #bitcoin-core-dev

05:33 brunoerg has quit [Ping timeout: 265 seconds]

05:50 b_101 has joined #bitcoin-core-dev

05:51 brunoerg has joined #bitcoin-core-dev

05:54 b_101 has quit [Ping timeout: 240 seconds]

05:56 brunoerg has quit [Ping timeout: 250 seconds]

05:57 flooded has joined #bitcoin-core-dev

06:00 test__ has quit [Ping timeout: 250 seconds]

06:06 brunoerg has joined #bitcoin-core-dev

06:10 vysn has joined #bitcoin-core-dev

06:10 brunoerg has quit [Ping timeout: 248 seconds]

06:22 brunoerg has joined #bitcoin-core-dev

06:26 brunoerg has quit [Ping timeout: 240 seconds]

06:28 brunoerg has joined #bitcoin-core-dev

06:33 brunoerg has quit [Ping timeout: 250 seconds]

06:39 brunoerg has joined #bitcoin-core-dev

06:44 brunoerg has quit [Ping timeout: 250 seconds]

06:56 brunoerg has joined #bitcoin-core-dev

07:01 brunoerg has quit [Ping timeout: 256 seconds]

07:01 brunoerg has joined #bitcoin-core-dev

07:06 brunoerg has quit [Ping timeout: 265 seconds]

07:53 Guyver2 has joined #bitcoin-core-dev

08:21 brunoerg has joined #bitcoin-core-dev

08:28 AaronvanW has joined #bitcoin-core-dev

08:30 aielima has joined #bitcoin-core-dev

08:31 brunoerg has quit [Ping timeout: 265 seconds]

08:37 jespada has joined #bitcoin-core-dev

08:44 jespada has quit [Read error: Connection reset by peer]

08:44 brunoerg has joined #bitcoin-core-dev

08:49 jespada has joined #bitcoin-core-dev

08:53 brunoerg has quit [Ping timeout: 246 seconds]

09:06 test__ has joined #bitcoin-core-dev

09:08 brunoerg has joined #bitcoin-core-dev

09:10 flooded has quit [Ping timeout: 256 seconds]

09:13 brunoerg has quit [Ping timeout: 265 seconds]

09:19 <bitcoin-git> [bitcoin] fanquake closed pull request #27797: rpc, net: add erlay status in `getpeerinfo` (master...2023-05-erlay-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/27797

09:35 brunoerg has joined #bitcoin-core-dev

09:42 brunoerg has quit [Ping timeout: 250 seconds]

09:46 brunoerg has joined #bitcoin-core-dev

09:47 Guyver2 has left #bitcoin-core-dev [Closing Window]

09:51 brunoerg has quit [Ping timeout: 240 seconds]

09:51 abubakarsadiq has joined #bitcoin-core-dev

10:14 brunoerg has joined #bitcoin-core-dev

10:16 salvatoshi has joined #bitcoin-core-dev

10:19 brunoerg has quit [Ping timeout: 265 seconds]

10:20 brunoerg has joined #bitcoin-core-dev

10:25 brunoerg has quit [Ping timeout: 248 seconds]

10:28 AaronvanW has quit [Remote host closed the connection]

10:29 PaperSword has joined #bitcoin-core-dev

11:00 AaronvanW has joined #bitcoin-core-dev

11:07 brunoerg has joined #bitcoin-core-dev

11:12 brunoerg has quit [Ping timeout: 250 seconds]

11:19 brunoerg has joined #bitcoin-core-dev

11:26 brunoerg has quit [Ping timeout: 265 seconds]

11:33 AaronvanW has quit [Ping timeout: 240 seconds]

11:37 brunoerg has joined #bitcoin-core-dev

11:41 brunoerg has quit [Ping timeout: 246 seconds]

11:48 brunoerg has joined #bitcoin-core-dev

11:52 brunoerg has quit [Ping timeout: 240 seconds]

12:04 brunoerg has joined #bitcoin-core-dev

12:11 preimage has joined #bitcoin-core-dev

12:13 brunoerg has quit [Ping timeout: 265 seconds]

12:14 micha_ has joined #bitcoin-core-dev

12:15 flooded has joined #bitcoin-core-dev

12:19 test__ has quit [Ping timeout: 248 seconds]

12:24 brunoerg has joined #bitcoin-core-dev

12:27 pablomartin has joined #bitcoin-core-dev

12:28 brunoerg has quit [Ping timeout: 248 seconds]

12:36 bitdex has quit [Quit: = ""]

12:42 Cory has joined #bitcoin-core-dev

12:42 Cory has quit [Changing host]

12:42 Cory has joined #bitcoin-core-dev

12:43 martinus has quit [Read error: Connection reset by peer]

12:43 martinus_ has joined #bitcoin-core-dev

12:49 brunoerg has joined #bitcoin-core-dev

12:54 brunoerg has quit [Ping timeout: 265 seconds]

13:03 b_101 has joined #bitcoin-core-dev

13:05 brunoerg has joined #bitcoin-core-dev

13:08 b_101 has quit [Ping timeout: 240 seconds]

13:10 brunoerg has quit [Ping timeout: 240 seconds]

13:21 AaronvanW has joined #bitcoin-core-dev

13:23 brunoerg has joined #bitcoin-core-dev

13:27 brunoerg has quit [Ping timeout: 250 seconds]

13:32 micha_ has quit [Changing host]

13:32 micha_ has joined #bitcoin-core-dev

13:33 micha_ has quit [Changing host]

13:33 micha_ has joined #bitcoin-core-dev

13:34 brunoerg has joined #bitcoin-core-dev

13:49 SpellChecker_ has joined #bitcoin-core-dev

13:49 aielima has quit [Ping timeout: 240 seconds]

13:49 SpellChecker has quit [Ping timeout: 240 seconds]

13:51 aielima has joined #bitcoin-core-dev

13:54 SebastianvStaa has joined #bitcoin-core-dev

13:57 SebastianvStaa has quit [Client Quit]

13:58 SebastianvStaa has joined #bitcoin-core-dev

14:01 <achow101> #startmeeting

14:01 <hebasto> hi

14:01 <kanzure> hi

14:01 <glozow> hi

14:01 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild

14:01 <stickies-v> hi

14:01 <brunoerg> hi

14:01 <pinheadmz> hello

14:01 <instagibbs> hi

14:01 <dergoegge> hi

14:02 <achow101> There are no pre-proposed meeting topics this week. Are there any last minute topics to add to the list?

14:02 <furszy> hi

14:02 <TheCharlatan> hi

14:02 <_aj_> hi

14:02 <sipa> hi

14:02 <achow101> #topic assumeutxo updates (jamesob)

14:03 <achow101> #24008 was closed, and from conversations in ##bitcoin-assumeutxo, it sounds like the main pr (#27596) is the focus now

14:03 <cfields> hi

14:03 <gribble`> https://github.com/bitcoin/bitcoin/issues/24008 | assumeutxo: net_processing changes by jamesob · Pull Request #24008 · bitcoin/bitcoin · GitHub

14:03 <gribble`> https://github.com/bitcoin/bitcoin/issues/27596 | assumeutxo (2) by jamesob · Pull Request #27596 · bitcoin/bitcoin · GitHub

14:03 <kouloumos> hi

14:04 <instagibbs> "I'm in the car" he says

14:05 <instagibbs> so last I heard, he's taking in sdaftuar's suggestions for the net processing piece

14:05 <darosior> hi

14:05 SebastianvStaa has quit [Quit: Client closed]

14:05 <achow101> #topic package relay updates (glozow)

14:06 <josie> hi

14:06 <glozow> #27742 CI is green! No reviews yet... anything I can do to help encourage reviews? Or answer any questions?

14:06 <gribble`> https://github.com/bitcoin/bitcoin/issues/27742 | [NO MERGE] BIP331 Ancestor Package Relay by glozow · Pull Request #27742 · bitcoin/bitcoin · GitHub

14:06 SebastianvStaa has joined #bitcoin-core-dev

14:06 <instagibbs> ##bitcoin-assumeutxo

14:06 <instagibbs> ^ where to discuss more often, he says

14:06 <instagibbs> fin

14:06 <willcl-ark> hi

14:06 <glozow> If people are looking for something easier to review, the BIP PR is updated and open for review: https://github.com/bitcoin/bips/pull/1382

14:07 <instagibbs> I've worked through the orphan handling piece, but all that code is relatively new to me

14:07 <achow101> glozow: #26711 is still the next step?

14:07 <gribble`> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub

14:07 <glozow> instagibbs: awesome, thanks so much!

14:07 <glozow> yes, #26711 is the mempool PR open for review

14:07 <instagibbs> I'm waiting for real PR to bother you with my suggestions, will go through it a couple more times once open

14:07 <gribble`> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub

14:08 <glozow> ok, i will assume approach is "ok" and open the first PR

14:08 <achow101> cool

14:08 <instagibbs> first set is just encapsulation of orphan handling, I think that's safe to open

14:08 <instagibbs> and has benefits already

14:09 <glozow> correct, I will open that

14:09 <glozow> was just hoping for like 1 comment or so 😅

14:09 <achow101> #topic libbitcoinkernel updates (TheCharlatan)

14:10 <achow101> seems like #27711 should be the next pr for libbitcoinkernel?

14:10 <gribble`> https://github.com/bitcoin/bitcoin/issues/27711 | kernel: Remove shutdown from kernel library by TheCharlatan · Pull Request #27711 · bitcoin/bitcoin · GitHub

14:10 <TheCharlatan> kernel PRs are progressing, the next two are now undrafted.

14:10 <TheCharlatan> The shutdown discussion is continued in #27711.

14:10 <gribble`> https://github.com/bitcoin/bitcoin/issues/27711 | kernel: Remove shutdown from kernel library by TheCharlatan · Pull Request #27711 · bitcoin/bitcoin · GitHub

14:10 <fanquake> 🚀

14:11 <TheCharlatan> PR #27576 that should finally get rid of the ArgsManager in kernel code.

14:11 <gribble`> https://github.com/bitcoin/bitcoin/issues/27576 | kernel: Remove args, settings, chainparams, chainparamsbase from kernel library by TheCharlatan · Pull Request #27576 · bitcoin/bitcoin · GitHub

14:11 <cfields> woohoo :)

14:11 <josie> TheCharlatan: nice!

14:11 <TheCharlatan> thank you reviewers :)

14:12 <achow101> #topic BIP 324 updates (sipa)

14:12 <sipa> Not much to report, I'm afraid.

14:13 <Murch> Hi

14:13 <achow101> still waiting for review on https://github.com/bitcoin-core/secp256k1/pull/1129?

14:13 <sipa> Indeed.

14:14 <achow101> #topic Ad-hoc high priority for review

14:14 <achow101> Anything to add/remove from https://github.com/orgs/bitcoin/projects/1/views/4?

14:15 <achow101> or are there any other topics to discuss this week?

14:15 <pinheadmz> #27101

14:15 <gribble`> https://github.com/bitcoin/bitcoin/issues/27101 | Support JSON-RPC 2.0 when requested by client by pinheadmz · Pull Request #27101 · bitcoin/bitcoin · GitHub

14:15 <pinheadmz> anyone else want JSON RPC 2.0 ?

14:16 <pinheadmz> not sand, not a big rock, more of a medium sized pebble. for the jar.

14:16 <achow101> added

14:18 <achow101> #endmeeting

14:22 bugs_ has joined #bitcoin-core-dev

14:24 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a83d4417b35...9e54dde04ccd

14:24 <bitcoin-git> bitcoin/master 6fce5dd Marnix: doc: update getnodeaddresses for CJDNS, I2P and Tor and rm link

14:24 <bitcoin-git> bitcoin/master 9e54dde fanquake: Merge bitcoin/bitcoin#27719: doc: remove Tor link & generalize onion getno...

14:24 <bitcoin-git> [bitcoin] fanquake merged pull request #27719: doc: remove Tor link & generalize onion getnodeaddresses RPC (master...doc-tor) https://github.com/bitcoin/bitcoin/pull/27719

14:26 SebastianvStaa has quit [Quit: Client closed]

14:32 <jamesob> thanks for covering for me instagibbs

14:39 <bitcoin-git> [bitcoin] ryanofsky opened pull request #27800: streams: Drop confusing DataStream::Serialize method and operator (master...pr/streamstream) https://github.com/bitcoin/bitcoin/pull/27800

14:50 tripleslash has quit [Ping timeout: 250 seconds]

15:09 abubakarsadiq has quit [Quit: Connection closed for inactivity]

15:35 abubakarsadiq has joined #bitcoin-core-dev

16:13 hernanmarino has joined #bitcoin-core-dev

16:17 MatrixBot123456 has quit [Quit: Bridge terminating on SIGTERM]

16:24 micha_ has quit [Quit: Connection closed for inactivity]

16:26 <bitcoin-git> [bitcoin] ryanofsky opened pull request #27801: wallet: Add tracing for sqlite statements (master...pr/sqtrace) https://github.com/bitcoin/bitcoin/pull/27801

16:54 brunoerg has quit [Read error: Connection reset by peer]

16:54 MatrixBot123456 has joined #bitcoin-core-dev

16:54 brunoerg has joined #bitcoin-core-dev

17:01 Talkless has joined #bitcoin-core-dev

17:38 vysn has quit [Remote host closed the connection]

17:42 pablomartin has quit [Ping timeout: 240 seconds]

18:06 <bitcoin-git> [bitcoin] theblackmace opened pull request #27802: Update .style.yapf (master...master) https://github.com/bitcoin/bitcoin/pull/27802

18:08 jarthur has joined #bitcoin-core-dev

18:14 puchka has quit [Ping timeout: 250 seconds]

18:16 puchka has joined #bitcoin-core-dev

18:16 b_101 has joined #bitcoin-core-dev

18:17 aielima has quit [Quit: Ciao]

18:21 b_101 has quit [Ping timeout: 240 seconds]

18:26 b_101 has joined #bitcoin-core-dev

18:31 preimage has quit [Ping timeout: 240 seconds]

18:32 b_101_ has joined #bitcoin-core-dev

18:33 b_101 has quit [Ping timeout: 248 seconds]

18:33 test_ has joined #bitcoin-core-dev

18:37 flooded has quit [Ping timeout: 246 seconds]

18:40 b_101 has joined #bitcoin-core-dev

18:41 b_101_ has quit [Ping timeout: 240 seconds]

19:21 Talkless has quit [Quit: Konversation terminated!]

19:32 <bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9e54dde04ccd...34ac3f438a26

19:32 <bitcoin-git> bitcoin/master 702b56d Ryan Ofsky: RPC: Add add OBJ_NAMED_PARAMS type

19:32 <bitcoin-git> bitcoin/master 9623314 Ryan Ofsky: RPC: Allow RPC methods accepting options to take named parameters

19:32 <bitcoin-git> bitcoin/master 95d7de0 Ryan Ofsky: test: Update python tests to use named parameters instead of options objec...

19:32 <bitcoin-git> [bitcoin] achow101 merged pull request #26485: RPC: Accept options as named-only parameters (master...pr/nonly) https://github.com/bitcoin/bitcoin/pull/26485

20:39 abubakarsadiq has quit [Quit: Connection closed for inactivity]

21:43 flooded has joined #bitcoin-core-dev

21:43 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/3116ccd790e7...a537cb0b8780

21:43 <bitcoin-git> bitcoin/24.x c2e9214 MarcoFalke: rpc: Fix invalid bech32 handling

21:43 <bitcoin-git> bitcoin/24.x a537cb0 Andrew Chow: Merge bitcoin/bitcoin#27755: [24.x] rpc: Fix invalid bech32 handling

21:43 <bitcoin-git> [bitcoin] achow101 merged pull request #27755: [24.x] rpc: Fix invalid bech32 handling (24.x...backport_27727_24_2) https://github.com/bitcoin/bitcoin/pull/27755

21:44 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/4d2f2fae9782...b7ded852bbf3

21:44 <bitcoin-git> bitcoin/23.x d987707 MarcoFalke: rpc: Fix invalid bech32 handling

21:44 <bitcoin-git> bitcoin/23.x b7ded85 Andrew Chow: Merge bitcoin/bitcoin#27756: [23.x] rpc: Fix invalid bech32 handling

21:44 <bitcoin-git> [bitcoin] achow101 merged pull request #27756: [23.x] rpc: Fix invalid bech32 handling (23.x...backport_27727_23_x) https://github.com/bitcoin/bitcoin/pull/27756

21:45 brunoerg has quit [Remote host closed the connection]

21:46 test_ has quit [Ping timeout: 250 seconds]

22:01 brunoerg has joined #bitcoin-core-dev

22:01 bugs_ has quit [Quit: Leaving]

22:06 <bitcoin-git> [bitcoin] Xekyo opened pull request #27803: [Fuzz/Bugfix] Mitigate timeout in CalculateTotalBumpFees (master...2023-06-miniminer-timeout) https://github.com/bitcoin/bitcoin/pull/27803

22:13 Guest84 has joined #bitcoin-core-dev

22:15 brunoerg has quit [Ping timeout: 250 seconds]

22:20 Guest84 has quit [Quit: Client closed]

22:27 Guest1 has joined #bitcoin-core-dev

22:29 Guest1 has quit [Client Quit]

22:30 Mohammed9090 has joined #bitcoin-core-dev

22:34 Mohammed9090 has quit [Client Quit]

22:36 b_101_ has joined #bitcoin-core-dev

22:37 b_101 has quit [Ping timeout: 268 seconds]

22:45 brunoerg has joined #bitcoin-core-dev

22:51 brunoerg has quit [Ping timeout: 265 seconds]

22:55 AaronvanW has quit [Remote host closed the connection]

22:59 preimage has joined #bitcoin-core-dev

23:06 b_101 has joined #bitcoin-core-dev

23:07 b_101_ has quit [Ping timeout: 240 seconds]

23:14 jespada has quit [Ping timeout: 250 seconds]

23:15 furszy has quit [Ping timeout: 250 seconds]

23:15 jrayhawk has quit [Ping timeout: 250 seconds]

23:15 vasild has quit [Ping timeout: 240 seconds]

23:15 furszy has joined #bitcoin-core-dev

23:15 furszy has quit [Changing host]

23:15 furszy has joined #bitcoin-core-dev

23:16 vasild has joined #bitcoin-core-dev

23:16 jrayhawk has joined #bitcoin-core-dev

23:18 jespada has joined #bitcoin-core-dev

23:27 AaronvanW has joined #bitcoin-core-dev

23:30 preimage has quit [Quit: WeeChat 3.8]

23:37 brunoerg has joined #bitcoin-core-dev

23:41 brunoerg has quit [Ping timeout: 246 seconds]