<josie>
is the plan to have the weekly IRC meeting at the regular time this Thursday (1900 UTC) and pick a new time based on the poll results for the meetings going forward?
<bitcoin-git>
[bitcoin] brunoerg opened pull request #27549: fuzz: addrman, add coverage for `network` field in `Select()` (master...2023-04-fuzz-addrman-select) https://github.com/bitcoin/bitcoin/pull/27549
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
bugs_ has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
dberkelmans has quit [Quit: Client closed]
<sdaftuar>
b10c: i can't speak on behalf of other reviewers but my view is that neither formulation is particular clearer than the other, so if it were me i'd just add a comment to help future code readers if i thought it was confusing.
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guest6681 has joined #bitcoin-core-dev
ddisqq has joined #bitcoin-core-dev
Guest6681 has quit [Client Quit]
test_ is now known as _flood
jon_atack has quit [Quit: WeeChat 3.8]
<sdaftuar>
jamesob6: thinking about the download logic for validating the chain to the base block hash in the ibd-chainstate.. is it the case that we might as well constrain ourselves to only downloading the blocks that are on the headers chain we're looking for, and only up to that base block?
<sdaftuar>
it looks like in #24008 that the logic you propose would support downloading whatever chain a peer has, if i'm understanding correctly.
pharonix71 has quit [Remote host closed the connection]
pharonix71 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
<jamesob6>
sdaftuar: yup, I just wanted to avoid special-casing the background chainstate if possible. What're you thinking?
<jamesob6>
I guess it'd be safer to confine the bg chainstate download to being along that headers chain... And if there is a longer valid headers chain, we'd find out about it earlier/elsewhere
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
r00kiefullnode has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
r00kiefullnode has quit [Quit: Ping timeout (120 seconds)]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<michaelfolkson>
achow101: I can't attend this week's meeting but I would like to submit a question in advance. For what it is worth I personally don't see any reason to NACK ryanofsky as a maintainer but I do think consistency is important.
<michaelfolkson>
From https://github.com/bitcoin/bitcoin/pull/25871#issuecomment-1382334059 "Maintainers inherently need to look at the things that everyone else has already looked at, if only to give it a final once over before merging (but hopefully, an actual review, not just looking it over)."
<michaelfolkson>
"I also want to mention that the people who have become maintainers in the past have had this kind of maintainer attitude towards review prior to becoming a maintainer."
brunoerg has quit [Ping timeout: 265 seconds]
<michaelfolkson>
"Previous maintainer additions were almost always foregone conclusions. They largely were the obvious choise to be a maintainer with a focus in some area because of the way that they were reviewing and calling for things to be merged."
brunoerg has joined #bitcoin-core-dev
<michaelfolkson>
I'd like to understand how these apply in this case and they didn't in the previous case with Vasil. The danger without consistency is the individual is chosen and then the requirements are fitted around them rather than laying out the requirements and then seeing who is the best fit for those requirements.
<michaelfolkson>
Of course if you've changed your mind on the requirements that would also be interesting to know
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
<jon_atack>
An attack on the I2P network is ongoing since a day or so. Bitcoin nodes running using the i2pd router may not be able to create SAM sessions due to floodfills.
<jon_atack>
Reverting back to i2pd version 2.42.1 has been reported to be one temporary workaround.
<jon_atack>
The Java I2P router seems to be unaffected due to its Sybil analysis and block list function.
<jon_atack>
I've re-established bitcoind connections with the I2P network by switching from i2pd to the Java I2P router (https://geti2p.net).
<jon_atack>
For users who switch over: Unlike i2pd, SAM is not enabled by default in the Java I2P Router. It must be started manually, or configured to start automatically, in the configure clients page in the router console or in the clients.config file.
<jon_atack>
See this open discussion in the i2pd repository for updates on the attack and its mitigation.
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
ddisqq has quit [Quit: Leaving...]
ddisqq has joined #bitcoin-core-dev
ddisqq has quit [Client Quit]
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
mudsip has quit []
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
aielima has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
vysn has quit [Quit: WeeChat 3.8]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow closed pull request #27476: mempool: keep CPFP'd transactions when loading from mempool.dat (master...2023-04-persist-packages) https://github.com/bitcoin/bitcoin/pull/27476
brunoerg has quit [Ping timeout: 246 seconds]
vysn has joined #bitcoin-core-dev
nintendo1889 has joined #bitcoin-core-dev
vysn has quit [Quit: WeeChat 3.8]
vysn has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
<BlueMatt[m]>
is there a case where bitcoin core may return nonsense fees for estimatesmartfee if its been offline for a few hours? trying to figure out why some lightning nodes sometimes just use trash fees (1sat/vB) which is very insecure and can lead to unintended force-closes.
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
BlueMatt has joined #bitcoin-core-dev
wpaulino has joined #bitcoin-core-dev
aielima has quit [Quit: Ciao]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
preimage has quit [Quit: WeeChat 3.8]
Henry151_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
nintendo1889 has quit [Quit: Connection closed for inactivity]