brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
b_101 has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
vyHamii has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] russeree opened pull request #27747: Use 'byte'/'bytes' for bech32(m) validation error message - 27727 follow up. (master...27727-ext) https://github.com/bitcoin/bitcoin/pull/27747
b_101 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
PaperSword has quit [Ping timeout: 240 seconds]
PaperSword has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
hernanmarino has quit [Ping timeout: 240 seconds]
nulldoot2k_ has joined #bitcoin-core-dev
vyHamii has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] LarryRuane opened pull request #27748: bugfix: account for system-allocated memory in pool resource (master...2023-05-resource-pool-system-alloc) https://github.com/bitcoin/bitcoin/pull/27748
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
b_101 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
EleYah has quit [Quit: EleYah]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
evri has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
<bitcoin-git>
[bitcoin] LarryRuane closed pull request #27748: bugfix: account for system-allocated memory in pool resource (master...2023-05-resource-pool-system-alloc) https://github.com/bitcoin/bitcoin/pull/27748
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Client Quit]
puchka has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
Evel-Knievel has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
aielima has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
pablomartin has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
<fanquake>
website is fully functional again, so release posts are up
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<MacroFake>
[17:11] <instagibbs> cant make heads or tails of output
<MacroFake>
instagibbs: git range-diff is a diff of a diff, so it works best if the diff of the diff is zero
nulldoot2k_ has quit [Quit: Leaving]
<MacroFake>
If the diff was too large, it will usually bail out and hightlight the commit id in red or green and you'll need to do the normal review stuff instead
<MacroFake>
You can also use the normal git flags like "--word-diff-regex=." or "--color-moved=dimmed-zebra" on it, if useful
<MacroFake>
[00:08] <jamesob> kind of dumb, but does anyone know of a shorthand for wiping a node's datadir in the functional test framework?
<MacroFake>
wiping the datadir in tests is not supported, because it holds the config file, which is needed to start a node
<MacroFake>
I presume you want to delete the block dir, which can be done with node.chain_path.unlink()
<instagibbs>
MacroFake when you say "diff too large" you mean the actual difference in the two ranges?
<MacroFake>
I meant "diff of diff too large", for example the difference between commit_a and commit_b in the call "git range-diff bitcoin-core/master commit_a commit_b"
<instagibbs>
hmmm, well shouldnt be the case, it was nearly a trivial rebase. I'll play around with more flags
<MacroFake>
for example, "git range-diff bitcoin-core/master 7869b169f2 0ff26b8c0f" will be too large
<MacroFake>
instagibbs: What was your command you tried?
<instagibbs>
will DM since it's a random branch
<MacroFake>
It should be 3 arguments, not 2, as with git diff
bugs_ has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<achow101>
Welcome to the weekly general IRC meeting
<Murch>
GM
<achow101>
there are no pre-propsoed meeting topics this week. are there any last minute topics to add to the list?
<theStack>
hi
<darosior>
hi
SebastianvStaa has joined #bitcoin-core-dev
<achow101>
#topic assumeutxo updates (jamesob)
<josie>
hi
<glozow>
hi
<jamesob>
Not too much to report here - Suhas seems to have found a bug in some of the blockindex management code that I'm trying to resolve. I'm adding functional testcases and will be evaluating his proposed changes today.
<achow101>
the blocker is still #24008?
<jamesob>
I'm actively looking for an apprentice to take on some of the brunt work of refactoring, mostly as a convenient means to recruit someone newish into the project.
<jamesob>
TheCharlatan: yeah, allegedly, although I haven't looked at it myself yet. I came up with my own fix last night and will push it to the big branch shortly.
<MacroFake>
TheCharlatan: Do you want review or are you addressing the nits?
<TheCharlatan>
I think molding the current shutdown behavior into something kernel friendly should be done with some prudence, so I hope this unblocks progress on both the other work remaining work for splitting out the few left over files from the kernel and being able to focus solely on shutdown routines.
<TheCharlatan>
MacroFake, I'll address the nits in #27636 if I have to push again.
<gribble>
https://github.com/bitcoin/bitcoin/issues/27636 | kernel: Remove util/system from kernel library, interface_ui from validation. by TheCharlatan · Pull Request #27636 · bitcoin/bitcoin · GitHub
<MacroFake>
Might be good to reply to them, so that reviewers know what is going on
<fjahr>
luke-jr: is that in response to any recent pr/issue in particular?
<luke-jr>
fjahr: apparently some dev was pressuring another wallet to stop using bloom :/
<luke-jr>
claiming we were going to remove support for it or something
preimage has joined #bitcoin-core-dev
<fanquake>
hard to say anything here with so little context / such vauge information, but if you're referring to issues like https://github.com/getumbrel/umbrel/issues/1624, you'll have to do better than "dumb"
<fanquake>
the response from upstream was "makes sense"
<fanquake>
there was a similar issue opened in another repo, but I can't recall which one right now
<luke-jr>
fanquake: no, this was afaict an in-person thing, and re client usage
<luke-jr>
disabling it on the node for public p2p makes sense
<luke-jr>
anyway, the point isn't to complain as much as it is to express that it shouldn't be removed ;)