#bitcoin-core-dev on 2023-08-28 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:05 benwestgate has quit [Quit: Leaving.]

00:11 andrew_mo_ has quit [Remote host closed the connection]

00:16 andrew_mo_ has joined #bitcoin-core-dev

00:18 test_ has joined #bitcoin-core-dev

00:21 andrew_mo_ has quit [Ping timeout: 255 seconds]

00:22 flooded has quit [Ping timeout: 260 seconds]

00:30 brunoerg has joined #bitcoin-core-dev

00:34 andrew_mo_ has joined #bitcoin-core-dev

00:37 brunoerg has quit [Ping timeout: 260 seconds]

00:39 andrew_mo_ has quit [Ping timeout: 255 seconds]

00:43 andrew_mo_ has joined #bitcoin-core-dev

00:51 brunoerg has joined #bitcoin-core-dev

00:55 andrew_mo_ has quit [Remote host closed the connection]

01:08 andrew_mo_ has joined #bitcoin-core-dev

01:12 andrew_mo_ has quit [Ping timeout: 255 seconds]

01:21 andrew_mo_ has joined #bitcoin-core-dev

01:25 andrew_mo_ has quit [Ping timeout: 245 seconds]

01:31 brunoerg has quit [Ping timeout: 240 seconds]

01:33 brunoerg has joined #bitcoin-core-dev

01:34 Unruly247 has quit [Remote host closed the connection]

01:37 andrew_mo_ has joined #bitcoin-core-dev

01:42 andrew_mo_ has quit [Ping timeout: 248 seconds]

01:45 brunoerg has quit [Ping timeout: 244 seconds]

01:46 andrew_mo_ has joined #bitcoin-core-dev

01:52 andrew_mo_ has quit [Ping timeout: 255 seconds]

02:02 <PaperSwo1d> ./btcdeb '[OP_0 OP_0 OP_CHECKMULTISIG]' 0 returns 01 :D

02:03 brunoerg has joined #bitcoin-core-dev

02:03 andrew_mo_ has joined #bitcoin-core-dev

02:07 andrew_m_ has joined #bitcoin-core-dev

02:08 andrew_mo_ has quit [Ping timeout: 250 seconds]

02:08 brunoerg has quit [Ping timeout: 248 seconds]

02:11 andrew_m_ has quit [Ping timeout: 245 seconds]

02:12 brunoerg has joined #bitcoin-core-dev

02:16 zhejyan_ has joined #bitcoin-core-dev

02:17 brunoerg has quit [Ping timeout: 246 seconds]

02:17 zhejyan has quit [Ping timeout: 248 seconds]

02:17 andrew_mo_ has joined #bitcoin-core-dev

02:18 mudsip has joined #bitcoin-core-dev

02:18 mudsip has quit [Client Quit]

02:19 Nekorand has quit [Ping timeout: 245 seconds]

02:21 andrew_mo_ has quit [Ping timeout: 240 seconds]

02:23 brunoerg has joined #bitcoin-core-dev

02:24 andrew_mo_ has joined #bitcoin-core-dev

02:28 andrew_mo_ has quit [Ping timeout: 255 seconds]

02:29 brunoerg has quit [Ping timeout: 255 seconds]

02:37 brunoerg has joined #bitcoin-core-dev

02:41 brunoerg has quit [Ping timeout: 246 seconds]

02:43 andrew_mo_ has joined #bitcoin-core-dev

02:47 andrew_mo_ has quit [Ping timeout: 248 seconds]

02:52 brunoerg has joined #bitcoin-core-dev

02:54 andrew_mo_ has joined #bitcoin-core-dev

02:56 brunoerg has quit [Ping timeout: 246 seconds]

03:00 andrew_mo_ has quit [Ping timeout: 246 seconds]

03:00 andrew_mo_ has joined #bitcoin-core-dev

03:04 andrew_m_ has joined #bitcoin-core-dev

03:05 andrew_mo_ has quit [Ping timeout: 246 seconds]

03:06 andrew_m_ has quit [Read error: Connection reset by peer]

03:06 andrew_mo_ has joined #bitcoin-core-dev

03:11 andrew_mo_ has quit [Ping timeout: 255 seconds]

03:18 andrew_mo_ has joined #bitcoin-core-dev

03:22 andrew_mo_ has quit [Ping timeout: 245 seconds]

03:24 andrew_mo_ has joined #bitcoin-core-dev

03:27 flooded has joined #bitcoin-core-dev

03:29 andrew_mo_ has quit [Ping timeout: 255 seconds]

03:31 test_ has quit [Ping timeout: 255 seconds]

03:33 brunoerg has joined #bitcoin-core-dev

03:41 andrew_mo_ has joined #bitcoin-core-dev

03:46 andrew_mo_ has quit [Ping timeout: 255 seconds]

03:55 DarrylTheFiish has quit [Remote host closed the connection]

03:59 andrew_mo_ has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:01 DarrylTheFish has joined #bitcoin-core-dev

04:03 andrew_mo_ has quit [Ping timeout: 246 seconds]

04:03 andrew_mo_ has joined #bitcoin-core-dev

04:04 DarrylTheFiish has joined #bitcoin-core-dev

04:07 DarrylTheFish has quit [Ping timeout: 246 seconds]

04:08 andrew_mo_ has quit [Ping timeout: 255 seconds]

04:12 andrew_mo_ has joined #bitcoin-core-dev

04:17 andrew_mo_ has quit [Ping timeout: 246 seconds]

04:24 andrew_mo_ has joined #bitcoin-core-dev

04:29 andrew_mo_ has quit [Ping timeout: 246 seconds]

04:33 Unruly247 has joined #bitcoin-core-dev

04:43 andrew_mo_ has joined #bitcoin-core-dev

04:44 Talkless has joined #bitcoin-core-dev

04:48 Unruly247 has quit [Quit: Leaving...]

04:49 andrew_mo_ has quit [Ping timeout: 255 seconds]

04:51 andrew_mo_ has joined #bitcoin-core-dev

04:55 Talkless has quit [Quit: Konversation terminated!]

04:55 AaronvanW has joined #bitcoin-core-dev

04:55 andrew_mo_ has quit [Ping timeout: 246 seconds]

05:03 andrew_mo_ has joined #bitcoin-core-dev

05:09 andrew_mo_ has quit [Ping timeout: 255 seconds]

05:21 andrew_mo_ has joined #bitcoin-core-dev

05:25 andrew_mo_ has quit [Ping timeout: 246 seconds]

05:37 andrew_mo_ has joined #bitcoin-core-dev

05:42 andrew_mo_ has quit [Ping timeout: 255 seconds]

05:44 andrew_mo_ has joined #bitcoin-core-dev

05:50 andrew_mo_ has quit [Ping timeout: 246 seconds]

06:03 andrew_mo_ has joined #bitcoin-core-dev

06:06 Guest40 has joined #bitcoin-core-dev

06:09 andrew_mo_ has quit [Ping timeout: 255 seconds]

06:10 Guest40 has quit [Client Quit]

06:21 andrew_mo_ has joined #bitcoin-core-dev

06:26 andrew_m_ has joined #bitcoin-core-dev

06:26 andrew_mo_ has quit [Ping timeout: 246 seconds]

06:30 andrew_m_ has quit [Ping timeout: 246 seconds]

06:32 andrew_mo_ has joined #bitcoin-core-dev

06:36 test_ has joined #bitcoin-core-dev

06:36 andrew_mo_ has quit [Ping timeout: 246 seconds]

06:40 flooded has quit [Ping timeout: 255 seconds]

06:45 andrew_mo_ has joined #bitcoin-core-dev

06:49 andrew_mo_ has quit [Ping timeout: 255 seconds]

07:01 andrew_mo_ has joined #bitcoin-core-dev

07:06 andrew_mo_ has quit [Ping timeout: 246 seconds]

07:11 Talkless has joined #bitcoin-core-dev

07:19 andrew_mo_ has joined #bitcoin-core-dev

07:24 andrew_mo_ has quit [Ping timeout: 255 seconds]

07:29 andrew_mo_ has joined #bitcoin-core-dev

07:34 andrew_mo_ has quit [Ping timeout: 248 seconds]

07:48 Guyver2 has joined #bitcoin-core-dev

08:28 javi404 has quit [Ping timeout: 248 seconds]

08:30 javi404 has joined #bitcoin-core-dev

08:33 vyHamii has joined #bitcoin-core-dev

08:46 Guest74 has joined #bitcoin-core-dev

08:47 Guyver2 has left #bitcoin-core-dev [Closing Window]

08:54 andrew_mo_ has joined #bitcoin-core-dev

08:58 andrew_mo_ has quit [Ping timeout: 246 seconds]

09:09 Guest74 has quit [Ping timeout: 246 seconds]

09:10 jonatack2 has joined #bitcoin-core-dev

09:11 andrew_mo_ has joined #bitcoin-core-dev

09:12 jonatack1 has quit [Ping timeout: 246 seconds]

09:15 andrew_mo_ has quit [Ping timeout: 246 seconds]

09:20 andrew_mo_ has joined #bitcoin-core-dev

09:25 andrew_mo_ has quit [Ping timeout: 258 seconds]

09:27 theStack has joined #bitcoin-core-dev

09:31 Talkless has quit [Read error: Connection reset by peer]

09:31 Talkless has joined #bitcoin-core-dev

09:36 andrew_mo_ has joined #bitcoin-core-dev

09:40 andrew_mo_ has quit [Ping timeout: 255 seconds]

09:47 andrew_mo_ has joined #bitcoin-core-dev

09:52 andrew_mo_ has quit [Ping timeout: 248 seconds]

09:54 Nekorand has joined #bitcoin-core-dev

10:03 andrew_mo_ has joined #bitcoin-core-dev

10:07 andrew_mo_ has quit [Ping timeout: 246 seconds]

10:10 <PaperSwo1d> Does anyone know when Bitcoin Core started to check pubkey prefixes for P2MS as a part of isStandard()?

10:20 andrew_mo_ has joined #bitcoin-core-dev

10:25 andrew_mo_ has quit [Ping timeout: 255 seconds]

10:25 vyHamii has quit [Quit: Leaving]

10:35 bitdex has quit [Remote host closed the connection]

10:35 bitdex has joined #bitcoin-core-dev

10:38 andrew_mo_ has joined #bitcoin-core-dev

10:44 andrew_mo_ has quit [Ping timeout: 246 seconds]

10:50 josie_ is now known as josie

10:56 andrew_mo_ has joined #bitcoin-core-dev

11:01 andrew_mo_ has quit [Ping timeout: 255 seconds]

11:02 <josie> getting a CI failure that seems related to a depends cache, not really sure how to proceed here: https://cirrus-ci.com/task/5736388545478656

11:03 <josie> MacroFake, hebasto: any insights? seems to be related to building qt from what I can tell?

11:04 <josie> doesn't seem related to my PR, but I also don't see other people running into it

11:06 <hebasto> josie: I'll be able to look into it closer later today.

11:07 <josie> hebasto: ty! im around all day, so ping me if I can be any help

11:08 benwestgate has joined #bitcoin-core-dev

11:12 andrew_mo_ has joined #bitcoin-core-dev

11:16 andrew_mo_ has quit [Ping timeout: 246 seconds]

11:28 <theStack> PaperSwo1d: looks like those checks were introduced in PR #12460 (for both P2PK and P2MS), for v0.17.0

11:28 <gribble> https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact · Pull Request #12460 · bitcoin/bitcoin · GitHub

11:28 andrew_mo_ has joined #bitcoin-core-dev

11:29 <theStack> to verify, you could try to submit a tx with invalid pubkey prefix in v0.16.0 and see if the mempool accepts it

11:33 andrew_mo_ has quit [Ping timeout: 246 seconds]

11:45 andrew_mo_ has joined #bitcoin-core-dev

11:49 andrew_mo_ has quit [Ping timeout: 246 seconds]

12:01 andrew_mo_ has joined #bitcoin-core-dev

12:05 andrew_mo_ has quit [Ping timeout: 246 seconds]

12:09 Talkless has quit [Read error: Connection reset by peer]

12:10 Talkless has joined #bitcoin-core-dev

12:18 andrew_mo_ has joined #bitcoin-core-dev

12:22 andrew_mo_ has quit [Ping timeout: 246 seconds]

12:29 bitdex has quit [Quit: = ""]

12:35 andrew_mo_ has joined #bitcoin-core-dev

12:41 andrew_mo_ has quit [Ping timeout: 246 seconds]

12:54 andrew_mo_ has joined #bitcoin-core-dev

12:58 andrew_mo_ has quit [Ping timeout: 258 seconds]

13:06 andrew_mo_ has joined #bitcoin-core-dev

13:12 andrew_mo_ has quit [Ping timeout: 245 seconds]

13:18 Guest57 has joined #bitcoin-core-dev

13:23 andrew_mo_ has joined #bitcoin-core-dev

13:29 andrew_mo_ has quit [Ping timeout: 255 seconds]

13:31 AaronvanW has quit [Remote host closed the connection]

13:32 AaronvanW has joined #bitcoin-core-dev

13:32 Aaronvan_ has joined #bitcoin-core-dev

13:33 Chris_St1 has quit [Ping timeout: 255 seconds]

13:34 Chris_St1 has joined #bitcoin-core-dev

13:36 AaronvanW has quit [Ping timeout: 246 seconds]

13:40 Chris_St1 has quit [Ping timeout: 246 seconds]

13:40 andrew_mo_ has joined #bitcoin-core-dev

13:41 jamesob443688173 has joined #bitcoin-core-dev

13:41 jamesob has joined #bitcoin-core-dev

13:42 Chris_St1 has joined #bitcoin-core-dev

13:44 andrew_mo_ has quit [Ping timeout: 246 seconds]

13:45 Guyver2 has joined #bitcoin-core-dev

13:48 Guest57 has quit [Quit: Client closed]

13:56 andrew_mo_ has joined #bitcoin-core-dev

13:58 vysn has joined #bitcoin-core-dev

14:00 preimage has joined #bitcoin-core-dev

14:00 andrew_mo_ has quit [Ping timeout: 246 seconds]

14:03 andrew_mo_ has joined #bitcoin-core-dev

14:07 andrew_mo_ has quit [Ping timeout: 246 seconds]

14:10 andrew_mo_ has joined #bitcoin-core-dev

14:15 andrew_mo_ has quit [Ping timeout: 255 seconds]

14:16 zhejyan has joined #bitcoin-core-dev

14:17 zhejyan_ has quit [Ping timeout: 245 seconds]

14:27 andrew_mo_ has joined #bitcoin-core-dev

14:30 bugs_ has joined #bitcoin-core-dev

14:32 andrew_mo_ has quit [Ping timeout: 246 seconds]

14:43 andrew_mo_ has joined #bitcoin-core-dev

14:45 andrew_m_ has joined #bitcoin-core-dev

14:47 andrew_mo_ has quit [Ping timeout: 246 seconds]

14:49 andrew_m_ has quit [Ping timeout: 255 seconds]

15:00 andrew_mo_ has joined #bitcoin-core-dev

15:05 andrew_mo_ has quit [Ping timeout: 255 seconds]

15:10 andrew_mo_ has joined #bitcoin-core-dev

15:14 andrew_mo_ has quit [Ping timeout: 246 seconds]

15:24 test_ is now known as _flood

15:26 andrew_mo_ has joined #bitcoin-core-dev

15:30 andrew_mo_ has quit [Ping timeout: 245 seconds]

15:34 Guest21 has joined #bitcoin-core-dev

15:35 Guest21 has quit [Client Quit]

15:35 andrew_mo_ has joined #bitcoin-core-dev

15:40 andrew_mo_ has quit [Ping timeout: 248 seconds]

15:41 andrew_mo_ has joined #bitcoin-core-dev

15:45 andrew_mo_ has quit [Ping timeout: 246 seconds]

15:45 <dviola> curious, does bitcoin core patches bdb 4.8 in any way? the one that is part of depends

15:47 <sipa> apparently yes, https://github.com/bitcoin/bitcoin/blob/master/depends/patches/bdb/clang_cxx_11.patch

15:47 <sipa> looks like a name clash with c++11 std functions

15:49 <dviola> thanks

15:54 benwestgate has quit [Quit: Leaving.]

15:57 andrew_mo_ has joined #bitcoin-core-dev

16:01 andrew_mo_ has quit [Ping timeout: 245 seconds]

16:14 andrew_mo_ has joined #bitcoin-core-dev

16:16 achow101 has quit [Remote host closed the connection]

16:19 andrew_mo_ has quit [Ping timeout: 255 seconds]

16:23 andrew_mo_ has joined #bitcoin-core-dev

16:29 andrew_mo_ has quit [Ping timeout: 255 seconds]

16:29 mudsip has joined #bitcoin-core-dev

16:30 mudsip has quit [Client Quit]

16:32 andrew_mo_ has joined #bitcoin-core-dev

16:37 andrew_mo_ has quit [Ping timeout: 246 seconds]

16:45 Guyver2 has left #bitcoin-core-dev [Closing Window]

16:45 takinbo has quit [Remote host closed the connection]

16:47 takinbo has joined #bitcoin-core-dev

16:50 andrew_mo_ has joined #bitcoin-core-dev

16:54 andrew_mo_ has quit [Ping timeout: 246 seconds]

17:02 codo has quit [Quit: bbl]

17:04 vasild has quit [Ping timeout: 246 seconds]

17:06 andrew_mo_ has joined #bitcoin-core-dev

17:06 vasild has joined #bitcoin-core-dev

17:07 <hebasto> josie: https://cirrus-ci.com/task/6596817396170752 passed; probably, the previous run faced a hiccup caused by cosmic rays :)

17:10 andrew_mo_ has quit [Ping timeout: 246 seconds]

17:14 andrew_mo_ has joined #bitcoin-core-dev

17:14 andrew_mo_ has quit [Remote host closed the connection]

17:14 andrew_mo_ has joined #bitcoin-core-dev

17:27 achow101 has joined #bitcoin-core-dev

17:28 Guest94 has joined #bitcoin-core-dev

17:30 cm has quit [Ping timeout: 246 seconds]

17:30 cm has joined #bitcoin-core-dev

17:31 Guest94 has quit [Client Quit]

17:55 bugs_ has quit [Quit: Leaving]

18:39 mudsip has joined #bitcoin-core-dev

18:40 benwestgate has joined #bitcoin-core-dev

18:42 Guest50 has joined #bitcoin-core-dev

18:47 mudsip has quit []

18:50 andrew_mo_ has quit [Remote host closed the connection]

18:53 andrew_mo_ has joined #bitcoin-core-dev

18:57 andrew_mo_ has quit [Ping timeout: 255 seconds]

19:11 andrew_mo_ has joined #bitcoin-core-dev

19:13 Guest64 has joined #bitcoin-core-dev

19:15 andrew_mo_ has quit [Ping timeout: 245 seconds]

19:17 Guest64 has quit [Client Quit]

19:19 benwestgate has quit [Quit: Leaving.]

19:24 Guest50 has quit [Quit: Client closed]

19:28 andrew_mo_ has joined #bitcoin-core-dev

19:33 andrew_mo_ has quit [Ping timeout: 255 seconds]

19:40 andrew_mo_ has joined #bitcoin-core-dev

19:51 jetpack_ has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]

19:52 jetpack has joined #bitcoin-core-dev

19:55 Talkless has quit [Quit: Konversation terminated!]

20:44 mudsip has joined #bitcoin-core-dev

20:45 <PaperSwo1d> Thanks @thestack! The reason why I was asking is that I wrote an IsPayToMultisig() in script.cpp and I am getting positives that are absolutely P2MS that Solver is saying are not. This happens very frequently until block 240,000 with p2ms 1 of 2 TXs where on pubkey has the wrong prefix 0x00. The behavior stops after that block sans a few exceptions.

20:45 mudsip has quit [Client Quit]

20:46 <PaperSwo1d> an example outpoint is scriptPubkey is 5121037953dbf08030f67352134992643d033417eaa6fcfb770c038f364ff40d76158821006f69d7fd3893e4f3f412e2142e08ae37b10f1729ce98affb4818999f8acd90bc52ae

22:02 andrew_mo_ has quit [Remote host closed the connection]

22:02 andrew_mo_ has joined #bitcoin-core-dev

22:02 andrew_mo_ has quit [Remote host closed the connection]

22:03 andrew_mo_ has joined #bitcoin-core-dev

22:46 andrew_mo_ has quit [Remote host closed the connection]

22:46 andrew_mo_ has joined #bitcoin-core-dev

22:48 bitdex has joined #bitcoin-core-dev

22:51 andrew_mo_ has quit [Ping timeout: 245 seconds]

22:51 andrew_mo_ has joined #bitcoin-core-dev

22:55 brunoerg has quit [Remote host closed the connection]

22:56 andrew_mo_ has quit [Ping timeout: 255 seconds]

22:56 brunoerg has joined #bitcoin-core-dev

22:58 andrew_mo_ has joined #bitcoin-core-dev

23:00 brunoerg has quit [Ping timeout: 240 seconds]

23:02 andrew_mo_ has quit [Ping timeout: 248 seconds]

23:05 andrew_mo_ has joined #bitcoin-core-dev

23:08 vysn has quit [Remote host closed the connection]

23:12 Aaronvan_ has quit [Quit: Leaving...]

23:13 preimage has quit [Quit: WeeChat 4.0.3]

23:18 andrew_mo_ has quit [Remote host closed the connection]

23:18 andrew_mo_ has joined #bitcoin-core-dev

23:23 andrew_mo_ has quit [Ping timeout: 248 seconds]

23:26 TheRec_ has joined #bitcoin-core-dev

23:27 TheRec has quit [Read error: Connection reset by peer]

23:27 andrew_mo_ has joined #bitcoin-core-dev

23:30 TheRec_ has quit [Read error: Connection reset by peer]

23:30 brunoerg has joined #bitcoin-core-dev

23:30 TheRec has joined #bitcoin-core-dev

23:30 TheRec has quit [Changing host]

23:30 TheRec has joined #bitcoin-core-dev

23:35 brunoerg has quit [Ping timeout: 244 seconds]

23:40 Guest84 has joined #bitcoin-core-dev

23:42 Nekorand has quit [Ping timeout: 246 seconds]

23:42 andrew_mo_ has quit [Remote host closed the connection]

23:43 andrew_mo_ has joined #bitcoin-core-dev

23:43 Guest84 has quit [Client Quit]

23:45 andrew_mo_ has quit [Read error: Connection reset by peer]

23:45 andrew_m_ has joined #bitcoin-core-dev

23:50 andrew_m_ has quit [Ping timeout: 255 seconds]

23:51 andrew_mo_ has joined #bitcoin-core-dev

23:53 brunoerg has joined #bitcoin-core-dev

23:57 brunoerg has quit [Ping timeout: 240 seconds]

23:58 brunoerg has joined #bitcoin-core-dev