ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
mcey_ has quit [Quit: Leaving]
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
mcey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
__DuBPiRaTe__ has quit [Quit: Leaving]
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
furszy has quit [Quit: ZNC - https://znc.in]
furszy has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
furszy has quit [Quit: ZNC - https://znc.in]
furszy has joined #bitcoin-core-dev
conman has quit [Remote host closed the connection]
ion- has quit [Ping timeout: 246 seconds]
ion- has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
eval-exec has quit [Ping timeout: 272 seconds]
mcey has quit [Remote host closed the connection]
mcey has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
ion- has quit [Ping timeout: 265 seconds]
ion- has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
kevkevin has quit [Ping timeout: 265 seconds]
ion- has quit [Ping timeout: 252 seconds]
eval-exec has quit [Ping timeout: 265 seconds]
eval-exec1 has joined #bitcoin-core-dev
eval-exec1 is now known as eval-exec
kevkevin has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 265 seconds]
ion- has quit [Ping timeout: 255 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
Chris_Stewart_5 has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
ion-_ has joined #bitcoin-core-dev
ion-__ has joined #bitcoin-core-dev
ion-___ has joined #bitcoin-core-dev
ion- has quit [Read error: Connection reset by peer]
ion-_ has quit [Ping timeout: 276 seconds]
ion-__ has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
ion-___ has quit [Remote host closed the connection]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
eval-exec has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has quit [Ping timeout: 272 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] marcofleon opened pull request #31001: refactor: ensure type safety for txid and wtxid in `RelayTransaction` (master...2024/09/relaytx-type-safety) https://github.com/bitcoin/bitcoin/pull/31001
ion-_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 246 seconds]
kevkevin has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Ping timeout: 255 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
kevkevin has quit [Ping timeout: 255 seconds]
ion-_ has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 246 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
pablomartin has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
virtu has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 256 seconds]
eval-exec has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 244 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d812cf11896a...f3c74c4a7e12
<bitcoin-git> bitcoin/master f1daa80 Hennadii Stepanov: guix: Drop no longer needed `PATH` modification
<bitcoin-git> bitcoin/master f3c74c4 merge-script: Merge bitcoin/bitcoin#30989: guix: Drop no longer needed `PATH` modificati...
<bitcoin-git> [bitcoin] fanquake merged pull request #30989: guix: Drop no longer needed `PATH` modification (master...240927-guix-path) https://github.com/bitcoin/bitcoin/pull/30989
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
preimage has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 248 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.4.2]
preimage has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 272 seconds]
preimage has quit [Client Quit]
preimage has joined #bitcoin-core-dev
ion-_ has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
<hebasto> achow101: GUI parted of release notes checked
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<sipa> reading
preimage has quit [Quit: WeeChat 4.4.2]
<sipa> lgtm
<instagibbs> nothing popped out to me
___nick___ has quit [Ping timeout: 276 seconds]
<lightlike> maybe mempoolfullrbf=1 should be moved to or also mentioned in the "mempool policy changes" section (I would have expected it there, not in the "Updated settings" section).
<sipa> lightlike: fair point
<achow101> lightlike: moved it
<lightlike> thanks!
Talkless has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoincore.org] achow101 opened pull request #1067: Bitcoin Core 28.0 (master...28.0-rel) https://github.com/bitcoin-core/bitcoincore.org/pull/1067
Chris_Stewart_5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] torkelrogstad closed pull request #29175: rpc: validate fee estimation mode case insensitive (master...2024-01-04-estimatemode) https://github.com/bitcoin/bitcoin/pull/29175
eval-exec has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 248 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 248 seconds]
achow101 has quit [Quit: Bye]
mcey_ has quit [Ping timeout: 248 seconds]
achow101 has joined #bitcoin-core-dev
__DuBPiRaTe__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #31003: Introduce waitFeesChanged() mining interface (master...2024/07/mining-fees-changed) https://github.com/bitcoin/bitcoin/pull/31003
<Chris_Stewart_5> achow101: Its unclear to me how to add #30982 to these auto generated release notes, the link at the top is not working: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft
<gribble> https://github.com/bitcoin/bitcoin/issues/30982 | docs: Add instructions on how to self-sign bitcoin-core binaries for macOS by Christewart · Pull Request #30982 · bitcoin/bitcoin · GitHub
<achow101> Chris_Stewart_5: click the "edit" button. you should have the permissions to edit it
<achow101> they're not auto generated
Chris_Stewart_5 has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<Chris_Stewart_5> achow101: ok its added, thanks for the tip
Talkless has quit [Remote host closed the connection]
PaperSword has joined #bitcoin-core-dev
cygnet3 has quit [Quit: Leaving]
qxs has quit [Ping timeout: 260 seconds]
qxs has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/f3c74c4a7e12...c33eb2360e24
<bitcoin-git> bitcoin/master 754e425 laanwj: crypto: Add missing WriteBE16 function
<bitcoin-git> bitcoin/master e020304 laanwj: net: Add netif utility
<bitcoin-git> bitcoin/master d72df63 laanwj: net: Use GetLocalAddresses in Discover
<bitcoin-git> [bitcoin] achow101 merged pull request #30043: net: Replace libnatpmp with built-in PCP+NATPMP implementation (master...2024-05-pcp) https://github.com/bitcoin/bitcoin/pull/30043
andrewtoth has quit [Remote host closed the connection]
<lightlike> nice!
laanwj has joined #bitcoin-core-dev
<laanwj> 🚀
<sipa> wen default on?
<achow101> it doesn't work on my router lol
<achow101> (the messages come back correctly, but the port isn't open)
<laanwj> i think after we've done a few of vasild's open suggestions, to make sure it heeds onlynet and binds
<laanwj> could ostensibly enable it unless one of those settings is overridden, but i don't think making it compatible is a big next step
<achow101> can we delete upnp now?
<laanwj> achow101: strange, maybe the firewall blocks it at another level? or are you behind two routers maybe?
<achow101> could be firewall
<laanwj> i hope soon? not sure, but upnp has been disabled by default for a long time, and i don't know if many people bother enabling it
<laanwj> one problem is that we don't really have an idea how many routers support one thing or the other
andrewtoth has joined #bitcoin-core-dev
<sipa> nat-pmp is over 10 years old now
<achow101> if someone could figure out how to turn on upnp, i'd hope they could also figure out how to manually port forward too, and that's assuming their router doesn't support natpmp or pcp
<sipa> well, no, the RFC is over 10 years old; the protocol itself is almost 20 years old
<laanwj> agree
<sipa> fwiw, my tp-link ax3000 pro with up-to-date firmware seems to support nat-pmp just fine, but nothing pcp/ipv6 happens (despite it getting an ipv6 address range from my ISP)
<laanwj> pcp/ipv6 is supported in newer versions of miniupnpd, but it's more recent and may not make it to all consumer routers, in any case with the fallback in place it should be automatically detected. it's likely that the same router won't handle IPv6 APIs in upnp either.
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c33eb2360e24...d7f956a309e3
<bitcoin-git> bitcoin/master 781c01f TheCharlatan: init: Check mempool arguments in AppInitParameterInteractions
<bitcoin-git> bitcoin/master c1d8870 TheCharlatan: refactor: Move most of init retry for loop to a function
<bitcoin-git> bitcoin/master e9d60af TheCharlatan: refactor: Replace init retry for loop with if statement
<bitcoin-git> [bitcoin] achow101 merged pull request #30968: init: Remove retry for loop (master...removeInitForLoop) https://github.com/bitcoin/bitcoin/pull/30968
<sipa> laanwj: i didn't know upnp even supported ipv6
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f956a309e3...fc642c33ef28
<bitcoin-git> bitcoin/master c16ae71 Sebastian Falbesoner: test: switch MiniWallet padding unit from weight to vsize
<bitcoin-git> bitcoin/master 940edd6 Sebastian Falbesoner: test: refactor: introduce and use `TRUC_CHILD_MAX_VSIZE` constant
<bitcoin-git> bitcoin/master fc642c3 Ava Chow: Merge bitcoin/bitcoin#30718: test: switch MiniWallet padding unit from wei...
<bitcoin-git> [bitcoin] achow101 merged pull request #30718: test: switch MiniWallet padding unit from weight to vsize (master...test-MiniWallet_change_padding_unit_to_vbytes) https://github.com/bitcoin/bitcoin/pull/30718
<sipa> TIL, NAT-PMP and PCP are consecutive RFCS (6886 and 6887), date from the same month (April 2013), and share some authors.
<sipa> Almost seems like they were written simultaneously.
Nebraskka has quit [Quit: Good day old chaps]
achow101 has quit [Ping timeout: 255 seconds]
achow101 has joined #bitcoin-core-dev
<fjahr> Is there an interest to merge #30885? If not, I can also just close it but it has had 3 ACKs for about 2 weeks now.
<gribble> https://github.com/bitcoin/bitcoin/issues/30885 | scripted-diff: Modernize nLocalServices naming by fjahr · Pull Request #30885 · bitcoin/bitcoin · GitHub
bugs_ has quit [Quit: Leaving]
emcy__ has quit [Remote host closed the connection]
mcey has joined #bitcoin-core-dev