ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
reardencode has quit [Ping timeout: 252 seconds]
reardencode has joined #bitcoin-core-dev
Guest27 has joined #bitcoin-core-dev
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Changing host]
dzxzg has joined #bitcoin-core-dev
Guest27 has quit [Quit: Client closed]
dzxzg has quit [Quit: Client closed]
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Quit: Client closed]
dzxzg has joined #bitcoin-core-dev
reardencode has quit [Ping timeout: 252 seconds]
reardencode has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
TheRec has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 248 seconds]
TheRec has quit []
lbia has joined #bitcoin-core-dev
benwestgate has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
<luke-jr> sipa: who was suggesting autodetection?
<luke-jr> I mean, if Qt is missing, fail unless it's explicitly disabled
Guest77 has joined #bitcoin-core-dev
Guest77 has quit [Client Quit]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] Tdhun opened pull request #30829: Create Satoshi Nakamoto (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30829
<bitcoin-git> [bitcoin] Tdhun opened pull request #30830: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/30830
benwestgate has joined #bitcoin-core-dev
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 closed pull request #30830: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/30830
<bitcoin-git> [bitcoin] achow101 closed pull request #30829: . (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30829
arik__ has quit [Ping timeout: 252 seconds]
runnerelektrode_ has quit [Ping timeout: 248 seconds]
hugohn____ has quit [Read error: Connection reset by peer]
runnerelektrode_ has joined #bitcoin-core-dev
hugohn____ has joined #bitcoin-core-dev
arik__ has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
bztrn has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Wbaker7702 opened pull request #30831: GUI Related (master...master) https://github.com/bitcoin/bitcoin/pull/30831
<bitcoin-git> [bitcoin] achow101 closed pull request #30831: GUI Related (master...master) https://github.com/bitcoin/bitcoin/pull/30831
<bitcoin-git> [bitcoin] Wbaker7702 opened pull request #30832: Wbaker7702/patch 753 (master...Wbaker7702/patch-753) https://github.com/bitcoin/bitcoin/pull/30832
<bitcoin-git> [bitcoin] achow101 closed pull request #30832: Wbaker7702/patch 753 (master...Wbaker7702/patch-753) https://github.com/bitcoin/bitcoin/pull/30832
bztrn has quit [Changing host]
bztrn has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
benwestgate has quit [Quit: Leaving.]
kevkevin has quit [Remote host closed the connection]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
SpellChecker has quit [Quit: bye]
bztrn has quit [Ping timeout: 256 seconds]
jon_atack has quit [Ping timeout: 252 seconds]
SpellChecker has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 260 seconds]
preimage has quit [Quit: WeeChat 4.4.1]
vasild has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
jirijakes has joined #bitcoin-core-dev
<vasild> Not sure if anybody is planning to re-add *.swp files to gitignore(5) into the repository. A local workaround is: echo "*.swp" > ~/.config/git/ignore
Guyver2 has joined #bitcoin-core-dev
Guest80 has joined #bitcoin-core-dev
Guest80 has quit [Client Quit]
aleggg has quit [Ping timeout: 252 seconds]
<fanquake> If they aren't being generated by our build system, then they belong in a local .git_ignore
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f472e9bcd27...c3af4b1ec3fd
<bitcoin-git> bitcoin/master a7a4e11 fanquake: cmake: scope Boost Test check to vcpkg
<bitcoin-git> bitcoin/master c3af4b1 merge-script: Merge bitcoin/bitcoin#30822: cmake: scope Boost Test check to `vcpkg`
<bitcoin-git> [bitcoin] fanquake merged pull request #30822: cmake: scope Boost Test check to `vcpkg` (master...scope_boost_test_vcpkg) https://github.com/bitcoin/bitcoin/pull/30822
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c3af4b1ec3fd...c0cbe26a8694
<bitcoin-git> bitcoin/master 2222f7a MarcoFalke: test: Rename SeedRand::SEED to FIXED_SEED for clarity
<bitcoin-git> bitcoin/master fa84f9d MarcoFalke: test: Pin and document TEST_DIR_PATH_ELEMENT
<bitcoin-git> bitcoin/master c0cbe26 merge-script: Merge bitcoin/bitcoin#30748: test: Pin and document TEST_DIR_PATH_ELEMENT,...
<bitcoin-git> [bitcoin] fanquake merged pull request #30748: test: Pin and document TEST_DIR_PATH_ELEMENT, SeedRand::FIXED_SEED (master...2408-test) https://github.com/bitcoin/bitcoin/pull/30748
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c0cbe26a8694...118b55c462e2
<bitcoin-git> bitcoin/master fa8dd95 MarcoFalke: bench: Use LogInfo instead of the deprecated alias LogPrintf
<bitcoin-git> bitcoin/master fadbcd5 MarcoFalke: bench: Remove redundant logging benchmarks
<bitcoin-git> bitcoin/master 118b55c merge-script: Merge bitcoin/bitcoin#30790: bench: Remove redundant logging benchmarks
<bitcoin-git> [bitcoin] fanquake merged pull request #30790: bench: Remove redundant logging benchmarks (master...2409-bench-log-cleanup) https://github.com/bitcoin/bitcoin/pull/30790
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/118b55c462e2...0e5cd608da5d
<bitcoin-git> bitcoin/master 86c80e9 Ryan Ofsky: contrib: make check-deps.sh script work with cmake
<bitcoin-git> bitcoin/master 3c99f5a Ryan Ofsky: contrib: fix check-deps.sh to check for weak symbols
<bitcoin-git> bitcoin/master 0aaa129 Ryan Ofsky: contrib: fix check-deps.sh when libraries do not import symbols
<bitcoin-git> [bitcoin] fanquake merged pull request #30415: contrib: fix check-deps.sh to check for weak symbols (master...pr/weakcheck) https://github.com/bitcoin/bitcoin/pull/30415
benwestgate has quit [Read error: Connection reset by peer]
abubakarsadiq has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<sipa> what are .swp files?
<fanquake> might be created by an editor, like vim, so it knows what it's editing
<fanquake> Assume the kind of file you'd never want to commit to any repository, so also makes sense to nullify globally, locally
<hebasto> I believe, that vim can be configured to place those files somewhere else, not in the source tree
<fanquake> If anyone has a Windows box, and feels like doing some benchmarking: #30833
<gribble> https://github.com/bitcoin/bitcoin/issues/30833 | 28.0rc1 synchronizes much slower on Windows · Issue #30833 · bitcoin/bitcoin · GitHub
<sipa> fanquake, vasild: ah, in that case the ignoring of such files don't belong ib our repository; were they ever in our ignore files?
<fanquake> sipa: yea, our .gitignore previously had a bunch of random stuff in it, but most was pruned out in #30664
<gribble> https://github.com/bitcoin/bitcoin/issues/30664 | build: Remove Autotools-based build system by hebasto · Pull Request #30664 · bitcoin/bitcoin · GitHub
<fanquake> Removing all those entries was not necessarily related to removing autotools, but a number of them were autotools specific
<sipa> heh, interesting
<sipa> i recall several PRs were people wanted to add their editor/ide specific files to the ignore list, which were always rejected
<vasild> yeah, not a big deal, I am ok either way (having it in .gitignore in the repo as before, or not). Just mentioned the alternative to ignore them without touching the repo, in case other people suddenly start seeing untracked .swp files in `git status`
<vasild> (like me)
<sipa> *.swp was apparently added in 2011: #291
<gribble> https://github.com/bitcoin/bitcoin/issues/291 | Add common temp files to .gitignore. by jrmithdobbs · Pull Request #291 · bitcoin/bitcoin · GitHub
<fanquake> i wonder if that predates git & it's core.excludesfile option
<hebasto> ^^ the description is amazing :)
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
jonatack has quit [Ping timeout: 252 seconds]
Guest57 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Guest57 has left #bitcoin-core-dev [#bitcoin-core-dev]
benwestgate has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0e5cd608da5d...bbf95c0cc571
<bitcoin-git> bitcoin/master e07a3ed Hennadii Stepanov: ci: Add missed configuration options to "Win64 native" job
<bitcoin-git> bitcoin/master c07fdd6 Hennadii Stepanov: fuzz: Don't compile BDB-specific code on MSVC in `wallet_bdb_parser.cpp`
<bitcoin-git> bitcoin/master ee22bf5 Hennadii Stepanov: doc: Update and amend MSVC build guide
<bitcoin-git> [bitcoin] fanquake merged pull request #30755: ci: Add missed configuration options to "Win64 native" job (master...240829-ci-win) https://github.com/bitcoin/bitcoin/pull/30755
jirijakes has quit [Ping timeout: 246 seconds]
jleost has quit [Ping timeout: 255 seconds]
SpellChecker_ has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #30834: test: Work around boost compilation error (master...2409-test-boost-fix) https://github.com/bitcoin/bitcoin/pull/30834
Guyver2 has joined #bitcoin-core-dev
anrichp has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #30835: build: Introduce "Kernel" installation component (master...240906-kernel) https://github.com/bitcoin/bitcoin/pull/30835
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bbf95c0cc571...a5fa90706add
<bitcoin-git> bitcoin/master fa3ecdf MarcoFalke: Revert "build: work around issue with Boost = 18"
<bitcoin-git> bitcoin/master fa9d7d5 MarcoFalke: test: Work around boost compilation error
<bitcoin-git> bitcoin/master a5fa907 merge-script: Merge bitcoin/bitcoin#30834: test: Work around boost compilation error
<bitcoin-git> [bitcoin] fanquake merged pull request #30834: test: Work around boost compilation error (master...2409-test-boost-fix) https://github.com/bitcoin/bitcoin/pull/30834
SpellChecker has quit [Quit: bye]
zeropoint has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 245 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
jleost has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Guest53 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
Guest53 has quit [Client Quit]
mcey has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
anrichp has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] ariard opened pull request #30837: Add NODE_TXRELAY_V2. (master...2024-node-txrelay-v2) https://github.com/bitcoin/bitcoin/pull/30837
rkrux has joined #bitcoin-core-dev
rkrux has quit [Quit: Client closed]
jleost has quit [Remote host closed the connection]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [gui-qml] hebasto pushed 2 commits to main: https://github.com/bitcoin-core/gui-qml/compare/48bc2c85b56c...b979bdc88834
<bitcoin-git> gui-qml/main 2b61d22 johnny9: qml: Put BlockClock into an Error state if init fails
<bitcoin-git> gui-qml/main b979bdc Hennadii Stepanov: Merge bitcoin-core/gui-qml#383: Put BlockClock into an error state if node...
<bitcoin-git> [gui-qml] hebasto merged pull request #383: Put BlockClock into an error state if node init fails (main...node-error-state) https://github.com/bitcoin-core/gui-qml/pull/383
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #30838: build: Use CMake's default permissions in macOS `deploy` target (master...240906-permissions) https://github.com/bitcoin/bitcoin/pull/30838
Talkless has joined #bitcoin-core-dev
flag has quit [Ping timeout: 264 seconds]
flag has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
jirijakes has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
Guest76 has joined #bitcoin-core-dev
Guest76 has quit [Ping timeout: 256 seconds]