<stickies-v>
there’s also a python wrapper available https://github.com/stickies-v/py-bitcoinkernel/ - adding more documentation but it’s about 90% feature complete and I try to keep it up to date with #30595, so feedback and contributions are welcome if anyone's interested in trying it out
<abubakarsadiq>
Nice doc, esp the examples, been playing around with the python wrapper
Emc26 has joined #bitcoin-core-dev
<stickies-v>
thanks for the battletesting abubakarsadiq !
<sipa>
cool
<fjahr>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<sipa>
hi
<abubakarsadiq>
yeah, new issue coming in @stickies-v :0
<sipa>
I'm making good progress on adding an interface to TxGraph (see #31363) for dealing with reorgs. These are complicated because they may cause us to violate policy limits (cluster size/count limit), with no way to "reject" the change (as we can with RBF). So we need a way to "trim" down clusters in violation, which is a challenge if they happen to be extremely large.
<instagibbs>
I'm actually reviewing, it's just a lot
<sipa>
instagibbs: i'm aware, it's much more than i had anticipated
<sipa>
feel free to reach out with any questions
<instagibbs>
will do (offline)
Emc99 has quit [Ping timeout: 240 seconds]
<sipa>
On the research front, there are a few interesting insights that may result in a more efficient (but still exponential) cluster linearization algorithm, one in addition to, or to replace the existing ones in cluster_linearize.h
<fjahr>
I think that’s it for the WGs. If I missed a WG where someone is present or if someone joined late, please speak up now :)
<fjahr>
Anything else to discuss?
<sipa>
Meeting next week, I assume not?
<fjahr>
No meeting next week I guess unless someone objects/wants to host one for a particular reason?
_andrewtoth_ has quit [Remote host closed the connection]
<stickies-v>
enjoy the holidays folks! see you in the new year
<Chris_Stewart_5>
:+1: ^
<TheCharlatan>
happy holidays and looking forward to seeing some of you at the hackers congress.
<fjahr>
#endmeeting
Emc26 has quit [Quit: Client closed]
_andrewtoth_ has joined #bitcoin-core-dev
<instagibbs>
sipa re:vsize limits being busted on large reorgs, IIUC current interface only deals with counts, not vsize. would this be re-delegated for the specific purposed of reorgs only?
moresteakpls has quit [Quit: Client closed]
<sipa>
instagibbs: my plan is adding a cluster weight limit to the constructor, and it would equally trigger the "oversize" property to violate it
<instagibbs>
Ok!
<sipa>
(txgraph doesn't care about units, so weight/vsize/size, i'm just calling it size)
<instagibbs>
yeah fsure, feefrac
<sipa>
right
<instagibbs>
sgtm
alex_mill has quit [Quit: Client closed]
<sipa>
instagibbs: i toyed with instead providing a max_size argument to the Trim() function, which would then trim down clusters down to the specified size (and count limit), but i decided it's simpler (both in interface and implementation) to just add a configurable size limit to graphs
<instagibbs>
I think it's most natural, even if not necessary for computational reasons, to add at ctor time
mudsip has joined #bitcoin-core-dev
<sipa>
yeah, my thinking evolved; initially the count limit and oversize property were just for protecting txgraph itself (so it doesn't need to deal with cases that require huge clusters to be materialized), while the policy aspect (cluster count/size limit as a rule) would remain responsibilty of the layer above (through txgraph functions to enforce it), but it appears much simpler to just combine the
<bitcoin-git>
[bitcoin] hebasto opened pull request #31541: qa: Use `sys.executable` when invoking other Python scripts (master...241219-qa-signers) https://github.com/bitcoin/bitcoin/pull/31541
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
rolf has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
bugs_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
javi404 has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
<dviola>
that patch is a proposal for qt5-base to accept it as a backport, but #kde-devel said it is unlikely for them to accept given that qt5 is already EOL
<dviola>
fine with me, but I think it's still good that the issue has been found
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Guest54 has joined #bitcoin-core-dev
Guest54 has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<laanwj>
qt5 is EOL? i didn't know, agree getting the qt6 PR in would be good anyhow
Guest33 has joined #bitcoin-core-dev
Guest33 has quit [Client Quit]
vasild_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
johnny9dev584508 has quit [Ping timeout: 252 seconds]