achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #33592: contrib: remove deprecated --deep signing from macdeployqtplus (master...fix-deep-arg) https://github.com/bitcoin/bitcoin/pull/33592
imakeconfou has quit [Ping timeout: 246 seconds]
warren has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/38886a671086...c61c504f273c
<bitcoin-git> bitcoin/master 65882fa Hennadii Stepanov: ci: Remove upstreamed vcpkg workaround
<bitcoin-git> bitcoin/master 9aa5b3c Hennadii Stepanov: ci: Switch to `x64-windows-release` triplet
<bitcoin-git> bitcoin/master 2d5cedf Hennadii Stepanov: ci: Switch to VS-vendored vcpkg instance
<bitcoin-git> [bitcoin] fanquake merged pull request #34883: ci: vcpkg-specific cleanups (master...260320-release-triplet) https://github.com/bitcoin/bitcoin/pull/34883
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c61c504f273c...2fe76ed8324a
<bitcoin-git> bitcoin/master 0b48988 Hennadii Stepanov: ci: Upgrade IWYU to 0.26 compatible with Clang 22
<bitcoin-git> bitcoin/master 3129d4a Hennadii Stepanov: ci: Rename `TIDY_LLVM_V` to `IWYU_LLVM_V` in IWYU-specific code
<bitcoin-git> bitcoin/master 2fe76ed merge-script: Merge bitcoin/bitcoin#34896: ci: Upgrade IWYU to 0.26 compatible with Clan...
<bitcoin-git> [bitcoin] fanquake merged pull request #34896: ci: Upgrade IWYU to 0.26 compatible with Clang 22 (master...260322-iwyu-update) https://github.com/bitcoin/bitcoin/pull/34896
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
dzxzg has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] epicleafies opened pull request #540: RPC command console (qt6...rpc-command-console) https://github.com/bitcoin-core/gui-qml/pull/540
kevkevin has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/88aecb41f4fe...36c925583d8c
<bitcoin-git> bitcoincore.org/master 0877004 Ava Chow: Release v28.4
<bitcoin-git> bitcoincore.org/master 36c9255 merge-script: Merge bitcoin-core/bitcoincore.org#1229: Release v28.4
<bitcoin-git> [bitcoincore.org] fanquake merged pull request #1229: Release v28.4 (master...release-28.4) https://github.com/bitcoin-core/bitcoincore.org/pull/1229
<bitcoin-git> [bitcoin] fanquake opened pull request #34915: doc: archive release notes for v28.4 (master...archive_28_4_relnotes) https://github.com/bitcoin/bitcoin/pull/34915
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xy1 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 265 seconds]
cmirror has joined #bitcoin-core-dev
timbo_xy1 has quit [Ping timeout: 265 seconds]
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
jerryf has quit [Remote host closed the connection]
afiore has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
hacker4web3bitco has quit [Read error: Connection reset by peer]
hacker4web3bitco has joined #bitcoin-core-dev
imakeconfou has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Nebraskka has quit [Read error: Connection reset by peer]
Nebraskka has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 265 seconds]
ghost43 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
svanstaa has quit [Ping timeout: 244 seconds]
svanstaa_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 255 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] Sjors opened pull request #34916: contrib: override system locale in gen-manpages.py (master...2026/03/manpages-locale) https://github.com/bitcoin/bitcoin/pull/34916
<bitcoin-git> [bitcoin] rkrux opened pull request #34917: wallet: mark bip125-replaceable deprecated, remove walletrbf argument (master...wallet-rbf) https://github.com/bitcoin/bitcoin/pull/34917
<bitcoin-git> [bitcoincore.org] azuchi opened pull request #1232: Add japanese translation for 28.4 (master...ja-translate-28.4) https://github.com/bitcoin-core/bitcoincore.org/pull/1232
<hebasto> a fresh false positive `-Wunused-but-set-variable` ln clang 23 -- https://github.com/hebasto/bitcoin-core-nightly/actions/runs/23524974067/job/68476342922#step:6:666
afiore_ has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore_ is now known as afiore
<hebasto> actually, it might be legit after fac81affb527132945773a5315bd27fec61ec52f
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 244 seconds]
ozdeadman has joined #bitcoin-core-dev
deadmanoz has quit [Ping timeout: 268 seconds]
l0rinc has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #34918: fuzz: Remove unused g_setup pointer in deserialize.cpp (master...2603-fuzz-w-unused) https://github.com/bitcoin/bitcoin/pull/34918
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/36c925583d8c...7d8349dfe156
<bitcoin-git> bitcoincore.org/master 50aa512 azuchi: Add japanese translation for 28.4
<bitcoin-git> bitcoincore.org/master 7d8349d merge-script: Merge bitcoin-core/bitcoincore.org#1232: Add japanese translation for 28.4
<bitcoin-git> [bitcoincore.org] fanquake merged pull request #1232: Add japanese translation for 28.4 (master...ja-translate-28.4) https://github.com/bitcoin-core/bitcoincore.org/pull/1232
hacker4web3bitco has quit [Ping timeout: 252 seconds]
dviola has quit [Ping timeout: 256 seconds]
diego has joined #bitcoin-core-dev
diego is now known as Guest2383
hacker4web3bitco has joined #bitcoin-core-dev
imakeconfou has quit []
memset has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
memset has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg opened pull request #34919: test: script: boundary at exactly 65535 bytes must use OP_PUSHDATA2 (master...2026-03-test-script-minimalpush) https://github.com/bitcoin/bitcoin/pull/34919
synexic has quit [Quit: Ping timeout (120 seconds)]
synexic7 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #34920: wallet: drop stale TODOs (master...2026/03/todo) https://github.com/bitcoin/bitcoin/pull/34920
abubakarsadiq has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 272 seconds]
aleggg has joined #bitcoin-core-dev
synexic has joined #bitcoin-core-dev
synexic7 has quit [Read error: Connection reset by peer]
Guest2383 has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #34912: wallet: Check only our inputs for multisig wallets (master...2026-02-12-check-sig-owned-in) https://github.com/bitcoin/bitcoin/pull/34912
l0rinc has quit [Quit: l0rinc]
hacker4web3bitco has quit [Ping timeout: 245 seconds]
synexic has quit [Quit: Ping timeout (120 seconds)]
synexic has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
synexic6 has joined #bitcoin-core-dev
synexic has quit [Read error: Connection reset by peer]
synexic6 is now known as synexic
kevkevin has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 245 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 252 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 252 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 276 seconds]
kevkevin_ has joined #bitcoin-core-dev
afiore_ has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
afiore has quit [Ping timeout: 265 seconds]
afiore_ is now known as afiore
ghost43 has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 256 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 246 seconds]
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [gui] apogio closed pull request #898: Add coins (UTXOs) tab and makes it view-only (master...feature-utxo-viewer) https://github.com/bitcoin-core/gui/pull/898
kevkevin_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
mudsip has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin_ has quit [Ping timeout: 245 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
SwaggerXx has quit [Ping timeout: 252 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 252 seconds]
deadmanoz has joined #bitcoin-core-dev
imakeconfou has joined #bitcoin-core-dev
isaquef has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Ping timeout: 265 seconds]
SwaggerX has joined #bitcoin-core-dev
SwaggerX has quit [Client Quit]
SwaggerX has joined #bitcoin-core-dev
<achow101> looking at the foundry reorg, I noticed that my node received the 3rd foundry block 10 minutes before it switches to it. In that time, it had further received the 2 blocks that come after that block. any ideas why switching to that chain would take so long?
SwaggerX has quit [Quit: Bye]
SwaggerX has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hodlinator opened pull request #34922: test: Make *TestingSetup more lightweight (master...2026/03/unittest_log_opt) https://github.com/bitcoin/bitcoin/pull/34922
<bitcoin-git> [bitcoin] sedited pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fe76ed8324a...6d54365c3ef7
<bitcoin-git> bitcoin/master 1438165 Sjors Provoost: wallet: drop stale TODOs
<bitcoin-git> bitcoin/master 6d54365 merge-script: Merge bitcoin/bitcoin#34920: wallet: drop stale TODOs
<bitcoin-git> [bitcoin] sedited merged pull request #34920: wallet: drop stale TODOs (master...2026/03/todo) https://github.com/bitcoin/bitcoin/pull/34920
cotsuka has quit [Read error: Connection reset by peer]
<eugenesiegel> achow101: maybe https://github.com/bitcoin/bitcoin/issues/33687 or similar
bugs_ has quit [Quit: Leaving]
cotsuka has joined #bitcoin-core-dev
<achow101> eugenesiegel: I don't think so. that discusses delay in a peer providing the block, but my logs say "received block" ~10 minutes before the UpdateTip
<achow101> https://achow101.com/files/debug.log2026-03-23-foundry-reorg.txt is the log if you want to take a look at it
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d54365c3ef7...fde37778ba6b
<bitcoin-git> bitcoin/master 3e08903 fanquake: doc: archive release notes for v28.4
<bitcoin-git> bitcoin/master fde3777 Ava Chow: Merge bitcoin/bitcoin#34915: doc: archive release notes for v28.4
<bitcoin-git> [bitcoin] achow101 merged pull request #34915: doc: archive release notes for v28.4 (master...archive_28_4_relnotes) https://github.com/bitcoin/bitcoin/pull/34915
imakeconfou has quit []
<bitcoin-git> [packaging] achow101 opened pull request #337: snap: Update to 28.4 (28.x...snap-28.4) https://github.com/bitcoin-core/packaging/pull/337
timbo_xyz has quit [Remote host closed the connection]
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] HouseOfHufflepuff closed pull request #34903: wallet: Validate all descriptors before importing in importdescriptors (master...wallet-importdescriptors-validate-before-rescan) https://github.com/bitcoin/bitcoin/pull/34903
isaquef has quit [Quit: Client closed]
timbo_xyz has quit [Ping timeout: 265 seconds]
SwaggerXx has joined #bitcoin-core-dev
SwaggerX has quit [Ping timeout: 264 seconds]
<bitcoin-git> [packaging] achow101 merged pull request #337: snap: Update to 28.4 (28.x...snap-28.4) https://github.com/bitcoin-core/packaging/pull/337
SwaggerXx has quit [Ping timeout: 276 seconds]
SwaggerX has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 merged pull request #34800: [31.x] Backports (31.x...31_x_backports) https://github.com/bitcoin/bitcoin/pull/34800
<bitcoin-git> [bitcoin] achow101 pushed 40 commits to 31.x: https://github.com/bitcoin/bitcoin/compare/d3737769caac...f0e2cbc5e5e0
<bitcoin-git> bitcoin/31.x 9852bbd fanquake: depends: disable Qt sbom generation
<bitcoin-git> bitcoin/31.x a3ffff0 fanquake: depends: delete Boost extra files
<bitcoin-git> bitcoin/31.x f7f7e68 MarcoFalke: ci: Bump GHA actions versions
<bitcoin-git> [bitcoin] achow101 pushed tag v31.0rc2: https://github.com/bitcoin/bitcoin/compare/v31.0rc2
<achow101> guix builders: 31.0rc2 tagged
<eugenesiegel> achow101: thx will take a look
eugenesiegel has quit [Ping timeout: 245 seconds]
lightningbot has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 265 seconds]
dzxzg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<achow101> eugenesiegel: I think you might be right actually. I've just noticed that the first foundry block got stalled on its download
<achow101> the "received block" must've been for a different block hash and I got them confused
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
dzxzg has quit [Client Quit]
dzxzg has joined #bitcoin-core-dev
timbo_xyz has joined #bitcoin-core-dev
Guest97 has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 265 seconds]
Guest97 has quit [Client Quit]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
<dzxzg> (also related to investigating https://bnoc.xyz/t/two-block-reorg-at-height-941880/97/17) should we disconnect bip157 light clients that request blocks we don't know about or just ignore them? during that reorg looking through @achow101's logs it seems lots of nodes BIP157/BIP158 requests for the other side of the block race and got disconnected
<dzxzg> technically this seems to be a bug in their implementation of bip157/bip158 (https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki#getcfilters) "StopHash MUST be known to belong to a block accepted by the receiving peer. This is the case if the peer had previously sent a headers or inv message with that block or any descendents. A node that receives getcfilters with an unknown StopHash SHOULD NOT respond."
vasild has quit [Remote host closed the connection]
vasild_ has joined #bitcoin-core-dev
<dzxzg> which I'm guessing is anti-fingerprinting, but I wonder if it would be wiser to just ignore instead of disconnecting?
dzxzg has quit [Quit: Konversation terminated!]
dzxzg has joined #bitcoin-core-dev
<dzxzg> on looking more closely it appears those are one and the same node reconnecting version "/btcwire:0.5.0/neutrino:0.12.0-beta/"
<bitcoin-git> [gui] sbddesign opened pull request #934: gui: Fix issues with new create wallet dialogue (master...fix-151-issues-with-new-create-wallet-dialogue) https://github.com/bitcoin-core/gui/pull/934
timbo_xyz has joined #bitcoin-core-dev
timbo_xyz has quit [Ping timeout: 265 seconds]