<bitcoin-git>
[bitcoin] achow101 opened pull request #35294: wallet: Update tx chain state during loading during AttachChain instead of before (master...wallet-chain-load-inconsistency) https://github.com/bitcoin/bitcoin/pull/35294
<bitcoin-git>
[bitcoin] maflcko opened pull request #35297: p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll (master...2605-p2p-mutex-early) https://github.com/bitcoin/bitcoin/pull/35297
BrandonOdiwuor has quit [Ping timeout: 245 seconds]
jackielove4u has joined #bitcoin-core-dev
cfields has quit [Ping timeout: 252 seconds]
cfields_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
afiore_ has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
afiore has quit [Ping timeout: 276 seconds]
ghost43 has quit [Ping timeout: 276 seconds]
afiore_ is now known as afiore
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Quit: Client closed]
midnight has quit [Ping timeout: 265 seconds]
cold has quit [Ping timeout: 255 seconds]
cold has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
roconnor_ is now known as roconnor
Guest52 has joined #bitcoin-core-dev
Guest52 has quit [Client Quit]
eugenesiegel has joined #bitcoin-core-dev
ozdeadman has joined #bitcoin-core-dev
deadmanoz has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 276 seconds]
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
enochazariah has quit [Quit: Ping timeout (120 seconds)]
bugs_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
l0rinc has quit [Quit: l0rinc]
memset has joined #bitcoin-core-dev
GoldenGoose_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
GoldenGoose has quit [Ping timeout: 264 seconds]
enochazariah has joined #bitcoin-core-dev
<pinheadmz>
re: deprecating libevent logging category... which of these is the least horrible
<pinheadmz>
or option 4, dont return an RPC warning, just log it where no one will see it
eugenesiegel has quit [Quit: Client closed]
<_aj_>
log it where no one will see it
<pinheadmz>
:+1:
<darosior>
pinheadmz: does it need to be part of the RPC response?
<_aj_>
or add -deprecatedrpc=libeventlogging and give hard errors if that's not set
Guyver2 has joined #bitcoin-core-dev
<darosior>
I mean the RPC response appears to tell you which logging categories are enabled. The libevent category can just always be false here. And the deprecation warning would go in release notes / logging, etc
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<_aj_>
note that #34038 is attempting to change the logging rpc output
<corebot>
https://github.com/bitcoin/bitcoin/issues/34038 | logging: replace -loglevel with -trace, expose trace logging via RPC by ajtowns · Pull Request #34038 · bitcoin/bitcoin · GitHub
<pinheadmz>
or i could change the name of the category to "libevent (DEPRECATED)" just in the return object
<_aj_>
why not just treat libevent as an undefined logging category (not listed, error if specified) for the logging rpc unless a -deprecatedrpc is set?
<_aj_>
users see the category is gone, and go "oh, okay" or lookup the release notes; bots get an error and crash, but can be made to work without edits by restarting with -deprpc
<pinheadmz>
yeah thats how the branch works now and thats fine. i was just hoping for a seamless transition
<_aj_>
isn't the whole point of adding a warning to add a seam?
<pinheadmz>
lnd ci testing for example sets debugexclude=libevent and took me a few days to realize bticoind wasnt even starting, because it swallows stdout
<_aj_>
seamless to me would just be leaving the category and having it do nothing
kevkevin has joined #bitcoin-core-dev
<pinheadmz>
yeah, ok. leave the category, it does nothing. log a deprecation wraning and put it in the relase notes.
<_aj_>
ci didn't immediately crash/red-flag as a result of bitcoind not starting?
<pinheadmz>
no it wasnt super obvious to me
<_aj_>
wtf that doesn't seem great for ci...
<pinheadmz>
Error: Received unexpected error:
<pinheadmz>
invalid http POST response (nil), method: addnode, id: 1, last error=Post "http://127.0.0.1:10126": dial tcp 127.0.0.1:10126: connect: connection refused
<pinheadmz>
but i was modifying their ci a lot anyway to run my PR branch, in my own fork
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
<_aj_>
pinheadmz: the bitcoind invocation should be exiting immediately with a return code of 1 (even with daemon or daemonwait), which should abort ci with "Error: Unsupported logging category -debugexclude=foo." there, really (imho)
kevkevin has quit [Ping timeout: 265 seconds]
enochazariah has quit [Ping timeout: 245 seconds]
<pinheadmz>
thats what happens when you can *see* the stdout / stderr! and i eventually figured that out by printing to the console, but their CI swallows it and deletes logs
<_aj_>
yeah, that's a CI problem though
adil has quit [Quit: adil]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
bugs_ has quit [Ping timeout: 244 seconds]
bugs_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
kevkevin_ has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
PaperSword has quit [Read error: Connection reset by peer]
PaperSword has joined #bitcoin-core-dev
S3RK has quit [Ping timeout: 272 seconds]
PaperSword has quit [Read error: Connection reset by peer]
PaperSword1 has joined #bitcoin-core-dev
PaperSword1 is now known as PaperSword
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
bugs_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<sipa>
"connection refused" for "nothing is listening" is a pretty confusing error to be honest, at the kernel level
S3RK has joined #bitcoin-core-dev
S3RK has quit [Ping timeout: 246 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
aleggg has quit [Read error: Connection reset by peer]
aleggg has joined #bitcoin-core-dev
Guest62 has joined #bitcoin-core-dev
Guest62 has quit [Quit: Client closed]
Guest62 has joined #bitcoin-core-dev
useruser7887 has joined #bitcoin-core-dev
Guest62 has quit [Quit: Client closed]
useruser7887 has left #bitcoin-core-dev [#bitcoin-core-dev]
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Read error: Connection reset by peer]
PaperSword1 is now known as PaperSword
afiore_ has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore_ is now known as afiore
kevkevin has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Read error: Connection reset by peer]
PaperSword1 is now known as PaperSword
cotsuka has quit [Read error: Connection reset by peer]
memset has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 246 seconds]
memset has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
PaperSword has quit [Read error: Connection reset by peer]
PaperSword has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
ViniciusCestarii has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
ViniciusCestarii has quit [Client Quit]
ViniciusCestarii has joined #bitcoin-core-dev
ViniciusCestarii has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
kevkevin has quit [Remote host closed the connection]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
<bitcoin-git>
[gui-qml] achow101 merged pull request #548: Apply password during onboarding and prompt for password when needed (qt6...wallet-password) https://github.com/bitcoin-core/gui-qml/pull/548
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
GoldenGoose_ has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
GoldenGoose has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
jonatack has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]