Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
bugs_ has joined #bitcoin-core-dev
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
nymius has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #36398: wallet: only rebroadcast transactions originating from the wallet (master...202620_wallet_restric_rebroadcast) https://github.com/bitcoin/bitcoin/pull/36398
durandal_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
mudsip has quit []
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #36399: common: Skip environment locale check on illumos (master...261001-illumos-locale) https://github.com/bitcoin/bitcoin/pull/36399
<abubakarsadiq>
#topic Fuzzing WG Update (eugenesiegel, marcofleon)
<b10c>
hi
<eugenesiegel>
I'm not sure if marcofleon is here, but no update from my side
<abubakarsadiq>
👍
<abubakarsadiq>
#topic Kernel WG Update (sedited)
<enochazariah>
hi
<nervana21>
hi
<andrewtoth_>
hi
<marcofleon>
no update this week
<marcofleon>
possibly next
<theStack>
hi
pzafonte has joined #bitcoin-core-dev
<abubakarsadiq>
I think @sedited is not here, so I will move on.
<abubakarsadiq>
#topic Benchmarking WG Update (l0rinc, andrewtoth)
<l0rinc>
nothing from my side, but want to present something next week
<andrewtoth_>
I haven't had an update in this WG in a while. I think I can be removed as lead.
<andrewtoth_>
I will still actively review speedup PRs and benchmark, but I don't really have regular updates to give.
<abubakarsadiq>
alright, if l0rinc also has no update, it can be archived.
<abubakarsadiq>
#topic QML GUI WG Update (johnny9dev)
<johnny9dev>
Pseudorandom has completed a comprehensive overhaul of the UX
<johnny9dev>
Its looking good and were close to a design we think will work for release
<johnny9dev>
Will start getting more feedback on it.
<johnny9dev>
If anyone is interested in trying its in the qt6 branch of the project
<johnny9dev>
That's all for this week
<abubakarsadiq>
thanks @johnny9dev
<abubakarsadiq>
#topic QML GUI WG Update (johnny9dev)
<abubakarsadiq>
#topic QA WG Update (brunoerg)
<brunoerg>
Hi, I've been working on a new project which is a collaborative mutation testing platform (https://mutanthub.space/). I've noticed that we have people using different tools and approaches to create mutants, different PRs addressing mutants (some overlaps), etc.
<willcl-ark>
are there pre-built bins johnny9dev?
<brunoerg>
So the idea of this new platform is that everything is centralized there and it becomes more collaborative.
<brunoerg>
Anyone can submit surviving mutants, reproduce and evaluate them.
<brunoerg>
For every surviving mutant, people can claim that a commit or PR kills it (so people can test it and/or avoid overlaps), as well as we can have discussions about mutants there.
<johnny9dev>
willcl-ark: by the end of the day bitcoincore.app will have them
<brunoerg>
feedback is welcome
<sipa>
hi
<brunoerg>
that's all
<willcl-ark>
👍
<abubakarsadiq>
@brunoerg whats the process of submitting mutants?
<brunoerg>
e.g. you can open any file from our source code (at https://mutanthub.space/projects/bitcoin/bitcoin/code), click on a specific line and suggest a mutant. Me as admin of the platform or any other people that wants to help in this process have to approve it (just to avoid trolls).
<brunoerg>
we also have a feature that me and selected people can do bulk import from a json file.
<dzxzg>
The killed mutants are the ones where a fix has been pushed to the project?
<abubakarsadiq>
nice, thanks
<brunoerg>
killed mutants are the ones that are detected by any of our tests
<brunoerg>
considering the tests at the same commit point from where that mutant was created
<dzxzg>
ah i see, thanks for sharing it looks awesome
pseudoramdom has quit [Remote host closed the connection]
<abubakarsadiq>
Anything else to discuss?
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
deadmano- has quit [Ping timeout: 259 seconds]
<dzxzg>
Maybe just an ask there's still some items on the 32.0 milestone, it would be helpful if anyone has extra hands to look thee
<eugenesiegel>
would people find it helpful if they could tag some sort of bot or add a label that says they want a fuzzamoto build on their PR (assuming fuzzamoto covers the code in the first place)
ozdeadman has joined #bitcoin-core-dev
<instagibbs>
eugenesiegel remind me where is there a spot to look at scenarios covered
<willcl-ark>
I have another bot-related topic, after eugenesiegel
<eugenesiegel>
I can vibe-code a bot ppl can ping and make it as un-invasive as possible, that's all from me
<willcl-ark>
I'm wondering if there'd be interest in a limited trial of automated AI reviews on PRs. I've already been testing this in my mirror of bitcoin/bitcoin, and I feel the results are useful enough. If there is interest, I think we could start on PRs coming from contibutors outside the frequent-contributor group.
cotsuka has quit [Remote host closed the connection]
<instagibbs>
could we start with allowing people to call it in for their PR, so people can sample it
<willcl-ark>
My suspicion is that some (or all) PRs arrive with LLM assistance or review in some capacity, and that human reviewers will then download the branch and make another llm-assisted first pass review. An automated review could do some of that initial work once and make the findings available to everyone/the original author.
<willcl-ark>
instagibbs: that could also be an approach
<eugenesiegel>
can we make it so that another person can't invoke it on your own PR if it's opt-in?
<willcl-ark>
If you want to see what the reviews are like first, then you can check new/recently-synced PRs here: https://git.fish.foo/bitcoin/bitcoin there should be a comment from "ralph" after some time with a review
<yancy>
I think that would be interesting upon request
<dzxzg>
what model is it using?
<willcl-ark>
I have to run out now, but will read all following messages when I get back (sorry about that). Happy to provide more details/links to bot code/prompts etc if folks want
<andrewtoth_>
I think most of the value of LLM reviews is still having it be distilled by experienced contributors. So just posting the LLM output on a PR doesn't add much value IMO.
winterrdog has joined #bitcoin-core-dev
<abubakarsadiq>
andrewtoth_: +1, I think it can be noise sometimes, so a dev should review the LLM reviews and post them.
l0rinc has quit [Quit: l0rinc]
<abubakarsadiq>
#endmeeting
<corebot>
abubakarsadiq: Meeting ended at 2026-10-01T16:31+0000
<instagibbs>
I think status quo could be greatly helped, especially in terms of new contributors, I'm not sure what the right system is but I am not sure everyone pretending to not meat proxy is the right way. Could we give willcl-ark a long leash to try something on a trial period and adapt as we go? something to discuss i guess
<instagibbs>
Obviously we wouldnt want multiple instances rampaging around
<instagibbs>
eugenesiegel is ther a fuzzamoto watering hole anywhere
<andrewtoth_>
I think maybe new contributors are the least likely to benefit from non-distilled review output. LLM reviews are fuzzy and will generally always return a bunch of "issues" with the code that can be "improved". It still takes a human to tell it when to stop, and newer contributors won't know which threads to pull and which are false positives/noise.
cotsuka has quit [Read error: Connection reset by peer]
dzxzg has quit [Quit: onversation terminated!]
cotsuka has joined #bitcoin-core-dev
<yancy>
makes sense
macgyver13 has joined #bitcoin-core-dev
<andrewtoth_>
That blog post also came up in the discussion about adding co-authorship to commits a few weeks ago.
nervana21 has quit [Quit: WeeChat 4.10.0]
macgyver13 has quit [Changing host]
macgyver13 has joined #bitcoin-core-dev
macgyver13 has quit [Quit: macgyver13]
macgyver13 has joined #bitcoin-core-dev
winterrdog has quit [Read error: Connection reset by peer]
viniciuscestarii has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] nebula-21 opened pull request #36402: refactor: `wallet_importdescriptors` to separate `run_test()` contents into specific functions (master...refactor-wallet-importdescriptors-test) https://github.com/bitcoin/bitcoin/pull/36402
enochazariah has quit [Ping timeout: 260 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<maflcko>
willcl-ark: I am not sure about directly putting the LLM review in the main repo. My hope is still that the repo discussions are from humans for humans. I want to read comments written in the indidual voice and language of the human author. But seeing the share of monotone claude-speak in the repo today, maybe that ship has sailed :(
ghost43 has quit [Remote host closed the connection]
<maflcko>
My recommendation would be to add a anchor link to it (https://github.com/willcl-ark/nix/pull/1), so that it is easier to jump to it, for anyone who wants to, and also easy to ignore for anyone who does not want to.
ghost43 has joined #bitcoin-core-dev
winterrdog has joined #bitcoin-core-dev
<instagibbs>
I would definitely say that the author isn't liable to respond to the review, like they are in general required to respond to humans
<instagibbs>
but there's a lot of review like that already :/
<eugenesiegel>
is the author required to respond to a human copy-pasting llm output though
<andrewtoth_>
I think adding this review to corecheck.dev or similar is better than having it in the main repo. That way it can still be pointed to when useful.
<instagibbs>
eugenesiegel no, which is why I think status quo is already bad
<andrewtoth_>
how do you know if it's a human copy-pasting llm output?
eugenesiegel has quit [Quit: Client closed]
<brunoerg>
andrewtoth_ I feel few people check corecheck
eugenesiegel has joined #bitcoin-core-dev
<eugenesiegel>
andrewtoth_: you "can't", but you can guess I suppose
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<andrewtoth_>
if it's people I've met, then I assume they are the ones copy-pasting. But otherwise I assume it's a bot behind the avatar.
winterrdog has quit [Read error: Connection reset by peer]
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git>
[gui-qml] pseudoramdom opened pull request #940: qml: Add a customizable widget dashboard and Node overview (qt6...widget-system) https://github.com/bitcoin-core/gui-qml/pull/940
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
WizJin__ has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 247 seconds]
winterrdog has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
winterrdog_ has joined #bitcoin-core-dev
winterrdog has quit [Read error: Connection reset by peer]
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 253 seconds]
PaperSword1 has quit [Ping timeout: 254 seconds]
enochazariah has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
winterrdog has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
Guest43 has joined #bitcoin-core-dev
enochazariah has quit [Read error: Connection reset by peer]
Guest43 has quit [Client Quit]
Guest33 has joined #bitcoin-core-dev
winterrdog has quit [Read error: Connection reset by peer]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
memset_ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
dzxzg has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
nymius has quit [Quit: nymius]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 260 seconds]
dzxzg has quit [Quit: Konversation terminated!]
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #36404: fuzz: don't set random state for private broadcast test (master...private_broadcast_remove_fuzz_seed) https://github.com/bitcoin/bitcoin/pull/36404
<bitcoin-git>
[bitcoin] fametrano opened pull request #36405: test: look for the wtxid in p2p_blocksonly's block-relay-only inv check (master...test-blocksonly-wtxid-inv) https://github.com/bitcoin/bitcoin/pull/36405
<bitcoin-git>
[bitcoin] fametrano opened pull request #36406: test: make p2p_orphan_handling's never-requested checks able to fail (master...test-orphan-handling-never-requested-int) https://github.com/bitcoin/bitcoin/pull/36406
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
PaperSword has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
nymius has joined #bitcoin-core-dev
nymius has quit [Client Quit]
smartin has quit [Quit: smartin]
<bitcoin-git>
[bitcoin] fametrano opened pull request #36407: test: make orphanage_dos_many fill the orphanage (master...test-orphanage-dos-many-inv) https://github.com/bitcoin/bitcoin/pull/36407
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
l0rinc has joined #bitcoin-core-dev
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
<l0rinc>
I like the idea of extending corecheck in a non-invasive, opt-in way with careful AI review - it's a lot easier to instruct new contributors to just check that instead of reexplaining the same concepts.
<l0rinc>
My concern is that those reviews will be very opinionated/centralized by whoever writes the prompts, so we should probably have our preferences documented in Core
<l0rinc>
and the code review prompt be something simple like "review this PR based on locally available docs" or if we want to force deeper work: 1) "create an issue from this PR" 2) "implement this issue" 3) "compare these two implementations and add comments based on their differences"
<l0rinc>
But it would help reviewers a lot if the basics were already covered by robots (the bot could even ACK when it thinks there are no blockers) - given that human review is even more of a bottleneck than ever...
<maxedw>
happy to add AI review page to Corecheck if people think it's useful.
<yancy>
corecheck.dev is pretty nice for frequent contrbuters that know about the dashboard. New people probably are going to look at it though, even if the PR literally says look over there.
<yancy>
new people are probably _not_ going to look at it
<l0rinc>
drahtbot could automatically convert to draft for new contributors if the AI review finds any blockers - with a response on how to mitigate the problem
l0rinc has quit [Quit: l0rinc]
cotsuka has quit [Read error: Connection reset by peer]
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
<l0rinc>
one more note: if we end up using AI review, they should combine outputs from multiple models, not just the cheapest ones - which will likely cost thousands of dollars per month
<kanzure>
instead of having people donate AI output tokens, they should donate AI API keys to specific developers who can prompt better and burn those tokens for more useful outputs.
cotsuka has quit [Read error: Connection reset by peer]
l0rinc has quit [Ping timeout: 260 seconds]
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
enochazariah__ has quit [Quit: Connection closed for inactivity]
bitcoindev1337 has quit [Remote host closed the connection]
bitcoindev1337 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 254 seconds]
l0rinc has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]