<vasild>
field was not exposed in interfaces::WalletTx. Thus the new GUI has no access to replaces_txid. The old GUI never used that. How to address? Expose replaces_txid so that the new GUI can access it?
<vasild>
achow101: ^
sliv3r__ has quit [Ping timeout: 242 seconds]
purpleKarrot has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
sliv3r__ has quit [Read error: Connection reset by peer]
<darosior>
Reviewing the website PR. Looks good to me, but sent in a clanker to check for omissions / difference with previous release PRs just in case
<darosior>
Oh it's checking that all links are correct, and the torrent hash as well. Cool
<instagibbs>
unsure if matters, we're doing a post-EOL 29.x release? not sure how that's communicated in table update if ever
<fanquake>
I think it's just a release, and it goes EOL right after
<instagibbs>
👍
<fanquake>
We can "release" 29.5 before 32.1
<instagibbs>
"one last time.... starting now"
<fanquake>
stickies-v: wanna look at generating the new RPC docs for the site?
<stickies-v>
ah yeah will do
<darosior>
fanquake: is the 31.2 website PR ready for review too?
<fanquake>
darosior: yes should be
<fanquake>
Will open a couple more
bitdex has quit [Quit: = ""]
Guyver2 has joined #bitcoin-core-dev
nymius has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
<stickies-v>
i'm thinking i'll do the RPC docs for 32.0, there are no RPC changes vs 32.1 anyway and then we don't mess up the versioning scheme (we always publish on x.0 versions)
otoburb has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
<instagibbs>
> Crashes on android 7 8 and 9 armv7a
<instagibbs>
*sweats*
jonatack has quit [Ping timeout: 268 seconds]
eugenesiegel has joined #bitcoin-core-dev
<darosior>
Heh
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
eugenesiegel5 has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
eugenesiegel5 has quit [Ping timeout: 254 seconds]
<darosior>
Following the TCP urgent data OOM for select(), i'm working on extensive testing of our expectation of each platform's socket API on the one hand, and extending our existing FuzzedSock to report anything within those bounds, so our fuzz targets can exercise more behaviours a real OS exhibits. Also adding an assertion in the conman target that we
<darosior>
never read on a paused socket appear to catch the bug after a while (tested by reverting the patch)
<darosior>
Stating it here in case others had the same idea
<darosior>
I hope this hardening of our socket testing can also give more assurance about switching all platforms to use poll(), since Windows finally fixed the main defect in its implementation
smartin has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
purpleKarrot has joined #bitcoin-core-dev
nymius has quit [Quit: nymius]
SwaggerXx has joined #bitcoin-core-dev
SwaggerX has quit [Ping timeout: 267 seconds]
Cchadwicka has quit [Ping timeout: 247 seconds]
bugs_ has quit [Quit: Leaving]
<darosior>
Fun fact: dropping DONTWAIT on Send(), which would let a malicious peer stall us forever on Linux, is only covered by p2p_ping_ibd.py which was only added back in August (8b5bbfe1fc)
purpleKarrot has quit [Quit: purpleKarrot]
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__ has joined #bitcoin-core-dev
antanst7125531 has quit [Ping timeout: 254 seconds]