< phantomcircuit> morcos, have you benchmarked the mempool indexing code with a really large mempool?
< phantomcircuit> nvm this issue is entirely unrelated to that
< dcousens> wumpus: ooi, why wouldn't a daemon print to stderr?
< GitHub48> [bitcoin] jonasschnelli opened pull request #7159: [RPC] Add RBF opt-in possibilities to rawtx functions (master...2015/12/rpc_rbf) https://github.com/bitcoin/bitcoin/pull/7159
< GitHub138> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aeedd8a53b2d...3cd836c1d855
< GitHub138> bitcoin/master fab8347 MarcoFalke: [qt] Use tr() instead of _()...
< GitHub138> bitcoin/master 3cd836c Wladimir J. van der Laan: Merge pull request #7158...
< GitHub45> [bitcoin] laanwj closed pull request #7158: [qt] Use tr() instead of _() (master...MarcoFalke-2015-translations) https://github.com/bitcoin/bitcoin/pull/7158
< wumpus> dcousens: because "As defined in W. Richard Stevens' 1990 book, Unix Network Programming (Addison-Wesley, 1990), a daemon is 'a process that executes 'in the background' (i.e., without an associated terminal or login shell)"
< wumpus> at best, stderr is connected to nowhere, at worst, it causes some other trouble...
< dcousens> wumpus: assuming you run bitcoind in `-daemon` mode :P
< wumpus> obviously
< dcousens> perhaps `-printtoconsole` should override that behaviour, allowing stderr to be meaningful
< wumpus> (just want to put it in context besides bitcoin)
< dcousens> haha, yeah, thanks for the ref :)
< wumpus> and sure - something could be said for an 'error log' in addition to the 'debug log' for serious issues, which in case of printtoconsole could go to stderr
< wumpus> * [new branch] 0.12 -> 0.12
< MarcoFalke> :3
< sipa> wheeeeeee
< BlueMatt> !
< GitHub145> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/c12ff995f7d70aafb12f34887fb64aa7482bbc85
< GitHub145> bitcoin/master c12ff99 Wladimir J. van der Laan: Now that 0.12 has been branched, master is 0.12.99...
< GitHub32> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/29850008085811fc93b71b345fb2da4146d695e4
< GitHub32> bitcoin/0.12 2985000 Wladimir J. van der Laan: Bump version to 0.12.0...
< gmaxwell> weee
< wumpus> https://github.com/bitcoin/bitcoin/pull/7062 is still open for 0.12 milestone, but we'll just backport that when merged
< sipa> MarcoFalke: things that ought to be backported to 0.11 if we do a new release in that branch
< wumpus> MarcoFalke: I was somewhat surprised too :)
< wumpus> but yes what sipa says makes sense
< sipa> hah, greg tagged it as 0.12 AND 0.11
< sipa> but it seems github only remembers one
< MarcoFalke> It was never done this way, but yeah.
< wumpus> right, as only one milestone is remembered, it's not terribly convenient for selection
< sipa> maybe we just need tags for milestones
< wumpus> not for milestones, but a tag 'needs backport' may be useful, dunno
< MarcoFalke> milestones are for future releases?
< MarcoFalke> yes, per wumpus
< MarcoFalke> "backport .11" tag
< wumpus> I'm not even sure it needs an explicit version in it, a general tag may be enough, then the issue itself could mention to what versions
< gmaxwell> Damn, github seemed to show "added 12 and 11" in the log, so I assumed it actually did add it to both.
< GitHub142> [bitcoin] laanwj closed pull request #6745: Net: Remove "Address refresh broadcast" logic. (master...addr_known_reset) https://github.com/bitcoin/bitcoin/pull/6745
< gmaxwell> What height are people at right now?
< sipa> 386520
< sipa> ;;height
< gribble> Error: "height" is not a valid command.
< sipa> ;;blocks
< gmaxwell> darn it, why is my laptop saying "0 blocks received in the last 4 hours" ? It's at 386520.
< gribble> 386520
< midnightmagic> 38652
< midnightmagic> er +0
< midnightmagic> ;;tblb
< gribble> (tblb <interval>) -- Calculate the expected time between blocks which take at least <interval> seconds to create. To provide the <interval> argument, a nested 'seconds' command may be helpful.
< midnightmagic> ;;tslb
< gribble> Time since last block: 13 minutes and 38 seconds
< gmaxwell> sipa: that gribble command just queries bc.i ... perhaps we should cluestick nanotube about the rest interface in bitcond. :)
< sipa> gmaxwell: i know, but more information is useful
< gmaxwell> I think what might happen is that while the laptop is in my bag and offline the warning triggers and it doesn't go away when back online.
< btcdrak> oh look, we branched :)
< GitHub182> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/c12ff995f7d7...884367662155
< GitHub182> bitcoin/master ec73ef3 Gregory Maxwell: Replace setInventoryKnown with a rolling bloom filter....
< GitHub182> bitcoin/master e206724 Gregory Maxwell: Remove mruset as it is no longer used.
< GitHub182> bitcoin/master 6b84935 Patick Strateman: Rename setInventoryKnown filterInventoryKnown
< GitHub120> [bitcoin] laanwj closed pull request #7133: Replace setInventoryKnown with a rolling bloom filter (rebase of #7100) (master...known_bloom) https://github.com/bitcoin/bitcoin/pull/7133
< GitHub84> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/884367662155...54a550bef8a8
< GitHub84> bitcoin/master 086ee67 Pieter Wuille: Switch to a more efficient rolling Bloom filter...
< GitHub84> bitcoin/master 54a550b Wladimir J. van der Laan: Merge pull request #7113...
< GitHub22> [bitcoin] laanwj closed pull request #7113: Switch to a more efficient rolling Bloom filter (master...betterrolling) https://github.com/bitcoin/bitcoin/pull/7113
< GitHub154> [bitcoin] laanwj reopened pull request #6745: Net: Remove "Address refresh broadcast" logic. (master...addr_known_reset) https://github.com/bitcoin/bitcoin/pull/6745
< sipa> wumpus: i'll review more PRs (merged and unmerged ones) for 0.12, but first HK
< GitHub52> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/54a550bef8a8...5548d9cb11c8
< GitHub52> bitcoin/master b440409 Matt Bogosian: Add missing automake package to deb-based UNIX install instructions.
< GitHub52> bitcoin/master 5548d9c Wladimir J. van der Laan: Merge pull request #7152...
< GitHub183> [bitcoin] laanwj closed pull request #7152: Add missing automake package to deb-based UNIX install instructions. (master...posita/fix-doc-build-unix) https://github.com/bitcoin/bitcoin/pull/7152
< wumpus> sipa: sure!
< GitHub168> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/cfb44ce97a939cb9b6db96f4b273c2a618e11d88
< GitHub168> bitcoin/0.12 cfb44ce Matt Bogosian: Add missing automake package to deb-based UNIX install instructions....
< jtimon> so when is 0.12 going to branch?
< jtimon> wasn't it supposed to be dec 1st?
< MarcoFalke> It already did?
< jtimon> MarcoFalke: oh, I missed that, thanks
< MarcoFalke> jtimon maybe you can create a separate PR for the first 3 commits of https://github.com/bitcoin/bitcoin/pull/6625/commits
< MarcoFalke> So they don't go through the rebase every time.
< jtimon> now I can start working on top of 3cd836c1, great!
< jtimon> MarcoFalke: yeah I suggested it https://github.com/bitcoin/bitcoin/pull/6625#issuecomment-157403741 but sipa said that wasn't necessary. As said here https://github.com/bitcoin/bitcoin/pull/6625#issuecomment-161610648 is what I'm going to do the next time that the last commit causes conflicts
< jtimon> btcdrak: said it was fine for 0.12 too, but that didn't ended up being the case
< GitHub156> [bitcoin] ptschip opened pull request #7164: Do not download transactions during initial blockchain sync (master...tx_getdata) https://github.com/bitcoin/bitcoin/pull/7164
< GitHub142> [bitcoin] laanwj opened pull request #7165: WIP: build: Enable C++11 in build, require C++11 compiler (master...2015_12_c++11) https://github.com/bitcoin/bitcoin/pull/7165
< gmaxwell> \O/
< sipa> and the crowd goes wild
< wumpus> hah!
< sipa> test/scheduler_tests.cpp:31:13: warning: ‘void scheduler_tests::MicroSleep(uint64_t)’ defined but not used [-Wunused-function] static void MicroSleep(uint64_t n)
< wumpus> sipa: yeah that function is not used pending fixing of the scheduler tests, harmles
< sipa> i'm aware, just wasn't sure whether we were aware of the warning :)
< wumpus> I was aware
< wumpus> scheduler stuff really needs to be fixed, I just have no time for that right now
< sipa> understood
< wumpus> (this is better than having travis hang 4% of the time)
< gmaxwell> :-/
< wumpus> not sure even if it's a bug in the test or the implementation. Though I'm not aware of any issues with it that don't concern the test, although in practice we only use it single-threaded so whatever trips up the test is likely not an issue in practical use...
< wumpus> if the intent is to only ever use it single-threadedly, both the implementation and the test could be simplified a lot
< wumpus> (although it is always difficult to test something inherently time-based)
< jl2012> Why Antpool is not upgrading to BIP65? It is the last major pool to upgrade
< jl2012> sorry wrong group
< cfields> oh, i hadn't seen the 0.12 branch yet. woohoo :)
< cfields> sipa: i have a few questions about addrman when you have a min
< cfields> sipa: for one, i'm not understanding the timing used for Connected()
< jtimon> btcdrak: could you make me a branch with bip68 and bip112 on top of 3cd836c1 ?
< cfields> (specifically, why it's called when a node is deleted). Is that meant to mean "this is the last time i saw that i was connected to this node" ?
< jtimon> no hurry though, I can do it myself if you don't have time as well
< sipa> cfields: yup
< jtimon> would be nicer to wait for them to get merged before backporting the commits, but I'm not sure I can wait that long...
< sipa> that's why it's done then, to not leak information beforehand about being connected to that node
< cfields> sipa: ok. So is it reasonable to call that any time is a node is disconnected, whether done via forced disconnect/ban, shutdown, timeout, etc?
< cfields> i assume yes?
< sipa> yes
< sipa> i guess it would be even better to pass along the timestamp, and send it the lastreceived timestamp of CNode
< cfields> yes, that's what i was planning to change it to
< cfields> well, i was intending to use the disconnect time itself. lastreceived makes more sense i guess
< sipa> don't think it matters much
< cfields> max(lastsent,lastreceived) maybe?
< cfields> ok
< sipa> lastsent doesn't mean much, we want to know when we last saw the node
< sipa> will look, but not now
< cfields> the range/mask is up for bikeshed, i'm just interested in your general opinion
< cfields> np, thanks
< cfields> gmaxwell: would be great to get your thoughts on that as well since it was your idea :)
< jtimon> cfields: any further thoughts on #7091 ?
< cfields> jtimon: i haven't been keeping up with those. looking now.
< jtimon> cfields: thanks!
< cfields> jtimon: i really don't care for the idea of building everything twice when a helper lib can be used to avoid that. Also, as-is, that seems like a slipperly slope as everything that's lib-friendly is likely to start ending up in that last.
< jtimon> no, only whatever is required to expose verifyblock in libconsensus should end up there
< jtimon> but things are being built twice for libconsensus already, that doesn't change
< jtimon> main, chain and coins should never end up there, even if they end up being lib-friendly
< cfields> jtimon: understood. but if you're creating a helper lib, may as well use it
< jtimon> I don't undesrtand the point about the helper lib
< jtimon> why is it a "helper" lib?
< jtimon> and how is the consensus package not being used?
< cfields> by "helper" i mean a private lib that's only used for linking into public binaries
< cfields> jtimon: i gave a patch a few days ago that shows how to link the helper directly into libconsensus.so rather than building twice
< jtimon> oh, yes, I focused on your nits (and finding out that for some reason the packages have to be build in backards order [linking order]), but I forgot about cherry picking from your branch
< jtimon> I'll look into that
< jtimon> btw, you never answer that question, why autotools wants the packages to be build in the same order that is needed for linking (the opposite of what I was trying to achieve)
< jtimon> ?
< cfields> jtimon: i responded on github
< jtimon> cfields: but to be clear, your improvement is kind of orthogonal to mine, isn't it?
< cfields> jtimon: no, the helper lib needs to be created one way or the other
< jtimon> cfields: but that can be done after 7091, no?
< cfields> jtimon: no, the lib syntax and usage is different
< jtimon> oh, I didn't knew that
< cfields> one is an automake lib, the other is a libtool lib
< jtimon> I guess I'll have to close #7091 and start over
< cfields> jtimon: you'll be in HK?
< jtimon> yes
< cfields> maybe we can hack on it a bit there?
< jtimon> yeah, it would be nice to do this in front of you (or you do it in front of me)
< cfields> yea, realtime would be much easier i think
< jtimon> does that sound good to you, peer programming this? I think it will be very fast that way
< cfields> you're staying for the dev meetup on the 8th/9th?
< jtimon> great, closing 7091 then
< jtimon> yes
< sipa> jtimon: don't close things too eagerly :)
< cfields> great! yea, let's plan some time then
< cfields> sipa: heh, he's not shy about re-opening :)
< sipa> i know
< GitHub19> [bitcoin] jtimon closed pull request #7091: Consensus build package (master...consensus-build) https://github.com/bitcoin/bitcoin/pull/7091
< jtimon> well I have been told to create a new one instead, but since "the lib syntax and usage is different" is going to be quite different anyway, who knows, maybe we do it in cfields' computer
< sipa> ok!
< jtimon> there's no point in have to rebase if say you do something nice like moving merkle to the consensus folder or something
< cfields> jtimon: sipa has a point though. by all means if you think you're right, fight me on it :)
< jtimon> cfields: but I agree with building the objects only once, I'm just not sure how much of 7091 as is, is incompatible with what you want to do, if you prefer to tell me that in person next week
< jtimon> and I don't close it because you have objections to it, just because I'm not going to rebase it as is if it's incompatible with building only once, which I also want for bitcoin jt
< jtimon> the code is in jtimon/libconsensus-f2 (pre-bitcoin-jt) anyway
< cfields> ok
< GitHub29> [bitcoin] gmaxwell opened pull request #7166: Disconnect on mempool requests from peers when over the upload limit. (master...mempool_p2p_when_overlimit) https://github.com/bitcoin/bitcoin/pull/7166
< jgarzik> Wizards,
< jgarzik> Has anybody written up designs for a "wallet" does not have complete control over the keys?
< jgarzik> A bank that cannot steal from you :)
< jgarzik> er, oops, wrong channel