< GitHub125> [bitcoin] calebogden opened pull request #7313: Found and fixed some typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7313
< cfields> Luke-Jr: yea, just saw. testing locally
< Chris_Stewart_5> What does OP_CODESEPARATOR do? The description is "All of the signature checking words will only match signatures to the data after the most recently-executed OP_CODESEPARATOR."
< Chris_Stewart_5> so it is just the index of a signature?
< Chris_Stewart_5> the actually code in core says pbegincodehash = pc;
< sipa> Chris_Stewart_5: historic cruft
< jonasschnelli> wumpus: do you know the reason why we multiple RPCTimerInterface?
< jonasschnelli> Is it because the RPCRunLater() needs to be called from the GUI whenever one used the GUI console?
< GitHub182> [bitcoin] jonasschnelli opened pull request #7317: Fix RPCTimerInterface ordering issue (master...2016/01/qt_thread) https://github.com/bitcoin/bitcoin/pull/7317
< wumpus> jonasschnelli: no, the reason is that one may use the RPC console without the web server running
< wumpus> the two timer interfaces should be equivalent, the only difference is that one uses libevent's timer mechanism and the other qt's
< jonasschnelli> Right. The problem is, that dispatching a QThread from a non QThread (events timer meachism) won't work.
< wumpus> fuck fuck fuck
< wumpus> does it dispatch a thread? I thought it just creates a timer?
< wumpus> this makes things a lot more complex
< jonasschnelli> I mean it's only the walletphassphrase call... (an important one)
< wumpus> the idea behind a generic timer interface was that it doesn't matter who provides the timer 'service'
< wumpus> but apparently it does
< jonasschnelli> I think it should always use the libevent timer routine if available.
< wumpus> so I'm afrid we'll have to pass the 'RPC context' all the way down
< jonasschnelli> my PR https://github.com/bitcoin/bitcoin/pull/7317 is a quick fix.
< jonasschnelli> It does not make things more worse..
< wumpus> hm but it makes an assumption of the order of interfaces in timerInterfaces
< wumpus> I agree with your logic though
< wumpus> but we should spell it out explicitly, 'if libevent is available use that otherwise fall back to qt'
< wumpus> otherwise there are a tons of ways future "harmless refactors" can mess this up again
< jonasschnelli> right.. so should I add a priority (int) in the timer interface and always use the one with highest prio?
< jonasschnelli> Or other concepts?
< wumpus> yea.. that sounds good to me
< wumpus> or just have explicit logic in the GUI
< wumpus> install a timer interface only when APpInit() hasn't installed one
< wumpus> I think that's even more straightforward
< wumpus> have a single timer interface instead of a list o them
< jonasschnelli> ah... right... don't add the QTTimerInterface when there is already one.
< wumpus> yes
< jonasschnelli> okay.. i try to change it to only support one timer interface.
< wumpus> that's what we effectively want, one timer interface, but I thought they were equivalent so 'picking one' was fine, apparantly not :(
< wumpus> I hope it isn't a problem the other way around, using libevent timer mechanism when talking to qt
< wumpus> in that case we really need an rpc 'context'
< jonasschnelli> sorry, sorry, MarcoFalke just told me the fact that i did push branches to bitcoin/bitcoin, will delete them immediately! that git beast!
< jonasschnelli> will keep three of them until the related PRs closed (to avoid close/reopen).
< wumpus> oh I also did that by accident once, no problem, just remove them when they're done
< GitHub110> [bitcoin] jonasschnelli opened pull request #7318: Backport: quickfix for RPC timer interface problem (0.12...2016/01/bp_rpctimerinterface) https://github.com/bitcoin/bitcoin/pull/7318
< GitHub85> [bitcoin] jonasschnelli opened pull request #7319: [Backport 0.12][QT] Intro: Display required space (0.12...2016/01/bp_qtintrodatadirsize) https://github.com/bitcoin/bitcoin/pull/7319
< MarcoFalke> Are any merges planned before the rc1 tag?
< MarcoFalke> Any pulls need testers?
< btcdrak> MarcoFalke: I dont think you can have an RC until the remaining 0.12 tagged PRs are merged.
< btcdrak> MarcoFalke: else it cant be a release candidate by very definition (if stuff is pending), unless it's being specifically excluded for the next maintenance release.
< GitHub182> [bitcoin] MarcoFalke opened pull request #7320: [qa] Test walletpassphrase timeout (master...Mf1601-rpcWalletPass) https://github.com/bitcoin/bitcoin/pull/7320
< MarcoFalke> How can I delete a walletpassphrase?
< jonasschnelli> MarcoFalke: you can't :)
< jonasschnelli> export / create new / import
< MarcoFalke> ok, thx.
< MarcoFalke> I need a reminder to run `BITCOIND=bitcoin-qt qa/pull-tester/rpc-tests.py` whenever I leave home.
< GitHub123> [bitcoin] MarcoFalke opened pull request #7321: Always respect GetRequiredFee for wallet txs (master...Mf1601-walletFeeFix) https://github.com/bitcoin/bitcoin/pull/7321
< GitHub113> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/ff9b61002606...1320300ea11f
< GitHub113> bitcoin/0.12 b1a8374 MarcoFalke: [qt] Intro: Display required space...
< GitHub139> [bitcoin] laanwj closed pull request #7319: [Backport 0.12][Qt] Intro: Display required space (0.12...2016/01/bp_qtintrodatadirsize) https://github.com/bitcoin/bitcoin/pull/7319
< GitHub113> bitcoin/0.12 1320300 Wladimir J. van der Laan: Merge pull request #7319...
< GitHub91> [bitcoin] laanwj closed pull request #7318: [Backport 0.12][RPC] quickfix for RPC timer interface problem (0.12...2016/01/bp_rpctimerinterface) https://github.com/bitcoin/bitcoin/pull/7318
< GitHub151> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/1320300ea11f...9265e89a7778
< GitHub151> bitcoin/0.12 daa8da2 Jonas Schnelli: Backport: quickfix for RPC timer interface problem
< GitHub151> bitcoin/0.12 9265e89 Wladimir J. van der Laan: Merge pull request #7318...
< GitHub143> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/3b57e9cff09c528201246dbc7b890c1593e49fb1
< GitHub143> bitcoin/master 3b57e9c Wladimir J. van der Laan: Merge pull request #7317...
< GitHub60> [bitcoin] laanwj closed pull request #7317: Fix RPCTimerInterface ordering issue (master...2016/01/qt_thread) https://github.com/bitcoin/bitcoin/pull/7317
< GitHub134> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b57e9cff09c...9de541a9c95a
< GitHub134> bitcoin/master f61766b Alex Morcos: Make sure conflicted wallet tx's update balances
< GitHub134> bitcoin/master 9de541a Wladimir J. van der Laan: Merge pull request #7306...
< GitHub101> [bitcoin] laanwj closed pull request #7306: Make sure conflicted wallet tx's update balances (master...fixconflicts) https://github.com/bitcoin/bitcoin/pull/7306
< GitHub2> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/4707797df2d41d46a40f59977738e58f87a949fe
< GitHub2> bitcoin/0.12 4707797 Alex Morcos: Make sure conflicted wallet tx's update balances...
< Quent> hey, when is the next release do we know?
< MarcoFalke> Feb 1
< MarcoFalke> rc1 is today or Monday, I think
< Quent> thanks
< MarcoFalke> morcos?
< MarcoFalke> rpc tests look fine but there is a typo which makes travis fail
< GitHub174> [bitcoin] theuni opened pull request #7322: c++11: add scoped enum fallbacks to CPPFLAGS rather than defining them locally (master...c++11-prep) https://github.com/bitcoin/bitcoin/pull/7322
< morcos> MarcoFalke: thanks. fixed.
< cfields> wumpus: I have a few questions in to Travis about how to proceed. There are several paths we could take, all missing one thing or another. I'm looking to find out what's most likely to be fixed first
< cfields> worst case, i guess we can just leave c++11 disabled for win32 builds temporarily, as that's the most troublesome
< phantomcircuit> sipa, in FRESH/DIRTY in coins.h "parent" means closer to disk, right?
< sipa> phantomcircuit: yes
< phantomcircuit> sipa, is it possible for FRESH to be set but not DIRTY ?
< phantomcircuit> sipa, also, why does CCoinsViewCache::BatchWrite erase the entires from the batch?
< sipa> phantomcircuit: to avoid a copy
< sipa> phantomcircuit: otherwise you'd get a memory usage doubling whenever you're flushing
< phantomcircuit> sipa, so the cacheCoins.clear(); in CCoinsViewCache::Flush never does anything?
< sipa> phantomcircuit: deleting the map's storage?
< sipa> unsure, not looking at code now
< phantomcircuit> sipa, cacheCoins.size() == 0 always before it's called
< phantomcircuit> oh ok nvm then :)
< morcos> phantomcircuit: i had questions about that too, and i'd love it if you want to look at #6936 and figure out why the performance improvement isn't as good as you might expect
< cfields> morcos: i just spent a ton of time in there, i'd be happy to talk it through if you'd like
< cfields> morcos: haha, just looked at your PR. I was hacking on the same goal :)
< morcos> cfields: great, thanks. maybe next week we can chat on it?
< cfields> sure
< cfields> morcos: fwiw, i was doing a test, and just hacked it up to always keep _all_ tx in the cache (to test the penalty of going to disk on osx) and the difference was very significant
< cfields> so i'm surprised that you weren't happy with the improvement you saw
< cfields> note that i primed the cache at startup, though, so it was always warm
< cfields> (the cost of priming the cache turned out to be negligible compared to the gain of actually having it primed)