07:38
<
luke-jr >
jonasschnelli: isn't that what we already gave BIP 150?
07:39
<
luke-jr >
hm, I guess it's still marked tentative on my end; so BIP 150 :p
07:39
<
jonasschnelli >
luke-jr: Could be? Wasn't aware of that. Thanks
07:39
<
jonasschnelli >
Ah. Right... it was combine at the PR level once.
10:00
<
GitHub26 >
bitcoin/master 936c144 Wladimir J. van der Laan: build: Remove check for `openssl/ec.h`...
10:00
<
GitHub26 >
bitcoin/master b40e19c Wladimir J. van der Laan: Merge #8520: build: Remove check for `openssl/ec.h`...
10:01
<
GitHub99 >
bitcoin/master c1582d5 Wladimir J. van der Laan: qa: Remove duplicate `hash160` implementation...
10:01
<
GitHub99 >
bitcoin/master b41ac92 Wladimir J. van der Laan: Merge #8521: qa: Remove duplicate `hash160` implementation...
10:02
<
GitHub138 >
bitcoin/master 6ffd996 Sev: Corrected JSON typo on setban of net.cpp
10:02
<
GitHub138 >
bitcoin/master 29496fc Wladimir J. van der Laan: Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp...
10:26
<
GitHub170 >
bitcoin/master fae596f MarcoFalke: [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain
10:26
<
GitHub170 >
bitcoin/master fa2d68f MarcoFalke: [qa] Adjust timeouts for micro-optimization of run time
10:26
<
GitHub170 >
bitcoin/master fad8cf6 MarcoFalke: [qa] Use single cache dir for chains
10:33
<
GitHub110 >
bitcoin/master 8194a6e Jeremy Rubin: Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
10:33
<
GitHub110 >
bitcoin/master 65e6444 Wladimir J. van der Laan: Merge #8513: Fix a type error that would not compile on OSX....
10:51
<
GitHub146 >
bitcoin/master 1aacfc2 leijurv: various typos
10:51
<
GitHub146 >
bitcoin/master e753eae Wladimir J. van der Laan: Merge #8505: Trivial: Fix typos in various files...
10:53
<
sipa >
m-m-m-megamerge
11:07
<
GitHub176 >
bitcoin/0.13 4f55293 Luke Dashjr: doc/release-notes: Misc
11:07
<
GitHub176 >
bitcoin/0.13 40d705c Luke Dashjr: doc/release-notes: Mention the relevance of Compact Blocks on non-mining nodes' influence on network policy
11:07
<
GitHub176 >
bitcoin/0.13 5e499e7 Luke Dashjr: doc/release-notes: Document changed bytespersigop behaviour
11:12
<
GitHub138 >
bitcoin/master 3c5251d Wladimir J. van der Laan: test: Remove java comparison tool
11:12
<
GitHub138 >
bitcoin/master eb0c52e Wladimir J. van der Laan: travis: Remove hostname hack...
11:12
<
GitHub138 >
bitcoin/master 733035b Wladimir J. van der Laan: Merge #8504: test: Remove java comparison tool...
13:01
<
jonasschnelli >
I compiled it locally on different machines and can't get that test failure...
13:02
<
sipa >
jonasschnelli: it requires rebuilding glibc with debug options, i think
13:02
<
jonasschnelli >
It could be a bug in gcc, I'm using std::prev(myVector.end()) which should be valid and safe?
13:02
<
sipa >
jonasschnelli: only if the vector is not empty
13:02
<
jonasschnelli >
Yes. There is a check for empty vectors above..
13:03
<
jonasschnelli >
I stepped with the debugger through the whole unit test and cannot fine a invalid std::prev
13:03
<
jonasschnelli >
*find
13:04
<
sipa >
maybe it's not in a call to std::prev?
13:05
<
jonasschnelli >
wait.. found the issue! nm
13:06
<
jonasschnelli >
There is a call of std::prev(vector.begin()) which is invalid
17:37
<
Anduck >
bitcoin core slack has leaked my e-mail to scammers
17:37
<
Anduck >
i used unique e-mail when i joined bitcoincore.slack.com
17:38
<
Anduck >
do bitcoincore.slack.com maintainer/admin have access to the e-mails or does slack only have them?
17:45
<
brg444 >
Anduck unfortunately that is just how slack is set up, every user's email address is public
17:46
<
Anduck >
i've not received any attempts from other slacks
17:47
<
btcdrak >
Anduck, this is a feature of Slack and cannot be changed. Anyone can slurp up all member emails addresses.
17:47
<
Anduck >
thanks for replys
17:47
<
btcdrak >
Anduck, make sure you use 2FA and a unique password.
17:47
<
brg444 >
It's likely Core's slack is particularly targeted, unfortunately :/
17:50
<
Anduck >
i see, i see
20:54
<
Chris_Stewart_5 >
In the bitcoin developer reference, when decoding a partial merkle tree it says: Fail if there are unused flag bits—except for the minimum number of bits necessary to pad up to the next full byte.
20:54
<
Chris_Stewart_5 >
I can't seem to actually find this anywhere in Core though -- is this an actual requirement?
20:59
<
Chris_Stewart_5 >
Hmm I guess I thought it would be in TraverseAndExtract I guess. Thanks
21:21
<
phantomcircuit >
while trying to fix 8445 i noticed that pwalletMain is NULL if -disablewallet is passed
21:22
<
phantomcircuit >
and yet the disablewallet test passes despite there being things doing pwalletMain-> accesses
21:22
<
phantomcircuit >
sipa: ^
21:22
<
phantomcircuit >
jonasschnelli: ^
21:22
<
phantomcircuit >
am i missing something here?
21:23
<
gmaxwell >
may be due to the compiler rerorginzing things so that those accesses don't happen
21:24
<
phantomcircuit >
gmaxwell: oooh im dumb
21:24
<
phantomcircuit >
pwalletMain ? pwalletMain->GetKeyPoolSize() : 0
21:28
<
gmaxwell >
or that
22:35
<
jeremyrubin >
Hey, what's the preffered practice for rebasing a PR onto master?
22:36
<
jeremyrubin >
push -f onto my branch ok?
23:06
<
sipa >
we don't know
23:07
<
achow101 >
so cobra went rogue?
23:07
<
Lauda >
If by rogue, you mean skipping the peer review process, then yes.
23:36
<
phantomcircuit >
cfields: is travis broken?
23:36
<
phantomcircuit >
8445 passes on my local system but not on travis and the travis failures keep changing
23:37
<
cfields >
phantomcircuit: unsure, will have a look
23:37
<
cfields >
achow101: erm, i'd say. no mention of gitian...
23:50
<
kanzure >
jeremyrubin: force-pushing to your branch might be a little rude if anyone has been doing work on top of your branch. if you're pretty sure that's not happening, then go for it.
23:51
<
gmaxwell >
the question was related to PRs against master. people should not generally be doing work on top of those.
23:51
<
gmaxwell >
And we will often
_require_ people to tidy up their branches before merging in any case.