< jonasschnelli> luke-jr: requesting BIP number for the authentication BIP: https://github.com/jonasschnelli/bips/blob/2016/07/auth_bip/bip-undef-0.mediawiki
< luke-jr> jonasschnelli: isn't that what we already gave BIP 150?
< luke-jr> hm, I guess it's still marked tentative on my end; so BIP 150 :p
< jonasschnelli> luke-jr: Could be? Wasn't aware of that. Thanks
< luke-jr> jonasschnelli: used to be part of https://github.com/bitcoin/bips/pull/362, right?
< jonasschnelli> Ah. Right... it was combine at the PR level once.
< GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c2d471e18f0...b40e19c6c48f
< GitHub26> bitcoin/master 936c144 Wladimir J. van der Laan: build: Remove check for `openssl/ec.h`...
< GitHub26> bitcoin/master b40e19c Wladimir J. van der Laan: Merge #8520: build: Remove check for `openssl/ec.h`...
< GitHub114> [bitcoin] laanwj closed pull request #8520: build: Remove check for `openssl/ec.h` (master...2016_08_remove_openssl_ech_check) https://github.com/bitcoin/bitcoin/pull/8520
< GitHub99> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b40e19c6c48f...b41ac928b89f
< GitHub99> bitcoin/master c1582d5 Wladimir J. van der Laan: qa: Remove duplicate `hash160` implementation...
< GitHub99> bitcoin/master b41ac92 Wladimir J. van der Laan: Merge #8521: qa: Remove duplicate `hash160` implementation...
< GitHub157> [bitcoin] laanwj closed pull request #8521: qa: Remove duplicate `hash160` implementation (master...2016_08_hash160_dupe) https://github.com/bitcoin/bitcoin/pull/8521
< GitHub138> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b41ac928b89f...29496fc9e095
< GitHub138> bitcoin/master 6ffd996 Sev: Corrected JSON typo on setban of net.cpp
< GitHub138> bitcoin/master 29496fc Wladimir J. van der Laan: Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp...
< GitHub20> [bitcoin] laanwj closed pull request #8512: Trivial: Corrected JSON typo on setban of net.cpp (master...setban) https://github.com/bitcoin/bitcoin/pull/8512
< GitHub170> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/29496fc9e095...740cff5808c3
< GitHub170> bitcoin/master fae596f MarcoFalke: [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain
< GitHub170> bitcoin/master fa2d68f MarcoFalke: [qa] Adjust timeouts for micro-optimization of run time
< GitHub170> bitcoin/master fad8cf6 MarcoFalke: [qa] Use single cache dir for chains
< GitHub62> [bitcoin] laanwj closed pull request #8296: [qa] Don't overwrite setup_chain and sort scripts (master...Mf1607-qaSetupChain) https://github.com/bitcoin/bitcoin/pull/8296
< GitHub83> [bitcoin] laanwj closed pull request #8482: [qa] Use single cache dir for chains (master...Mf1608-qaCache) https://github.com/bitcoin/bitcoin/pull/8482
< GitHub110> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/740cff5808c3...65e644418106
< GitHub110> bitcoin/master 8194a6e Jeremy Rubin: Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
< GitHub110> bitcoin/master 65e6444 Wladimir J. van der Laan: Merge #8513: Fix a type error that would not compile on OSX....
< GitHub120> [bitcoin] laanwj closed pull request #8513: Fix a type error that would not compile on OSX. (master...fix-osx-break) https://github.com/bitcoin/bitcoin/pull/8513
< GitHub146> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65e644418106...e753eaeb343c
< GitHub146> bitcoin/master 1aacfc2 leijurv: various typos
< GitHub146> bitcoin/master e753eae Wladimir J. van der Laan: Merge #8505: Trivial: Fix typos in various files...
< GitHub132> [bitcoin] laanwj closed pull request #8505: Trivial: Fix typos in various files (master...replacable-typo) https://github.com/bitcoin/bitcoin/pull/8505
< sipa> m-m-m-megamerge
< GitHub176> [bitcoin] laanwj pushed 4 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/4374f0ee35f8...a402396dce64
< GitHub55> [bitcoin] laanwj closed pull request #8490: [0.13] release notes: Mention new relevance of non-mining nodes on network policy; and misc fixes (0.13...relnotes_013_misc) https://github.com/bitcoin/bitcoin/pull/8490
< GitHub176> bitcoin/0.13 4f55293 Luke Dashjr: doc/release-notes: Misc
< GitHub176> bitcoin/0.13 40d705c Luke Dashjr: doc/release-notes: Mention the relevance of Compact Blocks on non-mining nodes' influence on network policy
< GitHub176> bitcoin/0.13 5e499e7 Luke Dashjr: doc/release-notes: Document changed bytespersigop behaviour
< GitHub138> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e753eaeb343c...733035bdb755
< GitHub138> bitcoin/master 3c5251d Wladimir J. van der Laan: test: Remove java comparison tool
< GitHub138> bitcoin/master eb0c52e Wladimir J. van der Laan: travis: Remove hostname hack...
< GitHub138> bitcoin/master 733035b Wladimir J. van der Laan: Merge #8504: test: Remove java comparison tool...
< GitHub95> [bitcoin] laanwj closed pull request #8504: test: Remove java comparison tool (master...2016_08_jexit) https://github.com/bitcoin/bitcoin/pull/8504
< GitHub97> [bitcoin] MarcoFalke opened pull request #8531: [qa] abandonconflict: Use assert_equal (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/8531
< jonasschnelli> Is there a way to locally detect unsafe iterator usage? https://travis-ci.org/bitcoin/bitcoin/jobs/152408747#L1413
< jonasschnelli> I compiled it locally on different machines and can't get that test failure...
< sipa> jonasschnelli: it requires rebuilding glibc with debug options, i think
< jonasschnelli> It could be a bug in gcc, I'm using std::prev(myVector.end()) which should be valid and safe?
< sipa> jonasschnelli: only if the vector is not empty
< jonasschnelli> Yes. There is a check for empty vectors above..
< sipa> ah, right
< jonasschnelli> I stepped with the debugger through the whole unit test and cannot fine a invalid std::prev
< jonasschnelli> *find
< sipa> maybe it's not in a call to std::prev?
< jonasschnelli> wait.. found the issue! nm
< jonasschnelli> There is a call of std::prev(vector.begin()) which is invalid
< btcdrak> Seeking reviews of the 0.13.0 release blog post https://github.com/bitcoin-core/bitcoincore.org/pull/199
< Anduck> bitcoin core slack has leaked my e-mail to scammers
< Anduck> i used unique e-mail when i joined bitcoincore.slack.com
< Anduck> do bitcoincore.slack.com maintainer/admin have access to the e-mails or does slack only have them?
< brg444> Anduck unfortunately that is just how slack is set up, every user's email address is public
< Anduck> i've not received any attempts from other slacks
< btcdrak> Anduck, this is a feature of Slack and cannot be changed. Anyone can slurp up all member emails addresses.
< Anduck> ok.
< Anduck> thanks for replys
< btcdrak> Anduck, make sure you use 2FA and a unique password.
< brg444> It's likely Core's slack is particularly targeted, unfortunately :/
< Anduck> i see, i see
< GitHub166> [bitcoin] jl2012 opened pull request #8533: Implement LOW_S and NULLDUMMY softfork (BIP146) (master...bip146) https://github.com/bitcoin/bitcoin/pull/8533
< GitHub170> [bitcoin] jl2012 closed pull request #8514: Enforce LOW_S rules on all transactions with WITNESS BIP9 parameters (master...lows) https://github.com/bitcoin/bitcoin/pull/8514
< GitHub1> [bitcoin] MarcoFalke opened pull request #8534: [travis] Drop java (master...Mf1608-qaJava) https://github.com/bitcoin/bitcoin/pull/8534
< Chris_Stewart_5> In the bitcoin developer reference, when decoding a partial merkle tree it says: Fail if there are unused flag bits—except for the minimum number of bits necessary to pad up to the next full byte.
< Chris_Stewart_5> I can't seem to actually find this anywhere in Core though -- is this an actual requirement?
< sipa> line 177
< Chris_Stewart_5> Hmm I guess I thought it would be in TraverseAndExtract I guess. Thanks
< phantomcircuit> while trying to fix 8445 i noticed that pwalletMain is NULL if -disablewallet is passed
< phantomcircuit> and yet the disablewallet test passes despite there being things doing pwalletMain-> accesses
< phantomcircuit> sipa: ^
< phantomcircuit> jonasschnelli: ^
< phantomcircuit> am i missing something here?
< gmaxwell> may be due to the compiler rerorginzing things so that those accesses don't happen
< phantomcircuit> gmaxwell: oooh im dumb
< phantomcircuit> pwalletMain ? pwalletMain->GetKeyPoolSize() : 0
< gmaxwell> or that
< jeremyrubin> Hey, what's the preffered practice for rebasing a PR onto master?
< jeremyrubin> push -f onto my branch ok?
< sipa> sure
< sipa> we don't know
< achow101> so cobra went rogue?
< Lauda> If by rogue, you mean skipping the peer review process, then yes.
< phantomcircuit> cfields: is travis broken?
< phantomcircuit> 8445 passes on my local system but not on travis and the travis failures keep changing
< cfields> phantomcircuit: unsure, will have a look
< cfields> achow101: erm, i'd say. no mention of gitian...
< kanzure> jeremyrubin: force-pushing to your branch might be a little rude if anyone has been doing work on top of your branch. if you're pretty sure that's not happening, then go for it.
< gmaxwell> the question was related to PRs against master. people should not generally be doing work on top of those.
< gmaxwell> And we will often _require_ people to tidy up their branches before merging in any case.