< dcousens>
What was the original motivations for const members in CTransaction?
< luke-jr>
dcousens: I was wondering that myself, actually. I think it might have been to cache the hash, but with as much overhead as it seems to be taking now, I wonder if we might be better off with just literally caching it..
< dcousens>
luke-jr: if not even through some auxillary lazy datastructure that has just the [possibly computed] hash and the underlying TX
< luke-jr>
that's what I mean
< luke-jr>
clear a bool when data is changed, and set it when we update the cached hash
< luke-jr>
possibly threading issues though, not sure
< dcousens>
I know it would definitely be measurable, but I wonder how significant the performance difference is to no cached tx->getHash
< dcousens>
and, if highly significant, whether a localized solution would be better
< dcousens>
(aka, localized to the problem where it occurs, not just 'in general')
< GitHub97>
[bitcoin] rebroad closed pull request #8618: [WIP] Erase orphans only when banned (master...EraseOrphansOnlyWhenBanned) https://github.com/bitcoin/bitcoin/pull/8618
< * luke-jr>
emails rebroad suggesting he move at least some of his questions/comments to IRC.
< btcdrak>
I was thinking the same,
< sipa>
likewise
< sipa>
maybe suggest that if he doesn't fully understand what the code is doing, his first reaction shouldn't be to go change it, but that PRs that just add comments to explain how/why things work would be welcome
< btcdrak>
yes it is much easier to ask quickly on IRC to get clarity or direction.
< GitHub154>
bitcoin/master b729fcd Luke Dashjr: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit
< GitHub154>
bitcoin/master de07fdc Pieter Wuille: Merge #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit...
< GitHub24>
[bitcoin] sipa closed pull request #8617: Include instructions to extract Mac OS X SDK on Linux using 7zip and SleuthKit (master...gitian_osx_extractor) https://github.com/bitcoin/bitcoin/pull/8617