< jonasschnelli>
luke-jr: the source for DigitalBitbox is my wiki diff.
< jonasschnelli>
:-)
< luke-jr>
jonasschnelli: I noticed another company did a simple PGP signed message on a pastebin ;)
< jonasschnelli>
luke-jr: good idea. Though my bitcoin.it account looks authentic and it's public available that I am a co-founder of DigitalBitbox... though a tweet or pgp signed pastebin is a good idea.. will do
< luke-jr>
jonasschnelli: yes, but having to inspect history is a pain
< jonasschnelli>
Yeah
< bitcoin-git>
[bitcoin] pavlosantoniou opened pull request #10619: Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619
< instagibbs>
what is vchDefaultKey for?
< instagibbs>
checking if the wallet is fFirstRun only?
< sipa>
it used to mean much more
< sipa>
but now i guess that's pretty much it
< instagibbs>
we're burning m/0'/0'/0', which makes naive importing of hd wallets impossible if the first address is used
< instagibbs>
work around is obviously to manually import first address
< instagibbs>
Can we just fill it with some valid constant key instead, for backwards compatibility?
< instagibbs>
oh I'm mistaken, it's silently used and added to the wallet. I think that's slightly surprising.
< jonasschnelli>
instagibbs: getting rid of vchDefaultKey would be good... though its currently used to find out if its the wallet first run...
< instagibbs>
jonasschnelli, right, but any valid pubkey works
< instagibbs>
just have new wallets put in a static pubkey, profit?
< jonasschnelli>
yes. that works
< instagibbs>
k sounds good
< NewBTCDev>
Hello, new dev trying to build on windows. Getting a make error that I don't understand... Could someone please take a peek and point me in the right direction? Thanks. https://pastebin.com/nNHh1B0h
< jonasschnelli>
NewBTCDev: Building on Windows itself is heavy and not supported out-of-the-box (AFAIK)... try cross compile via Linux?
< NewBTCDev>
Thanks Jonass, Those are the steps I'm taking. I'm also setting up a linux VM right now.... Will my life be a lot easier building on linux? I'm new to C++ projects
< jonasschnelli>
NewBTCDev: A lot easier (if you ask me)
< jonasschnelli>
Windows cross compile via mingw/depends is supereasy
< bitcoin-git>
[bitcoin] instagibbs opened pull request #10621: Use fixed pubkey during wallet init for default key (master...staticdefault) https://github.com/bitcoin/bitcoin/pull/10621
< Lightsword>
what’s the function that serializes BIP34 height in core?
< sipa>
Lightsword: ContextualCheckBlock
< Lightsword>
sipa, that’s only checking it right? I mean the function that does the length prefixed height serialization when mining a block