< bitcoin-git> [bitcoin] gmaxwell opened pull request #10618: Remove confusing MAX_BLOCK_BASE_SIZE. (master...size_b_gone) https://github.com/bitcoin/bitcoin/pull/10618
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de8db47b7ff3...cafe24f039e1
< bitcoin-git> bitcoin/master 9af207c Cory Fields: random: fix crash on some 64bit platforms...
< bitcoin-git> bitcoin/master cafe24f Pieter Wuille: Merge #10614: random: fix crash on some 64bit platforms...
< bitcoin-git> [bitcoin] sipa closed pull request #10614: random: fix crash on some 64bit platforms (master...fix-osx-crash) https://github.com/bitcoin/bitcoin/pull/10614
< jonasschnelli> luke-jr: the source for DigitalBitbox is my wiki diff.
< jonasschnelli> :-)
< luke-jr> jonasschnelli: I noticed another company did a simple PGP signed message on a pastebin ;)
< jonasschnelli> luke-jr: good idea. Though my bitcoin.it account looks authentic and it's public available that I am a co-founder of DigitalBitbox... though a tweet or pgp signed pastebin is a good idea.. will do
< luke-jr> jonasschnelli: yes, but having to inspect history is a pain
< jonasschnelli> Yeah
< bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10619: Avoid possibility of NULL pointer dereference in getblockchaininfo(...) (master...fix01) https://github.com/bitcoin/bitcoin/pull/10619
< instagibbs> what is vchDefaultKey for?
< instagibbs> checking if the wallet is fFirstRun only?
< sipa> it used to mean much more
< sipa> but now i guess that's pretty much it
< instagibbs> we're burning m/0'/0'/0', which makes naive importing of hd wallets impossible if the first address is used
< instagibbs> work around is obviously to manually import first address
< instagibbs> (looking at #9728)
< gribble> https://github.com/bitcoin/bitcoin/issues/9728 | Can create Watch Only HD wallet with -hdwatchonly by NicolasDorier · Pull Request #9728 · bitcoin/bitcoin · GitHub
< instagibbs> Can we just fill it with some valid constant key instead, for backwards compatibility?
< instagibbs> oh I'm mistaken, it's silently used and added to the wallet. I think that's slightly surprising.
< jonasschnelli> instagibbs: getting rid of vchDefaultKey would be good... though its currently used to find out if its the wallet first run...
< instagibbs> jonasschnelli, right, but any valid pubkey works
< instagibbs> just have new wallets put in a static pubkey, profit?
< jonasschnelli> yes. that works
< instagibbs> k sounds good
< NewBTCDev> Hello, new dev trying to build on windows. Getting a make error that I don't understand... Could someone please take a peek and point me in the right direction? Thanks. https://pastebin.com/nNHh1B0h
< jonasschnelli> NewBTCDev: Building on Windows itself is heavy and not supported out-of-the-box (AFAIK)... try cross compile via Linux?
< NewBTCDev> Thanks Jonass, Those are the steps I'm taking. I'm also setting up a linux VM right now.... Will my life be a lot easier building on linux? I'm new to C++ projects
< jonasschnelli> NewBTCDev: A lot easier (if you ask me)
< jonasschnelli> Windows cross compile via mingw/depends is supereasy
< bitcoin-git> [bitcoin] instagibbs opened pull request #10621: Use fixed pubkey during wallet init for default key (master...staticdefault) https://github.com/bitcoin/bitcoin/pull/10621
< Lightsword> what’s the function that serializes BIP34 height in core?
< sipa> Lightsword: ContextualCheckBlock
< Lightsword> sipa, that’s only checking it right? I mean the function that does the length prefixed height serialization when mining a block
< Lightsword> trying to fix this height length serialization function in pool software https://bitbucket.org/ckolivas/ckpool/src/4718cea30af47963aa55dcc4c452b9b2f9768ff8/src/libckpool.c?at=master&fileviewer=file-view-default#libckpool.c-1757:1774 doesn’t work at some lower block numbers it seems
< sipa> BlockAssembler::CreateNewBlock
< luke-jr> kallewoof: ping
< luke-jr> Lightsword: probably it's missing the sign bit
< luke-jr> Lightsword: the len2/len3 ought to be 32768 and 8388608
< luke-jr> 0x8000 and 0x800000
< Lightsword> luke-jr, ah, I recall having trouble with it at block heights even below 10 as well
< Lightsword> luke-jr, if it was a sign bit issue wouldn’t it not work at all?
< phantomcircuit> Lightsword, iirc thre isn't any code in bitcoin to do the actual serialization
< phantomcircuit> just to check that it's right
< phantomcircuit> ?
< phantomcircuit> i could be wrong
< luke-jr> Lightsword: it would work on and off, but it's not
< phantomcircuit> wait there has to be
< luke-jr> phantomcircuit: it checks by serialising and comparing
< Lightsword> luke-jr, see any other potential issues there?