< jtimon> maybe we should add stack exchange to the where botbot link is?
< wumpus> you mean in the channel topic? currently we suggest #bitcoin for usage questions, that seems ok
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d609fd85ca41...f3f1e2e7d380
< bitcoin-git> bitcoin/master 5a9b508 practicalswift: [trivial] Add end of namespace comments
< bitcoin-git> bitcoin/master f3f1e2e Wladimir J. van der Laan: Merge #9544: [trivial] Add end of namespace comments. Improve consistency....
< bitcoin-git> [bitcoin] laanwj closed pull request #9544: [trivial] Add end of namespace comments. Improve consistency. (master...consistent-use-of-end-of-namespace-comments) https://github.com/bitcoin/bitcoin/pull/9544
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3f1e2e7d380...22a0aca32974
< bitcoin-git> bitcoin/master ce79f32 Marko Bencun: add WhitelistedRange to CConnman::Options...
< bitcoin-git> bitcoin/master 07b2afe Marko Bencun: add Binds, WhiteBinds to CConnman::Options...
< bitcoin-git> bitcoin/master 22a0aca Wladimir J. van der Laan: Merge #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options...
< bitcoin-git> [bitcoin] laanwj closed pull request #10496: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options (master...connman_options) https://github.com/bitcoin/bitcoin/pull/10496
< bitcoin-git> [bitcoin] practicalswift opened pull request #10672: Avoid division by zero in the case of a corrupt estimates file (master...division-by-zero) https://github.com/bitcoin/bitcoin/pull/10672
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/22a0aca32974...234ffc677ee5
< bitcoin-git> bitcoin/master 5257698 Alex Morcos: Change semantics of HaveCoinInCache to match HaveCoin...
< bitcoin-git> bitcoin/master 234ffc6 Wladimir J. van der Laan: Merge #10559: Change semantics of HaveCoinInCache to match HaveCoin...
< bitcoin-git> [bitcoin] laanwj closed pull request #10559: Change semantics of HaveCoinInCache to match HaveCoin (master...haveunspentincache) https://github.com/bitcoin/bitcoin/pull/10559
< bitcoin-git> [bitcoin] practicalswift opened pull request #10673: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked() (master...null-pointer-dereference) https://github.com/bitcoin/bitcoin/pull/10673
< instagibbs> addmultisigaddress seems of quite dubious value. Lost a couple hours thinking it was supposed to add the script to watchonly :/ why shouldn't people just createmultisig->importaddress with redeemscript
< sipa> instagibbs: because addmultisigaddress is older than watchonly
< instagibbs> "legacy" somehow I could have guessed :)
< sipa> and the wallet integration never made it past 'proof of concept'... namely it only treats coins sent to multisig as yours if 1) you know the redeemscript and 2) you have access to all the keys
< sipa> which i think should be deprecated
< sipa> the wallet shouldn't try to infer what is yours - we have watchonly now to deal with that
< bitcoin-git> [bitcoin] jnewbery closed pull request #9569: Setting -blocksonly sets -maxmempool to zero. (master...blocksonlynomempoolsharing) https://github.com/bitcoin/bitcoin/pull/9569
< instagibbs> sipa, ok, that makes a bit more sense why there are these two competing systems
< instagibbs> should addmultisig be marked as deprecated?
< sipa> unsure; but perhaps this behaviour should at least be documenting in the help
< instagibbs> yes I am surely going to do that
< sipa> thanks!
< instagibbs> hmm as-is you cannot use importaddress to import a non-watchonly address. I guess that's where addmultisig has to be used... that's not straight forward at all
< sipa> ?
< instagibbs> meaning, cannot use it to import a p2sh multisig you control
< sipa> really?
< instagibbs> well, using the redeemscript, lemme check otherwise
< sipa> even if you only have some of the keys?
< instagibbs> i believe if you have all of them
< instagibbs> right, so you can't import the redeemscript, but you can import the p2sh address itself, provided the wallet doesn't know the redeemscript
< instagibbs> via addmultisig or some other method
< sipa> there is also importscript
< instagibbs> i think that's just importaddress with a script arg?
< sipa> right
< sipa> isn't that enough?
< instagibbs> was just noting if you try that with a redeemscript you own the keys to it rejects it
< instagibbs> so importmultisig appears to be the only place to tell your wallet about something it controls
< sipa> importmultisig? does that exist
< instagibbs> importmultisigaddress*
< instagibbs> can never remember which one has *address at the end
< instagibbs> create/add
< sipa> there is addmultisig and createmultisig, no?
< sipa> no import
< instagibbs> oh, yes, sorry