< bitcoin-git>
bitcoin/master 3f8fa7f Cory Fields: Make sure to clean up mapBlockSource if we've already seen the block...
< bitcoin-git>
bitcoin/master 0e5cff6 Wladimir J. van der Laan: Merge #11012: Make sure to clean up mapBlockSource if we've already seen the block...
< bitcoin-git>
[bitcoin] laanwj closed pull request #11012: Make sure to clean up mapBlockSource if we've already seen the block (master...cleanup-blocksource) https://github.com/bitcoin/bitcoin/pull/11012
< bitcoin-git>
bitcoin/master 90d4d89 practicalswift: scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL...
< bitcoin-git>
bitcoin/master ce74799 Wladimir J. van der Laan: Merge #10483: scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL...
< bitcoin-git>
[bitcoin] laanwj closed pull request #10483: scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL (master...nullptr) https://github.com/bitcoin/bitcoin/pull/10483
< bitcoin-git>
[bitcoin] practicalswift opened pull request #11043: Use std::unique_ptr (C++11) where possible (master...unique-pointers) https://github.com/bitcoin/bitcoin/pull/11043
< bitcoin-git>
[bitcoin] jonasschnelli opened pull request #11046: Replace boost sleep_for with C++11 equivalent (master...2017/08/boost_sleep_for) https://github.com/bitcoin/bitcoin/pull/11046
< jonasschnelli>
wumpus: Not sure but I guess cfields already prepared for C++11 sleep_for interruptibility via the CThreadInterrupt (net.h)
< wumpus>
not sure either, just needed to bring it up. I'd be really happy to finally get rid of that annoying configure error about it.
< wumpus>
although usually it means someone is missing a boost library or two, and that just happens to be where it gets detected
< jonasschnelli>
Right. I didn't meant it as a fix for a missing boost library. It was just the last piece that made me finally write that PR.
< jonasschnelli>
Step by step approach of removing boost
< BlueMatt>
at least CScheduler still needs boost_sleep...dunno about net, but i think those threads are like not even in the threadGroup anymore, right?
< BlueMatt>
which would mean they def dont need boost_sleep
< jonasschnelli>
BlueMatt: where does CScheduler relay on boost::thread::sleep(_for)?
< BlueMatt>
interruption, or something like that iirc
< jonasschnelli>
I don't think so
< BlueMatt>
oh, maybe it doesnt
< BlueMatt>
you're right
< BlueMatt>
well there were some issues with removing the boost time stuff there, dont recall what they were now
< jonasschnelli>
I guess a boost free CScheduler would be easy... I remember I once did this.
< BlueMatt>
iirc there were issues when that was done
< BlueMatt>
but I'd have to dig up the pr
< jonasschnelli>
(when I had significant unrhythmic offsets)
< jonasschnelli>
But one step after another. The sleep_for workaround/detection can go first.
< jonasschnelli>
...Avoiding larger PRs
< jonasschnelli>
(refactoring PRs)
< bitcoin-git>
[bitcoin] TheBlueMatt closed pull request #10652: Small step towards demangling cs_main from CNodeState (master...2017-06-cnodestateaccessors-1) https://github.com/bitcoin/bitcoin/pull/10652