< bitcoin-git>
bitcoin/master 11dd29b practicalswift: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest& request)...
< bitcoin-git>
bitcoin/master 02f4c4a Wladimir J. van der Laan: Merge #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&)...
< bitcoin-git>
[bitcoin] laanwj closed pull request #10977: [net] Fix use of uninitialized value in getnetworkinfo(const JSONRPCRequest&) (master...valgrind-getnetworkinfo) https://github.com/bitcoin/bitcoin/pull/10977
< wumpus>
xvfb is 'simple', but it is another external dependency
< wumpus>
at least 'make check' tests should be self-contained
< luke-jr>
it's not like it's a real dependency O.o
< luke-jr>
only pulled in for Travis basically
< wumpus>
or when people want to run make check locally, the tests aren't just for travis
< wumpus>
they shouldn't be required to set up an x server to run the tests
< luke-jr>
oh well, kinda independent from this PR since it's not touching that relationship
< wumpus>
yeah
< John>
hi
< John>
oh yay i can talk here
< John>
is this the place where the "non segwit" guys hang out?
< John>
oh
< John>
i guess now wumpus
< John>
*not
< wumpus>
sigh, just what we needed, that guy here too
< gmaxwell>
[Offtopic] If any of you have been using vanitygen with a patch that makes it produce compressed keys, beware, 1/256 private keys it outputs are corrupted. The corruption is recoverable, with a bit of bruteforcing.
< gmaxwell>
Symptom is that bitcoin core rejects the private keys as invalid, which they are.
< gmaxwell>
If you become a victim of this or know someonw who is, just tell me I can tell you how to recover.
< bitcoin-git>
[bitcoin] ajtowns opened pull request #10994: Add option to avoid warning on certain network upgrades (master...ignore-vbits) https://github.com/bitcoin/bitcoin/pull/10994
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
< wumpus>
at the time, bench was completely useless
< wumpus>
it had one (example) benchmark
< wumpus>
we could discuss re-adding it to the distribution in 0.16 as that has changed
< jonasschnelli>
wumpus: I think it would worth ship it..
< arubi>
sipa, would be cool to have the .conf file per network. I do this now with shell functions and I'd love if it would be a part of the original bitcoin.conf. makes it much simpler to version control
< sipa>
oh, absolutely
< wumpus>
.conf file per network is not only cool, it is necessary for network config, e.g. if you currently bind a specific rpcport or p2p port, you can't use the other networks anymore
< wumpus>
also if you want to use a proxy for mainnet, but not, say, for testnet, that's not possible currently
< arubi>
right, what's going on now is that I might have a special client running on both testnet and regtest, now I need two names for it, one that's like testnet-cli and and another is regtest-cli. I can do the conf stuff in the function and common stuff in .conf, but that branching happening one level above is awesome