< bitcoin-git>
bitcoin/master fadf60e MarcoFalke: qa: Note on test order in test_runner
< bitcoin-git>
bitcoin/master d38d1a3 MarcoFalke: Merge #11965: qa: Note on test order in test_runner...
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #11965: qa: Note on test order in test_runner (master...Mf1712-qaTestRunnerOrder) https://github.com/bitcoin/bitcoin/pull/11965
< bitcoin-git>
[bitcoin] promag opened pull request #12080: Add support to search the address book (master...2018-01-searchaddressbook) https://github.com/bitcoin/bitcoin/pull/12080
< bitcoin-git>
[bitcoin] Christewart opened pull request #12082: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (master...add_tx_valid_singleanyonecanpay) https://github.com/bitcoin/bitcoin/pull/12082
< BlueMatt>
someone wanna nack+close or otherwise look at #12051? (issue is adding gpl-2 stuff to dist tarball)
< luke-jr>
BlueMatt: if it's in git, it should be in the dist tarball
< BlueMatt>
I dont see why thats the case, its obviously a policy discussion we should discuss, not a hard rule, probably up to wumpus, I'd say
< jimpo>
If I want a stream interface to read from a byte vector, is my best option CDataStream? The downside is that it copies the the contents and in my use case, I can read from the vector by reference.
< ryanofsky>
jimpo, yeah i think that's the easiest thing to do. you could also write a new stream class that wraps already allocated storage
< jimpo>
OK, yeah, I was going to propose a CVectorReader (given that there's already a CVectorWriter), and wanted to check if there was some reason not to.
< ryanofsky>
it'd be nice to have. i wanted something like that for #10102, but was lazy and just used CDataStream instead
< gribble>
https://github.com/bitcoin/bitcoin/issues/10102 | bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP, Depends on #10244) by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
< sipa>
jimpo: that may make sense; i wonder how many existing uses of CDataStream could use a CVectorReader
< Chris_Stewart_5>
so everytime you read from CDataStream everything is copied instead of referenced?
< jimpo>
Every time you create a CDataStream from a vector, the vector contents are copied
< BlueMatt>
jimpo: I have one implemented in fibre somewhere.....
< BlueMatt>
0.15.1 erratta (backport-introduced bug): addnode $NODE onetry peers do not stay connected due to us assuming they are extra outbound nodes until #11456 makes them m_manual_connection nodes