< MarcoFalke> gmaxwell: Better open an issue on github, so we don't forget about the bug
< MarcoFalke> There is one specifically about the gui and abandontransaction, but I assume that is a different report from yours?
< MarcoFalke> #12179
< gribble> https://github.com/bitcoin/bitcoin/issues/12179 | "abandon transaction" only removed tx from display until client restart · Issue #12179 · bitcoin/bitcoin · GitHub
< dsaf> hello
< Dizzle> Hey, any of you core devs going to some of the upcoming conferences?
< Dizzle> i.e. Blockchain Dev Conference, Bitcoin Super Conference, etc
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9cf6393a4f82...1213be6c3a09
< bitcoin-git> bitcoin/master fa796bb MarcoFalke: qa: Add missing syncwithvalidationinterfacequeue to tests
< bitcoin-git> bitcoin/master 1213be6 Wladimir J. van der Laan: Merge #12217: qa: Add missing syncwithvalidationinterfacequeue to tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #12217: qa: Add missing syncwithvalidationinterfacequeue to tests (master...Mf1801-qaWalletMempoolAsyncTake2) https://github.com/bitcoin/bitcoin/pull/12217
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/1213be6c3a09...000ac4fd015c
< bitcoin-git> bitcoin/master 0c74e2e Wladimir J. van der Laan: Log debug build status and warn when running benchmarks...
< bitcoin-git> bitcoin/master 34328b4 Wladimir J. van der Laan: Use PACKAGE_NAME instead of hardcoding application name in log message
< bitcoin-git> bitcoin/master 000ac4f Wladimir J. van der Laan: Merge #12197: Log debug build status and warn when running benchmarks...
< bitcoin-git> [bitcoin] laanwj closed pull request #12197: Log debug build status and warn when running benchmarks (master...2018_01_debug_in_log) https://github.com/bitcoin/bitcoin/pull/12197
< fanquake> Looks like we've got a new wave of random GH accounts commenting in issues offering "make your own btc fork" services..
< wumpus> spam about tools to create forks, heh, at least that's a new one, compared to 'use this fork' or 'use this altcoin' spam
< fanquake> Offering their forking "services" heh
< wumpus> github doesn't really address spam, they'll just tell you to block the account from the org, so let me know if anyone needs to be blocked
< fanquake> wumpus @SupportBlockchain is the current spamming user
< wumpus> done
< fanquake> Would be good for at least someone else to look at #12095, otherwise it should be ready for merge.
< gribble> https://github.com/bitcoin/bitcoin/issues/12095 | [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication by fanquake · Pull Request #12095 · bitcoin/bitcoin · GitHub
< wumpus> fanquake: ah yes that one can just be merged imo
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/000ac4fd015c...3fa1ab4368cf
< bitcoin-git> bitcoin/master 311a423 fanquake: [contrib] Use BDB_LIBS/CFLAGS in install_db4
< bitcoin-git> bitcoin/master f3196a0 fanquake: [contrib] Add --disable-replication to install_db4
< bitcoin-git> bitcoin/master 3fa1ab4 Wladimir J. van der Laan: Merge #12095: [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication...
< wumpus> it is nice to get in before 0.16, even if not essential
< fanquake> #12108 is also fairly trivial, has some acks already.
< gribble> https://github.com/bitcoin/bitcoin/issues/12108 | [Refactor] Remove unused fQuit var from checkqueue.h by donaloconnor · Pull Request #12108 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj closed pull request #12095: [contrib] Use BDB_LIBS/CFLAGS and pass --disable-replication (master...db4-script-flags) https://github.com/bitcoin/bitcoin/pull/12095
< bitcoin-git> [bitcoin] fanquake closed pull request #11971: [docs]: include README with binary releases (master...bindoc) https://github.com/bitcoin/bitcoin/pull/11971
< bitcoin-git> [bitcoin] fanquake closed pull request #11759: Docs: reflow the text and add better markup (master...jasan/little_text_fixes) https://github.com/bitcoin/bitcoin/pull/11759
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fa1ab4368cf...9220426280d0
< bitcoin-git> bitcoin/master 30ded3e donaloconnor: [Refactor] Remove unused fQuit var from checkqueue.h
< bitcoin-git> bitcoin/master 9220426 Wladimir J. van der Laan: Merge #12108: [Refactor] Remove unused fQuit var from checkqueue.h...
< bitcoin-git> [bitcoin] laanwj closed pull request #12108: [Refactor] Remove unused fQuit var from checkqueue.h (master...20180107_checkqueue_ref) https://github.com/bitcoin/bitcoin/pull/12108
< wumpus> stange "make check" timeouts on bitcoin-i686-w64-mingw32 on travis https://travis-ci.org/bitcoin/bitcoin/jobs/334642991#L2656
< wumpus> the strangeness is that test_bitcoin.exe passes, and the last thing printed is PASS: exhaustive_tests.exe
< wumpus> so it hangs after that
< wumpus> oh apparently it fixed itself, was a transitory issue
< bitcoin-git> [bitcoin] ajtowns opened pull request #12292: [tests] Fix names of excluded extended tests for travis (master...rename_tests_fix_travis) https://github.com/bitcoin/bitcoin/pull/12292
< bitcoin-git> [bitcoin] fanquake opened pull request #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present (master...is-hd-enabled-rpc) https://github.com/bitcoin/bitcoin/pull/12293
< bitcoin-git> [bitcoin] fanquake closed pull request #12042: Add hdenabled flag in getwalletinfo (master...getwalletinfo/hdenabledflag) https://github.com/bitcoin/bitcoin/pull/12042
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9220426280d0...f3c7062b7bbf
< bitcoin-git> bitcoin/master a73aab7 Alin Rus: Use the character based overload for std::string::find....
< bitcoin-git> bitcoin/master f3c7062 Wladimir J. van der Laan: Merge #12159: Use the character based overload for std::string::find....
< bitcoin-git> [bitcoin] laanwj closed pull request #12159: Use the character based overload for std::string::find. (master...use_char_overload_find) https://github.com/bitcoin/bitcoin/pull/12159
< bitcoin-git> [bitcoin] fanquake opened pull request #12294: [Docs] Create NetBSD build instructions and fix compilation (master...netbsd-build-docs) https://github.com/bitcoin/bitcoin/pull/12294
< bitcoin-git> [bitcoin] fanquake closed pull request #12125: [Docs] Create NetBSD build instructions and fix compilation. (master...master) https://github.com/bitcoin/bitcoin/pull/12125
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3c7062b7bbf...c0ae864ef51d
< bitcoin-git> bitcoin/master 6eddd43 practicalswift: Fix warnings when building with DEBUG_ADDRMAN...
< bitcoin-git> bitcoin/master c0ae864 Wladimir J. van der Laan: Merge #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN...
< bitcoin-git> [bitcoin] laanwj closed pull request #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN (master...DEBUG_ADDRMAN-warnings) https://github.com/bitcoin/bitcoin/pull/11577
< fanquake> wumpus #11989 could go in or close
< gribble> https://github.com/bitcoin/bitcoin/issues/11989 | [build] .gitignore: add QT Creator artifacts by Sjors · Pull Request #11989 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake closed pull request #11969: logs: Improve "mempool min fee not met" error (master...mempoolfix) https://github.com/bitcoin/bitcoin/pull/11969
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c0ae864ef51d...eebe4580bc8d
< bitcoin-git> bitcoin/master a2808cf Anthony Towns: [tests] Fix names of excluded extended tests for travis
< bitcoin-git> bitcoin/master eebe458 MarcoFalke: Merge #12292: [tests] Fix names of excluded extended tests for travis...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12292: [tests] Fix names of excluded extended tests for travis (master...rename_tests_fix_travis) https://github.com/bitcoin/bitcoin/pull/12292
< bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/eebe4580bc8d...6378e5c51414
< bitcoin-git> bitcoin/master db32a4f Werner Lemberg: bitcoin_qt.m4: Improve QT_VERSION tests....
< bitcoin-git> bitcoin/master 8695315 Werner Lemberg: bitcoin_qt.m4: Use correct M4 quoting characters.
< bitcoin-git> bitcoin/master 079f4b2 Werner Lemberg: bitcoin_qt.m4: Add missing braces around variables in autoconf messages.
< bitcoin-git> [bitcoin] laanwj closed pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6378e5c51414...90d41049f90b
< bitcoin-git> bitcoin/master ac5104f Sjors Provoost: [build] .gitignore: add QT Creator artifacts
< bitcoin-git> bitcoin/master 90d4104 Wladimir J. van der Laan: Merge #11989: [build] .gitignore: add QT Creator artifacts...
< bitcoin-git> [bitcoin] laanwj closed pull request #11989: [build] .gitignore: add QT Creator artifacts (master...ignore-qt-creator-artifacts) https://github.com/bitcoin/bitcoin/pull/11989
< bitcoin-git> [bitcoin] practicalswift opened pull request #12295: tests: Fix accidental redefinition via list comprehension. Enable lint-python.sh checking for this gotcha. (master...accidental-redefinition-of-variable) https://github.com/bitcoin/bitcoin/pull/12295
< capa66> hello, I havea question about segwit addresses in bitcoin-core, if i generate an address using addwitnessaddress can i send to that address and see the balance in bitcoin-qt?
< capa66> version 15
< capa66> .1
< capa66> sorry i'll take this to #bitcoin
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/90d41049f90b...9d9c4185fada
< bitcoin-git> bitcoin/master c6b6385 fanquake: [rpc] Mention that HD is enabled if hdmasterkeyid is present
< bitcoin-git> bitcoin/master 9d9c418 MarcoFalke: Merge #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present (master...is-hd-enabled-rpc) https://github.com/bitcoin/bitcoin/pull/12293
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12296: wallet: Only fee-bump and non-conflicted/non-confirmed txes (master...Mf1801-walletFeeBumpNoConf) https://github.com/bitcoin/bitcoin/pull/12296
< promag> MarcoFalke: what is the difference between TransactionCanBeBumped and https://github.com/bitcoin/bitcoin/blob/master/src/wallet/feebumper.cpp#L48-L69 ?
< promag> I mean, TransactionCanBeBumped could just call PreconditionChecks?
< instagibbs> promag, pretty sure it's just a wrapper for QT
< instagibbs> with a couple additional checks
< promag> yeah, PreconditionChecks doesn't check SignalsOptInRBF
< instagibbs> I did a bit of work last week refactoring, I was curious as to pre-check choices as well
< instagibbs> so one issue is TransactionCanBeBumped IIRC just allows the checkbox to be checked
< instagibbs> but that indeed is a static check, hm
< promag> ok, the real check comes later
< instagibbs> promag, these seemed reasonable to me to move https://github.com/instagibbs/bitcoin/commit/718f05cab5fe632c5dc4e3c689d5e4cd51331089
< promag> instagibbs: feebumper::CommitTransaction also calls PreconditionChecks, maybe it's not necessary to check that there
< instagibbs> it's a last minute catch
< instagibbs> belt and suspenders
< instagibbs> / make sure the transaction still has no descendants and hasn't been mined in the meantime
< bitcoin-git> [bitcoin] promag opened pull request #12297: Improve CWallet::IsAllFromMe for false results (master...2018-01-isallfromme) https://github.com/bitcoin/bitcoin/pull/12297
< bitcoin-git> [bitcoin] promag opened pull request #12298: Refactor HaveKeys to early return on false result (master...2018-01-ismine-havekeys) https://github.com/bitcoin/bitcoin/pull/12298