< achow101> do the fee estimates work on virtual size?
< achow101> s/work on/use
< belcher_> yes achow101 they are in units of vbytes
< belcher_> or kilovbytes*
< achow101> ok, that's what I thought. docs and ui needs fixing then
< ycshao> Hi
< bitcoin-git> [bitcoin] achow101 opened pull request #12180: Use vbytes (master...use-vbytes) https://github.com/bitcoin/bitcoin/pull/12180
< mrannanay> Hi, this may be slightly tangential, I've been wanting to start contributing regularly to core, but I think the issues with the "good-first-issue" tag are a little stale (either awaiting responses or integrating with third party applications) and do not give a lot of exposure into the codebase. (The link for reference -
< mrannanay> Wondering if there could be a way to help newcomers like me help get started with contributing to core by offloading code-issues. (Yes, I want to help and contribute!)
< jonasschnelli> mrannanay: just pick something you like to work on... then ask here if you need help.
< jonasschnelli> Make sure it fits your skill-profile..
< jonasschnelli> don't pick hardcode c++ code is you have limited c++ knowhow... maybe better extend the documentation then.
< jonasschnelli> Or extend some python tests
< mrannanay> Right, sure! I've been working with distributed systems at college. Will continue to hang out here and pick something to work on.
< * Randolf> welcomes mrannanay
< mrannanay> haha thanks @Randolf
< bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12181: [TRIVIAL] Remove continue statement at the end of loop. (master...redundant_continue) https://github.com/bitcoin/bitcoin/pull/12181
< bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12182: [TRIVIAL] Remove useless string initialization. (master...remove_useless_string_init) https://github.com/bitcoin/bitcoin/pull/12182
< Arvidt> Hi, what's the reason for the spike in bitcoin connections to my full node since yesterday? normally under 40, now up to 120. Many say they wher bitcoinj:0.14.5 and bitcore:1.1.0
< achow101> Arvidt: probably spy nodes
< achow101> there will often be people who fire up thousands of nodes based on bitcoinj and then try to connect to everyone on the network in order to spy on transaction broadcasts
< Arvidt> According to my Munin graph this one looks special. Around 1st November there was a spike to 60. Now it jumped up from 40 to 120 in one day and even after starting my node today (after doing backup) fresh up again, it jumped straight up to 120 again (left maxconnection parameter at default of 125) in two hours. Never seen that before.
< bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12183: Make use of emplace_back in nonassociative containers. (master...use_emplace) https://github.com/bitcoin/bitcoin/pull/12183
< bitcoin-git> [bitcoin] kekimusmaximus opened pull request #12184: [TRIVIAL] Drop C headers in favour of C++-compatibility headers. (master...cpp11_includes) https://github.com/bitcoin/bitcoin/pull/12184
< Victorsueca> Cross-talk from #bitcoin here, I was wondering if there is any PR or plans to add hardware wallet support to Bitcoin Core
< Victorsueca> I remember having seen something about that but not sure
< achow101> Victorsueca: people are working on it, but the wallet stuff will need a lot of major changes to allow that
< Victorsueca> thanks for the info
< larafale> is it possible that a block only contains a coinbase ? last block 504,229 is empty.
< sipa> yes, perfectly possible, happens all the time
< larafale> sipa: ok thx :)
< instagibbs> Victorsueca, chainhead, latest is https://github.com/instagibbs/bitcoin/tree/external_sign_4 but it's in no way upstreamable due to underlying changes required to make it sane
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12181: [TRIVIAL] Remove continue statement at the end of loop. (master...redundant_continue) https://github.com/bitcoin/bitcoin/pull/12181