< SatoshiNakamoto> Thanks
< SatoshiNakamoto> Im come back
< SatoshiNakamoto> !
< SatoshiNakamoto> !!!
< lightningbot> SatoshiNakamoto: Error: "!" is not a valid command.
< gribble> Error: "!!" is not a valid command.
< SatoshiNakamoto> ok
< SatoshiNakamoto> Send Bitcoin
< fanquake> wumpus / sipa ^
< fanquake> promag re your Windows testing questions, I've added a VM setup guide (for native builds) here: https://github.com/fanquake/core-review/blob/master/windows.md
< bitcoin-git> [bitcoin] jimpo opened pull request #15118: Flatfile (master...flatfile) https://github.com/bitcoin/bitcoin/pull/15118
< Euclid2010> Hello guys I have an old wallet back in 2011 I want to access funds in the wallet now however the wallet is password encrypted and I forgot the password I suppose I can erase the password in db4.8_dump however upon doing so the receiving address change in sending address does anyone know a way to work around this problem?
< luke-jr> Euclid2010: it's impossible
< luke-jr> the only way to access an encrypted wallet, is to have the password
< luke-jr> also, this is not the right channel for this conversation - move to #bitcoin with it please
< Euclid2010> I also ask the same question in #bitcoin pardon.
< promag_> fanquake: cool thanks
< promag_> #12153 ready to merge?
< gribble> https://github.com/bitcoin/bitcoin/issues/12153 | Avoid permanent cs_main lock in getblockheader by promag · Pull Request #12153 · bitcoin/bitcoin · GitHub
< fanquake> promag_ looks like it will be
< luke-jr> is Travis fubar'd again? got functional tests failing from Qt-only changes..
< fanquake> Could be GitHub, I'm seeing unicorns occasionally.
< luke-jr> nah, GitHub wouldn't cause PSBT tests to fail
< luke-jr> and feature_shutdown O.o
< luke-jr> yeah, retrying fixed it for now :x
< promag_> luke-jr: is your branch rebased?
< promag_> luke-jr: nevermind, it is
< promag_> luke-jr: you might want to try #14958
< gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub
< promag_> s/try/review x)
< bitcoin-git> [bitcoin] thedevworks closed pull request #15105: gui: Use MINUS (U+2212) instead of HYPHEN-MINUS (U+002D) (master...2019-1-4-hyphenminus) https://github.com/bitcoin/bitcoin/pull/15105
< luke-jr> promag_: why would it ever get to the stop before everything else is done? O.o
< promag_> because Thread(...).start() is async?
< promag_> and then it calls stop_node
< promag_> at that point waitfornewblock may or not be running
< promag_> that's the race
< promag_> that 14958 ensures it's running
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c719987718d...295a1ad52235
< bitcoin-git> bitcoin/master fac4e73 MarcoFalke: test: Run invalid_txs.InputMissing test in feature_block
< bitcoin-git> bitcoin/master 295a1ad MarcoFalke: Merge #15102: test: Run invalid_txs.InputMissing test in feature_block...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15102: test: Run invalid_txs.InputMissing test in feature_block (master...Mf1901-testInputMissing) https://github.com/bitcoin/bitcoin/pull/15102
< provoostenator> promag: the test suite uses the new "wait" parameter, which then causes old node versions to throw an error. I just added versions to the testnode class.
< provoostenator> *promag_
< fanquake> wumpus: #15110, 15094 mergable. Maybe 12153 too.
< gribble> https://github.com/bitcoin/bitcoin/issues/15110 | build_msvc: Fix the build problem in libbitcoin_server by Mr-Leshiy · Pull Request #15110 · bitcoin/bitcoin · GitHub
< wumpus> fanquake: thanks!
< wumpus> does anyone disagree with giving fanquake ops here? would help if he can kick out the satoshi jokers in the middle of the (european) night
< wumpus> 15110 doesn't have a single (utACK), I can't test anything MSVC either
< wumpus> oh you tested, nm
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/295a1ad52235...f0fa6bad00f1
< bitcoin-git> bitcoin/master c98f886 Alexey Poghilenkov: Fix the build problem in libbitcoin_server
< bitcoin-git> bitcoin/master f0fa6ba Wladimir J. van der Laan: Merge #15110: build_msvc: Fix the build problem in libbitcoin_server...
< bitcoin-git> [bitcoin] laanwj closed pull request #15110: build_msvc: Fix the build problem in libbitcoin_server (master...MrLeshiy_Fix_Build) https://github.com/bitcoin/bitcoin/pull/15110
< fanquake> Surprisingly, getting the native windows builds setup wasn't as difficult as I expected
< cdecker> +1 on ops for fanquake :-)
< fanquake> Although nearly managed to run out of room in the VM <.<
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5ff7b372cdbd...0a0b2ea11fde
< bitcoin-git> bitcoin/0.17 59dd855 Ben Carman: gui: Fix for Incorrect application name when passing -regtest...
< bitcoin-git> bitcoin/0.17 0a0b2ea Wladimir J. van der Laan: Merge #15094: 0.17: Backport for #15085...
< provoostenator> ACK fanquake op
< provoostenator> Well, concept ACK, since I can't verify his identity on IRC :-)
< wumpus> hehe
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0fa6bad00f1...fcc618d508e6
< bitcoin-git> bitcoin/master fab3f14 MarcoFalke: rpc: Document bytessent_per_msg and bytesrecv_per_msg
< bitcoin-git> bitcoin/master fcc618d Wladimir J. van der Laan: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg...
< bitcoin-git> [bitcoin] laanwj closed pull request #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (master...Mf1901-docRpcGetPeerInfo) https://github.com/bitcoin/bitcoin/pull/15078
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fcc618d508e6...1973257da050
< bitcoin-git> bitcoin/master fa38d3d MarcoFalke: [rpc] Correct reconsiderblock help text, add test
< bitcoin-git> bitcoin/master 1973257 Wladimir J. van der Laan: Merge #15057: [rpc] Correct reconsiderblock help text, add test...
< bitcoin-git> [bitcoin] laanwj closed pull request #15057: [rpc] Correct reconsiderblock help text, add test (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/15057
< promag_> +1 op for fanquake
< promag_> provoostenator: oh I see
< promag> provoostenator: regarding "it tends to return "unable to".", where do you get that?
< provoostenator> If I do "unloadwallet B" in the GUI console I get "Cannot unload the requested wallet (code -8)". It works from command line though.
< promag> provoostenator: right, because you have a wallet selected
< promag> just run "unloadwallet" to unload the current selected wallet
< promag> or select "None" and run "unloadwallet B" to unload that wallet
< provoostenator> promag: selecting wallet B in the main GUI doesn't help. Selecting any of the wallets or no wallet in console UI doesn't help.
< promag> not in the mainwindow, but in the console
< provoostenator> Doesn't matter what I select there, same error
< promag> huh, let me see
< provoostenator> Oh no
< provoostenator> Now it's working for None, I'm pretty sure it complained before.
< provoostenator> Crash
< provoostenator> When I load it again
< provoostenator> And then unload with None
< provoostenator> May want to double check that area of the code (this was on your branch).
< promag> let me try to reproduce
< provoostenator> My bitcoin.conf has one wallet in it, called A (in case that matters). I then just load and unload wallet B a bunch of times from the GUI console..
< provoostenator> "pointer being freed was not allocated"
< promag> yup, got it
< provoostenator> Yeah, it's pretty easy to reproduce.
< promag> provoostenator: pushed a fix, let me know how it looks
< promag> provoostenator: pushed a fix, let me know how it looks
< promag> dejavu
< jimpo> gmaxwall Regarding block filter construction, would you prefer that be in the block validation ConnectBlock code path instead of a separate index?
< bitcoin-git> [bitcoin] jnewbery opened pull request #15122: [docs] Expand release notes for importmulti changes (master...pr14565_release_notes) https://github.com/bitcoin/bitcoin/pull/15122
< relligions> hi
< relligions> which is the general #altcoins chanel, it seems gone?
< relligions> phantomcircuit: where is the general crypto chat channel
< luke-jr> ##altcoin-dev
< relligions> no it's a dev channel, the old one ##altcoins seems to be gone for users not devs
< relligions> luke-jr: bch is bitcoin
< relligions> I got banned on #bitcoin for discussing bch
< relligions> lightning network is clearly not the Satoshi's bitcoin
< relligions> It's following the original bitcoin protocol
< luke-jr> you're about to be banned here too
< jarthur> relligions: you probably want #BitcoinCash
< relligions> for what
< relligions> jarthur: yes!
< jarthur> relligions: this is the development/operations channel for a popular Bitcoin reference client, the altcoin chat is off-topic and getting in the way. That's why you'd be banned.
< relligions> jarthur exactly!
< relligions> so blockstreamcoin is offtopic
< relligions> and Satoshi Nakamotos
< relligions> is ontopic
< bitcoin-git> [bitcoin] Empact opened pull request #15124: Fail if either disk space check fails (master...disk-space-check) https://github.com/bitcoin/bitcoin/pull/15124
< jamesob> is it a reasonable to say that in general `cd depends && make` is safer than using distro-specific packaging?
< wumpus> jamesob: it shouldn't be, really
< wumpus> the distro dependencies should be as good, as long as they are at least the versions mentioned as minimum in doc/dependencies.md
< wumpus> 'depends' is a tool for convenenience and for building the packaged executables, if it's essential that some dependency matches (such as for secp256k1) the version it's included as subtree
< jamesob> as well as for cross-compilation, I guess. gotcha.
< jamesob> didn't know if there was some something-something-deterministic-build-something-something going on or planned
< jamesob> (have fun parsing that)
< wumpus> yup, for cross-compilation it's also useful for convenience, not strictly necessary if you build the other dependencies using say, buildroot, yocto
< jamesob> wumpus: thanks
< wumpus> deterministic builds that's what gitian is for, which in turn uses depends, using depends on its own is not enough to get deterministic builds
< jnewbery> meshcollider: what's the eventual plan for private keys in importmulti with descriptors? After #15024, there are two ways of importing the privkeys: either in the descriptor itself or with the keys argument. Would it be better to only allow importing privkeys from the descriptor itself?
< gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by MeshCollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
< jnewbery> If you agree, then I think it makes sense to flip the ordering of the PRs (ie reduce 15024 to just commit https://github.com/bitcoin/bitcoin/pull/15024/commits/8a270b9582d82991766172430d508a1a7358e80d and merge that first, and then have 14491 following it)
< jnewbery> promag: is #13100 blocked on anything?
< gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
< dongcarl> Is it possible to `-connect` or `-addnode` a node with a custom listening port?
< sipa> sure
< sipa> use ip:port notation
< sipa> or [ip]:port for ipv6
< dongcarl> Thanks! Wasn't in the help page I think
< sipa> perhaps that should get fixed then
< promag> jnewbery: you could look #15101
< gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub
< jnewbery> thanks promag. Will check it out tomorrow
< promag> jnewbery: cool thanks
< promag> jnewbery: after that one the simple ones are "Close Current Wallet" and "Open External Wallet"
< promag> jnewbery: "New Wallet" and "Open Wallet" require custom dialog
< promag> jnewbery: don't want to push all of this to 13100
< promag> jnewbery: btw, you could check #14941 too
< gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub
< promag> nevermind